- Mar 22, 2023
-
-
Alexander Schnitzler authored
This change splits off the creation of column maps in the DataFactory class into its own ColumnMapFactory class. Benefits are: - clear distinction of responsibilities - better testability - easier to understand for readers Releases: main Resolves: #100235 Change-Id: Iaa2cbaa1ad8498edc90adf3d90c97712b7ca62aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78186 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Michael Schams authored
Following the TYPO3 documentation and the TYPO3 content style guide (in particular the section "Spelling, terms and glossary"), the BE now uses the term "Page TSconfig" consistently. Resolves: #100244 Releases: main Change-Id: I46bdeda149a1e9e1f77f0309ade15dedd1ccac45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78207 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Mar 21, 2023
-
-
Christian Kuhn authored
This patch level release comes with a set of minor bug fixes and should be the minimum version for TYPO3 v12 from now on. > composer req typo3fluid/fluid:^2.7.3 Resolves: #100243 Releases: main Change-Id: Id57b8b7f0a30211fe90d09b854475fceda58901e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78206 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Albrecht Köhnlein authored
Avoid PHP warnings when calling the method to process INTinclude scripts when jsInline or jsFooterInline was set. Previously, the jsInline and jsFooterInline was called after $TSFE->INTincScript_loadJScode(), where TSFE considered there were no *_INT objects, however, they were processed later-on, thus no "divKey" was set and a PHP warning was set. Change-Id: Ie639d58a2efce10177a41042080534ce26a1a291 Resolves: #100216 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78170 Tested-by:
Albrecht Köhnlein <ak@koehnlein.eu> Reviewed-by:
-
Benni Mack authored
This change deprecates the global array $TBE_STYLES and with that the registration of CSS files for backend styling, which is now handled via $GLOBALS['TYPO3_CONF_VARS']['BE']['stylesheets'] Resolves: #100232 Releases: main Change-Id: I36251d492563442fc82b43ec81a581f504583401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78189 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Bartsch authored
The `items` array in an itemsProcFunc does no longer contain item arrays but SelectItem objects. Therefore, the corresponding type hint is changed in CreateRecordReactionTable and the code usages are adjusted to prevent a TypeError. Resolves: #100242 Related: #99739 Releases: main Change-Id: I05be3bd33a816a6f957032d1482c37b3c33cbf9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78205 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Oliver Klee authored
Resolves: #100142 Releases: main Change-Id: I3981c16020eb2b210a40bedce89d8050bd2a851c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78094 Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Benni Mack authored
Extbase uses the $alternativeLanguageKeys, which previously omitted the actual language chain for XLF files, because it did not use the Locales->createLocale() method, but instead just used new Locale(). Resolves: #100030 Releases: main Change-Id: Ia663a00cb8e55d843678abddcd8d60bf46e336df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78192 Tested-by:
-
Christian Kuhn authored
Private property ColumnMap->relationTableWhereStatement is unused and can be removed from the codebase without further impact. Resolves: #100239 Releases: main Change-Id: Ibc40c48fef8e1e88e0ac0807017c477b3acea62d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78199 Reviewed-by:
-
Sybille Peters authored
The default value for argument "method" is effectively "post", so this is added as default value in registerArgument so that it will show up in the automatically generated viewhelper reference. Since the argument is always added anyway (after lowercasing it), there is no difference in the rendered output. The TYPO3 default differs from the default general default for forms, which is GET. Resolves: #99086 Releases: main Change-Id: If34ebc1a65527a605e64513c598a5c381dbeebf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76599 Reviewed-by:
-
Stefan Bürk authored
Update `ext:styleguide` to ensure it contains the changes to avoid automatic TCA migration deprecation, because of recently introduced associative array keys for TCA items with #99739 and https://github.com/TYPO3/styleguide/pull/372 in `ext:styleguide`. Used command(s): > composer update --dev typo3/cms-styleguide Resolves: #100238 Related: #99739 Releases: main Change-Id: I4dff9c72de48a3e9d82d32a65e7cbd95483e0201 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78196 Reviewed-by:
-
Christian Kuhn authored
MissingTsfeException: This one is useless, we can simply return false in the expression function instead of throwing the exception. InvalidTypoScriptConditionException: This was rendered unused with the refactoring of the condition matcher and expression language TypoScript implementation in patch #100047. Resolves: #100237 Related: #100047 Releases: main Change-Id: Ic6732bbb07b5e38deee8d94921eac12041f00e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78195 Reviewed-by:
-
Jochen Roth authored
Currently, users have to use the list module and click on the root page to add/edit/remove a task group. This has been changed by adding editing features for groups within the module. Resolves: #99874 Releases: main Change-Id: I0103ca853649382cf055d612dd4f4d657d90dc64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77781 Tested-by:
-
Alexander Schnitzler authored
Prior to this change, buildBaseValidatorConjunction() was responsible for initializing $this->baseValidatorConjunctions[$indexKey] and additionally adding an object validator if the given target type was a class name. Now, the initialization takes place in getBaseValidatorConjunction() already and buildBaseValidatorConjunction() is only called if target types is a class name. That way, buildBaseValidatorConjunction() gets rid of an if-statement and the whole method looses one indentation. Additionally, buildBaseValidatorConjunction() is guaranteed to get passed a class-string, so argument name $targetClassName actually makes sense. Releases: main Resolves: #100191 Change-Id: I7003fa1e827274e0a1eed3674e675a6f30a6c07c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78142 Reviewed-by:
-
Nikita Hovratov authored
The TCA types select, radio and check now have associative array keys for their items array. The mapping is as following: 0 => 'label' (select, radio, check) 1 => 'value' (select, radio) 2 => 'icon' (select) 3 => 'group' (select) 4 => 'description' (select; renderType=selectCheckBox) This change eases the introduction of new functionality to the items array in the future and provides a vastly improved code readability. Resolves: #99739 Releases: main Change-Id: Id0586bc8f8e1e0624eed5925be645e7b39692469 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77626 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Benjamin Kott authored
We are now introducing the modern filelist rendering to the folder create browser. This patch also includes removes some leftover code from AbstractResourceLinkHandler and a bugfix for a wrong identifier PageLinkHandler. Releases: main Resolves: #100225 Change-Id: I5b6bb0a6dc773e3959483ca7f7e10dedf5adc0de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78179 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Stefan Bürk authored
A new PSR-14 event `BeforeRedirectMatchDomainEvent` is introduced to the RedirectService, allowing extension authors to implement a custom redirect matching. This can be used to implement custom logic to match the request and determine a redirect. For example, dealing with `GET` request params and changing the target based on the value of an parameter. Therefore, special and rare use-cases can be implemented avoiding complex all-scenario match logic in the core and keeping it to a generic and overall cases in the core-implementation. Resolves: #99803 Releases: main Change-Id: I1819c3cd27b6a764000b61dc9cde580fa3b6d40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77675 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Stefan Bürk authored
A new PSR-14 event "ModifyRedirectManagementControllerViewDataEvent" is introduced, allowing extension authors to modify or enrich view data for the ManagementController. Especially view is exchanged to display more or other information along the way. Resolves: #99802 Releases: main Change-Id: I774ca9b7ddecc4e1088baccd80fb8460e4297548 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77672 Tested-by:
-
Oliver Klee authored
Function callbacks are declared using the new PHP 8.1 feature "first class callable", which e.g. uses the named `trim(...)` function symbol, instead of the string `'trim'`. see https://www.php.net/manual/en/functions.first_class_callable_syntax.php Resolves: #100147 Releases: main Change-Id: Id4577fb5412163f5e49927f2f404f21d82a8e9e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78100 Reviewed-by:
-
- Mar 20, 2023
-
-
Alexander Schnitzler authored
Releases: main Resolves: #100200 Change-Id: Ic4837e21e477b4b1d26665428e282eab729ab927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78148 Reviewed-by:
-
Benjamin Serfhos authored
Resolves: #100210 Releases: main Change-Id: I3a011cf4b964bdb580015ee3719ada9a8f03a62c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78158 Reviewed-by:
Benjamin Serfhos <serfhos@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
The common multi record selection actions "edit multiple" and "delete multiple" are now available as separate modules. This allows to use them without duplicating corresponding code over and over. Additionally is the already available base class extended for a common function to fetch the entity identifiers of the selected records. Resolves: #100227 Releases: main Change-Id: Ib336e0f5a459a158da594e234207f4407a735422 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78181 Tested-by:
-
Georg Ringer authored
As editing content is the most used task, the file module should be moved right after the web module instead of having it below the site module. Especially since PageTsConfig and TypoScript are now part of the Sites module, the file module is too far below. Resolves: #100228 Releases: main Change-Id: Ic074e385c85c88371bce139e560da8cf6a1985a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78182 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Josef Glatz <typo3@josefglatz.at>
-
Benni Mack authored
PHP-CS-Fixer 3.15 is now officially PHP 8.2 compatible, so we raise this dependency. See https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.15.0 Used command: composer req --dev friendsofphp/php-cs-fixer:^3.15 Resolves: #100226 Releases: main, 11.5 Change-Id: I21041eae62d32aafba3b7c33edd6e2b975ada957 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78180 Tested-by:
-
Torben Hansen authored
This change replaces all `withConsecutive()` calls in tests by using a callback function to check for consecutive arguments and return values. (`withConsecutive()` is deprecated in PHPUnit 9.6 and removed from PHPUnit 10.) Resolves: #100182 Releases: main Signed-off-by:
-
Georg Ringer authored
Add strtolower calls at `GenericMetaTagManager::removeProperty` to be in sync with `PageRenderer::removeMetaTag`. Resolves: #100198 Releases: main, 11.5 Change-Id: If758375d3293cbcd8897891a866c6cf6fb6df508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78146 Tested-by:
-
Christian Kuhn authored
This patch adds a last feature to the PageTsConfig and TypoScript UI in TYPO3 v12. A simple syntax scanner: * Detect missing and excess braces * Detect invalid lines - for instance "foo <" which missses an identifier stream on the right side. This is a basic set, the main visitor can be extended later to look for additional details, for instance looking for @import lines that can't find any includes. The patch introduces the main logic. Note the "source" display is a bit fiddly currently, it mirrors some issues from the existing "source" display of included nodes: This area should receive fine additional fine tuning patches. Apart from that, the patch finally brings a ReST file about the new / refactored PageTsConfig and TypoScript modules. Change-Id: Id1e6fdcbc294c6f8c3be0520e7e0ae1d50287b16 Resolves: #100218 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77364 Tested-by:
-
Mathias Bolt Lesniak authored
Updates to the Final notes section: * The Expert Advisory Board (EAB), which no longer exists, has been replaced with the TYPO3 Association Board, which does exist and has absorbed the functions of the EAB. * Adds a link to information about the TYPO3 Association * Reformats the "Donate to TYPO3" and "Become a member of the TYPO3 Association" links. * Explicitly links "Become a member of the TYPO3 Association" to the page listing membership options. Resolves: #100217 Releases: main, 11.5, 10.4 Change-Id: I05ad4bf263fe93e62fc50e8f9f9af7e6387d85d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78172 Tested-by:
-
Benni Mack authored
This change finally removes all usages to strftime(), as this function was deprecated in PHP 8.1. It is recommended to use php-intl to use locale-aware date formatting. For places, where no alternative is available (stdWrap and <f:format.date>), a polyfill function, which credits to https://github.com/alphp/strftime is added to the DateFormatter class. Kudos to the original autor "BohwaZ" (https://bohwaz.net/) and the GitHub Repository for allowing us to use this (MIT license). Open Source rocks! Resolves: #95872 Releases: main Change-Id: Ib61170ddc87f12957cbb3d3402fd8eb8b8603a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78161 Reviewed-by:
-
Alexander Schnitzler authored
Extbase extension settings defined in FlexForm always override settings defined globally in TypoScript. This is a problem for FlexForm fields which are empty, since an empty value will always override a possible globally defined TypoScript setting. This behavior might be unwanted and in case of EXT:felogin, it is currently not possible to define various settings in TypoScript (e.g. redirect PIDs, storage PID and more), since they are unintentionally overridden by FlexForm settings. This patch introduces the new extbase TypoScript configuration `ignoreFlexFormSettingsIfEmpty`, which allows extbase extensions to define FlexForm settings, that will be ignored if empty. Additionally, the new PSR-14 event `BeforeFlexFormConfigurationOverrideEvent` is available for extension authors, so a custom FlexForm override process can be implemented. The new feature is now used in ext:felogin to prevent unwanted overrides of globally defined TypoScript extension settings. Resolves: #99976 Related: #92363 Related: #61649 Releases: main Signed-off-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Kott authored
With this change, we are rolling out the universal file-list rendering for files and folders to the link browser. The link browser implementation for files and folders is now part of the file list extension. The link browser now allows the user to choose the display type of resources to match the personal preference between list and tile rendering. When the user now edits a link for a folder, the entry point is now the parent folder of the selected element folder instead of showing the contents of the selected resource. The user now sees the selected folder in the presented list, this behavior mimics the handling of selected files. Resolves: #100206 Releases: main Change-Id: Ib06257b9215ab74cff5039defd56785e63ce0e86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78154 Reviewed-by:
-
Alexander Schnitzler authored
This change converts class TableColumnType to a native, backed enum. Releases: main Resolves: #100220 Change-Id: Ic2a421695cb4099911404b58856d159a2bb981e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78173 Tested-by:
-
Benni Mack authored
A new TypoScript option is introduced to allow to set additional tag attributes to links of pages which are access restricted but link to a login page. This works globally for a page, but also for HMENUs. Globally: config.typolinkLinkAccessRestrictedPages.ATagParams = class="restricted" for HMENUs: page.10 = HMENU page.10.showAccessRestrictedPages = 13 page.10.showAccessRestrictedPages.ATagParams = class="access-restricted" Resolves: #19856 Releases: main Change-Id: I21acdb1ef3290491291acb647c164bcfcee1837f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78165 Tested-by:
-
Alexander Schnitzler authored
In order to have this method more readable, elseif statements are broken apart and replaced with early returns. Releases: main Resolves: #100193 Change-Id: Iea89286280229f7e872c02d75893c4246c6865c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78144 Reviewed-by:
-
Benjamin Kott authored
Resolves: #100164 Releases: main Change-Id: Ie9ec6d5aa098ba29893f0b425291c0339996a644 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78123 Reviewed-by:
-
Benjamin Kott authored
Releases: main Resolves: #100201 Change-Id: If123a7cb0b6892fac35eb4ceaeef5b18bd980103 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78150 Tested-by:
-
- Mar 19, 2023
-
-
Benni Mack authored
When using TYPO3 as a response for multipart result or application/binary responses, TSFE should not append "charset=utf-8" to the Content-Type HTTP response header. Resolves: #100189 Related: #99373 Related: #97550 Releases: main, 11.5 Change-Id: I645bb6941bb4bd01cb508a873e1add074c39ca57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78132 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Mar 18, 2023
-
-
Chris Müller authored
Resolves: #100212 Related: #99834 Releases: main Change-Id: I95c051ee295bf762f632d7a30c65a083f5aab46d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78159 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Benni Mack authored
PHP 8 introduced native Enumerations, which can now be used instead of our own implementation from TYPO3 v7. Enums are effectively singletons making it much faster than previously when used many times. Since LikeWildcard in indexed search is internal and only used internally within indexed search, the usage is rather small. Resolves: #100213 Releases: main Change-Id: I4d3f60c7d4b91e921271487c8688036939403805 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78162 Tested-by:
-
Stefan Froemken authored
If StandaloneView was instanciated as constructor argument you will now get a non shared object. Resolves: #99172 Releases: main Change-Id: I8dc72774eedfb7fd2b24e0106bb8e1ec8ecf2807 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78149 Tested-by:
-
