- Sep 21, 2023
-
-
Stefan Bürk authored
In `ContentObjectRenderer->getImgResource()` null coalescing operator has been used to guard type errors. That has been guarded by a early array check and ensurance, therefore the guards are obselete. Remove them ! Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101982 Releases: main, 12.4 Change-Id: Ic178e29a5d99ded62738707dc285f2c031330fb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81119 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com>
-
- Sep 20, 2023
-
-
Benni Mack authored
When using TypoScript, the setting "sample" allows to scale faster than with "geometry" setting. However, when FAL was introduced the setting was called "useSample" which never worked since TYPO3 v6.0 in conjunction with FAL. The option is however useful and is now working again. The according code is moved into GraphicalFunctions in order to avoid future access to this public property. Resolves: #101981 Releases: main, 12.4 Change-Id: I5c926460d4c5393c418d1e90fcb11052ab3e5cae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81115 Tested-by:
-
Oliver Bartsch authored
In case a user does not have access to the physical file, containing the online media id, this does no longer lead to an exception, which would e.g. prevent the user from accessing any backend module, rendering a preview for such online media asset. Resolves: #80210 Releases: main, 12.4 Change-Id: I4c1a3cfdea211dd1775e57796584416ab7df05d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81117 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Nedbal authored
The previous hashing inputs didn't include the X/Y coordinates or the calculated offsets, so similarly configured GIFBUILDERs had a high likelyhood of loading older images. Adding more inputs, but not falling back to fully encoding all of $this->setup should keep the performance and increase uniqueness. Resolves: #94648 Releases: main, 12.4 Change-Id: Id396f3df34b64317a2ac394d85660b1e8516294a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81118 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Nikita Hovratov authored
Just like SvgImageProcessor, DeferredBackendImageProcessor now also catches the exception, which is thrown, when image dimensions equal zero and falls back to 64x64 image dimension. This enables editors to correct bad image cropping without the need to do it in the database. To be more specific, a new Exception ZeroImageDimensionException is added, which is used in both processors now. The image cropping editor is already fixed to only allow a minimum dimension of 10x10. However, already corrupted files can not be accessed without this patch. Resolves: #93807 Related: #99943 Releases: main, 12.4, 11.5 Change-Id: I259c365052dd02110d43418ba48b768bbe073fc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81111 Tested-by:
-
Stephan Großberndt authored
Remove leftover code of IMGMENU, which has been deprecated in v9 and removed in v10. Resolves: #101979 Related: #101973 Related: #85902 Releases: main Change-Id: I6c0f0df3065ab7b7cc3368d5ba383f0cd27645aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81112 Tested-by:
-
Oliver Bartsch authored
In case a user adds an online media asset, which is already present in the target folder a flash message now properly informs about it instead of stating that the asset was "added successfully". Resolves: #101980 Releases: main, 12.4 Change-Id: Iae2bb05a22cc498a5f0bad1fa5e6723d0c2d99b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81113 Reviewed-by:
-
Andreas Fernandez authored
The JavaScript module `@typo3/backend/document-save-actions` is used in FormEngine and Scheduler context mainly to disable the submit button in the according forms, where also a spinner is rendered within the button to visualize a running action. Over the time, the module took over some tasks that logically belong to FormEngine, which lead to slimming down the module. In a further effort, jQuery has been removed from said module, leading to a change in behavior how the callback chain can be aborted. Native JavaScript events cannot get asked whether event propagation has been stopped, making changes in the callbacks necessary. All callbacks registered via `addPreSubmitCallback()` now need to return a boolean value. Resolves: #101822 Releases: main Change-Id: Ida17480f81d07f8cda43d29455ccf5d0b9ccfff2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80819 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Klee authored
Resolves: #101978 Releases: main Change-Id: Iba3e449c60e82c1f5d379fb52de5e71c82a0e74c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81110 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benni Mack authored
In addition, this class is now fully typed. Resolves: #101954 Releases: main Change-Id: I6bca63321171a24ad4efaac97e19db98b676375d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81087 Tested-by:
-
Sebastian Klein authored
The changelog now shows a current version of the timestamp plugin. In the documentation of EXT:rte_ckeditor, a typo in the plugin namespace is fixed. Both examples show the same code. Resolves: #101971 Releases: main, 12.4 Change-Id: Ic8900bd990717d1887601ddf4ecabebfe78075a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81102 Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Benni Mack authored
Since PHP 8.0, there is a new "\GDImage" object that is used for image manipulation functions. Before, this was a "resource", but can now be type-hinted properly in all cases regarding GifBuilder. This reduces the amount of PHPstan errors for GifBuilder et al to a minimum. Resolves: #101967 Releases: main Change-Id: I0653452efb6295e103c57a53bc60f4de7174b349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81097 Tested-by:
-
Philipp Kitzberger authored
The video ID of a private vimeo video is appended by a hash parameter. This tuple is stored in the pseudo video file (*.vimeo) and needs to be respected when rendering the iframe or fetching data via the vimeo API. Resolves: #97446 Releases: main, 12.4 Change-Id: Icbeac0552c5f78d2dc405ce58daae195c352195e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77609 Tested-by:
-
Benjamin Franzke authored
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-39.html Executed commands: npm install -P $( grep ckeditor5 package.json | \ grep '\^38' | \ grep -v dev-utils | \ sed 's/^[^"]*"\([^"]*\)".*/\1@^39/' \ ) npm run build Resolves: #101917 Releases: main, 12.4 Change-Id: Ie6251df91db88b4609535eb047c8761b49a0164b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81018 Tested-by:
-
Oliver Bartsch authored
When selecting a mass action in the "duplication resolving modal", all individual actions are disabled. On reseting the mass action by selecting the "Please choose" option, the individual actions are now properly enabled again. Resolves: #101972 Releases: main, 12.4 Change-Id: I6f14b53f650b32e41c424438285e336c690dad04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81103 Tested-by:
-
Andreas Fernandez authored
The module `@typo3/core/ajax/ajax-request` previously had a lot of string-based mambo jambo when composing URLs and query strings. The API is now streamlined to use `URL` and its included `searchParams` property to build URLs, removing the need to compose URLs manually. Resolves: #101969 Releases: main Change-Id: I40c73531c86d828fb298f5d6ae1a0bb9030c23cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81098 Tested-by:
-
Andreas Nedbal authored
While public, the addToMap method only filled a protected property without an accessor, so while a image map exists, it is never used in GifBuilder or outside of it, warranting the removal of useless functionality. Resolves: #101973 Releases: main Change-Id: If375d5060b966054698012eb97153121d31f9385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81104 Tested-by:
-
Oliver Bartsch authored
Instead of manually resolving the path of the processed thumbnail image, use FAL API "getForLocalProcessing". This prevents wrong paths when using storages with "baseUri" set. Resolves: #101968 Related: #82855 Releases: main Change-Id: I08d4b64c115ca7ecdab8233b36de801e22109e9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81099 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Bartsch authored
Due to another couple of use cases, the necessary fields to generate the record title, used in the "record saved" notification in FormEngine, are now always fetched, if not already present. Additionally, it's now ensured that the "uid" is always available, since it is necessary for labels with foreign table lookups. Resolves: #101964 Releases: main, 12.4 Change-Id: I933211f582e31c7af9fea909075420316a81a544 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81095 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
This change is a overhaul of the LocalDriver class after 12 years. All comments are updated, types are added, where possible. Resolves: #101468 Releases: main Change-Id: Ie639d352415a67a8f4d499913b5c30f8d6e1b33b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81041 Tested-by:
-
Andreas Nedbal authored
A lot of the methods implemented in GraphicalFunctions are only used in GifBuilder, thus it makes sense to move them into that class. This also coincides with most of these methods utilizing GDlib while the remaining methods in GraphicalFunctions now mostly access and work with Image/GraphicsMagick. In addition, some helper methods are in place in order to keep the existing logic in the installer available to verify image generation. In the long term, a new API is introduced to utilize base methods for GDLib and ImageMagick into separate classes by encapsulating the actual commands, whereas GifBuilder will remain the "TypoScript" entrypoint to work with Images from cObjects. Resolves: #101955 Releases: main Change-Id: If22cf3800effc5a3a11a8bf9f224f91ba6225d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81089 Reviewed-by:
-
Stefan Froemken authored
Deleting a missing file will not throw exception "InsufficientFileWritePermissionsException" anymore, as a missing file has nothing to do with insufficient file permissions. Preventing that exception allows calling the event "FileDeletionAspect" to remove remaining file related records. Resolves: #101725 Releases: main, 12.4 Change-Id: I272466a47a67358ec4e09cc73d2ffec1339f1b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80613 Tested-by:
-
Oliver Hader authored
This change uses the dependency ordering service in the method `\TYPO3\TestingFramework\Core\Testbase::setUpPackageStates` for test scenarios in functional and acceptance tests. Besides that the following changes were applied: * remove invalid dependency in fixture ext:test_configoverride_second * add `PackageStatesTest` to keep track of extension dependencies * add dependency to ext:frontend in ext:form, since it overrides TCA for the tables tt_content and sys_template (which would result in different ext:impexp results due to table field orderings) * recreate IRRE related XML fixtures for ext:impexp since fixture extensions are now ordered alphabetically (and due to #100734) Resolves: #101809 Releases: main, 12.4 Change-Id: I1f91a75ac8aec9db0291b0f5c8bcf7162d5b0082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81076 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benjamin Kott authored
Resolves: #101953 Releases: main, 12.4 Change-Id: I1b0d715a96ee914dc8f9787089406457b750df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81086 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="group" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=group. Resolves: #101908 Related: #101553 Releases: main Change-Id: I355b1e83c367c08e7c0e6428e563798aa49fe766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80990 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Sep 19, 2023
-
-
Benni Mack authored
When the crop object is serialized in a wrong manner or does not contain all information. In order to avoid PHP errors, the casting is done so the page still gets rendered. Resolves: #93138 Releases: main, 12.4, 11.5 Change-Id: Ia71dc81363c519a663c9cc91e2f0f200e7570832 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81079 Reviewed-by:
-
Oliver Bartsch authored
A new controller is added, which allows to update Metadata of online media assets. This basically updates the preview image and some basic data like author and the assets dimensions. To trigger the update, a new action is available in the context menu and the secondary dropdown of online media assets. The functionality can be extended in the future to update further information like the asset's title. However, this needs some more considerations, because an editor might already changed the title intentionally. Resolves: #82855 Releases: main Change-Id: Iba82400c582de0d4e7b2d4eab219a86bc4830be6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81083 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Sebastian Tittel <sebastiantittel@mail.de> Reviewed-by:
-
Stefan Froemken authored
This introduces a new "Edit Metadata" button to the element information view of files, allowing to directly edit the file's Metadata without losing the context. Resolves: #99165 Releases: main Change-Id: Ie32d3bdb31013c195f0efc58cb830c35c6d64a9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76769 Tested-by:
-
Benni Mack authored
GifBuilder is currently a subclass of GraphicalFunctions. Some places only use logic of GraphicalFunctions, even though GifBuilder is instantiated. This patch adapts these places. Resolves: #101956 Releases: main Change-Id: I437d2836ca8d4ae930e6655bd8da268b0db01ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81088 Tested-by:
-
Benni Mack authored
FileProcessingService and its surrounding code within File / FileReference / ResourceStorage and ProcessedFileRepository was hinted to use "FileInterface" which is technically wrong, and - if used - throws a PHP 8 warning because the ProcessedFileRepository checks for the "uid" which is not present in a FileInterface (only for FileReferences, File and ProcessedFile objects). Since it is technically not possible to process a processed file due to the DB relations, this code is now using the correct type hints to avoid PHP errors. In addition, the FileProcessingService is now made DI-aware, so it can injected all necessary services. As this is part of a series to clean up types within FAL in v13, the PHP method signature changes will be documented in a separate commit. Resolves: #101943 Related: #101945 Releases: main Change-Id: I2727cbe12d9f9b507428088ae2c4075af5e90670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81075 Tested-by:
-
Andreas Nedbal authored
This setting stems from an even older setting called 'im_mask_temp_ext_gif' which was introduced because of issues with PNG file generation with some earlier versions of ImageMagick 5. TYPO3 requires at least ImageMagick 6 or newer in recent versions, where PNG generation issues couldn't be observed using this setting. It's obsolete and removed. Resolves: #101950 Releases: main Change-Id: I4d6fd01591c1f36fe22e4019392ffdab2be908a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81084 Tested-by:
-
Christian Kuhn authored
Last usage of <INCLUDE_TYPOSCRIPT is the testing framework. To allow switching to @import, we switch to remaining places to "EXT:" syntax which is allowed in @import as well. Resolves: #101952 Releases: main Change-Id: I434b55db1fc95b7648008a2dacea36d7e565ce86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81085 Tested-by:
-
Benni Mack authored
When FAL was introduced in TYPO3 v6.0, some concepts were introduced which aren't so smart, 11 years later. * Building an AbstractRepository * Using Extbase RepositoryInterface in FAL repositories The shared code between the two implementing classes, FileRepository and AbstractFileRepository isn't justified to use an AbstractRepository which dynamically creates objects through inheritance for its subclass repositories. Instead, the AbstractRepository is now removed and both FileRepository and ProcessedFileRepository are now free, and can also use DI in a way it was meant. For this reason, the whole AbstractRepository class within the "TYPO3\CMS\Core\Resource" namespace is removed along with the dependency to Extbase in this regard. FileRepository and ProcessedFileRepository now only contain the methods they require, and all methods and properties are fully typed. Resolves: #101948 Releases: main Change-Id: I5a1f1fb899e94836cb16c85c2048df264fd59813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81081 Tested-by:
Göran Bodenschatz <g.bodenschatz@ecentral.de> Tested-by:
-
Christian Kuhn authored
There is no point in having namespace declarations in those config files. Releases: main Resolves: #101944 Change-Id: Iccb97731a1e66a45c12d69c01f85def74073f0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81077 Tested-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="language" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema. Resolves: #101915 Related: #101553 Releases: main Change-Id: I8f23278df9aa1991fc4744c3e63ef9689543fd97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81017 Tested-by:
-
Oliver Hader authored
This change extracts dynamic stylesheets of web components that are attached to the light DOM to a corresponding static file in the directory `Build/Sources/Sass/element/` (it will be merged to `backend.css` during the build process). This change allows to get rid of the `window.litNonce` helper function that was introduced to allow CSP for dynamic styles. Besides that, the shadow DOM component `typo3-backend-spinner` now uses constructed stylesheets directly. In addition, the missing component names have been added to the global map. Resolves: #101744 Releases: main, 12.4 Change-Id: I7cf3cdc31d0ffe685897e48f000f18e9b5b5aca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80664 Tested-by:
-
Benjamin Kott authored
To support the right to left reading mode for languages like Arabic, we have adjusted the styles in the backend to use logical instead of physical properties. Resolves: #101902 Releases: main, 12.4 Change-Id: I60936682fbeeb35c676f157e63135137b03106e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80986 Reviewed-by:
-
- Sep 18, 2023
-
-
Oliver Bartsch authored
FileStorageTreeProvider now considers all file mounts, a user (non-admin) has access to, for the file and folder search in the folder tree. Resolves: #98423 Releases: main, 12.4 Change-Id: Id58665392b4351d0c5ecb46335097027f6bf139e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81072 Reviewed-by:
-
Simon Gilli authored
Support for FAL references in FlexForms is added to the FlexFormProcessor. No additional processing is needed anymore to resolve FAL references. Resolves: #94501 Releases: main Change-Id: If3e3355f1dda497be5d7f498b9df85cb56de96d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69753 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
The @internal update() method of MetaDataRepository now checks the data to be updated against the current database row, preventing updating of the records timestamp in case no actual update needs to be done. Additionally, the method now returns the database row. Resolves: #97775 Releases: main, 12.4 Change-Id: I1429605880ec815deb1d6111bc6b1686558b6f5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81046 Tested-by:
-
