[!!!][TASK] Move GIFBUILDER-specific methods into GifBuilder
A lot of the methods implemented in GraphicalFunctions are only used in GifBuilder, thus it makes sense to move them into that class. This also coincides with most of these methods utilizing GDlib while the remaining methods in GraphicalFunctions now mostly access and work with Image/GraphicsMagick. In addition, some helper methods are in place in order to keep the existing logic in the installer available to verify image generation. In the long term, a new API is introduced to utilize base methods for GDLib and ImageMagick into separate classes by encapsulating the actual commands, whereas GifBuilder will remain the "TypoScript" entrypoint to work with Images from cObjects. Resolves: #101955 Releases: main Change-Id: If22cf3800effc5a3a11a8bf9f224f91ba6225d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81089 Reviewed-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
Showing
- Build/phpstan/phpstan-baseline.neon 141 additions, 141 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php 75 additions, 2133 deletionstypo3/sysext/core/Classes/Imaging/GraphicalFunctions.php
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php 4 additions, 5 deletions...t/core/Classes/Resource/Processing/LocalPreviewHelper.php
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101955-RemovedPublicMethodsRelatedToImageGeneration.rst 118 additions, 0 deletions...g-101955-RemovedPublicMethodsRelatedToImageGeneration.rst
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php 1 addition, 1 deletion.../frontend/Classes/ContentObject/ContentObjectRenderer.php
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php 2180 additions, 231 deletionstypo3/sysext/frontend/Classes/Imaging/GifBuilder.php
- typo3/sysext/install/Classes/Controller/EnvironmentController.php 125 additions, 113 deletions...sext/install/Classes/Controller/EnvironmentController.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php 196 additions, 0 deletions.../Configuration/ExtensionScanner/Php/MethodCallMatcher.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php 7 additions, 1 deletion...guration/ExtensionScanner/Php/MethodCallStaticMatcher.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php 35 additions, 0 deletions...uration/ExtensionScanner/Php/PropertyProtectedMatcher.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php 50 additions, 0 deletions...figuration/ExtensionScanner/Php/PropertyPublicMatcher.php
Please register or sign in to comment