Skip to content
Snippets Groups Projects
Commit e60da491 authored by Benni Mack's avatar Benni Mack
Browse files

[TASK] Use proper File objects in FileProcessingService

FileProcessingService and its surrounding code
within File / FileReference / ResourceStorage and
ProcessedFileRepository was hinted to use "FileInterface"
which is technically wrong, and - if used - throws
a PHP 8 warning because the ProcessedFileRepository
checks for the "uid" which is not present in a FileInterface
(only for FileReferences, File and ProcessedFile objects).

Since it is technically not possible to process a processed
file due to the DB relations, this code is now
using the correct type hints to avoid PHP errors.

In addition, the FileProcessingService is now made DI-aware,
so it can injected all necessary services.

As this is part of a series to clean up types within
FAL in v13, the PHP method signature changes will
be documented in a separate commit.

Resolves: #101943
Related: #101945
Releases: main
Change-Id: I2727cbe12d9f9b507428088ae2c4075af5e90670
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81075


Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
parent cff5ba85
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment