- Apr 11, 2023
-
-
Christian Kuhn authored
When the "Access" module is called without a selected page, the root page icon rendering triggers a PHP 8.0 array access warning. This was triggered by the refactoring with #100454, but is a general issue of the method, which is why the patch should go to 11.5 as well. The patch sanitizes $row['uid']. Other parts of the method access further array keys without fallback, but those should be fine - at least for now - since this is about 'pages', and if there is a uid, the other fields are probably provided as well. Resolves: #100527 Related: #100454 Releases: main, 11.5 Change-Id: I40df9fcb86a145cfa68f7dc3086649c52efe7d79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78535 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Jasmina Ließmann authored
Display description to improve understanding of this submodule. Usage of card module to split the sections into two columns. Adding a hint if no records were found. Resolves: #100546 Releases: main Change-Id: I9e1ebd58fa86321fa11285afec1b8980f4a77f68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78554 Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
-
Benjamin Kott authored
To better support RTL languages we start dropping the legacy bootstrap directional class names for text alignment and start using the logical property names instead. Resolves: #100525 Releases: main Change-Id: I6d1f8b0add80a3473314451d402d61ee75a6a91e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78533 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christoph Lehmann authored
TSFE->page now holds a copy of the page in default language, so it can be re-used. Resolves: #100371 Releases: main Change-Id: I2f80a9d2e29e9baf3b1747e67d47e3130706205d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78344 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Kott authored
This patch enables strict types for the Icon:class. We are also introducing a fluent setter object pattern for and introducing a title property that can set to be rendered directly on the icon. This will avoid unnessesary <span title="...">...</span> wraps around rendered icons, since it can now be added directly to the icon. .. code-block:: php // Before $iconMarkup = ' <span title="title"> ' . $this->iconFactory->getIcon('actions-open')->render() . ' </span> '; // After $iconMarkup = $this->iconFactory->getIcon('actions-open') ->setTitle('title') ->render(); Resolves: #100543 Releases: main Change-Id: Ife55cbde49e626fea916cfb6e6af1134e121ae2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78551 Reviewed-by: -
Jasmina Ließmann authored
In submodule "Manage Reference Index" the instructions for command line usage have been moved into an infobox. Resolves: #100545 Releases: main Change-Id: I9394947737e097462d62f39fc6eaa1bf7064fe85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78553 Reviewed-by:
-
Wouter Wolters authored
Test classes should never extend each other. phpunit 10 is also a bit more picky about naming of abstract test cases. The patch adds a script to verify all test case files are declared final, adds it to CI, and adapts existing tests accordingly. > Build/Scripts/runTests.sh -s checkTestClassFinal Change-Id: I07581bffebe42a82fafc56a9bc6cae7c46508b1a Resolves: #100544 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78460 Tested-by:
-
Benjamin Kott authored
Resolves: #100540 Releases: main Change-Id: I4acdefdf455bff6e855ce130c8165a398f271a6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78548 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Benjamin Kott authored
Resolves: #100542 Releases: main Change-Id: I0de8551dfa466ea2d4db7cee86c3003e1620f430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78550 Tested-by:
-
Benjamin Kott authored
The problem with the current implementation is that it does not consider that a tab may already be active but not visible initially. In that case the `shown.bs.tab` event is never triggered. We are moving to an observer that stays active until the element is visible once, after that the observer for the tree is de-registered. Resolves: #97082 Releases: main, 11.5 Change-Id: If63534ac28afd7d7ca53a963f6fad34ae9522885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78541 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Oliver Hader authored
Since issue #100270 some icons are not rendered anymore in the backend when having a strict `style-src` CSP directive enabled (not allowing `'unsafe-inline'`, using a `'nonce-...'` instead). Resolves: #100547 Related: #100270 Releases: main Change-Id: Ida6b51641536dc89c022dbf155ad4c2e44e56632 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78555 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benjamin Kott authored
To avoid double borders at the bottom for tables in a .table-fit wrapper the default border-bottom, for the last row is removed. The current version forgot to consider that there can be multiple tbody or tfoot. The selector is now adjusted to consider this. For bordered tables, a double border appeared at the top, this one is now also correctly removed. Captions are now supported in a .table-fit wrapper and placed correctly. Resolves: #100533 Releases: main Change-Id: I1ce699c175cb4248e4803b872355918e6f22cb24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78543 Tested-by:
-
- Apr 10, 2023
-
-
Tymoteusz Motylewski authored
Add more test cases found when running mutation tests. Resolves: #100532 Releases: master, 11.5 Change-Id: I3dc61e303351d4f63b4b4ad757f21188f1e60117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78542 Tested-by:
-
Benjamin Kott authored
Resolves: #100541 Releases: master Change-Id: I77acf7bfa17432103fc198acc1d9c8900934a363 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78549 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
- Apr 09, 2023
-
-
Benjamin Kott authored
Resolves: #100270 Releases: main Change-Id: Iab72c6ac0952d740f283cbe1860554b10a96abb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78228 Tested-by:
-
Jasmina Ließmann authored
Previously, the form fields in the add/edit form of a task were displayed in their entirety, filling the screen. Additional settings were placed at the end of the form, so that changes to this area were usually not visible when the task type was changed. With this patch, the width of the input mask is now reduced in order to increase the clarity within the form and to create a uniform appearance with forms of the form engine. The markup of the checkboxes has been slightly adjusted, the position of the button for selecting a start page ('LinkValidator' task) has been corrected and individual spacing between the form fields has also been adjusted to match those of the form engine. In order to better guide the user in the setting steps, the fields are now grouped into form areas according to their purpose. Likewise, the fields for advanced settings are moved to a higher position so that changes in this area are more visible when changing the task type. The task type is now also displayed in the edit form. In general, this patch aligns the add/edit task rendering of the scheduler module more with FormEngine rendering. Mid-term, this module should use FormEngine for rendering anyways, so this is a kind of a pre-patch. There is a minor glitch when single tasks don't provide additional fields, now having a lonely heading. We may change this with a dedicated patch since it's a bit tricky with the current javascript hide/unhide implemenation of additional fields. Resolves: #100042 Releases: main Change-Id: Ia8b16c07167d5b368a31ba66be5db3d96481a809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77977 Tested-by: -
Chris Müller authored
Replace "self" in callables by their first class callable syntax. Resolves: #100534 Related: #99499 Releases: main Change-Id: I9cdc016d018dd8fa7fbed22c0f5bc4e67fcc1b5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78544 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Apr 08, 2023
-
-
Benjamin Kott authored
Executed commands: npm install @typo3/icons@^3.6.0 npm run build Resolves: #100530 Releases: main Change-Id: Ib4007e558038fb3c44b3cc2ed093440aa7b86984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78539 Tested-by:
-
Benjamin Kott authored
Resolves: #100531 Releases: main Change-Id: I7bed93133978fd15e6e1efb36205b6e116f75461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78540 Tested-by:
-
- Apr 07, 2023
-
-
Benjamin Kott authored
Today we are dropping the removal of breaks in compiled CSS. This will hopefully make the need for rebasing of CSS patches less likely and improve the readability of compiled CSS massively and better shows the impact of changes. With the current state of CSS the overall increase of file size will be marginally and not noticeable at all. This is a well thought through tradeoff, that feels more than acceptable. The differences in size are listed below: adminpanel.css - without breaks: 40.3 kB - with breaks: 40.6 kB webfont.css - without breaks: 3.09 kB - with breaks: 3.1 kB backend.css: - without breaks: 380 kb - with breaks: 385 kB dashboard.css: - without breaks: 6.97 kB - with breaks: 7.06 kB dashboard/modal.css - without breaks: 1.21 kB - with breaks: 1.22 kB form.css - without breaks: 28 kB - with breaks: 28.3 kB workspaces.css - without breaks: 3.05 kB - with breaks: 3.09 kB Note: Those files are transferred using compression usually. That means the additional white spaces will be almost eliminated by brotli and colleagues. Resolves: #100529 Releases: main Change-Id: I12c5f018cdd92512127915753a536eb4f41dee0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78538 Reviewed-by:
-
Benjamin Kott authored
This is the first step to correct the CSS list-tree. Even it is documented in the style guide extension it was managed to have several kinds of implementation through the core. To make it clear and force people to look up the actual use, we are now also streamlining the naming scheme. Old: .list-tree New: .treelist This led to a misplacement of the open/collapsed indicator/toggle of tree branches. The control element was somehow moved inside the treelist-group, which is purely intended to handle a single row of informational content. In addition collapse classes were mixed up with tree stylings, which lead to cut-off indicators, and sluggish opening and close animations. Helpers to make tables responsive where used out of place to achieve similar but different behavior for panels that are intended to overflow if the content is too long. The diff component was used in an unintended space and was not used as documented. That made manual adaptions necessary that now have been revoked. Instead, we now only apply the table structure only if the nesting is correct. So the parts of the component can be used in other places for now. While we are here, we are adapting and streamlining the colors of the diff component. All randomly placed text-monospace classes were removed from the table rendering and are now only applied to the information group if necessary. This avoids having badges, buttons, etc restyled to a monospace font. The styling adaptions in the import/export module were incomplete and several necessary corrections were missing. We now made it easier to define the background color for the element. Misplaced control CSS classes that seem to be leftovers have been removed from elements they don`t belong to. As mentioned, this patch is part of the ongoing cleanup and has no intention to be finished or solve all the remaining issues. Resolves: #100476 Releases: main Change-Id: I675496fbcc1205ce243daa74ff99ade28fb03efe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78485 Reviewed-by:
-
Benjamin Kott authored
Resolves: #100528 Releases: main Change-Id: I1d15e3d74de7fbb9bec4c8e99e2e0af90f996ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78537 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Benjamin Kott authored
We are introducing new table columns for avatar, time and datetime in preparation for more adoptions. The avatar column also removes the space on the right to bring it closer to the name of the user while having a fixed size for medium avatars. To avoid column jumping we also limit the size of the icon column to the width of a small icon that is normally used in the tables in the backend. The new time and datetime column classes are utilizing the character unit and ensuring that the value is not wrapped to ensure a better reading experience across multiple tables. The button sizes in the table are now aligned with the list module and the delete actions now feature an icon in addition to the text. - Unnecessary/meaningless table headers for actions and icons are removed - Unnecessary div blocks for the grouped log entries are removed. - Unnecessary invisible divider was removed Resolves: #100511 Releases: main Change-Id: I15b4e42d31fc9426cfc20de36b39478eabb0ba33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78519 Tested-by:
-
Benjamin Kott authored
We are updating the browserlist to ensure we are not shipping unnecessary polyfills. npx update-browserslist-db@latest More Information: https://github.com/browserslist/update-db#readme Resolves: #100519 Releases: main Change-Id: I35bc618c667f594691888e38d342570e76e94bff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78524 Tested-by:
-
Torben Hansen authored
Since #99739 the TCA types select, radio and check use associative array keys for their items. In ext:lowlevel DatabaseIntegrityController, some functions still access indexed array keys, which leads to a PHP warning. This change ensures that the associative array keys introduced in #99739 are used. Resolves: #100521 Releases: main Signed-off-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #100489 Related: #99739 Releases: main Change-Id: I83b9632156d8f061ab3f0b710eb3639c95fb03b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78527 Reviewed-by:
-
Oliver Bartsch authored
Reference index errors are now rendered as a list. Resolves: #100509 Releases: main Change-Id: I8e46ea6e480172891a64424acb8c8e4acb3204dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78516 Tested-by:
-
Oliver Klee authored
This is a pre-patch to a bugfix. Resolves: #100491 Related: #100428 Releases: main Change-Id: I981f4f465ebacacdceaed4bfed151ce0d3ae3e3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78497 Tested-by:
-
Christian Kuhn authored
Test classes (*.Test.php) should not extend each other. If really needed, they can rely on abstracts (Abstract*TestCase.php) files for common functionality. Also, .csv fixture files shouldn't be cross used between extensions and functional and functionalDeprecated directories to avoid dead files. Avoid this for a deprecated test case. Resolves: #100523 Releases: main Change-Id: I00d9ca57cbfc90f4b4e412859e72ae3b55f2fadb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78531 Tested-by:
-
- Apr 06, 2023
-
-
Benjamin Kott authored
The web component should behave like a button, there is no need to have another button nested inside. Resolves: #100513 Releases: main Change-Id: I9ff0f64f751cdbe5968788515cff324777957dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78521 Reviewed-by:
-
Oliver Bartsch authored
This replaces usage of native attributes for custom properties to avoid unintended side effects. Resolves: #100474 Releases: main Change-Id: I3fdf9ae8a8b003f09c464af1b5e2d2355a50f38c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78482 Reviewed-by:
-
Oliver Bartsch authored
Add the fields "perms_user" and "perms_group" to the custom database query, since they are required by calcPerms() to properly calculate page permissions for non-admin users. Additionally an early return is added, which prevents fetching any page in case the user is not allowed to edit them at all. Resolves: #100085 Releases: main Change-Id: Ieb222bc11a61ea324319e1d883f02799447b2a30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78381 Reviewed-by:
Sybille Peters <sypets@gmx.de>
-
Oliver Bartsch authored
Rarely used fixCopyAfterDuplFields method in DataHandler is cleaned up, since a couple of arguments and options do no longer work due to previous removals. Actually the method is meanwhile only called once. Resolves: #100506 Releases: main Change-Id: I5396204943c14e1d867d9da8f5909725e50f40b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78514 Tested-by:
-
Oliver Bartsch authored
Due to an invalid page link, e.g. "t3://page?type=123", the "pageuid" key might not be set by PageLinkHandler. This is now properly handled in the parser. Resolves: #100510 Releases: main, 11.5 Change-Id: I0bc35cc1e3c0f5128ea52e3645faeaa5c600faaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78518 Reviewed-by:
-
Chris Müller authored
Resolves: #100522 Related: #100278 Releases: main Change-Id: I81fd92941ca87935f8a8c273a32692bf820fc63c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78528 Tested-by:
-
Benjamin Kott authored
Resolves: #100501 Releases: main Change-Id: I70f8de84b5caa7ca733b34fc25d9a65f29dba389 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78508 Tested-by:
-
Andreas Fernandez authored
With #99739, associated array keys for TCA items were introduced. Unfortunately this introduced a regression in the "Fileoperation permissions" section in "Compare Backend Users" where all information was not rendered, which is now fixed in the patch. Resolves: #100514 Related: #99739 Releases: main Change-Id: I53663a22149f878340f06d07e6241d815c37f600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78522 Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework:dev-main now got the most important patches for phpunit 10 compatibility. This needs to be raised. > composer u typo3/testing-framework Resolves: #100512 Related: #100249 Releases: main Change-Id: Ib737de1d1f5c9c9fb5f135054338ea573bbbc9fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78520 Reviewed-by:
-
Benjamin Kott authored
Resolves: #100497 Releases: main Change-Id: I378c7bfa1964993dd4a8a9d09caf9c3b2bf70412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78506 Reviewed-by:
-
Andreas Fernandez authored
To get rid of much boilerplate code, the custom component `typo3-extensionmanager-distribution-image` used to render distribution images in EXT:extensionmanager is migrated to Lit. Resolves: #100508 Releases: main Change-Id: I304f666b9a1ff2598c8d7adb705a9f113fb7e2f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78515 Tested-by:
-
