[TASK] Declare all test classes final
Test classes should never extend each other. phpunit 10 is also a bit more picky about naming of abstract test cases. The patch adds a script to verify all test case files are declared final, adds it to CI, and adapts existing tests accordingly. > Build/Scripts/runTests.sh -s checkTestClassFinal Change-Id: I07581bffebe42a82fafc56a9bc6cae7c46508b1a Resolves: #100544 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78460 Tested-by:core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- Build/Scripts/runTests.sh 7 additions, 0 deletionsBuild/Scripts/runTests.sh
- Build/Scripts/testClassFinalChecker.php 87 additions, 0 deletionsBuild/Scripts/testClassFinalChecker.php
- Build/gitlab-ci/nightly/integrity.yml 1 addition, 0 deletionsBuild/gitlab-ci/nightly/integrity.yml
- Build/gitlab-ci/pre-merge/integrity.yml 1 addition, 0 deletionsBuild/gitlab-ci/pre-merge/integrity.yml
- Build/phpstan/phpstan-baseline.neon 110 additions, 0 deletionsBuild/phpstan/phpstan-baseline.neon
- Build/testing-docker/local/docker-compose.yml 14 additions, 0 deletionsBuild/testing-docker/local/docker-compose.yml
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php 1 addition, 1 deletion...inpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php 1 addition, 1 deletion...ysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php 1 addition, 1 deletion...dminpanel/Tests/Unit/Service/ConfigurationServiceTest.php
- typo3/sysext/adminpanel/Tests/Unit/Service/ModuleLoaderTest.php 1 addition, 1 deletion...sysext/adminpanel/Tests/Unit/Service/ModuleLoaderTest.php
- typo3/sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php 1 addition, 1 deletion...sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php 1 addition, 1 deletion...end/Tests/Functional/Authentication/PasswordResetTest.php
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php 1 addition, 1 deletion...ts/Functional/Backend/Shortcut/ShortcutRepositoryTest.php
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php 1 addition, 1 deletion...sext/backend/Tests/Functional/Clipboard/ClipboardTest.php
- typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php 1 addition, 1 deletion...tion/SiteConfiguration/SiteConfigurationOverridesTest.php
- typo3/sysext/backend/Tests/Functional/Controller/BackendControllerTest.php 1 addition, 1 deletion...end/Tests/Functional/Controller/BackendControllerTest.php
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php 1 addition, 1 deletion...ests/Functional/Controller/EditDocumentControllerTest.php
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php 1 addition, 1 deletion...ts/Functional/Controller/FormInlineAjaxControllerTest.php
- typo3/sysext/backend/Tests/Functional/Controller/MfaAjaxControllerTest.php 1 addition, 1 deletion...end/Tests/Functional/Controller/MfaAjaxControllerTest.php
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php 1 addition, 1 deletion.../Functional/Controller/MfaConfigurationControllerTest.php
Please register or sign in to comment