- Aug 31, 2021
-
-
Nikita Hovratov authored
Bootstrap 5 dropped the support for data-bs-toggle="buttons". See: https://github.com/twbs/bootstrap/pull/30650 The replacement is to use the class "btn-check" in combination with the state of input fields. This has been done in the Localization module. Some other occurrences didn't rely on the bootstrap js and it was enough to simply remove the data attribute. Also remove a forgotten console.log debug. Resolves: #95048 Releases: master Change-Id: Icd31e7cc0cb9eb1581a7bcfe1448ed7dad24a935 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70832 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andrzej Kołbuc authored
Count Result query now will respect "Show even deleted entries" checkbox Resolves: #94865 Releases: master, 10.4 Change-Id: I2ed3a00f0c0d3e7f31e852a3bd2af5c83d393edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70546 Tested-by:
kharaf <k.haraf@macopedia.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
This patch groups Grunt tasks that can run simultaneously to improve the build performance. To achieve this, the package `grunt-concurrent` is used. On a 2018 Dell XPS 15 with Intel i7-9750H this saves roughly 12 seconds. To check the difference, the command `time grunt build` was executed twice: Sequential build: 48,09s user 10,06s system 154% cpu 37,565 total 50,60s user 11,89s system 154% cpu 40,539 total Parallel build: 77,91s user 5,96s system 261% cpu 28,311 total 67,43s user 5,05s system 262% cpu 27,619 total Due to issues with `grunt-contrib-imagemin`, the subscript `imagemin` is excluded from the `minify_assets` group for now. Resolves: #95016 Releases: master Change-Id: Ic12ff7c0cb43cd0ab050e3e7d1a3a783038189b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70244 Tested-by:
-
Stefan Bürk authored
Add uid as sorting criteria, if not already there for export data retrievement to get determistic sorting across dbms and dbms versions. $ Build/Scripts/runTests.sh -s functional -d mssql \ typo3/sysext/impexp/Tests/Functional/ImportExportTest.php Resolves: #95045 Related: #95032 Releases: master Change-Id: I1586d33b8633be6f4bb0fecca0d9d8497dede588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70829 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Stefan Busemann authored
Redirects which are created automatically, should be bound the page, which triggered the redirect, in order to do further future actions (f.e. publish a redirect if in2publish_core is in usage, show redirects for a page to an editor...). Resolves: #91776 Releases: master Change-Id: I4f611829242d2943a3d8ef8ec408d3222ecc7d32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70597 Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
-
- Aug 30, 2021
-
-
Helmut Hummel authored
With #93048 and #93048 every backend usage of public FAL urls were touched and passed through PathUtility::getAbsoluteWebPath() This change introduces a different approach to register an event listener in a backend middleware, which makes all public URLs absolute. With this, all PathUtility::getAbsoluteWebPath calls for FAL assets became obsolete and are removed again. Releases: master Resolves: #95027 Related: #93226 Related: #93048 Change-Id: I7e2a6eb0b431e50dc430a5641b6fe810bd29f725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70812 Tested-by:
-
Oliver Bartsch authored
The multi record selection component is responsible for managing the selection of records as well as toggling the corresponding actions. It should not implement any component specific action logic, but just dispatch a custom event, informing the component about the requested action. Therefore, the "edit file metadata" handling is moved into the corresponding FileList component. To make life easier for implementing components, the details, any dispatched action event contains, are now extended for the action specific configuration. Furthermore are the ActionConfiguration and ActionEventDetails interfaces now properly exported. This allows to increase type safety in the implementing components. Resolves: #95040 Releases: master Change-Id: I1a5da3eacee5ee86ae5cbacbad8f795c41674c80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70825 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Benni Mack authored
This change introduces a "secondary menu" for all trees and moves the "reload tree" into the secondary menu. In addition, a new icon "Collapse All" is introduced to be in line with the FormEngine Tree Renderer to also have this feature available in all SVG-based trees. Resolves: #95035 Resolves: #91858 Resolves: #94152 Resolves: #92459 Releases: master Change-Id: Id745ff1447bab9c481d9fbc46b2f80d2fb31ad72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68456 Tested-by:
-
Markus Klein authored
Remove old references to SwiftMailer and reference the correct class/interface names. Resolves: #95038 Releases: master, 10.4 Change-Id: I4a0f723c36102c61757a7d9ce5bc6c24c88374b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70824 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Bartsch authored
The multi record selection component, introduced in #94906, is extended for another convenience method, which allows users to select a row by clicking on it. This improves workflows on which multiple records, which are not necessarily next to each other, should be selected. Besides selecting single row, also the keyboard actions, added in #94944, can be used. The feature has to be enabled manually for every module, by placing a data attribute on any parent element of the table rows. This patch however enables the feature for all modules, already using the multi record selection. Resolves: #95034 Related: #94906 Related: 94944 Releases: master Change-Id: I5972db4621431b3d9d87d5b153362ccbb64b54c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70822 Tested-by:
Michael Schams <typo3.mschams@2021.schams.net> Tested-by:
-
Benjamin Franzke authored
A cache:flush CLI command is added that provides lowlevel cache flush functionality as in installtool. It is made extra sure that the command will be executable, even if all caches are stale or even broken. That means this command is able to repair broken di, localconf and tca caches. Technically this became possible due to preparations for lowlevel cli commands in #86248. Releases: master Resolves: #90197 Change-Id: I920867fa8a1ae908acf9788f5de2c6c79eb452d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70797 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benni Mack authored
Our dependency guzzlehttp/psr7 is raised to 2.0, however "LazyOpenStream" is now final, and that's why we need to change our "SelfEmittableLazyOpenStream" to become a decorator of the LazyOpenStream. Used composer commands: composer req guzzlehttp/guzzle:^7.3.0 guzzlehttp/psr7:^2.0 composer req guzzlehttp/guzzle:^7.3.0 guzzlehttp/psr7:^2.0 -d typo3/sysext/core --no-update Resolves: #94454 Releases: master Change-Id: Ica487d9bb04bf344e3d763fa83d561e2771afd21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70437 Tested-by:
-
Oliver Bartsch authored
Since #94662 it's possible to access the site configuration in `foreign_table_where` clauses. The corresponding site configuration was therefore fetched using the SiteFinder, which is however not needed as the SiteResolving data provider already does this. This path therefore replaces the duplicated call to SiteFinder by accessing the Site instance, already present in the result array. Resolves: #95033 Related: #94662 Releases: master Change-Id: I6ea8f09721ff6a3963c1521b8b1476d7e39ddcaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70821 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Stefan Bürk authored
Add uid as sorting criteria for export data retrievement to get determistic sorting across dbms and dbms versions. $ Build/Scripts/runTests.sh -s functional -d postgres -k 12 \ typo3/sysext/impexp/Tests/Functional/ImportExportTest.php $ Build/Scripts/runTests.sh -s functional -d postgres -k 13 \ typo3/sysext/impexp/Tests/Functional/ImportExportTest.php Resolves: #95032 Releases: master Change-Id: I33f8a2d1ad1a1fa8c93e9ee4fb7f43f9db94a60c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70818 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Bartsch authored
Since its introduction, the TOTP provider used the "content-coffee" icon, which did obviously not really suit here. Therefore, the TOTP provider is now using the "actions-qrcode" icon, as a reference on how TOTP can be set up. Resolves: #95031 Releases: master Change-Id: Ie3b476faa7b7fac9fb5e02b09e727c954d2584dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70817 Tested-by:
-
Andreas Fernandez authored
The Core Updater available in the Install Tool now offers the "Update now" button on every community-driven update. Previously, the button was set only in case an ELTS release is available, rendering the Core Updater broken until then. Resolves: #95006 Related: #94745 Releases: master, 10.4, 9.5 Change-Id: I7008e9ee98b07b7e10198890afa51554cd919fd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70770 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
The multi record selection component, introduced in allows to remove the custom checkbox logic next to further improvements. For example, one can now execute actions only for tasks of a specific task group. This is possible since the multi record selection component handles each task group as a separate instance. This is achieved by applying the "multi-record-selection-identifier" to each task group container. Besides, this patch does the following: * Remove any dependency to EXT:recordlist * Fix collapsing of task groups and toggling of icon * Fix tablesort styling, applied to the header cols * Remove unused span tags from the table listing * Always execute tasks via POST Resolves: #94918 Related: #94906 Releases: master Change-Id: Iecc2874cdb32e6c4a2d0552f78a19c61052c046e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 Tested-by:
-
Larry Garfield authored
There are many reasons to not issue a second HTTP request for error pages and instead issue an in-process subrequest. This patch makes that change, and refactors PageContentErrorHandler a bit while there. Resolves: #94402 Releases: master Change-Id: I6da9d753bebc0ef038278185629433587a9b7162 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69547 Tested-by:
-
Andreas Fernandez authored
Executed commands: cd Build yarn add "@typo3/icons@^2.3.0" grunt build Resolves: #95014 Releases: master Change-Id: Id652697d8c7c31224a9c6ea8483500df07ed0d3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70796 Tested-by:
-
Benjamin Franzke authored
A cache:warmup CLI command is added that is safe to be executed during deployment or development mode. It is made extra sure that the command will be executable, even if all caches are stale or even broken. That means this command is able to repair broken di, localconf and tca caches. Technically this became due to preparations for lowlevel cli commands in #86248. Caches that will be warmed up by TYPO3 core: + DI + ext_localconf + TCA + ext_tables + middleware stack + PackageManager + sites-configuration + expressionLanguageProviders + BackendRoutes + l10n (parses all xlf files, and creates cache for all languages) + assets: BackendIcons + dashboard: DashboardPresets + dashboard: WidgetGroups Out of scope or impossible to be warmed: * Frontend warmup: Can be providedby extensions that listen for the CacheWarmupEvent * RequireJS (assets cache): Often applies with context-conditions therefore not reliably warmable. * Extbase – better of for a separate patch intesting cache entries would be: RequestHandlers, ClassSchemata and PersistenceClasses(?) * Warmup of Fluid templates: It is impossible to auto-detect whether all files in Resources/{Templates,Layouts,Partials} are Fluid files. Could by added later on with an explicit registry that allows to define which templates are suitable for warmup. Releases: master Resolves: #93436 Change-Id: I53dd8915a2e06b3d21d778af985c76132e0d4f67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61645 Tested-by:
-
- Aug 29, 2021
-
-
Christian Kuhn authored
Resolves: #95030 Releases: master, 10.4 Change-Id: Ifc27ab7065dd7e9711b9770603bcfab8e70b06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70816 Tested-by:
-
Christian Kuhn authored
Resolves: #95029 Releases: master Change-Id: I444aa1b0161c140c40af2dca455246d8336fa4ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70813 Tested-by:
-
Wouter Wolters authored
The following core extensions are handled: EXT:install Resolves: #94880 Releases: master Change-Id: I2ae58f7f1c5a944394c82bb592ccbdac3bb57352 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70585 Tested-by:
-
Nikita Hovratov authored
This fixes some links to related rst files. Resolves: #94854 Releases: master Change-Id: Ifc981666661846291923adf55b63ecbde62f0cbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70511 Tested-by:
-
Christian Kuhn authored
This minor version raise brings significant performance improvements for functional tests, especially with mysql/mariadb & sqlite. composer req --dev typo3/testing-framework:^6.10.0 Change-Id: I09f8a673f55710b8d237faa280121853dcabc378 Resolves: #95028 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70806 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Aug 28, 2021
-
-
Stephan Bauer authored
Existing configuration should not be overwritten when adding new table options. Releases: master Resolves: #95019 Change-Id: Ie45619e9539e055ef99af1d7cec8cb80b6ed8bde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70802 Tested-by:
-
Oliver Bartsch authored
The multi record selection component is now able to handle multiple instances per page, by using an unique identifier for each instance. Resolves: #95017 Releases: master Change-Id: I31f5a85f74044501912fdc92183408ea9ca03b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70799 Tested-by:
-
- Aug 27, 2021
-
-
Simon Schaufelberger authored
Revert back tick that was introduced in commit 3b03ef46 Releases: master Resolves: #95018 Change-Id: I0ceb8c8f46a2bdd601d9ce0b250fda94e12e3735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70800 Tested-by:
-
Helmut Hummel authored
The idea of this change is, that when using Composer, all TYPO3 extensions, that are part of the Composer installation, should be considered as active and there is no need whatsoever to install code of an extension with Composer (and making all its classes available), but not wanting the extension to interact with TYPO3 API. Therefore with this change, all TYPO3 extensions installed with Composer are considered to be active (and therefore can and will interact with TYPO3 API). Additionally, since the list of active extension is known during Composer installation, a persistent artefact is created at this point, which represents the final state of TYPO3 extension packages for the PackageManager, making both, the PackageStates.php file and the PackageManager cache obsolete for Composer managed TYPO3 installations. Note any extension present in the typo3conf/ext folder, but not installed by Composer, will still be considered and marked as part of TYPO3 packages when doing a "composer install". The only requirement here is, that such extensions need a composer.json file nonetheless. Note this behaviour is deprecated and will be removed with TYPO3 12. Additionally the extension manager UI is adapted to not allow changing the active state of extensions anymore. Respectively the commands "extension:activate" and "extension:deactivate" are disabled in Composer managed systems as well. A new cli command "extension:setup" is introduced, which supersedes both, the extension manager UI as well as the activate/deactivate commands. It performs all steps that were done before, except changing the active state of an extension. With cli command "extension:setup" ALL extensions are set up in terms of database schema changes, static data import, distribution files imports, etc. Last but not least, any installed Composer package, that defines an extra.typo3/cms section in their composer.json file, but is not of type "typo3-cms-extension" at the same time, will be considered for TYPO3 and will have full access to TYPO3 API. It has to be noted though that such packages can not deliver public resources. This remains exclusive for TYPO3 extensions for now. Releases: master Resolves: #94996 Change-Id: I919873dd4ddd087c943f1289a12253c6acec7fa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 Tested-by:
-
Andreas Fernandez authored
Resolves: #94983 Related: #94280 Releases: master Change-Id: Ifb2b8a967de9345e900ad07f9a20fc7ef24e2918 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70744 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Benni Mack authored
LiveSearch, Shortcut and OpenDocs call jump() and thus, uses some "magic" top-level variables to store the actual URL to go to. This is not ideal, and the ModuleMenu should resolve this, preserve the state of the "id" parameter, open the content frame and (optionally) select a module which was in use. The global functions and variables are deprecated now: * top.currentSubScript * top.currentModuleLoaded * top.nextLoadModuleUrl * jump() Resolves: #95011 Releases: master Change-Id: I173fcaf3a90d753b0397e367fb99792edeedba65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70732 Tested-by:
-
Benni Mack authored
TYPO3's PSR-7 implementation has a small flaw when having URLs without a scheme, which should always return an empty string. This change initializes the scheme with an empty string by default. Resolves: #94872 Releases: master, 10.4 Change-Id: If2898d697f37e6e5fc8c4553d0bb500f7fc8b47e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70547 Tested-by:
-
- Aug 26, 2021
-
-
Oliver Hader authored
jQuery `$.proxy` invocation was used prior to ES6 times to have proper `thisArg` scoping in plain JavaScript functions that were used within jQuery events. Since arrow functions are used (which keep their local `thisArg` scope), corresponding `$.proxy` invocations can be removed completely. Resolves: #94970 Releases: master Change-Id: I2c7ec6f3a6140c98482a1c681fbae809c12c5431 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70733 Tested-by:
-
Oliver Bartsch authored
Fixes a regression, introduced in #94315 and restores legacy placeholder in cases it is used in custom error messages, set via TypoScript. Resolves: #95008 Related: #94315 Releases: master Change-Id: I59b95d9d311be81faa73ae14d48f97584882f5fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70771 Tested-by:
-
Jochen Roth authored
Cli commands were fixed by adding a fallback where undefined array key warning occured. Added tests as well to make sure it will work ever after. Resolves: #94763 Releases: master Change-Id: I76e91d61649b5e2c54b83f737e46d679df2526a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70306 Tested-by:
-
Christian Kuhn authored
Extbase ActionController has a view functionality to test if the target template files exist and to render an error message via NotFoundView if not. This is the only use of @internal marked NotFoundView and the only practical usage of extbase ViewInterface canRender(). This structure can be simplified significantly, without loosing functionality. The patch: * Removes @internal NotFoundView and its template * Drops canRender() from ViewInterface * Keeps canRender() in extbase ViewInterface implementations but marks them @deprecated and logs usages. * Changes extbase ActionController to not test canRender() but to let InvalidTemplateResourceException bubble up during $view->render(). This handling as a result - in case of missing templates - provides a full backtrace with a better error message than before, that of course still includes the controller and action name, plus the template location that has not been found. In the frontend, the exception is handled by the casual "plugin based exception handling" (TypoScript config.contentObjectExceptionHandler), a "template missing" programming error is now handled just like any other plugin exception. Resolves: #95003 Releases: master Change-Id: I5e55fdb2f1cfa66682b3b3a6ad0ebd21188dc10e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70762 Tested-by:
-
Christian Kuhn authored
Extbase EmptyView is unused since its introduction in 4.5. Calling render() returns a html comment. It has been substituted by NotFoundView within 4.5 development already. NotFoundView is removed with a different patch, too. Resolves: #95005 Related: #95003 Releases: master Change-Id: I8bbb4a641fa05fe34e2f7eabd7621ec3c0fe7bdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70769 Tested-by:
-
Jochen Roth authored
It's not possible to add rows/colums once all have been deleted manually. This has been fixed by adding a new button next to this "Small fields" button which allows a user to set the needed amount of columns and rows. Resolves: #94802 Releases: master Change-Id: I437d07c5d9176e9c962698882bbacef5eab19349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70443 Tested-by:
-
Wouter Wolters authored
Resolves: #94985 Releases: master Change-Id: I1514630bb43929dd12da15d44110c675b0774a97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70746 Tested-by:
-
Oliver Bartsch authored
The column selector component is moved to EXT:backend. This allows to use it in further modules without adding cross dependencies to EXT:recordlist. Resolves: #94990 Releases: master Change-Id: I97c6ce868e4accfe8906bffcd9b5c272066d5272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70750 Tested-by:
-
