[TASK] Avoid calling inline JavaScript jump()
LiveSearch, Shortcut and OpenDocs call jump() and thus, uses some "magic" top-level variables to store the actual URL to go to. This is not ideal, and the ModuleMenu should resolve this, preserve the state of the "id" parameter, open the content frame and (optionally) select a module which was in use. The global functions and variables are deprecated now: * top.currentSubScript * top.currentModuleLoaded * top.nextLoadModuleUrl * jump() Resolves: #95011 Releases: master Change-Id: I173fcaf3a90d753b0397e367fb99792edeedba65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70732 Tested-by:core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts 1 addition, 1 deletion...backend/Resources/Public/TypeScript/ContextMenuActions.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LiveSearch.ts 7 additions, 3 deletions...eScript/backend/Resources/Public/TypeScript/LiveSearch.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts 32 additions, 26 deletions...eScript/backend/Resources/Public/TypeScript/ModuleMenu.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts 6 additions, 8 deletions...d/Resources/Public/TypeScript/PageTree/PageTreeElement.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar/ShortcutMenu.ts 12 additions, 0 deletions...ckend/Resources/Public/TypeScript/Toolbar/ShortcutMenu.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeContainer.ts 6 additions, 4 deletions...ources/Public/TypeScript/Tree/FileStorageTreeContainer.ts
- Build/Sources/TypeScript/opendocs/Resources/Public/TypeScript/Toolbar/OpendocsMenu.ts 4 additions, 1 deletion...ndocs/Resources/Public/TypeScript/Toolbar/OpendocsMenu.ts
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Toolbar/WorkspacesMenu.ts 7 additions, 9 deletions...ces/Resources/Public/TypeScript/Toolbar/WorkspacesMenu.ts
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php 4 additions, 5 deletions...t/backend/Classes/Backend/Shortcut/ShortcutRepository.php
- typo3/sysext/backend/Resources/Private/Partials/ShortcutToolbarItem/Shortcut.html 1 addition, 1 deletion...ources/Private/Partials/ShortcutToolbarItem/Shortcut.html
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js 1 addition, 1 deletion...backend/Resources/Public/JavaScript/ContextMenuActions.js
- typo3/sysext/backend/Resources/Public/JavaScript/LiveSearch.js 4 additions, 4 deletions.../sysext/backend/Resources/Public/JavaScript/LiveSearch.js
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js 1 addition, 1 deletion.../sysext/backend/Resources/Public/JavaScript/ModuleMenu.js
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js 4 additions, 4 deletions...d/Resources/Public/JavaScript/PageTree/PageTreeElement.js
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js 1 addition, 1 deletion...ckend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.js 2 additions, 2 deletions...ources/Public/JavaScript/Tree/FileStorageTreeContainer.js
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js 12 additions, 8 deletionstypo3/sysext/backend/Resources/Public/JavaScript/backend.js
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php 4 additions, 4 deletions...ts/Functional/Backend/Shortcut/ShortcutRepositoryTest.php
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95011-VariousGlobalJavaScriptFunctionsAndVariables.rst 54 additions, 0 deletions...on-95011-VariousGlobalJavaScriptFunctionsAndVariables.rst
- typo3/sysext/impexp/Classes/Controller/ExportController.php 1 addition, 1 deletiontypo3/sysext/impexp/Classes/Controller/ExportController.php
Please register or sign in to comment