- Sep 03, 2021
-
-
11nd11 authored
Streamline and optimize styling and markup of the new form wizard of form manager. * Clean up markup and use common colors of TYPO3 v11 * Optimize UX and Overview of the new form wizard * Use new common styles and elements for better overview and modern look Resolves: #94805 Releases: master Change-Id: I0be4753be8d414db848453a0e4db941a8b127676 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70681 Tested-by:
Tobias Siegler <siegler.tobias@googlemail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Tobias Siegler <siegler.tobias@googlemail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Jochen Roth authored
Some acceptance tests fail radomly due to speed/timing of the checked elements or unresolved promises. This should be avoided now by using "waitForElements" instead of "canSeeElement". This may cause longer test runs but makes sure tests won't fail on performane hiccups. On top of that Icon.getIcon in DocumentSaveActions will catch unresolved promise in case a new page or reload was triggered by the button to avoid Javascript errors. For example in Scheduler -> Add Task and hit save. Resolves: #95070 Releases: master Change-Id: I927876ecfd46cbc2edae03db249982fcb8a9d2f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70860 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 02, 2021
-
-
Jochen Roth authored
Docker for Mac (and Windows?) currently misuses their users as canary testers by actively activating an "experimental" feature toggle which then ships a docker-compose v2 rc release. docker-composer v2's yaml parsing however is broken (you had ONE job!): It does not properly detect strings as strings and mumbles about this, and worse, it transforms shell "don't linebreak!" '\' operator into linebreaks. This breaks our carefully crafted and formatted testing related docker-compose.yml configuration. The situation persists for weeks already, there is no solution except manually disabling this docker for mac experimental feature toggle. The patch makes runTests.sh detect docker-composer v2, exits out with an error message telling the version is not supported and how to disable it. ddev went with a similar approach recently. Resolves: #95057 Releases: master, 10.4, 9.5 Change-Id: Iee1e6fd28d876262f00aba769a7e047c14db903c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70845 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The multi record selection component, introduced in #94906, is now added to the recordlist as well. Since the component is not bound to the clipboard functionality, this will solve a lot of issues, editors faced when trying to perform actions for multiple records at once. For example, it was previously required to activate the clipboard, change to a numeric "pad" and to copy records to this pad, before any action could be performed. This patch also resolves some smaller bugs related to clipboard actions and does some code cleanup in the DatabaseRecordList class as well as in the corresponding JavaScript module. Resolves: #95068 Related: #94906 Releases: master Change-Id: I5bd3120f71cd4043d778f8116b3cf643b6e72064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70803 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
This is a pre-patch for #95068, simplifying some code in list modules. In detail: * Multi record selection now uses a dedicated class for modules, adding the actions into a "panel" * To prevent JSON parsing errors, the action configuration is now encoded using GeneralUtility::jsonEncodeForHtmlAttribute * The code to add the "new record" button in DatabaseRecordList is streamlined Resolves: #95071 Releases: master Change-Id: If83cef25eee5976b916e9167ca25569749a5d3ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70861 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 01, 2021
-
-
Benjamin Franzke authored
The Build/composer/ directory (recently added in 95046 ) contains all core files (symlinked) once `composer install` has been executed, that means both typoscript and typescript files that end with .ts. This leads to compilation errors. These files must actually be ignored by `tsc` during `grunt build`. and should not be compiled at all (wasted ressources). While at it we also fix the tsconfig.json to include a trailing newline, in order to comply to our coding guidelines. Releases: master Resolves: #95046 Related: #94996 Change-Id: Ic8d4a4af1004e0f8c9ae5c4832b54e1018055ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70830 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Jochen Roth authored
The table editor is currently accessed by using a seperated wizard next to the bodytext field. On each and every "edit" a user needs to click this button to get the table editor. This has been changed by moving the table editor to the regular content edit view and replaces the text area with the table editor. The fields 'table_delimiter' and 'table_enclosure' are not working as expected, but this is not touched by this patch but will hopefully be taken care of in the future. Resolves: #95036 Releases: master Change-Id: I9497987f9d64774b2d1272e4c269ef766caf760c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70823 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change adds a new button to all files and folders to directly download a specific file from the file list or the context menu. In case a folder or multiple files/folders are selected, a zip file is created on-the-fly. Resolves: #90548 Releases: master Change-Id: I666d4b377b995bd95c0a8f0ca95b03fd45d05a0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70820 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
This resolves some problems on using the clipboard in the filelist module. Previously it was for example not possible to transfer files / folders to the clipboard again, after it was cleared, since the corresponding GET parameter was kept in the URL. This is now fixed by assigning the action to the filelist form. Further topics: - Pagination does now use the correct colspan - setCB and delete actions are now handled via multiple record selection events and do not longer rely on "trigger classes" - the superfluous internal "selectedElements" array is removed again, since the display of actions is handled by the multi record selection component anyways Resolves: #95055 Releases: master Change-Id: Iff15716e09d149ed29d72b1ae45e88ba2a43b92d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70841 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Since #94944 the multi record selection allows keyboard shortcuts for an improved UX. It's for example possible to select ranges. Therefore, the last checked element and the current target are used to determine the range. Any operation in case no valid shortcut is used. This however prevents the last checked element from being set. As a result the range determination did not longer work reliably. This is fixed by moving the shortcut check into the already existing guard clause, which does properly set the last checked element. Resolves: #95060 Related: #95034 Releases: master Change-Id: Ibc1c2fdc314b58af3848a4934d1f5e0124de2e55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70847 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 31, 2021
-
-
Nikita Hovratov authored
Bootstrap 5 dropped the support for data-bs-toggle="buttons". See: https://github.com/twbs/bootstrap/pull/30650 The replacement is to use the class "btn-check" in combination with the state of input fields. This has been done in the Localization module. Some other occurrences didn't rely on the bootstrap js and it was enough to simply remove the data attribute. Also remove a forgotten console.log debug. Resolves: #95048 Releases: master Change-Id: Icd31e7cc0cb9eb1581a7bcfe1448ed7dad24a935 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70832 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
This patch groups Grunt tasks that can run simultaneously to improve the build performance. To achieve this, the package `grunt-concurrent` is used. On a 2018 Dell XPS 15 with Intel i7-9750H this saves roughly 12 seconds. To check the difference, the command `time grunt build` was executed twice: Sequential build: 48,09s user 10,06s system 154% cpu 37,565 total 50,60s user 11,89s system 154% cpu 40,539 total Parallel build: 77,91s user 5,96s system 261% cpu 28,311 total 67,43s user 5,05s system 262% cpu 27,619 total Due to issues with `grunt-contrib-imagemin`, the subscript `imagemin` is excluded from the `minify_assets` group for now. Resolves: #95016 Releases: master Change-Id: Ic12ff7c0cb43cd0ab050e3e7d1a3a783038189b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70244 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
- Aug 30, 2021
-
-
Oliver Bartsch authored
The multi record selection component is responsible for managing the selection of records as well as toggling the corresponding actions. It should not implement any component specific action logic, but just dispatch a custom event, informing the component about the requested action. Therefore, the "edit file metadata" handling is moved into the corresponding FileList component. To make life easier for implementing components, the details, any dispatched action event contains, are now extended for the action specific configuration. Furthermore are the ActionConfiguration and ActionEventDetails interfaces now properly exported. This allows to increase type safety in the implementing components. Resolves: #95040 Releases: master Change-Id: I1a5da3eacee5ee86ae5cbacbad8f795c41674c80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70825 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
This change introduces a "secondary menu" for all trees and moves the "reload tree" into the secondary menu. In addition, a new icon "Collapse All" is introduced to be in line with the FormEngine Tree Renderer to also have this feature available in all SVG-based trees. Resolves: #95035 Resolves: #91858 Resolves: #94152 Resolves: #92459 Releases: master Change-Id: Id745ff1447bab9c481d9fbc46b2f80d2fb31ad72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68456 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The multi record selection component, introduced in #94906, is extended for another convenience method, which allows users to select a row by clicking on it. This improves workflows on which multiple records, which are not necessarily next to each other, should be selected. Besides selecting single row, also the keyboard actions, added in #94944, can be used. The feature has to be enabled manually for every module, by placing a data attribute on any parent element of the table rows. This patch however enables the feature for all modules, already using the multi record selection. Resolves: #95034 Related: #94906 Related: 94944 Releases: master Change-Id: I5972db4621431b3d9d87d5b153362ccbb64b54c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70822 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Michael Schams <typo3.mschams@2021.schams.net> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The multi record selection component, introduced in allows to remove the custom checkbox logic next to further improvements. For example, one can now execute actions only for tasks of a specific task group. This is possible since the multi record selection component handles each task group as a separate instance. This is achieved by applying the "multi-record-selection-identifier" to each task group container. Besides, this patch does the following: * Remove any dependency to EXT:recordlist * Fix collapsing of task groups and toggling of icon * Fix tablesort styling, applied to the header cols * Remove unused span tags from the table listing * Always execute tasks via POST Resolves: #94918 Related: #94906 Releases: master Change-Id: Iecc2874cdb32e6c4a2d0552f78a19c61052c046e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70675 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
Executed commands: cd Build yarn add "@typo3/icons@^2.3.0" grunt build Resolves: #95014 Releases: master Change-Id: Id652697d8c7c31224a9c6ea8483500df07ed0d3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70796 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 29, 2021
-
-
Christian Kuhn authored
Resolves: #95030 Releases: master, 10.4 Change-Id: Ifc27ab7065dd7e9711b9770603bcfab8e70b06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70816 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
This minor version raise brings significant performance improvements for functional tests, especially with mysql/mariadb & sqlite. composer req --dev typo3/testing-framework:^6.10.0 Change-Id: I09f8a673f55710b8d237faa280121853dcabc378 Resolves: #95028 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70806 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Aug 28, 2021
-
-
Oliver Bartsch authored
The multi record selection component is now able to handle multiple instances per page, by using an unique identifier for each instance. Resolves: #95017 Releases: master Change-Id: I31f5a85f74044501912fdc92183408ea9ca03b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70799 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- Aug 27, 2021
-
-
Helmut Hummel authored
The idea of this change is, that when using Composer, all TYPO3 extensions, that are part of the Composer installation, should be considered as active and there is no need whatsoever to install code of an extension with Composer (and making all its classes available), but not wanting the extension to interact with TYPO3 API. Therefore with this change, all TYPO3 extensions installed with Composer are considered to be active (and therefore can and will interact with TYPO3 API). Additionally, since the list of active extension is known during Composer installation, a persistent artefact is created at this point, which represents the final state of TYPO3 extension packages for the PackageManager, making both, the PackageStates.php file and the PackageManager cache obsolete for Composer managed TYPO3 installations. Note any extension present in the typo3conf/ext folder, but not installed by Composer, will still be considered and marked as part of TYPO3 packages when doing a "composer install". The only requirement here is, that such extensions need a composer.json file nonetheless. Note this behaviour is deprecated and will be removed with TYPO3 12. Additionally the extension manager UI is adapted to not allow changing the active state of extensions anymore. Respectively the commands "extension:activate" and "extension:deactivate" are disabled in Composer managed systems as well. A new cli command "extension:setup" is introduced, which supersedes both, the extension manager UI as well as the activate/deactivate commands. It performs all steps that were done before, except changing the active state of an extension. With cli command "extension:setup" ALL extensions are set up in terms of database schema changes, static data import, distribution files imports, etc. Last but not least, any installed Composer package, that defines an extra.typo3/cms section in their composer.json file, but is not of type "typo3-cms-extension" at the same time, will be considered for TYPO3 and will have full access to TYPO3 API. It has to be noted though that such packages can not deliver public resources. This remains exclusive for TYPO3 extensions for now. Releases: master Resolves: #94996 Change-Id: I919873dd4ddd087c943f1289a12253c6acec7fa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
Benni Mack authored
LiveSearch, Shortcut and OpenDocs call jump() and thus, uses some "magic" top-level variables to store the actual URL to go to. This is not ideal, and the ModuleMenu should resolve this, preserve the state of the "id" parameter, open the content frame and (optionally) select a module which was in use. The global functions and variables are deprecated now: * top.currentSubScript * top.currentModuleLoaded * top.nextLoadModuleUrl * jump() Resolves: #95011 Releases: master Change-Id: I173fcaf3a90d753b0397e367fb99792edeedba65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70732 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 26, 2021
-
-
Oliver Hader authored
jQuery `$.proxy` invocation was used prior to ES6 times to have proper `thisArg` scoping in plain JavaScript functions that were used within jQuery events. Since arrow functions are used (which keep their local `thisArg` scope), corresponding `$.proxy` invocations can be removed completely. Resolves: #94970 Releases: master Change-Id: I2c7ec6f3a6140c98482a1c681fbae809c12c5431 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70733 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Jochen Roth authored
It's not possible to add rows/colums once all have been deleted manually. This has been fixed by adding a new button next to this "Small fields" button which allows a user to set the needed amount of columns and rows. Resolves: #94802 Releases: master Change-Id: I437d07c5d9176e9c962698882bbacef5eab19349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70443 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The column selector component is moved to EXT:backend. This allows to use it in further modules without adding cross dependencies to EXT:recordlist. Resolves: #94990 Releases: master Change-Id: I97c6ce868e4accfe8906bffcd9b5c272066d5272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70750 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
Creating and editing file metadata translations is usually done in the filelist module. Therefore a custom toggle button in the "Localization" column had to be used. In the expanded state, various flag icons with an hard to guess overlay icon were displayed. Those could be used to either create or edit the file metadata records. This however had some drawbacks: - The toggle button was not accessible by keyboard - As toggle icon, the "pages languages overlay" icon was used, making it hard to understand for editors - As soon as one of those toggle buttons was clicked, all other toggle buttons jumped to the left To improve this, the toggle button is moved into the controls group and does now uses the "actions-translate" icon. It furthermore does now open a dropdown with proper link labels - as already known from the secondary menu. This therefore also increases consistency. Besides the visual changes, this patch also cleans up the underlying code and removes the custom JavaScript component, which was used for the toggle button. Resolves: #94997 Releases: master Change-Id: I898e234d35b125ba37ac6c30874fa206d2515184 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70759 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
Executed commands: cd Build/ yarn upgrade lit@^2.0.0-rc.3 \ lit-html@^2.0.0-rc.4 \ lit-element@^3.0.0-rc.3 \ @lit/reactive-element@1.0.0-rc.3 grunt rollup Resolves: #94943 Releases: master Change-Id: I5140e9782a8a98361dfbcaf8318c74cdc8a05600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70687 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The TOTP info modal displays the OTP auth url along with a description. This content however is added to the modal body by a callback. To prevent the "modal content empty" warning from being shown, the modal is now initialized with an empty string as content. Resolves: #94999 Releases: master Change-Id: I0a8c274466d4f62da8edb26a4c2b547b66be3ba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70761 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Aug 25, 2021
-
-
Jochen Roth authored
Now that we have frontend tests in the Backend suite the name Backend for acceptance suite does not fit anymore. So the suite name was changed from Backend to Application. Resolves: #94864 Releases: master Change-Id: Ib52053f6dbbfad9b7fef1ff11e81110cffa010b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70550 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Uwe Trotzek authored
The workspace module gets an additional stage filter to reduce the amount of changes a user is facing. This is very helpful if you are dealing with a lot of changes and want to see only records which are in a certain stage e.g. "Ready to publish". Resolves: #91021 Releases: master Change-Id: I80a3fa5c00ff302c9b2257370bdeda328033c204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64197 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 24, 2021
-
-
Christoph Schwob authored
Remove duplicate styles but some overrides for e.g. border already needed. Changed class .card-content to .card-body Add card-size-medium to card on ElementInformation to use some empty space, cause there's only one card. Resolves: #94529 Releases: master Change-Id: I1e8d3cdfe8e622806eff4f1e52f3a2bad1740fad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
This change uses the native web component to render icons, instead of referencing them from Fluid. This change also fixes a small issue regarding language icons and integrity icons. Resolves: #94977 Releases: master Change-Id: I3f99139497a5f4691bea30b53e399a860b050090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70735 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The workspace review features the collapse/expand functionality for record relations. An example is tt_content which may contain several sys_file_reference relations. They are included in the listing as well but collapsed by default. Since at least v10 those relations are always processed together. This means, in case an editor checks a parent record and executes an action, e.g. publish, the same action is also executed for the relations. However, the UX was previously not really helpful as this was not visible to the editor. Therefore, and to improve the UX in workspace review, those relations are now always "bound together". This means, when selecting the parent record all relations are selected, too. The same goes the other way round. When selecting a relation, all corresponding relations as well as the parent record are selected. As mentioned, this does not change any functionality as this process was already done "under the hood". This process is now just visualized for the editor. Resolves: #94404 Releases: master, 10.4 Change-Id: I28d2c9e67747dde5ffdfb36d24f8cc7f36c246a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70712 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The multi record selection, introduced in #94906, is extended for keyboard shortcuts. They can be used to achieve similar results as by using the actions in the multi record selection dropdown. * `shift` key: check / uncheck the range between the last checked checkbox and the current one * `option` (Mac) or `ctrl` (Windows/Linux) key: Toggle the current selection Resolves: #94944 Related: #94906 Releases: master Change-Id: Ia5f6625e6b380d908bddfbf5849f2ea6233fe420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70688 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Aug 23, 2021
-
-
Andreas Fernandez authored
The context menu skeleton is partially visible for a very short time, before its items are rendered and event listeners are attached. This is revealed by some flaky acceptance tests and was previously workarounded by an additional ->wait() call in the tests. The context menu stays hidden now until everything is set up and the workaround in the AC tests is removed again. The context menu gets hidden after 500ms once the user moved the mouse out of its boundaries. However, that timeout was never reset which closed another context menu that might have opened within that 500ms time span. To circument this issue, such timeouts are now monitored and cleared again once a new context menu is requested. Resolves: #94891 Releases: master, 10.4 Change-Id: Ia0551d8c0b41edeca27cd0b15e4285a89ad2c171 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70592 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Alexander Nitsche <typo3@alexandernitsche.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Stefan Bürk authored
If the dropzone was not visible, remove it without animation. Resolves: #94892 Releases: master Change-Id: Icfb0090b9383321cd1d24c0aba7026affdbb58d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70594 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Have you ever wondered why "unrelated" records got processed in workspaces review when using one of the mass actions? Simply because the workspace JavaScript component is using an internal array, holding all selected records. This internal array however was only reset on leaving the module. Therefore, all records which had been selected since the module was accessed were taken into account when a mass action was executed. This did not only affect records which were unchecked prior to mass action execution, but also records which were no longer visible at this time, e.g. due to an applied filter. In the worst case, that led to completely unrelated records got published to a live workspace. This is now fixed by resetting the mass action state whenever the listing gets updated. This way, only the selected records in the current view are taken into account when executing a mass action. Resolves: #94405 Releases: master, 10.4 Change-Id: I40cabe66fd7a4eb310a8113f69d49f234cc110a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The workspace JavaScript component tries to fetch the workspace listing on accessing the backend module. Since #94819 this results in a JavaScript TypeError since the provided selector for the progress bar component, used as indicator for the ajax request, might not exist. This is now fixed by checking if the the workspace is actually accessible prior to initiating the ajax call. Resolves: #94946 Related: #94819 Releases: master Change-Id: I0c77564acc197a57e2999f4439daf28ba3fd333c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70724 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The multi record selection component is now also used in the recycler module. This increases consistency, as custom checkbox logic could be removed. Also the recyclers' JavaScript implementation of the selection actions is simplified. To interact with the multi record selection component, some events are used. This also means, the functionality stays the same, while most of it is now handled by the Multi record selection component. Resolves: #94926 Releases: master Change-Id: I57d91d070bfa75c01d4cb87dfd0c5576d111dcfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70678 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Components, using the multi record selection, introduced in #94906, usually do not have to change any checkbox state manually. The multi record selection component is taking care of it. However, there might be cases when a consuming component needs to change checkbox state on its own. An example is the workspaces module, which may changes checkbox state of child records when their parent record got changed. See: #94404. To prevent the components from overriding each other, the multi record selection now respects a special data attribute `manually-changed`. If set on a checkbox element, the multi record selection component will not touch this checkbox, while executing its (mass) actions. Resolves: #94948 Releases: master Change-Id: I35b07ca45cab4b96d3eea93ff45426702a1532d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70713 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-