- Nov 13, 2022
-
-
Nikita Hovratov authored
Resolves: #98753 Releases: main Change-Id: Ibd1b655f8d7563165683e4d8307c9445ac9d3398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76574 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Nov 10, 2022
-
-
Oliver Klee authored
This update makes a warning more specific. Run commands: > composer req --dev phpstan/phpstan:^1.9.2 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99045 Releases: main, 11.5 Change-Id: I4c5af9d69e0e5b8f4b0d78efd4caa4ed79aed795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76538 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 08, 2022
-
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73975 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Nov 07, 2022
-
-
Oliver Klee authored
Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97420 Releases: main Change-Id: Id1ea668b1f313fa74292437755850eaa36511526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74344 Tested-by:
-
- Nov 06, 2022
-
-
Helmut Hummel authored
File meta data extractors have to provide an execution priority and a data priority. The execution priority, which was previously ignored, is now respected and extractors are ordered accordingly in ExtractorRegistry. Extractors with the same data priority can now provide data, while the data was overwritten previously. ExtractorRegistry::getExtractorsWithDriverSupport now returns a flat array of extractors again, not a nested one like introduced in #64942, just like annotated. Because this fix might change the order of the execution of extractors, it can be considered slightly breaking, thus TYPO3 11.5 is not targeted. Related: #64942 Related: #56727 Resolves: #92643 Releases: main Change-Id: I2a54709ba8a389e668b37e6003695ba3316968eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66232 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
This change simplifies further work on the TCA Tree logic. a) use imported names b) ensure to use int|string for Node->getId() as Core uses this for integers within e.g. sys_category c) fix some phpdoc infos d) remove an unused property e) use proper casting for integers f) use $this->lookupField instead of $this->getLookupField() when using 10000 of categories, this function call is superfluous. By using int|string, the changed code if ($node->getId() !== 0 && $node->getId() !== '0') saves 1 (!) DB query on every request. This change is meant also to be backported to v11, for this reason no changes to the types within properties are made (only type hints). Resolves: #99005 Releases: main, 11.5 Change-Id: I291cdd0925f77b0e48e224f207eb5e1b0c4fa041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76444 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Nov 03, 2022
-
-
Nikita Hovratov authored
Also, remove obsolete Fixture functions. Used command(s): > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98749 Related: #87607 Releases: main Change-Id: Ifc75db8d3fcda52d22d47292b43b250de255cd25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76432 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Andreas Fernandez authored
The backend search (aka Live Search) can search for database records only, currently. To make the search able to find anything other than database records a `SearchProviderInterface` is introduced which allows to add new providers in the future and may be used by extension authors in the long run. As the first implementations, the current database record search is extracted into a `DatabaseRecordProvider`, which excludes records from the `pages` table. Additionally, a new `PageRecordProvider` is added which comes with a custom web component that renders additional information for pages only. The changes introduced in this patch are not final and may change in further iterations, therefore all interfaces are declared as "internal" and documentation is missing on purpose. Resolves: #92008 Releases: main Change-Id: I16327f32a5e2bb05cc5f8a80540a2ced94213b39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76118 Tested-by:
-
Benni Mack authored
This is mainly related to test files, where the phpdoc annotations of the affected test classes have been removed, as we now use proper native types, where no additional PHPDoc comment describing the parameters are set. In addition, some further cleanups related to types that have already been properly defined are set. Resolves: #98987 Releases: main Change-Id: I8e82540e9f425799ebb851e66d4149202f81ecfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76398 Tested-by:
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.9.0 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Blog article about the new release: https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type Resolves: #98986 Releases: main, 11.5 Change-Id: I15516853c3a1bac80b80466fe4bae8a0f150ba68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76396 Tested-by:
-
- Oct 30, 2022
-
-
Torben Hansen authored
Resolves: #98887 Releases: main Change-Id: I9231fa207503e258e5bd5ee94c83ea243d3fdd28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76338 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Nikita Hovratov authored
Also, a wrong call to flushByTag(s) is corrected. Resolves: #98735 Releases: main Change-Id: I3f6ecbf7570d6383fb836e81f15aea857efd2032 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76334 Tested-by:
-
- Oct 28, 2022
-
-
Torben Hansen authored
Resolves: #98899 Resolves: #98901 Releases: main Change-Id: Ifb188334c1445e3e8847bca476b6c5182bce829c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76323 Tested-by:
-
- Oct 27, 2022
-
-
Christian Kuhn authored
* Make some unit tests functional test * Remove some state * Avoid last usages of vfsStream > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I3c0e4a1bc10aae042c5b850e817e8211918a0458 Resolves: #98740 Related: #97762 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76309 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Oct 26, 2022
-
-
Oliver Klee authored
Resolves: #98937 Related: #98936 Releases: main Change-Id: I55ed2c9546312c8bc9b99ffae2b8d3c8a38b5117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76300 Tested-by:
-
Christian Kuhn authored
To finally tame the FAL related unit tests, the resource related BaseTestCase is dissolved and merged into consuming classes as first step. This simplifies the construct and allows further refactorings. Resolves: #98936 Releases: main Change-Id: Id8da6b47a5d16d7eb38bfecf91d41d9365d4df7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76299 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
Moving cache framework related FileBackendTest unit tests to functional tests needs less mocks and avoids vfsStream. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98931 Resolves: #98734 Releases: main Change-Id: I0090ae0c0984add6584f3858df35fed5df91ab91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76295 Tested-by:
-
- Oct 25, 2022
-
-
Oliver Klee authored
Also update the PHPUnit PHPStan configuration. This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.11 > composer req --dev phpstan/phpstan-phpunit:^1.1.3 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98913 Releases: main, 11.5 Change-Id: Ifc374d02a2ad343bd6be9a61b2075deb019b98f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76253 Tested-by:
-
- Oct 23, 2022
-
-
Stefan Bürk authored
With doctrine/dbal v3.5.0 some changes has been introduced which shows invalid test setup. This change use proper test setup to be okay again, if doctrine/dbal v3.5.0 is used. See: https://github.com/doctrine/dbal/pull/5770 Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98704 Releases: main Change-Id: I936e5cd291086020e60be418176b0f294fb43a45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76231 Tested-by:
-
- Oct 21, 2022
-
-
Benni Mack authored
The functionality to check authentication such as frontend users only to certain PIDs, is now centralized in FrontendUserAuthentication along with the logic to use the common API with "userConstraints()" to enable a query restriction only to certain PIDs. This way, all restrictions are unified in the enable clause Further refactorings could be * use a service or event to modify the constraints in a unified way, or even move the constraints completely to the auth service. * use a UserRepository that should deal with the constraints Resolves: #98587 Releases: main Change-Id: I5ad4743a4f8d149509553b8cdda2f6210ca98c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76098 Tested-by:
-
- Oct 19, 2022
-
-
Benni Mack authored
This change unifies the generation of the LinkResult object in order to allow the generation of the LinkResult for JSON output (EXT:headless) and HTML output, by using the ->adapt() functionality within the typolink() call. The internal class (HtmlLinkResult), which was added during v12 development, is removed in favor of the new ::adapt() method. Resolves: #98657 Releases: main Change-Id: I7dbed554eccac6fedf5433a7dc0793b99b07c85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76166 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Oct 14, 2022
-
-
Felix Nagel authored
Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98603 Releases: main, 11.5 Change-Id: I83aa10d188495fae7a7cac9179ec0c7d362eedcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76108 Tested-by:
-
Oliver Klee authored
This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.9 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98610 Releases: main, 11.5 Change-Id: I65425faaf3c9b0f08bacb6fa56e60b97ca905ed1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76111 Tested-by:
-
- Oct 11, 2022
-
-
Christian Kuhn authored
A first code clean up of this class streamlines the properties and removes some rather obvious stuff. The unit tests receive an overhaul. Resolves: #98581 Related: #98578 Releases: main Change-Id: I9a6db5015c976986fde24f721e5c2fd8cc1d3f04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76090 Tested-by:
-
Christian Kuhn authored
The extbase ConfigurationManager is a complex beast full of anti patterns. We need to refactor here to unblock other things. AbstractConfigurationManager is the base of the 'concrete' classes BackendConfigurationManager and FrontendConfigurationManager. These are @internal with ConfigurationManager being the outer API. To reduce complexity and to allow looking at Frontend and Backend scenarios without triggering side effects on the other one, this divide and conquer patch simply copies all code from AbstractConfigurationManager into the inheriting classes, making them standalone. Existing unit tests of AbstractConfigurationManager are also copied to the two consuming classes. No further other refactorings are done with this patch to keep it simple. Resolves: #98578 Releases: main Change-Id: Ie7d663cc94c40363f46f41a09ee689113835133e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76089 Tested-by:
-
- Oct 06, 2022
-
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.8 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98541 Releases: main, 11.5 Change-Id: Idff8e6f7f9baa700a79ec0e823aee14f0fb63efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75998 Tested-by:
-
- Oct 04, 2022
-
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.7 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98524 Releases: main, 11.5 Change-Id: Idbb8e62aac0b480eb0590e483968741f2b58916d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75983 Tested-by:
-
- Oct 02, 2022
-
-
Benjamin Franzke authored
The array key `javaScriptModules` accepts a list of JavaScriptModuleInstructions the same way as `requireJsModules` did. In contrast to `requireJsModules` it has a generic name in order to reflect that the array is module-loader independent. (both, newer ES6 modules and legacy RequireJS modules are supported via JavaScriptModuleInstruction). Releases: main Resolves: #98431 Resolves: #97066 Related: #96323 Change-Id: Ie9d1c383da351e3b677b349728defc7472ead43a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75855 Tested-by:
-
Benni Mack authored
This change introduces a new registry class to be used automatically instead of accessing $GLOBALS['PAGES_TYPES'] which is not evaluated anymore. Also, instead of ExtensionManagementUtility::allowTableOnStandardPages() the flag $TCA[$table][ctrl][security][ignorePageTypeRestriction] is introduced which allows to avoid this call. Resolves: #98487 Releases: main Change-Id: I91bdb321500d133e645ccc5b6c0d159f5dd3ad87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75188 Tested-by:
-
Oliver Bartsch authored
In the process of using dedicated TCA types, the new TCA type "file" is introduced and replaces TCA type "inline" with "foreign_table" set to "sys_file_reference". The new type allows to remove a lot of cross dependencies and special cases for type "inline", in case the field is used in FAL context. Also DataHandler and friends benefit from this change, since dedicated functionality can be used now. It therefore effectively allows to improve FAL independently in the future. Due to the nature of "inline" a lot of code had to be copied for the new type, while changing the internal naming was not always easily possible. This will be done step by step with further patches. Besides the new TCA type also three new PSR-14 Events are introduced: - CustomFileControlsEvent - ModifyFileReferenceControlsEvent - ModifyFileReferenceEnabledControlsEvent While the ModifyFileReferenceControlsEvent and ModifyFileReferenceEnabledControlsEvent are equal to their inline counterparts does the CustomFileControlsEvent replace the "customControls" hook option, which is therefore only available for type "inline". Further notable changed: - Superfluous field "table_local" is removed from "sys_file_reference" - ExtensionManagementUtility::getFileFieldTCAConfig() is deprecated - Placeholders are introduced for common image/media/file types - File extension filtering is now done automatically in FormEngine and DataHandler Executed commands: composer u typo3/cms-styleguide Resolves: #98479 Releases: main Change-Id: Ie7a14e8cef444816d3c1844df43e6c0c93706d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75916 Tested-by:Jochen <rothjochen@gmail.com> Tested-by:
-
- Oct 01, 2022
-
-
Markus Klein authored
Due to the improved strictness of the API the query methods logicalAnd and logicalOr required at least two parameters. This is very inconvenient for developers and force the same boilerplate code to be present in almost all extensions using array decomposition like: ->logicalAnd(...$constraints) Prevent this situation by adding dummy-conditions inside the methods to fulfill the interface's contracts. As it is impossible to add straight conditions like "1=1" directly from within the Query object, the solution is to use conditions based on the "uid" field. Resolves: #98415 Related: #96044 Releases: main Change-Id: I824ef076b3e0dfbeb6701965f71d3c7df9c70cd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75836 Tested-by:
-
- Sep 28, 2022
-
-
Christian Kuhn authored
Extension 'recordlist' is a must-have extension that is part of 'minimal usable system' and always loaded: Especially 'backend' has various cross dependencies to 'recordlist', backend "search" using the list module for detail display is one of the most obvious ones. In general it's bad if the main 'backend' extension has such direct dependency towards another more specific extension: The core development slowly strives to have the tuple 'core-backend-frontend' as main set of crucial extenions, with eventually making 'backend' and 'frontend' optional in some happy future. To solve the unfortunate dependency from 'backend' to 'recordlist', 'recordlist' is now merged into 'backend', reducing the set of extensions required for a 'minimal usable system' by one. > composer update --lock Change-Id: Ie73ccb992b9ad29626478ff9acd6dc9a15b8aa9a Resolves: #98443 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75876 Reviewed-by:
-
- Sep 26, 2022
-
-
Larry Garfield authored
Sets return types for most classes that implement PHP SPL classes. Only "mixed" return types are not set: That would be hard breaking for extensions that support both core v11 and v12, since it is not PHP 7.4 compatible. Those places are marked with an @todo to switch to mixed in v13. Resolves: #98035 Releases: main Change-Id: Icd62a69270a6718c8356108e55a0729779609c53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75310 Tested-by:
-
Christian Kuhn authored
EXT:workspace User TSconfig options "options.workspaces.swapMode" and "options.workspaces.changeStageMode": * They are at least partially broken since the switch to doctrine/dbal in core v8. This hasn't been reported as bug, we can safely assume they are used very seldom. * They are rather hard to understand and usability wise questionable since more elements than selected in the Backend module magically change workspace state or are published. * The options are at least partially obsolete since the core considers references for important child records internally already - for instance for inline parent-child relations - and changes child state as needed. The patch removes these TSconfig options and their implementation. Change-Id: I0bb1e955a5124302eac8063e0a3c3f2e4441f857 Resolves: #98437 Resolves: #97422 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75861 Tested-by:
-
- Sep 22, 2022
-
-
Christian Kuhn authored
Public property BackendUserAuthentication->workspace is always an integer and should be declared as such. This avoids a series of casts throughout the core. Change-Id: I6fae41981b0923b61c4f4405762d155a149f983c Resolves: #98416 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75845 Tested-by:
-
- Sep 21, 2022
-
-
Christian Kuhn authored
Resolves: #98397 Releases: main Change-Id: Id3c3ee0a9de93062840ee0acc39a8c8917326535 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75807 Tested-by:
-
Christian Kuhn authored
The Extbase Request still had a fallback to fetch the base Request from $GLOBALS. The base Request is of course a hard dependency of the Extbase Request, it should be actively hand over as construct argument. Change-Id: If0b66ce0daae8983d2a083808af0b8cbc724e824 Resolves: #98391 Related: #98370 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75782 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Sep 20, 2022
-
-
Christian Kuhn authored
The ext:fluid RenderingContext extends standalone fluid RenderingContextInterface by adding getRequest(). This object is always carried around in TYPO3 fluid universe. When calling getRequest() in ViewHelpers, IDE's and static analyzers don't know about this inheritance. Unfortunately, we can't change standalone fluid at the moment since that would be breaking, and we can't change VH's method signatures either since that would violate contravariance. For now, we add a series on @var hints within various ViewHelpers to make phpstan and IDE's more happy. Resolves: #98378 Releases: main Change-Id: I2cd8fc5962b2b8af3ce3fefabbae4e41577bb141 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75783 Tested-by:
-
Christian Kuhn authored
The class prophecy has not been imported and does not seem to be needed for the test. Resolves: #98379 Releases: main Change-Id: I7f75854f3d8546076cc1d264c7b53431231623a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75792 Tested-by:
-
- Sep 19, 2022
-
-
Benni Mack authored
The three legacy hooks * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['record_is_used'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][PageLayoutView::class]['modifyQuery'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawItem'] are replaced by new PSR-14 Events: * TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent * TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent * TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent Additionally, the hooks * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['list_type_Info'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawFooter'] are removed as the same functionality can be achieved with the existing PreviewRenderer functionality since TYPO3 v10. The previous "main class" PageLayoutView is now removed (was marked as internal) along with the interfaces for the removed hooks * TYPO3\CMS\Backend\View\PageLayoutViewDrawFooterHookInterface * TYPO3\CMS\Backend\View\PageLayoutViewDrawItemHookInterface Resolves: #98375 Releases: main Change-Id: Iac4a76dce934de31c9749076d8054ae83ac45edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75778 Tested-by:
-
