[BUGFIX] Clean up TCA Tree code base
This change simplifies further work on the TCA Tree logic. a) use imported names b) ensure to use int|string for Node->getId() as Core uses this for integers within e.g. sys_category c) fix some phpdoc infos d) remove an unused property e) use proper casting for integers f) use $this->lookupField instead of $this->getLookupField() when using 10000 of categories, this function call is superfluous. By using int|string, the changed code if ($node->getId() !== 0 && $node->getId() !== '0') saves 1 (!) DB query on every request. This change is meant also to be backported to v11, for this reason no changes to the types within properties are made (only type hints). Resolves: #99005 Releases: main, 11.5 Change-Id: I291cdd0925f77b0e48e224f207eb5e1b0c4fa041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76444 Tested-by:core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 15 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/backend/Classes/Tree/AbstractTreeDataProvider.php 2 additions, 2 deletions.../sysext/backend/Classes/Tree/AbstractTreeDataProvider.php
- typo3/sysext/backend/Classes/Tree/TreeNode.php 14 additions, 14 deletionstypo3/sysext/backend/Classes/Tree/TreeNode.php
- typo3/sysext/core/Classes/Tree/TableConfiguration/AbstractTableConfigurationTreeDataProvider.php 2 additions, 2 deletions...figuration/AbstractTableConfigurationTreeDataProvider.php
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php 9 additions, 14 deletions...sses/Tree/TableConfiguration/DatabaseTreeDataProvider.php
Please register or sign in to comment