- Nov 13, 2022
-
-
Nikita Hovratov authored
Resolves: #98753 Releases: main Change-Id: Ibd1b655f8d7563165683e4d8307c9445ac9d3398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76574 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Nov 12, 2022
-
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. In the same run, dev depencendies are updated as well. Executed commands: npm install --save \ moment@^2.29.4 \ moment-timezone@^0.5.38 npm audit fix npm run build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76556 Tested-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
This patch simplifies some JavaScript-side validations in FormEngine. Most notably, parsing dates and times is now handled by moment.js (which will be replaced by luxon in the future), allowing us to remove decades-old mambo-jambo code nobody can reverse-engineer nowadays. In the same run, `ltrim()` and the unused `btrim()` methods are removed in favor of modern JavaScript functions. Previously, it was possible to supply the invalid date "13-13-2016" which was magically fixed to "13-01-2017". However, this was only possible by setting the value and triggering the `change` event via JavaScript and NOT by using the backend as a sane user. The behavior introduced with this patch is now streamlined to behave like using the datepicker or entering the field in the input field. Resolves: #99058 Releases: main Change-Id: I98af867ee3bda91222d21bcee1bc1f4c92e41d7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76544 Tested-by:
Roman Büchler <info@buechler.pro> Tested-by:
-
- Nov 11, 2022
-
-
Andreas Fernandez authored
In mid-2020, the library `web-animate` was added as a polyfill due to missing support of the Web Animations API (WAAPI). Now, in late 2022, all major browsers support WAAPI [1], and therefore the library became obsolete. Executed command: npm remove web-animate [1] https://caniuse.com/web-animation Resolves: #99063 Related: #91072 Releases: main Change-Id: Id1098b58a686bbd4ac1f6062e6750fa2115c576c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76560 Tested-by: -
Andreas Fernandez authored
The date-time-picker component now checks properly if the backend user's language could not get fetched from its UC by checking loose for a falsy value. Resolves: #99067 Releases: main, 11.5 Change-Id: I3ba104afde2321480099e96beff6ab77ecb126a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76561 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Nov 10, 2022
-
-
Oliver Klee authored
This update makes a warning more specific. Run commands: > composer req --dev phpstan/phpstan:^1.9.2 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99045 Releases: main, 11.5 Change-Id: I4c5af9d69e0e5b8f4b0d78efd4caa4ed79aed795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76538 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 08, 2022
-
-
Oliver Bartsch authored
Generation of a slug proposal based on defined generator fields does now also work for basic select fields, which were previously not considered by the JS component, because they do not use the FormEngine specific visible / hidden field combination. Resolves: #94371 Releases: main, 11.5 Change-Id: Iedd2d17e97db8abd9cf5c4a3b476825fcd854191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76485 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73975 Tested-by:
-
- Nov 07, 2022
-
-
Frank Naegler authored
This patch adds a new TCA field control "passwordGenerator" for TCA type "password", which can be used to generate a random password, based on defined password rules. The field control will be used in EXT:reactions the first time. In the future the field control might be combined with the existing password policies functionality. Therefore, most of the new functions and classes are marked as internal for now. Another feature to be added in the future will be (according to #69190) a modal / wizard, which will allow to change rules for the password to be generated. Resolves: #98540 Related: #98373 Releases: main Change-Id: Iab21b8bd0b3c261a702234579f62ba841c54ea0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76002 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Klee authored
Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97420 Releases: main Change-Id: Id1ea668b1f313fa74292437755850eaa36511526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74344 Tested-by:
-
- Nov 06, 2022
-
-
Helmut Hummel authored
File meta data extractors have to provide an execution priority and a data priority. The execution priority, which was previously ignored, is now respected and extractors are ordered accordingly in ExtractorRegistry. Extractors with the same data priority can now provide data, while the data was overwritten previously. ExtractorRegistry::getExtractorsWithDriverSupport now returns a flat array of extractors again, not a nested one like introduced in #64942, just like annotated. Because this fix might change the order of the execution of extractors, it can be considered slightly breaking, thus TYPO3 11.5 is not targeted. Related: #64942 Related: #56727 Resolves: #92643 Releases: main Change-Id: I2a54709ba8a389e668b37e6003695ba3316968eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66232 Tested-by:
-
Benni Mack authored
This change simplifies further work on the TCA Tree logic. a) use imported names b) ensure to use int|string for Node->getId() as Core uses this for integers within e.g. sys_category c) fix some phpdoc infos d) remove an unused property e) use proper casting for integers f) use $this->lookupField instead of $this->getLookupField() when using 10000 of categories, this function call is superfluous. By using int|string, the changed code if ($node->getId() !== 0 && $node->getId() !== '0') saves 1 (!) DB query on every request. This change is meant also to be backported to v11, for this reason no changes to the types within properties are made (only type hints). Resolves: #99005 Releases: main, 11.5 Change-Id: I291cdd0925f77b0e48e224f207eb5e1b0c4fa041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76444 Tested-by:
-
- Nov 04, 2022
-
-
Benni Mack authored
This change splits up the functionality of the "CreateFolderController" into "add folder" and "add file". This also affects: * Buttons in the file list module * Actions in the Context Menu which also uses more specific labels + icons. This way, it is much clearer for editors on specific actions. In addition, the code is split up into CreateFileController and CreateFolderController. Separate steps could be to also split up the online media functionality into a modal. Resolves: #98999 Releases: main Change-Id: I7ccbae09de6b9fa39996e0357129006091601e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76433 Tested-by:
-
Andreas Fernandez authored
As a follow-up to #98989, it'd make sense to show a notification if a bookmark was created to give the user some sort of feedback. Resolves: #99000 Related: #98989 Releases: main Change-Id: Idcde0defe302f23356ce37a22feec18e0237adc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76434 Tested-by:
-
Benjamin Kott authored
Adapting the link behavior to match the default CKEditor5 linking behavior. We are now also introducing the contextual balloon menu. This change makes the need for a dedicated unlink button in the menu bar obsolete and eases the use of editing links. The ballon menu opens with a single click and provides information about the current link as well as edit and unlink options. Resolves: #98997 Releases: main Change-Id: I6f4835bfe9e7674eb7c968a9a972479a54489799 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76259 Tested-by:
-
Stefan Bürk authored
PHPStan recently added a xdebug check The TYPO3 core php testing images has xdebug installed and enabled in cli mode, which now let PHPStan display a speaking notice about this circumstance. This change simply disable xdebug for phpstan calls in runTests.sh, thus avoiding this notice. xdebug is not needed to be enabled for PHPStan executions. Resolves: #98994 Releases: main, 11.5 Change-Id: I2b390884b4ccba85e9c2638bfa815f1a138c23e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76408 Tested-by:
-
- Nov 03, 2022
-
-
Nikita Hovratov authored
Also, remove obsolete Fixture functions. Used command(s): > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98749 Related: #87607 Releases: main Change-Id: Ifc75db8d3fcda52d22d47292b43b250de255cd25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76432 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Andreas Fernandez authored
Most modern operating systems allow to disable animations, also known as "reduced motion", which is a very important accessibility feature for people suffering from motion sickness. In CSS Level 5, a media query `prefers-reduced-motion` is available to check for this specific setting, if the browser can get the configuration from the operating system (looking at you, Chrome and GNOME). With Bootstrap 5, `prefers-reduced-motion` is already in place, disabling all animations caused by CSS. However, the notification component is partially animated via JavaScript and thus the media query wasn't taken into consideration and notifications were still animated. The media query is now checked on JavaScript side as well to avoid animating notifications. Resolves: #98990 Releases: main, 11.5 Change-Id: Ic6ed35fb6ccf17b1fe7cd1970858e4abe2755f84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76403 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Andreas Fernandez authored
When a backend user wants to create a bookmark, the confirmation modal that was previously in place doesn't pop up anymore as this is no dangerous action. Additionally, the responses of the controller are sent as a JSON string and proper status codes. Resolves: #98989 Releases: main Change-Id: If85c8dfa7cac383866b7063f9af1e784eb5e2183 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76402 Tested-by:
-
Andreas Fernandez authored
The backend search (aka Live Search) can search for database records only, currently. To make the search able to find anything other than database records a `SearchProviderInterface` is introduced which allows to add new providers in the future and may be used by extension authors in the long run. As the first implementations, the current database record search is extracted into a `DatabaseRecordProvider`, which excludes records from the `pages` table. Additionally, a new `PageRecordProvider` is added which comes with a custom web component that renders additional information for pages only. The changes introduced in this patch are not final and may change in further iterations, therefore all interfaces are declared as "internal" and documentation is missing on purpose. Resolves: #92008 Releases: main Change-Id: I16327f32a5e2bb05cc5f8a80540a2ced94213b39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76118 Tested-by:
-
Benni Mack authored
This is mainly related to test files, where the phpdoc annotations of the affected test classes have been removed, as we now use proper native types, where no additional PHPDoc comment describing the parameters are set. In addition, some further cleanups related to types that have already been properly defined are set. Resolves: #98987 Releases: main Change-Id: I8e82540e9f425799ebb851e66d4149202f81ecfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76398 Tested-by:
-
Oliver Klee authored
This update finds new problems and gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.9.0 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Blog article about the new release: https://phpstan.org/blog/phpstan-1-9-0-with-phpdoc-asserts-list-type Resolves: #98986 Releases: main, 11.5 Change-Id: I15516853c3a1bac80b80466fe4bae8a0f150ba68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76396 Tested-by:
-
- Oct 30, 2022
-
-
Torben Hansen authored
Resolves: #98887 Releases: main Change-Id: I9231fa207503e258e5bd5ee94c83ea243d3fdd28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76338 Tested-by:
-
Nikita Hovratov authored
Also, a wrong call to flushByTag(s) is corrected. Resolves: #98735 Releases: main Change-Id: I3f6ecbf7570d6383fb836e81f15aea857efd2032 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76334 Tested-by:
-
- Oct 29, 2022
-
-
Andreas Fernandez authored
The patch for #98288 accidentally overwrote the variable of the event in the event handler for deleting multiple files. The event variables in the modal button callbacks are renamed now. Resolves: #98709 Related: #98288 Releases: main Change-Id: I2d61f1215cdfe156628fcca61de524c98bfb0998 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76235 Tested-by:
-
- Oct 28, 2022
-
-
Torben Hansen authored
Resolves: #98899 Resolves: #98901 Releases: main Change-Id: Ifb188334c1445e3e8847bca476b6c5182bce829c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76323 Tested-by:
-
Andreas Fernandez authored
A new method `getByPrefix()` is added to the module `@typo3/backend/storage/abstract-client-storage`, affecting its implementations * `@typo3/backend/storage/browser-session` * `@typo3/backend/storage/client` A developer is now able to obtain multiple items prefixed by a given key either from `localStorage` or `sessionStorage`. Resolves: #98921 Releases: main Change-Id: I343289cc6fa6fdd57c019a0cdd85eae2b5dbdb81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76265 Tested-by:
-
- Oct 27, 2022
-
-
Oliver Bartsch authored
With #94641 toolbar dropdown menus were made scrollable, since otherwise bookmarks were cut off at the bottom of the screen. With #98307 the corresponding "max-height" option was removed, leading to the same bug as before. This is now fixed by adding the option again. Resolves: #98940 Related: #98307 Related: #94641 Releases: main Change-Id: I1c2fd17f503189d3ed3466f6d80b451b01ff454d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76310 Tested-by:
-
Christian Kuhn authored
* Make some unit tests functional test * Remove some state * Avoid last usages of vfsStream > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I3c0e4a1bc10aae042c5b850e817e8211918a0458 Resolves: #98740 Related: #97762 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76309 Tested-by:
-
Benjamin Kott authored
The CKEditor 5 has very limited support for managing links. By default, you only get a simple input field for a string. To bring the known and loved easy-to-use LinkBrowser to CKEditor 5 we need to overwrite the existing linking capabilities. For developers and integrators, this overwrite should be invisible as it was before with the CKEditor 4 integration. Instead of teaching the users that they need to load custom modules to change the link behavior, we are already migrating this in the background for them. A typical developer can just follow the CKEditor 5 guide to configuring the editor to its needs and the Core is already doing the adjustments and replacements of modules for them. We currently overwrite the existing link and unlink commands, but we register the toolbar buttons with a prefix. This makes existing CKEditor configurations incompatible since the linking buttons are missing in the toolbar. To make migrations easier we adjust custom toolbar buttons to match the CKEditor 5 defaults and drop the custom names for the buttons. In addition, we are streamlining the behavior of removing plugins. Since we are already overwriting the "Link" plugin there is no need to remove it if no removePlugin config is passed in the first place. This allows us to better test the behavior and reduces the cases we need to cover in the first place. Resolves: #98925 Releases: main Change-Id: I3d6d158f5ab1b21e73f86471344107a07d71b03e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76267 Tested-by:
-
- Oct 26, 2022
-
-
Oliver Klee authored
Resolves: #98937 Related: #98936 Releases: main Change-Id: I55ed2c9546312c8bc9b99ffae2b8d3c8a38b5117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76300 Tested-by:
-
Christian Kuhn authored
To finally tame the FAL related unit tests, the resource related BaseTestCase is dissolved and merged into consuming classes as first step. This simplifies the construct and allows further refactorings. Resolves: #98936 Releases: main Change-Id: Id8da6b47a5d16d7eb38bfecf91d41d9365d4df7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76299 Tested-by:
-
Christian Kuhn authored
Moving cache framework related FileBackendTest unit tests to functional tests needs less mocks and avoids vfsStream. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98931 Resolves: #98734 Releases: main Change-Id: I0090ae0c0984add6584f3858df35fed5df91ab91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76295 Tested-by:
-
Andreas Fernandez authored
This patch updates jasmine to the current version 4.4.0. This mainly impacts performance and dropped support for outdated environments and browsers. Karma is also updated and in the same run, unused launchers are removed. Executed commands: npm install --save-dev \ @types/jasmine@^4.3.0 \ jasmine-core@^4.4.0 \ karma@^6.4.1 \ karma-chrome-launcher@^3.1.1 \ karma-coverage@^2.2.0 \ karma-jasmine@^5.1.0 \ karma-junit-reporter@^2.0.1 \ karma-rollup-preprocessor@^7.0.8 npm remove \ karma-firefox-launcher \ karma-ie-launcher \ karma-opera-launcher \ karma-safari-launcher Resolves: #98922 Releases: main Change-Id: Id879aca002de72825d20a9b07ff1bf3a78f95057 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76266 Tested-by:Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Oct 25, 2022
-
-
Oliver Klee authored
Also update the PHPUnit PHPStan configuration. This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.11 > composer req --dev phpstan/phpstan-phpunit:^1.1.3 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98913 Releases: main, 11.5 Change-Id: Ifc374d02a2ad343bd6be9a61b2075deb019b98f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76253 Tested-by:
-
- Oct 24, 2022
-
-
Andreas Fernandez authored
When a content element gets hidden or visible, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #98471 it was not possible anymore to click the "+ Content" button above such element unless it was dragged and dropped again into the same column. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, relative positioning was added to the columns as this is needed for the dropzones, finally causing this bug. To solve this issue, the CE actions now have a higher z-index to be clickable again. Resolves: #98703 Related: #98471 Releases: main Change-Id: I32d93a79842cb599526eae9dec3373c3d3fc31eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76234 Tested-by:
-
- Oct 23, 2022
-
-
Stefan Bürk authored
With doctrine/dbal v3.5.0 some changes has been introduced which shows invalid test setup. This change use proper test setup to be okay again, if doctrine/dbal v3.5.0 is used. See: https://github.com/doctrine/dbal/pull/5770 Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98704 Releases: main Change-Id: I936e5cd291086020e60be418176b0f294fb43a45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76231 Tested-by:
-
- Oct 21, 2022
-
-
Benni Mack authored
The functionality to check authentication such as frontend users only to certain PIDs, is now centralized in FrontendUserAuthentication along with the logic to use the common API with "userConstraints()" to enable a query restriction only to certain PIDs. This way, all restrictions are unified in the enable clause Further refactorings could be * use a service or event to modify the constraints in a unified way, or even move the constraints completely to the auth service. * use a UserRepository that should deal with the constraints Resolves: #98587 Releases: main Change-Id: I5ad4743a4f8d149509553b8cdda2f6210ca98c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76098 Tested-by:
-
Andreas Fernandez authored
Resolve: #98686 Releases: main Change-Id: Id48b6e61e87eaaadc1e28cbf0b8439d9af791b57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76211 Tested-by:
-
Andreas Fernandez authored
A backend module's docheader is "folded" when scrolling down in the backend module. Sometimes, the folding process appears to be laggy due to the pixel-snapping approach of animating a position change, which also leads to more work for browser engines. For a better rendering performance, the element isn't physically moved in the DOM, but transformed instead, offloading work to the GPU. See [1] for further information. [1] https://web.dev/animations-overview/ Resolves: #98693 Releases: main, 11.5 Change-Id: I93be697d8105eef83ce2376c8879419058dfdb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76218 Tested-by:
-
