[TASK] Update to PHPStan 1.8.9

This update gets rid of some false positives.

Run commands:

> composer req --dev phpstan/phpstan:^1.8.9
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #98610
Releases: main, 11.5
Change-Id: I65425faaf3c9b0f08bacb6fa56e60b97ca905ed1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76111


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>

Build/phpstan/phpstan-baseline.neon

@@ -3590,21 +3590,11 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
 
-		-
-			message: "#^Result of && is always false\\.$#"
-			count: 1
-			path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
-
 		-
 			message: "#^Strict comparison using \\=\\=\\= between non\\-falsy\\-string and '' will always evaluate to false\\.$#"
 			count: 1
 			path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between non\\-falsy\\-string and '0' will always evaluate to false\\.$#"
-			count: 1
-			path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
-
 		-
 			message: "#^Parameter \\#1 \\$id of method TYPO3\\\\CMS\\\\Scheduler\\\\Task\\\\AbstractTask\\:\\:setTaskUid\\(\\) expects int, string given\\.$#"
 			count: 1

composer.json

@@ -113,7 +113,7 @@
 		"php-webdriver/webdriver": "^1.13.0",
 		"phpspec/prophecy": "^1.15.0",
 		"phpspec/prophecy-phpunit": "^2.0.1",
-		"phpstan/phpstan": "^1.8.8",
+		"phpstan/phpstan": "^1.8.9",
 		"phpstan/phpstan-phpunit": "^1.1.1",
 		"phpunit/phpunit": "^9.5.25",
 		"typo3/cms-styleguide": "~12.0@dev",

composer.lock

@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "11895d271248040c9045ee82d378cef0",
+    "content-hash": "2f03bf798305c9633899d4a0d0bfe94d",
     "packages": [
         {
             "name": "bacon/bacon-qr-code",
@@ -6506,16 +6506,16 @@
         },
         {
             "name": "phpstan/phpstan",
-            "version": "1.8.8",
+            "version": "1.8.9",
             "source": {
                 "type": "git",
                 "url": "https://github.com/phpstan/phpstan.git",
-                "reference": "08310ce271984587e2a4cda94e1ac66510a6ea07"
+                "reference": "3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/08310ce271984587e2a4cda94e1ac66510a6ea07",
-                "reference": "08310ce271984587e2a4cda94e1ac66510a6ea07",
+                "url": "https://api.github.com/repos/phpstan/phpstan/zipball/3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2",
+                "reference": "3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2",
                 "shasum": ""
             },
             "require": {
@@ -6545,7 +6545,7 @@
             ],
             "support": {
                 "issues": "https://github.com/phpstan/phpstan/issues",
-                "source": "https://github.com/phpstan/phpstan/tree/1.8.8"
+                "source": "https://github.com/phpstan/phpstan/tree/1.8.9"
             },
             "funding": [
                 {
@@ -6561,7 +6561,7 @@
                     "type": "tidelift"
                 }
             ],
-            "time": "2022-10-06T12:51:57+00:00"
+            "time": "2022-10-13T13:40:18+00:00"
         },
         {
             "name": "phpstan/phpstan-phpunit",