- Oct 14, 2022
-
-
Oliver Klee authored
This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.9 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98610 Releases: main, 11.5 Change-Id: I65425faaf3c9b0f08bacb6fa56e60b97ca905ed1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76111 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Karsten Nowak authored
Fix warning if bodyTagCObject is referenced in TypoScript template. Set as empty array. Resolves: #98611 Releases: main, 11.5 Change-Id: Iaf0f3c1ae78386b2e6d5290251246740ee3d7d13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76112 Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benjamin Kott authored
Commands executed: npm install bootstrap@^5.2.2 npm install --save-dev @types/bootstrap@^5.2.5 npm run build Resolves: #98612 Releases: main Change-Id: I219104ef89bb643c656bb57203125083f6d407ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76113 Tested-by:
-
Nikita Hovratov authored
The magic happening for cropHTML in the regex is really hard to understand. It led to compilation failures due to the costly regex pattern applied on possibly long pieces of text. In order to replace the "maxCroppingLength" workaround, where the regex is applied multiple times with less text, a new implementation is now in place. The new implementation extracts the regex part for html entities to be used as a straight pattern. This circumvents the bottleneck of the "entity|." alternative match for everything. The remaining logic is implemented in a programmatic way, which is easy to follow from top to bottom with added comments. Functionality of `crop()` is moved to new core class `\TYPO3\CMS\Core\Text\TextCropper` and `cropHTML()` methods is moved to corresponding new core class `\TYPO3\CMS\Core\Html\HtmlCropper` with a modernized method signature. Old internal ContentObjectRenderer methods are kept as wrapper methods to properly prepare argument preparation. Additionally new `HtmlCropper` and `TextCropper` are conditionally used in the well known fluid viewhelper `\TYPO3\CMS\Fluid\ViewHelpers\Format\CropViewHelper`. MultiByte position calculation error for `TextCropper` is fixed along the way which bubble up using the html crop tests from `ContentObjectRenderer` also for the `TextCropper`. Resolves: #97125 Related: #77642 Releases: main Change-Id: I15b778370df0d0a3d3087a0b199c3e16f7a46add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73834 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Oct 13, 2022
-
-
Benjamin Kott authored
Some CSS minifier remove the semicolon before the curly brace While this is valid CSS, the ScssPHP Parser is unable to identify the end of a declaration block. We are adding them, to avoid parsing errors. Superfluous semicolons will be dropped by the parser Moving CSS variables assigned to :root to the new parent. Resolves: #98605 Releases: main Change-Id: I6e24e94ea7415cf94aa8527aedfe5a4548288705 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76109 Tested-by:
-
Benjamin Kott authored
With the introduction of additional attributes for asset includes it was not considered that a asset can not provide any config at all. This patch adds the missing null checks to resolve the issue. Resolves: #98599 Releases: main Change-Id: I4af3dfb7c11943dc921a54ddbdc5e4da999ce653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76105 Tested-by:
-
Benni Mack authored
This change renames some variables within GeneralUtility::implodeAttributes and adds some first tests to this method. Resolves: #98597 Releases: main, 11.5 Change-Id: I5a667904e7788c76514c4832c197f37b74921bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76104 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Oct 12, 2022
-
-
Christian Weiske authored
Releases: main, 11.5 Resolves: #98591 Change-Id: I5474e11cd0653b61a1ac2c8725959bc4f1437da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76102 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Christian Kuhn authored
We can avoid ugly setters in TypoScript TreeBuilder class by handing over arguments to the main function, effectively making this service stateless. Especially cache and tokenizer should not be injected since they are runtime dependencies and should be given as arguments from controllers. $forceProcessExtensionStatics is an extbase specific thing kept for now, but it will be solved differently later, when extbase BackendConfigurationManager switches to new TypoScript parser. Change-Id: I5854c5a6d44737bc26071459fc746f52f4387e39 Resolves: #98586 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76099 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benni Mack authored
This change adapts our coding guidelines and rules with PHP-CS-Fixer, allowing for * PER (a.k.a. PSR-12) * no_useless_nullsafe_operator (only use nullsafe if allowed) * only single-spaces in arrays This effectively adapts our code base * use "public const" instead of "const" where visibility is not defined * one whitespace between "declare()" and "namespace" declarations * Use (float) instead of (double) casting * Additional space in annonymous classes (PER) * grouped "use" statements (classes, function, constants) * only one space between items in array lists * Use (bool) instead of (boolean) Resolves: #98585 Releases: main, 11.5 Change-Id: Idb83729d0e4f9dc3c41e4dc5346dab77e6fbce84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76097 Tested-by:
-
- Oct 11, 2022
-
-
Christian Kuhn authored
Resolves: #98414 Releases: main, 11.5 Change-Id: If29dc5fd03156889ac0d281d5c7b2e5683f708d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76095 Tested-by:
-
Christian Kuhn authored
Resolves: #98404 Releases: main, 11.5 Change-Id: I01f52c45d95f6ff2a56e0a3128f1367dc2a595aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76096 Tested-by:
-
Christian Kuhn authored
A first code clean up of this class streamlines the properties and removes some rather obvious stuff. The unit tests receive an overhaul. Resolves: #98581 Related: #98578 Releases: main Change-Id: I9a6db5015c976986fde24f721e5c2fd8cc1d3f04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76090 Tested-by:
-
Christian Kuhn authored
Resolves: #98582 Releases: main, 11.5 Change-Id: I20116640c9adc44df524b58172913a4d8f8a01ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76094 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Torben Hansen authored
Resolves: #98573 Releases: main Change-Id: Id69bd8f970f0d5f780850faf842620cf7ed87de2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76084 Tested-by:
-
Chris Müller authored
Resolves: #98580 Releases: main, 11.5 Change-Id: Ib3ee06cb2849efd8e4cf18fc2497f3c0fed0f752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76091 Tested-by:
-
Chris Müller authored
Resolves: #98564 Releases: main Change-Id: I2177342a3f5952ba33edcfa231283826cdc27a7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76092 Tested-by:
-
Christian Kuhn authored
The extbase ConfigurationManager is a complex beast full of anti patterns. We need to refactor here to unblock other things. AbstractConfigurationManager is the base of the 'concrete' classes BackendConfigurationManager and FrontendConfigurationManager. These are @internal with ConfigurationManager being the outer API. To reduce complexity and to allow looking at Frontend and Backend scenarios without triggering side effects on the other one, this divide and conquer patch simply copies all code from AbstractConfigurationManager into the inheriting classes, making them standalone. Existing unit tests of AbstractConfigurationManager are also copied to the two consuming classes. No further other refactorings are done with this patch to keep it simple. Resolves: #98578 Releases: main Change-Id: Ie7d663cc94c40363f46f41a09ee689113835133e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76089 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
Resolves: #98575 Related: #97747 Releases: main Change-Id: If0c5dca5574a1bb6842e6c1c45e14cbfac171389 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76086 Tested-by:
-
Rudy Gnodde authored
In order to register your own mailer implementation, a new interface has been introduced that makes registration of your own mailer much easier. Resolves: #97747 Releases: main Change-Id: Ibcad8a79cb8750db7725d7983781c4bdb90b363f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74853 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Christian Kuhn authored
TSFE->config['rootLine'] and TSFE->rootLine are not identical: The one in config array is a restricted set that stops at first sys_template having root=1 flag set. This broke with #98503 and is fixed with the patch. Change-Id: I029012838d64a16e9d12ddf806712d4f2755f92d Resolves: #98571 Related: #98503 Related: #97816 Related: #98044 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76078 Tested-by:
-
Stefan Bürk authored
Search- and filter functionaly usually uses `LIKE` or `NOT LIKE` SQL statements to search a provided search term in the database. Different dbms behave differently regarding search term casing. MySQL/MariaDB relies on chosen collation of the database-, table- and/or column level. Typical and recommended defaults on db side and by TYPO3 default settings are case-insensitive collations, which is the most common spread configuration. Based on this, most people assume search terms are searched case-insensitive, when using `LIKE` or `NOT LIKE` SQL statements. PostgresSQL on the other hand knows the keywords `LIKE` and `ILIKE`. The `ILIKE` keyword has to be used, when a case-insensitive search is wanted. The current implementation simply uses `LIKE` for all dbms, so searching with postgres is case sensitive, while it is usually case insensitive with MySQL/MariaDB. SQLite states `LIKE` is case-insensitive, which is basically correct. The limitation is, this only works for the 26 chars in the ASCII charset range, and not only for `LIKE` but also for the `UPPER()` and `LOWER()`. There should be a way to compile php extension sqlite with ICU support, enabling case awareness for more chars, but that's nothing we can expect people do and have by default. We cannot do much, so we leave some notes in the code regarding this detail. The patch changes ExpressionBuilder to use ILIKE on PostgresSQL to be in-line with the default MySQL/MariaDB behavior. Resolves: #98570 Releases: main, 11.5 Change-Id: I5a586a4bf46ee1b4699f4223fd4b19a0b9ae453b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76075 Tested-by:
-
Christian Kuhn authored
TypoScript related TreeFromLineStreamBuilder has state due to setTokenizer(), it should be "shared: false" in DI. We can make it stateless by avoiding the explicit set tokenizer and turning it into a mandatory argument of buildTree(). This makes all stateful properties mandatory arguments of the single entry method, which makes the class effectively stateless since all state is set a-new with next call. Resolves: #98572 Related: #97816 Releases: main Change-Id: I9b83add4e0db50010337972c09acc9bdb67da96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76081 Tested-by:
-
Christian Kuhn authored
The installer has a step to 'Create empty start page' which adds a default sys_template to a first page. This sys_template should set 'clear' flag to 3 to clear both 'constants' and 'setup', which triggers inclusion of global TypoScript. This is the same as done in BE Template Info module with "Create template for a new site". While we are at it, we're streamlining the class code a bit by removing obsolete annotations, adding some type hints, using constructor property promotion, and declaring this internal class final. Resolves: #98552 Releases: main Change-Id: Ia17e435b6bd02ff9a9c56c159e43997ebd217393 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76082 Tested-by:
-
Christian Kuhn authored
Obvious hardening of an array access. Resolves: #98469 Releases: main, 11.5 Change-Id: Ie4e083b0ff50de4e2fbabf4bdfd47753d29bd06d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76080 Tested-by:
-
Christian Kuhn authored
Harden GeneralUtility::explodeUrl2Array() and increase test coverage. Change-Id: I3136a27572414810989c038b78bd0f362cc64c65 Resolves: #98537 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76079 Tested-by:
-
Simon Schaufelberger authored
Resolves: #98539 Releases: main, 11.5 Change-Id: I1a9943316a7d8d657b2e64cc704ae52943a89b40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75996 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Oct 10, 2022
-
-
Stefan Bürk authored
This change raises typo3/testing-framework to include a bunch of changes to tighten unit- and function tests. * setUp() call chain integrity check for unit-tests * error_reporting() left-over integrity check for unit- and functional tests * error- and exception handler left-over integrity check for unit- and function tests (unit is new) Used command(s): > composer update typo3/testing-framework Resolves: #98569 Releases: main Change-Id: I61fe0b23aa8a9d461b849e79b06dfd851809b15f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76010 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
Stop a naughty mocking party provided by TypoScriptFrontendController unit tests by turning most of them into functionals. Resolves: #98568 Releases: main Change-Id: I65bd7e1c1dadb8e841551a8016a3d98a828031a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76074 Tested-by:
-
Georg Ringer authored
Invalid HTML must not produce notices in backend or frontend. Resolves: #98513 Releases: main, 11.5 Change-Id: I6aca14d97318b292616a5a4670150263a2c7ec69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75952 Tested-by:
-
Stefan Bürk authored
PostgresSQL is really picky about types and used operators. Thus using for example a `like` comparision on non string/text based fields fails hard. Database errors like following indicates this issue: > Undefined function: 7 ERROR: operator does not exist: > smallint ~~ unknown This changes implicit converts field data to a text representation for PostgresSQL, if field is not compatible. In case of small/tinyint fields a double cast is used, means casting to integer and then to string before applying the like comparison on it. The choosen solution is used to have a comparible behaviour against the other supported dbms systems like MariaDB, MySQL and SQLite, also doing a full search on all fields may be a bad decision. The whole search and full-search across all types should be reconsidered generally. Resolves: #98563 Releases: main, 11.5 Change-Id: I4dde0e49bf8fd68a01b50aeabc12c24398fb6ac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76038 Tested-by:
-
Anja Leichsenring authored
Resolves: #98559 Releases: main, 11.5 Change-Id: Ifa5c3ac6997545a79c7306ff9a3afc0d97675dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76033 Tested-by:
-
Stefan Bürk authored
Resolves: #98468 Releases: main, 11.5 Change-Id: Ia3f0ac3c5d4c20eaef5ffdafae060bab4a1c9aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76005 Tested-by:
-
Stefan Bürk authored
PostgresSQL seems to get picky with upper case column names, if they are not proper quoted in queries, like `pages.SYS_LASTCHANGED` as example. Executing such database queries will return database error message like ERROR: column "sys_lastchanged" does not exist also it has been provided as upper case variant. Related to system architecture and historical build up sometimes sql parts are build manually instead of using QueryBuilder directly. Thus fields and values are eventually not properly quoted, thus leading to this error message. This can be verified using ext:styleguide frontend pages and open the `/menu-recently-updated` using postgres dbms backend. This change ensures proper quoting for build up of the extraWhere (or additionalWhere) in core content object class `\TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuContentObject`. Resolves: #98561 Releases: main, 11.5 Change-Id: I28541eafd1ceee360c78b54d24967286ec66ea9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76035 Tested-by:
-
Stefan Bürk authored
Prior to PHP8.0 the long libpq version (`PGSQL_LIBPQ_VERSION_STR`) contained compiler informations, which is used in the install tool environment checks. Since PHP8.0 the value is identical to the short version (`PGSQL_LIBPQ_VERSION`) and using the long form is deprecated. See: https://www.php.net/manual/en/pgsql.constants.php This change now simply use the short version for the PostgreSQL libpq check, avoiding nasty PHP version flip-flop checkings. The minimum version has been adjusted along the way. Resolves: #98562 Releases: main, 11.5 Change-Id: I41f3cf0e51c16cc4c8dd5d9a95b262283f5bd7ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76036 Tested-by:
-
Mario Lubenka authored
DebuggerUtility::var_dump() is commonly used to debug PHP classes. We recommend hardening PHP classes by using typed properties in PHP classes. Previously uninitialized properties resulted in a PHP exception when passing the class instance into DebuggerUtility::var_dump. Uninitialized properties will not be processed by DebuggerUtility::var_dump anymore. Instead a label "uninitialized" indicates that it has not been initialized at the time of debugging. Resolves: #98519 Releases: main, 11.5 Change-Id: Ifbb9fd4d0de2e6214ab4b876b04302b2adaf6d2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75981 Tested-by:
-
Stefan Bürk authored
PostgresSQL is picky if aggregation functions like `order by`, `group by` and similar are used, but missing the corresponding columns in the "SELECT" column listing. ext:redirects backend module builds query using the QueryBuilder based on the demand dto object, which so far is a good practice. To get the total count of records based on selection and properly building the pagination it uses the same technique but executing a simple count query, which leads to the aggregation error using PostgresSQL dbms due the containing `order by` sortings. This changes simply omits the orderBy part of the build query to avoid this error and still counting on a correct full dataset. Resolves: #98534 Releases: main, 11.5 Change-Id: I09e5f88d9d4f7c0aa578f8e1503cd1b17bc2c5dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76037 Tested-by:
-
Andreas Fernandez authored
The library `imagesloaded` is only used in the image cropper to initialize the cropper functionality once the image is loaded. This can be achieved with native browser API, `imagesloaded` is therefor not needed anymore and thus removed. See https://caniuse.com/mdn-api_htmlimageelement_complete for compatibility. Executed command: npm remove --save imagesloaded @types/imagesloaded Resolves: #98548 Releases: main Change-Id: I154ef22b41febb3788599e8220dd55f6989c3048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76001 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Oct 09, 2022
-
-
Anja Leichsenring authored
Resolves: #98558 Releases: main, 11.5 Change-Id: Ic7bfd4812e49481f51603826a729423951275dbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76032 Tested-by:
-
Stefan Bürk authored
This change properly removes registered exception handlers in tests to avoid side effects. Thus acting as pre-patch to tighten unit tests with auto dangling error- and exception handler detection through the testing-framework BaseTestCase. Resolves: #98554 Releases: main, 11.5 Change-Id: I8efb23a84d380dff1643ce61c87e59a7550a72e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76009 Tested-by:
-
