[TASK] Type hint ext:fluid RenderingContext
The ext:fluid RenderingContext extends standalone fluid RenderingContextInterface by adding getRequest(). This object is always carried around in TYPO3 fluid universe. When calling getRequest() in ViewHelpers, IDE's and static analyzers don't know about this inheritance. Unfortunately, we can't change standalone fluid at the moment since that would be breaking, and we can't change VH's method signatures either since that would violate contravariance. For now, we add a series on @var hints within various ViewHelpers to make phpstan and IDE's more happy. Resolves: #98378 Releases: main Change-Id: I2cd8fc5962b2b8af3ce3fefabbae4e41577bb141 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75783 Tested-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 115 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php 4 additions, 1 deletion...backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php 5 additions, 1 deletion.../backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php 2 additions, 0 deletions...sext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php 4 additions, 1 deletion.../backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php 4 additions, 1 deletion...t/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php 7 additions, 1 deletion...nager/Classes/ViewHelpers/DownloadExtensionViewHelper.php
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php 7 additions, 1 deletion...onmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php 7 additions, 1 deletion...manager/Classes/ViewHelpers/RemoveExtensionViewHelper.php
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php 7 additions, 1 deletion...iewHelpers/ToggleExtensionInstallationStateViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php 8 additions, 2 deletions...Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php 2 additions, 0 deletions...t/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php 2 additions, 0 deletionstypo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php 2 additions, 0 deletions...ext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php 11 additions, 1 deletion.../Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php 2 additions, 0 deletions.../Classes/ViewHelpers/Form/ValidationResultsViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php 16 additions, 4 deletionstypo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php 2 additions, 0 deletions...ysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php 4 additions, 1 deletion...ysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php 5 additions, 4 deletions...sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php
Please register or sign in to comment