- Sep 21, 2023
-
-
Christian Kuhn authored
Tables with TCA columns set to type="flex" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=flex. Resolves: #101997 Related: #101553 Releases: main Change-Id: Ide5458994cfbfca0113be08b0e87b51babaeb540 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81158 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
core-ci <typo3@b13.com>
-
Andreas Fernandez authored
The AJAX API (`@typo3/core/ajax/ajax-request`) has been enhanced to accept native URL-related objects, making usage of the API for developers a little bit easier. Resolves: #101970 Releases: main Change-Id: Ica7c8d5ded7184c5aad6355dbdfa5c4f1f82b0ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81100 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Bartsch authored
Decoupling the ThumbnailViewHelper from the ImageViewHelper in #96362, all arguments were moved to the ThumbnailViewHelper. The commit message as well as a code comment stated that unneeded arguments will be removed later on. This is now done. All unused arguments are removed from the ViewHelper. Resolves: #101993 Related: #96362 Releases: main Change-Id: I62e711eeea54f24f19439e2f370f4195ed580414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81154 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Bürk authored
If imgResource option `noScale = 1` [1] is configured, the image itself is not scaled. However, the calculated scaled width and height values needs to be used for the `img` tag attributes `width` and `height`. In that case, the orginal image is used instead of a processed image, and the calculated values are discarded. This change recalculates these values if `noScale = 1` is requested to ensure that the scaled width and height values are used correctly. Example ------- page.100 = IMAGE page.100 { file = fileadmin/styleguide/bus_lane.jpg file.noScale = 1 file.width = 240m file.height = 240m wrap = |<br> } [1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Imgresource.html#noscale Resolves: #100972 Releases: main, 12.4 Change-Id: Ib09e3e837225347ee2e2a9c9979b014d8fd2b850 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81130 Reviewed-by: -
Torben Hansen authored
When a link is selected in CKEditor 5, the class `ck-link_selected` is added to the link. This caused the link browser to not show the selected class, which has been fixed with #101436. The bugfix does however not consider, that a CSS class in link browser can consist of a string with multiple classes separated by a space. This change ensures, that the link browser again accepts a class string containing multiple class names and shows the selected class string in the CSS-Class select field. Resolves: #101959 Related: #101436 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I278df61e035073a54ba176955141593c7cd9f3cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81092 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Oliver Bartsch authored
The `@internal` `ThumbnailController` is removed, because it has been unused since the introduction of the deferred BE image processing in #92188. Resolves: #101992 Related: #92188 Releases: main Change-Id: I670acb83fcc7be9c8867658467b4e1ca87bcb954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81152 Tested-by:
-
Daniel Siepmann authored
The change log previously only mentioned the database impact. But code might access the field as array key on the user array. This would result in unexpected behaviour. Furthermore this would result in Warnings since PHP 8.0. The changelog is extended with the impact. That allows people to not only check database queries but also array access while migrating. Furthermore suggested migration class was replaced by the FQCN to ease migration. People do no longer need to find the FQCN. Furthermore it might exist a class with same name in the project from third party code, or it might be added another class in the future. Resolves: #101987 Releases: main, 12.4, 11.5 Change-Id: I475606e0f9a325880ee10339adaa2971985b05fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81124 Reviewed-by:
-
Andreas Nedbal authored
If generated images used the exact X/Y coordinates all time (as in one documentation example) the initial image would always be reused. Serializing the setup array using ConfigurationService::serialize keeps performance but includes enough data to never reuse similarly positioned mask images. Resolves: #97212 Releases: main, 12.4 Change-Id: Ic9e02e8c082cc68a9eecf4e9b1b2bc6d770e1d17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81122 Tested-by:
-
Benjamin Kott authored
Resolves: #101975 Releases: main, 12.4 Change-Id: I630ebddc2287b5492cddeb0a098dcedcce765c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81106 Tested-by:
-
Oliver Klee authored
The width of an image is an int and should not be used as a boolean. Resolves: #101977 Releases: main, 12.4 Change-Id: I825d41ac32ebb9297975ab3353c1807eb305f796 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81108 Tested-by:
-
Oliver Bartsch authored
Whenever a file is renamed or moved, also the corresponding index entry is updated. However this does only works and is only relevant for File objects and can’t be done for e.g. processed files. Proper type checks for those two places are added, preventing corresponding type errors. Resolves: #88400 Releases: main, 12.4 Change-Id: I86ecd9500875e2a904ef9bd1768488f886947625 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81120 Tested-by:
-
Benni Mack authored
When FAL was introduced, some code from old GifBuilder generation was copied to the Helper classes. These now reside in GraphicalFunctions for further refactorings and better API support. Resolves: #101983 Releases: main Change-Id: I5818e8b2e8c0ca51fee25547d2952f55c13eee37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81107 Reviewed-by:
-
Benjamin Serfhos authored
It's possible that file references to files exists, where the physical file is missing. That stopped further file reference processing in the ext:lowlevel cleanup command `cleanup:missingrelations`. Therefore, this change explicitly catches the concrete `\TYPO3\CMS\Core\Resource\Exception\FileDoesNotExistException` exception and outputs the message, without interrupting the processing of further files. The handling code is moved to a dedicated method to clean up code duplication on the same step as a side-change. Other unforeseen errors still stop the execution. Resolves: #101924 Releases: main, 12.4 Change-Id: I2c8dba34a6f99d891408b5cc8fd86bddcb3c90c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81024 Tested-by:
-
Benni Mack authored
This change fixes a minor regression introduced in GraphicalFunctions when $this->scalecmd was used within GifBuilder to show proper images. Resolves: #101984 Related: #101981 Releases: main, 12.4 Change-Id: Id20cfde7cc9b2cbc8c88d3c6220e5fb2b0efe67a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81121 Tested-by:
-
Stefan Bürk authored
In `ContentObjectRenderer->getImgResource()` null coalescing operator has been used to guard type errors. That has been guarded by a early array check and ensurance, therefore the guards are obselete. Remove them ! Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101982 Releases: main, 12.4 Change-Id: Ic178e29a5d99ded62738707dc285f2c031330fb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81119 Reviewed-by:
-
- Sep 20, 2023
-
-
Benni Mack authored
When using TypoScript, the setting "sample" allows to scale faster than with "geometry" setting. However, when FAL was introduced the setting was called "useSample" which never worked since TYPO3 v6.0 in conjunction with FAL. The option is however useful and is now working again. The according code is moved into GraphicalFunctions in order to avoid future access to this public property. Resolves: #101981 Releases: main, 12.4 Change-Id: I5c926460d4c5393c418d1e90fcb11052ab3e5cae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81115 Tested-by:
-
Oliver Bartsch authored
In case a user does not have access to the physical file, containing the online media id, this does no longer lead to an exception, which would e.g. prevent the user from accessing any backend module, rendering a preview for such online media asset. Resolves: #80210 Releases: main, 12.4 Change-Id: I4c1a3cfdea211dd1775e57796584416ab7df05d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81117 Reviewed-by:
-
Andreas Nedbal authored
The previous hashing inputs didn't include the X/Y coordinates or the calculated offsets, so similarly configured GIFBUILDERs had a high likelyhood of loading older images. Adding more inputs, but not falling back to fully encoding all of $this->setup should keep the performance and increase uniqueness. Resolves: #94648 Releases: main, 12.4 Change-Id: Id396f3df34b64317a2ac394d85660b1e8516294a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81118 Tested-by:
-
Nikita Hovratov authored
Just like SvgImageProcessor, DeferredBackendImageProcessor now also catches the exception, which is thrown, when image dimensions equal zero and falls back to 64x64 image dimension. This enables editors to correct bad image cropping without the need to do it in the database. To be more specific, a new Exception ZeroImageDimensionException is added, which is used in both processors now. The image cropping editor is already fixed to only allow a minimum dimension of 10x10. However, already corrupted files can not be accessed without this patch. Resolves: #93807 Related: #99943 Releases: main, 12.4, 11.5 Change-Id: I259c365052dd02110d43418ba48b768bbe073fc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81111 Tested-by:
-
Stephan Großberndt authored
Remove leftover code of IMGMENU, which has been deprecated in v9 and removed in v10. Resolves: #101979 Related: #101973 Related: #85902 Releases: main Change-Id: I6c0f0df3065ab7b7cc3368d5ba383f0cd27645aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81112 Tested-by:
-
Oliver Bartsch authored
In case a user adds an online media asset, which is already present in the target folder a flash message now properly informs about it instead of stating that the asset was "added successfully". Resolves: #101980 Releases: main, 12.4 Change-Id: Iae2bb05a22cc498a5f0bad1fa5e6723d0c2d99b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81113 Reviewed-by:
-
Andreas Fernandez authored
The JavaScript module `@typo3/backend/document-save-actions` is used in FormEngine and Scheduler context mainly to disable the submit button in the according forms, where also a spinner is rendered within the button to visualize a running action. Over the time, the module took over some tasks that logically belong to FormEngine, which lead to slimming down the module. In a further effort, jQuery has been removed from said module, leading to a change in behavior how the callback chain can be aborted. Native JavaScript events cannot get asked whether event propagation has been stopped, making changes in the callbacks necessary. All callbacks registered via `addPreSubmitCallback()` now need to return a boolean value. Resolves: #101822 Releases: main Change-Id: Ida17480f81d07f8cda43d29455ccf5d0b9ccfff2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80819 Reviewed-by:
-
Oliver Klee authored
Resolves: #101978 Releases: main Change-Id: Iba3e449c60e82c1f5d379fb52de5e71c82a0e74c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81110 Tested-by:
-
Benni Mack authored
In addition, this class is now fully typed. Resolves: #101954 Releases: main Change-Id: I6bca63321171a24ad4efaac97e19db98b676375d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81087 Tested-by:
-
Sebastian Klein authored
The changelog now shows a current version of the timestamp plugin. In the documentation of EXT:rte_ckeditor, a typo in the plugin namespace is fixed. Both examples show the same code. Resolves: #101971 Releases: main, 12.4 Change-Id: Ic8900bd990717d1887601ddf4ecabebfe78075a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81102 Tested-by:
-
Benni Mack authored
Since PHP 8.0, there is a new "\GDImage" object that is used for image manipulation functions. Before, this was a "resource", but can now be type-hinted properly in all cases regarding GifBuilder. This reduces the amount of PHPstan errors for GifBuilder et al to a minimum. Resolves: #101967 Releases: main Change-Id: I0653452efb6295e103c57a53bc60f4de7174b349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81097 Tested-by:
-
Philipp Kitzberger authored
The video ID of a private vimeo video is appended by a hash parameter. This tuple is stored in the pseudo video file (*.vimeo) and needs to be respected when rendering the iframe or fetching data via the vimeo API. Resolves: #97446 Releases: main, 12.4 Change-Id: Icbeac0552c5f78d2dc405ce58daae195c352195e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77609 Tested-by:
-
Benjamin Franzke authored
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-39.html Executed commands: npm install -P $( grep ckeditor5 package.json | \ grep '\^38' | \ grep -v dev-utils | \ sed 's/^[^"]*"\([^"]*\)".*/\1@^39/' \ ) npm run build Resolves: #101917 Releases: main, 12.4 Change-Id: Ie6251df91db88b4609535eb047c8761b49a0164b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81018 Tested-by:
-
Oliver Bartsch authored
When selecting a mass action in the "duplication resolving modal", all individual actions are disabled. On reseting the mass action by selecting the "Please choose" option, the individual actions are now properly enabled again. Resolves: #101972 Releases: main, 12.4 Change-Id: I6f14b53f650b32e41c424438285e336c690dad04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81103 Tested-by:
-
Andreas Fernandez authored
The module `@typo3/core/ajax/ajax-request` previously had a lot of string-based mambo jambo when composing URLs and query strings. The API is now streamlined to use `URL` and its included `searchParams` property to build URLs, removing the need to compose URLs manually. Resolves: #101969 Releases: main Change-Id: I40c73531c86d828fb298f5d6ae1a0bb9030c23cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81098 Tested-by:
-
Andreas Nedbal authored
While public, the addToMap method only filled a protected property without an accessor, so while a image map exists, it is never used in GifBuilder or outside of it, warranting the removal of useless functionality. Resolves: #101973 Releases: main Change-Id: If375d5060b966054698012eb97153121d31f9385 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81104 Tested-by:
-
Oliver Bartsch authored
Instead of manually resolving the path of the processed thumbnail image, use FAL API "getForLocalProcessing". This prevents wrong paths when using storages with "baseUri" set. Resolves: #101968 Related: #82855 Releases: main Change-Id: I08d4b64c115ca7ecdab8233b36de801e22109e9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81099 Reviewed-by:
-
Oliver Bartsch authored
Due to another couple of use cases, the necessary fields to generate the record title, used in the "record saved" notification in FormEngine, are now always fetched, if not already present. Additionally, it's now ensured that the "uid" is always available, since it is necessary for labels with foreign table lookups. Resolves: #101964 Releases: main, 12.4 Change-Id: I933211f582e31c7af9fea909075420316a81a544 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81095 Reviewed-by:
-
Benni Mack authored
This change is a overhaul of the LocalDriver class after 12 years. All comments are updated, types are added, where possible. Resolves: #101468 Releases: main Change-Id: Ie639d352415a67a8f4d499913b5c30f8d6e1b33b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81041 Tested-by:
-
Andreas Nedbal authored
A lot of the methods implemented in GraphicalFunctions are only used in GifBuilder, thus it makes sense to move them into that class. This also coincides with most of these methods utilizing GDlib while the remaining methods in GraphicalFunctions now mostly access and work with Image/GraphicsMagick. In addition, some helper methods are in place in order to keep the existing logic in the installer available to verify image generation. In the long term, a new API is introduced to utilize base methods for GDLib and ImageMagick into separate classes by encapsulating the actual commands, whereas GifBuilder will remain the "TypoScript" entrypoint to work with Images from cObjects. Resolves: #101955 Releases: main Change-Id: If22cf3800effc5a3a11a8bf9f224f91ba6225d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81089 Reviewed-by:
-
Stefan Froemken authored
Deleting a missing file will not throw exception "InsufficientFileWritePermissionsException" anymore, as a missing file has nothing to do with insufficient file permissions. Preventing that exception allows calling the event "FileDeletionAspect" to remove remaining file related records. Resolves: #101725 Releases: main, 12.4 Change-Id: I272466a47a67358ec4e09cc73d2ffec1339f1b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80613 Tested-by:
-
Oliver Hader authored
This change uses the dependency ordering service in the method `\TYPO3\TestingFramework\Core\Testbase::setUpPackageStates` for test scenarios in functional and acceptance tests. Besides that the following changes were applied: * remove invalid dependency in fixture ext:test_configoverride_second * add `PackageStatesTest` to keep track of extension dependencies * add dependency to ext:frontend in ext:form, since it overrides TCA for the tables tt_content and sys_template (which would result in different ext:impexp results due to table field orderings) * recreate IRRE related XML fixtures for ext:impexp since fixture extensions are now ordered alphabetically (and due to #100734) Resolves: #101809 Releases: main, 12.4 Change-Id: I1f91a75ac8aec9db0291b0f5c8bcf7162d5b0082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81076 Reviewed-by:
-
Benjamin Kott authored
Resolves: #101953 Releases: main, 12.4 Change-Id: I1b0d715a96ee914dc8f9787089406457b750df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81086 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Anja Leichsenring authored
Tables with TCA columns set to type="group" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=group. Resolves: #101908 Related: #101553 Releases: main Change-Id: I355b1e83c367c08e7c0e6428e563798aa49fe766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80990 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Sep 19, 2023
-
-
Benni Mack authored
When the crop object is serialized in a wrong manner or does not contain all information. In order to avoid PHP errors, the casting is done so the page still gets rendered. Resolves: #93138 Releases: main, 12.4, 11.5 Change-Id: Ia71dc81363c519a663c9cc91e2f0f200e7570832 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81079 Reviewed-by:
-
