- Dec 21, 2021
-
-
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71402 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Stefan Bürk authored
With #96393 forward-compatible prepared statement support has been added to QueryBuilder and also provided several tests to covers this implementation. However one test tests doctrine/dbal behaviour for 'Statement->bindValue()' which behaves differently accross drivers and platforms, emitting different exception types or need an additional execute. This patch removes this test as it is not the job of core testing to test 3rd party code and inconsistent behaviour. Removed test were already removed on backport for #96393. Resolves: #96408 Related: #96393 Releases: main Change-Id: I35d65171dda9fbcc91c906708324997006e21c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72752 Tested-by:
-
- Dec 20, 2021
-
-
Andreas Fernandez authored
The function `idn_to_ascii()` will return either `false` or a string, the former one is returned on errors. In #93900, the result was cast to string, making the check for `false` useless. As `idn_to_ascii()` can return both, the string cast is removed to make the check for `false` functional again. Resolves: #96399 Related: #93900 Releases: main, 11.5 Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72740 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Benjamin Franzke authored
In ES6 mode Viewport.Topbar and ModuleMenu.App properties cannot be overwritten (in order to be substituted with a call spy), as they reference other JavaScript modules. The properties of ES6 models are readonly ("frozen") and can therefore not be overwritten in a test setup. Therefore the test is adapted to overwrite the references in Viewport and ModuleMenu instead. Also a timeout is added as await import('TYPO3/CMS/Backend/ModuleMenu') does not guarantee a loading order between modules in ES6, which causes test asserts to be executed too early. Releases: main Resolves: #96396 Related #96323 Change-Id: I5c213b70e43c5e1256e91ffe0d9f12f96dbb6615 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72736 Tested-by:Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Sybille Peters authored
The phpstan configuration documentation recommends to specify the paths relative to the directory of the configuration file. Thus using, currentWorkingDirectory (as current working directory) is unnecessary and removed. Resolves: #96163 Releases: main Change-Id: I2b625f4722e1955b5928a22dbdd2b4aedf6daafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72709 Tested-by:
-
Christian Kuhn authored
The patch makes the bulk of ViewHelper classes more strict and applies some general love. Some ViewHelpers have been left, those will see bigger refactorings soon. All affected classes are final, the changes are (hopefully) non-breaking. * declare(strict_types=1) if missing. * Use self:: instead of static:: since all VH's are final, so there is not point in using late static binding. * Return and argument type hints where possible and reduction of methods doc annotations which are covered by PHP method signatures. * Add types to some class properties. * Protect some detail methods that were apparently public by accident. This is not considered breaking. * Avoid extbase LocalizationUtility::translate() in favor of core LanguageService. * Avoid static class state, especially with TSFE. * Minor comment fixes. Change-Id: I4e3b9d01ea92802e47d05a10f4243196120b8510 Resolves: #96400 Related: #96368 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72741 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Franzke authored
CKEditor is now loaded via a plain <script async> tag in preparation for a transition from requirejs to ES6 modules. CKEditor v4 is not available as ES6 module and can not easily be transformed into a strict-mode compatible module. CKEditor v4 requires `this` to be the global window object in various functions, but `this` is not bound to the global window object in strict-mode (as implied by <script type="module">). Note: CKEditor is not a real AMD module anyway, but is configured to be shimed by requirejs to be loadable as AMD module, therefore it can safely be loaded using good old <script>. Releases: main Resolves: #96394 Related: #96323 Change-Id: Ife0b476ba29b85f85dfd654ea096cdf30c47b6ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72733 Tested-by:
-
Christian Kuhn authored
BackendController renders "Main.html" as central backend skeleton, plus "Topbar.html" and "MainModule.html". The patch moved the templates into one folder. Resolves: #96404 Releases: main Change-Id: I485d9ff03e457d78c8454e36ac893fbbc1ffe77c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72746 Tested-by:
-
Christian Kuhn authored
There is no point in having the main template in a sub folder, move it up. Additionally use full EXT: syntax for f:translate arguments and avoid a useless flashMessage VH call that is already done by ModuleTemplate automatically. Resolves: #96405 Releases: main Change-Id: Id2f9e4bd28f9ed7649ff5b3c73348cf7d2307a51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72747 Tested-by:
-
Christian Kuhn authored
Avoid dash between the two words. Resolves: #96401 Releases: main Change-Id: If3455598e643f1304400aa2271733bb5f69df0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72742 Tested-by:
-
Christian Kuhn authored
Resolves: #96403 Releases: main Change-Id: Id4843f31254fe2b4bd46fe3c7c37669c6f3a06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72744 Tested-by:
-
Christian Kuhn authored
Resolves: #96402 Releases: main Change-Id: I8266c5859954ea118a4ec92ca3ca9660e9854c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72743 Tested-by:
-
Stefan Bürk authored
The dev dependency friendsofphp/php-cs-fixer now has a minimum requirement to 3.4, which comes with PHP8.1 support. This allows TYPO3 to run PHP-CS Fixer with PHP 8.1 in the CI pipeline. Testing configuration is not adjusted with this patch, but allows using corresponding runTests.sh testsuites cgl and cglGit: Build/Scripts/runTests.sh -p 8.1 -s cglGit -n Build/Scripts/runTests.sh -p 8.1 -s cgl -n Used command: composer req friendsofphp/php-cs-fixer:^3.4 --dev Resolves: #96398 Releases: main, 11.5 Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72739 Tested-by:
-
Benni Mack authored
Resolves: #96392 Related: #95320 Releases: main Change-Id: I6dfe1e5ea95c1e5ceb748e2b1c50eec8644f1ecf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72732 Tested-by:
-
Benjamin Franzke authored
theChar is not initialized and therefore pollutes global scope. (It is assigned to window.theChar in the FormEngine iframe). Currently not an error (we are not using strict mode in RequireJS), just bad style, but once we switch to strict mode (type="module"), this will fail without proper declaration. Releases: main, 11.5 Resolves: #96395 Related: #96323 Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72735 Tested-by:
-
Stefan Bürk authored
doctrine/dbal:^3.2 changed return type of result for QueryBuilder execute methods, no longer have used prepared statement accessible for further query execution with other placeholder values. To raise doctrine/dbal:^3.2 two places have been changed to reuse the QueryBuilder instance itself instead of prepared statement with the corresponding patch #96287, thus given up the performance gain through reusable query execution plan in corresponding dbms systems. This patch adds support for prepared statements to TYPO3's QueryBuilder facade as this was not publicly available yet for TYPO3 users to be forward-compatible with Doctrine DBAL 3. Resolves: #96393 Related: #96287 Releases: main Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72610 Tested-by:
-
Sybille Peters authored
In a previous patch, some language labels were unified in EXT:redirects to that the same label was used for each field in the list module as well as in the edit view. Due to this some of the labels have become redundant and are now removed. Resolves: #96015 Related: #95832 Releases: main Change-Id: I2fd9c650dcca0aea81999a3de2b427895984c70f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72708 Tested-by:
-
Stefan Bürk authored
doctrine/dbal deprecated quite some methods to cleanup their codebase and provided replacements with more speaking method names. Most depcrecated method usages have been replaced in the core, but we missed some. The patch replaces the depcrecated method 'executeUpdate()' with the corresponding 'executeStatement()' method in several places to cleanup this up. This can be done also in 11.5 too, the required minimum version of doctrine/dbal provides these new methods as upwards compatible layer. Resolves: #96389 Releases: main, 11.5 Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72710 Tested-by:
-
- Dec 19, 2021
-
-
Stefan Bürk authored
With a recent change in typo3/testing-framework, various core caches in functional tests are set to NullBackend. This speeds up functional tests up to 10% since the table creation and insert load is higher in testing scenarios than actual cache hit benefits. Some functional tests however work on those tables, for instance the functional test of the database cache backend. The patch adapts these tests to according LocalConfiguration setup. > composer u typo3/testing-framework Resolves: #96387 Releases: main Change-Id: I9770c65d4cf80f98d2c4745024867acf6807e01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72706 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Dec 18, 2021
-
-
Torben Hansen authored
This patch ensures that the getQuery() function only uses the minus operator to negate the $storagePid variable, if the variable can be interpreted as an integer. Resolves: #96321 Releases: main, 11.5 Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72704 Tested-by:
-
- Dec 17, 2021
-
-
Markus Klein authored
RTE yaml configuration can be incomplete/wrong or empty. Do not access configuration settings without a safeguard. Resolves: #96383 Releases: main, 11.5 Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72702 Reviewed-by:
-
Helmut Hummel authored
A "type" does not need to be set in a composer.json, so the checks for package type must account for the type being null, to not trigger a warning in PHP 8 Releases: 11.5, main Resolves: #96372 Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72695 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Helmut Hummel authored
Instead of relying on a hard coded extension install path, now the real extension path is used provided by the package manager Releases: main, 11.5 Resolves: #96375 Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72697 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Helmut Hummel authored
Get rid of the select query entirely, which optimises the task to only require one update query instead of one select and possibly multiple update queries and gets rid of doctrine version related incompatibilities with fetching the select result. Resolves: #96369 Related: #87162 Releases: main, 11.5, 10.4 Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72693 Reviewed-by:
-
Oliver Bartsch authored
The RecordListGetTable hook allows to add an additional where clause to the recordlist query. Since the sanitized result was wrapped in an array before being passed to $queryBuilder->andWhere(), this led to an exception. This is now fixed by passing the sanitized clause as string to `addWhere()`. Resolves: #96378 Related: #92065 Releases: main, 11.5 Change-Id: I99fa184f49f9db9f7edf061d4137e1e6c275446e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72699 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
As anticipated in v11 with #95298, this patch declares ViewHelper classes PHP final, third party extensions can no longer extend core ViewHelpers. There is one exception: The ext:fluid FormViewHelper, which is currently extended by ext:form. This can't be resolved easily since it's on one hand quite a bit of code that would have to be copied, and more importantly, the FormField* ViewHelpers refer to the "parent" FormViewHelper class name in various places. Declaring FormViewHelper final thus needs a different refactoring, which may be done in v12 with further patches. Resolves: #96368 Related: #95298 Releases: main Change-Id: I7e8a587dadef4e411390710dd47e309cd2414e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72671 Tested-by:
-
- Dec 16, 2021
-
-
Nikita Hovratov authored
The FinisherOptionGenerator of the form extension generates the data structure for the form setting overrides on the fly. By doing so, it didn't make a distinction between normal TCA fields and flexform specific sections/containers and added the wrapper "TCEforms" to sections as well, which broke the validation in DataHandler for the fields inside the container (E.g. the email field). The patch checks if section is set to "true" and adds the "TCEforms" key only for normal TCA field configurations. Unit tests have been added for the DataHandler checkValue_flex_procInData_travDS method, which show cases with and without the "TCEforms" key. Also, since this works now, a PHP 8 warning appeared. This is fixed now, too. Resolves: #95441 Releases: main, 11.5 Change-Id: Ib12a0484bcbdc827664181ca6af89edfadee13d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71490 Tested-by:
-
Markus Klein authored
Fix PHP8 warning issue if $_SERVER['PATH_INFO'] is not set. Resolves: #96373 Releases: main, 11.4 Change-Id: I427aee39c6f6389e418f27474c01cbfd973355e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72696 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Benni Mack authored
Resolves: #96358 Releases: main, 11.5 Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72694 Tested-by:
-
Benni Mack authored
Resolves: #96310 Releases: main, 11.5 Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72599 Tested-by:
-
Benni Mack authored
HMENU special="directory" and special="updated" did not use PageRepository directly, which led to duplicate entries with workspaces. This change does not use "$cObj->exec_..." anymore and fixes all problems. Resolves: #96226 Releases: main, 11.5 Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72648 Tested-by:
-
Oliver Bartsch authored
The new `setContext` method is added to the ProviderInterface, making the API more robust. Resolves: #96333 Releases: main Change-Id: I1e2c2de893c247845a3640cac37fd76acead5595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72670 Tested-by:
-
Nikita Hovratov authored
This patch combines all seperated unit tests of DataMapFactory->setRelations() into a single test. These tests are now represented by the dataProvider. Resolves: #96364 Releases: main Change-Id: I1c1b7a9694a700a9fce68476c308df1b318dd8db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72667 Tested-by:
-
Christian Kuhn authored
ext:extensionmanager has a couple of view helpers that extend ActionViewHelper for no apparent reason. Change those to extend AbstractTagBasedViewHelper instead. Resolves: #96361 Releases: main, 11.5 Change-Id: Iedab908a30df0418a7c86d073d97a47548a87ab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72665 Tested-by:
-
Christian Kuhn authored
To prepare making all view helpers final as anticipated with #95298, ext:backend ThumbnailViewhelper must no longer extend ext:fluid ImageViewHelper. The patch is a simple transition, we may later have a look at the ThumbnailViewHelper again, since probably some of the possible arguments are not needed for thumbnails. Resolves: #96362 Related: #95298 Releases: main Change-Id: Ibf0f3ac108ab1849454769a947061a4604eb9fbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72666 Tested-by:
-
- Dec 15, 2021
-
-
Christian Kuhn authored
The "max" drop down in the ext:belog filter html is the only one that uses belog:form.translateLabelSelect view helper. By refactoring slightly, we can drop this view helper and simplify the code a bit. Resolves: #96360 Related: main Change-Id: Ib952dd3475d952354f8a07c31917f88751b93704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72664 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Marc Bastian Heinrichs authored
Resolves: #96308 Releases: main, 11.5, 10.4 Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72598 Tested-by:
-
Georg Ringer authored
If EXT:workspaces is not installed, the workspace information should also be skipped in the logging module. This makes it easier to read and less bloated. Resolves: #96314 Releases: main, 11.5 Change-Id: I22277ca681cc877d57686e02f36fe54e630d2f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72607 Tested-by:
-
Christian Kuhn authored
$command being either 'new' or 'edit' is tested in a previous if() a couple of lines above already. Resolves: #96357 Releases: main Change-Id: I8088d50df6c854127ebecb8038a648fdad9af172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72662 Tested-by:
-
Stefan Bürk authored
Add support for sqlite acceptance testing to 'Build/Scripts/runTests.sh'. Run acceptance/sqlite testing with PHP 8.1 in nightly as a first execution implementation, which could be reshuffled when minimum PHP requirements have been decided. Furthermore two acceptance tests are marked as skipped when executed with sqlite, which should be fixed in dedicated patches: * MaintenanceCest.php->analyzeDatabaseStructureWorks() Skipped, as database compare is never clean and ends in endless loop with sqlite, when ext:indexed_search is installed. This is a general issue, existing at least since v10.4. Needs investigation and a dedicated patch. * UpgradeCest.php->seeUpgradeWizard() Skipped, as utf-8 charset upgrade wizard is not visible for sqlite dbms backend, thus rendering this test obsolete with sqlite. Needs another update wizard test and possibly a dedicated patch. Resolves: #96340 Releases: main Change-Id: I74c8f1156d98a5419309e110ed761e3de21fa37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72446 Tested-by:
-
