[TASK] Modernize ViewHelper classes
The patch makes the bulk of ViewHelper classes more strict and applies some general love. Some ViewHelpers have been left, those will see bigger refactorings soon. All affected classes are final, the changes are (hopefully) non-breaking. * declare(strict_types=1) if missing. * Use self:: instead of static:: since all VH's are final, so there is not point in using late static binding. * Return and argument type hints where possible and reduction of methods doc annotations which are covered by PHP method signatures. * Add types to some class properties. * Protect some detail methods that were apparently public by accident. This is not considered breaking. * Avoid extbase LocalizationUtility::translate() in favor of core LanguageService. * Avoid static class state, especially with TSFE. * Minor comment fixes. Change-Id: I4e3b9d01ea92802e47d05a10f4243196120b8510 Resolves: #96400 Related: #96368 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72741 Tested-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php 3 additions, 12 deletions...sext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php 4 additions, 14 deletions...inpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ArrayBrowserViewHelper.php 4 additions, 13 deletions...xt/backend/Classes/ViewHelpers/ArrayBrowserViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php 4 additions, 10 deletions...3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/LanguageColumnViewHelper.php 1 addition, 1 deletion.../backend/Classes/ViewHelpers/LanguageColumnViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php 4 additions, 3 deletions...backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php 5 additions, 4 deletions.../backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php 0 additions, 1 deletion.../backend/Classes/ViewHelpers/Mfa/IfHasStateViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php 1 addition, 10 deletions...sext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php 5 additions, 6 deletions...ysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php 4 additions, 7 deletions.../backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php 5 additions, 8 deletions...t/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php 7 additions, 16 deletions...ysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php 7 additions, 17 deletions...ext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php 10 additions, 14 deletions...3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php 20 additions, 30 deletions...xt/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php 6 additions, 10 deletions...ext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/Display/TableAccessViewHelper.php 4 additions, 1 deletion...ser/Classes/ViewHelpers/Display/TableAccessViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php 18 additions, 26 deletions...sext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php 8 additions, 19 deletions...ser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php
Please register or sign in to comment