Skip to content
Snippets Groups Projects
Commit 24f25996 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[!!!][TASK] Declare all ViewHelpers final

As anticipated in v11 with #95298, this patch
declares ViewHelper classes PHP final, third party
extensions can no longer extend core ViewHelpers.

There is one exception: The ext:fluid FormViewHelper,
which is currently extended by ext:form. This can't
be resolved easily since it's on one hand quite a bit
of code that would have to be copied, and more importantly,
the FormField* ViewHelpers refer to the "parent"
FormViewHelper class name in various places. Declaring
FormViewHelper final thus needs a different refactoring,
which may be done in v12 with further patches.

Resolves: #96368
Related: #95298
Releases: main
Change-Id: I7e8a587dadef4e411390710dd47e309cd2414e65
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72671


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 2f6df56c
Branches
Tags
No related merge requests found
Showing
with 20 additions and 20 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment