- Mar 03, 2022
-
-
Benni Mack authored
This removes the option config.metaCharset and the conversion of content everywhere. The public method "TSFE->convOutputCharset" is gone. The property "config.metaCharset" has no effect anymore. Resolves: #97065 Releases: main Change-Id: I657b68adeba3501612ae0959fe54bdeb6470305c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73698 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Gabe Troyan authored
Rotate collapse arrow 90 degrees for expanded validators and finishers. Remove this indicator when there is no panel to expand. Resolves: #97041 Releases: main Change-Id: I184deca19b34075e2706d112e48d40a9ab5bfcd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73724 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
-
Christian Kuhn authored
With refactoring #96998, Extbase validators should always be initialized calling setOptions(). Issue #97010 showed this is easy to forget. The patch avoids instantiating single validators directly, they are now always instantiated using ValidatorResolver->createValidator() which takes care of options setting. Resolves: #97021 Related: #96998 Related: #97010 Releases: main Change-Id: Ibb2966a442b37748d339fd2d88add13387f6ec07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73694 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benni Mack authored
This change finalizes a long time of cleaning up the main CharsetConverter class, whereas most functionality is now internal and can use strict types for their arguments, simplifying the code and return types. Resolves: #97076 Releases: main Change-Id: I479da42096df0c83b8a091612d674ff334761535 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73760 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Mar 02, 2022
-
-
Benni Mack authored
The method getTreeList() has had a difficult time to use, and its logic is now moved to * PageRepository->getPageIdsRecursive() * PageRepository->getDescendantPageIdsRecursive() using a better API to understand and streamlined code. Resolves: #97027 Releases: main Change-Id: I5069fa744e78e7ffd3a1e1d3a60e352a2ff62199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73677 Tested-by:
-
Benjamin Franzke authored
In order to avoid the internal HtmlResponse class usage and to prepare for possible APIs to manage Content Security Policy headers assets rendered by the PageRenderer it's good for PageRenderer to be able to render full PSR-7 responses. Also cleanups up ModuleTemplate to make use of this capability. Resolves: #97071 Releases: main Change-Id: If628d33c916367e204695252b76f629397dd995a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73604 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Stefan Bürk authored
This patch raises two dev dependencies to do one more footstep towards symfony 6.x component raises. After this patch codeception is the only package which blocks symfony raise. raised packages: * composer/composer:^2.2.7: includes a opened requirement definition for composer/xdebug-helper which will not interfere with friendsofphp/php-cs-fixer >3.4 * friendsofphp/php-cs-fixer:^3.6.0: latest php-cs-fixer version which allows symfony 6.x components if needed used commands: > composer req --dev -W \ "composer/composer":"^2.2.7" \ "friendsofphp/php-cs-fixer":"^3.6.0" Resolves: #97053 Releases: main Change-Id: I3bda0966df9b82d3b2fda4c20d92b54ec16698c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73727 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
In case a stored page link, links to an invalid page (e.g. pid=0) or a no longer existing page, the corresponding array access must be omitted. Also the call to GU::fixed_lgd_cs should be skipped. Resolves: #97075 Releases: main, 11.5 Change-Id: I2055a2dfcde021efdd1fa8b20804595d7a40eac2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73759 Tested-by:
-
- Mar 01, 2022
-
-
Oliver Bartsch authored
Since the class is called in another context, the packageName must be defined explicitly. Resolves: #97074 Related: #96601 Releases: main Change-Id: I6284f3ba3db426086469fa1d569dcce2729801db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73758 Tested-by:
-
Stefan Bürk authored
PHP8.1 changed the defaults for the second argument '$flags' from 'ENT_COMPAT' to 'ENT_QUOTES | ENT_SUBSTITUTE', which changes the behaviour if that argument was not specified. In general this is a good change, thus leaving it unspecified and live with the stricter default was considered as the way to go in general. However, in the specific case for rendering the ReST files of the changelog and view it in the install tool this change now displays weired and malformed documentation. To mitigate this, this patch sets explicitly the second argument to 'ENT_COMPAT | ENT_SUBSTITUTE' to restore the old behaviour but take malformed away for preparing the documentation content. See: https://github.com/php/php-src/blob/85b669e56583ee5d536168db7aaffbebe9d1aff2/UPGRADING#L166 Resolves: #97073 Releases: main, 11.5 Change-Id: I3e78ef1a218fe0f09ccbcf6f4b073cf5900d42c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73757 Tested-by:
-
Oliver Bartsch authored
The code example was not rendered, since a empty line was missing. Additionally, the title has to start with "Important:". Resolves: #97072 Related: #93635 Releases: main, 11.5 Change-Id: I85b53f8d2f89558300b6ea996e1ab1147a678a92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73756 Tested-by:
-
Georg Ringer authored
Add a missing label to the workspace module and remove a not needed line break in a translation. Resolves: #97052 Releases: main, 11.5 Change-Id: I8a01373fde08bb249f42f9426247cbd589258731 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73726 Tested-by:
-
Stefan Bürk authored
doctrine/lexer has released a new minor version with fixed method docblocks, thus phpstan ignore pattern can now be removed again. See: https://github.com/doctrine/lexer/issues/62 > composer req doctrine/lexer:"^1.2.3" > composer req doctrine/lexer:"^1.2.3 \ --no-update -d typo3/sysext/core > Build/Scripts/runTests.sh \ -s phpstanGenerateBaseline Resolves: #97063 Related: #97055 Releases: main, 11.5 Change-Id: I5e729543c4721e7f9a17511c113139bf7908b208 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73740 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
This moves some labels from the template to the locallang file, making them translatable. Resolves: #97048 Releases: main, 11.5 Change-Id: I0d02864296b98148e2f01449edc2edbe880847f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73753 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Benni Mack authored
Instead of resolving the value $TSFE->contentPid at a point when the page generation happens, this is now done within "determineId", which allows to use this value in custom middlewares. Resolves: #97064 Releases: main Change-Id: I126c7295a1cb1a54e5f9d65ecb74b8b2e4ce2105 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73741 Tested-by:
-
Kevin Appelt authored
Resolves: #97008 Releases: main, 11.5 Change-Id: I00e34e4d43d1babd085435d096af773876480e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73679 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Jan Helke <jh@f7.de> Reviewed-by:
-
- Feb 28, 2022
-
-
Oliver Bartsch authored
Resolves: #97061 Related: #96107 Releases: main Change-Id: I808421151ae0576bf5bdbda51b95f2cc1790b4f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73739 Tested-by:
-
Oliver Bartsch authored
The "defaultCategorizedTables" option was still defined in DefaultConfiguration, while it was already declared as removed in #96153. This now removes the last remains. Resolves: #97060 Related: #96153 Releases: main Change-Id: I7681f4f28126e3b929f62fbcdaa80614738c2f68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73738 Tested-by:
-
Andreas Fernandez authored
In order to make TCA slimmer and more understandable, the `required` configuration is now used in favor of `eval`, which is also enforced by an automatic TCA migration. At least since #67354 TYPO3 is able to use an explicit `required` configuration: 'column' => [ 'label' => 'foo', 'config' => [ 'type' => 'input', 'required' => true, ], ] Resolves: #97035 Releases: main Change-Id: Ifa4b361e7e4a664596697d4351d6d4b933946d54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73709 Tested-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Feb 27, 2022
-
-
Stefan Bürk authored
doctrine/lexer has released a new minor version with changed method docblocks, which now emits phpstan errors because of incompatible types. This patch raises the minor version for development and core usage and adding phpstan ignore pattern to the baseline file until doctrine/lexer has fixed the incompatible state. This is a dedicated preparation to raise other dev dependencies. Issue has been reported to the corresponding github repository: https://github.com/doctrine/lexer/issues/62 used commands: > composer req doctrine/lexer:"^1.2.2" > composer req doctrine/lexer:"^1.2.2" \ --no-update -d typo3/sysext/core > Build/Scripts/runTests.sh \ -s phpstanGenerateBaseline Resolves: #97055 Releases: main, 11.5 Change-Id: Ib5c04202bdc6a4b5787a191e4bf1e175982fb217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73729 Tested-by:
-
Andreas Fernandez authored
Resolves: #97058 Releases: main, 11.5 Change-Id: Id0871bd2931f5b28c3a8f56471bd15d9aac3fadc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73733 Tested-by:
-
Benjamin Franzke authored
The private container now provides access to non-public services that have been at least once injected (and thus be considered as service during DI compilation phase). This may be used to provide dependencies to functional test setups where some dependencies needs to be mocked while other should receive the vanilla dependency the container would normally inject. A functional test case does implement the ContainerInterface now, allowing tests to access both public and private services. $this->getContainer() may still be used if the default container (delivering public services only) needs to be injected into a service. Related testing-framework pull request: https://github.com/TYPO3/testing-framework/pull/331 Commands executed: composer u typo3/testing-framework git grep -l "this->getContainer()->get(" | xargs sed -i 's/this->getContainer()->get(/this->get(/g' Resolves: #97032 Releases: main, 11.5 Change-Id: I5987d5244270a3e190c8721f6a8971c7fd1309ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73646 Tested-by:
-
Oliver Klee authored
GeneralUtility::getIndpEnv can also return values other than string, e.g., PATH_INFO might return null, and TYPO3_SSL will return a bool. Also, _ARRAY will return an array of all possible scalar values. The return type annotation needs to correctly reflect that in order for static type analysis to be able to work correctly when this function is called. Resolves: #97020 Releases: main, 11.5 Change-Id: Ibb24f1a3451c6598452402fc7a7b0a96c66bbd01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73693 Tested-by:
-
Christian Kuhn authored
Running bin/typo3 upgrade:run now encapsulates the wizard in question in double ticks. Before: > bin/typo3 upgrade:run Running Wizard Sanitize existing SVG files in fileadmin folder After: > bin/typo3 upgrade:run Running Wizard "Sanitize existing SVG files in fileadmin folder" Change-Id: I0739f836eb2b9cade517563a135f0333ecb6e055 Resolves: #97054 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73728 Tested-by:
-
Stefan Bürk authored
Update styleguide to provide latest changes. * ES6 modules and converted notification example #97006 * type=folder example #96983 * 'l10n_display' => 'defaultAsReadonly' example * example for inline children with max_items set #91808 * inline symmetric with group field example One of the styleguide changes adapted a table name which is now longer. This leads to an edit icon no longer being within view port. We fix the chrome options and increase the browser window size a bit - this gives a better overview when looking an acceptance test screenshots, too. This has minor impact on the page tree keyboard test, too. > composer u typo3/cms-styleguide Resolves: #97006 Resolves: #97056 Related: #96983 Related: #91808 Releases: main Change-Id: I257f2b0a8a51170ab7f0240f6fc2199d5e73c277 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73730 Tested-by:
-
Oliver Bartsch authored
The filter in the Belog module is extended for a new page selector (Database browser). Using the new selector, one is able to filter logs by specific page or even page trees, when using together with the "depth" option. Additionally, the modules' access is changed to "user", which allows administrators to enable the module for specific users or user groups. Non-admin users however will never see global logs, but only logs for pages they have access to. The user will be informed by corresponding info boxes. Resolves: #97051 Related: #97031 Releases: main Change-Id: I62383d6385a8b8d5e2650b3c44ac078dae1883b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73725 Tested-by:
-
- Feb 26, 2022
-
-
Oliver Bartsch authored
Resolves: #97050 Related: #96574 Releases: main Change-Id: I521154db1b4a7dd599ab011dd57faff9eaddbd9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73723 Tested-by:
-
Benjamin Franzke authored
Add dependency injection to PageRenderer and it's direct dependencies. Most prominently this avoids the static assets-cache injection from TYPO3 bootstrap and refactors to regular injection instead. ResourceCompressor is adapted to be delay it's initialization to be injectable without immediate side-effects. Backend Router and UriBuilder are not injected because they are a) only needed in backend context and b) should ideally be moved out of the PageRenderer into EXT:backend anyway. Resolves: #97030 Releases: main Change-Id: I8e72e5f87a095372439c3cd8106318ae272c6ce0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73594 Tested-by:
-
Björn Jacob authored
Using the legacy form template / partial variants residing in :file:`EXT:form/Resources/Private/Frontend/Templates` and :file:`EXT:form/Resources/Private/Frontend/Partials` is deprecated. The legacy templates will be removed in v13. Resolves: #95456 Releases: main Change-Id: Ib1346065d69a12d6664758a3c9bedf7efa3bd834 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71423 Tested-by:
-
colin_44 authored
Add documentation for editors about validators. Add to sitetree. Resolves: #97025 Releases: main, 11.5 Change-Id: If250bae9acf265574f20bcef801d2c1fd66ceeb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73713 Tested-by:
-
colin.findeisen@tritum.de authored
This patch adds a documentation regarding form elements for editors. As a drive-by change the site trees for integrators and editors have been fixed. Resolves: #82357 Releases: main, 11.5 Change-Id: I06548dd0f51cdbd814067f1c44e49629fd56b68e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73700 Tested-by:
-
Oliver Hader authored
DefaultSanitizerBuilder for HTML sanitizer creates a new behavior for each invocation which is superfluous and can be cached in memory. Resolves: #96862 Releases: main, 11.5, 10.4 Change-Id: I4a6710524a1f2f1256c8aa7694ceaa56a627a07f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73459 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Feb 25, 2022
-
-
Oliver Bartsch authored
Previously, the Belog module was accessible in System>Log as well as a third-level module in web>info. Latter required a couple of hacks, e.g. a manual extbase bootstrap. To simplify the underlying codebase, the "log" submodule is now removed from web_info. The main benefit of the log module in web>info was the usage of the page tree to filter logs by page. This feature will be added to the System>Log module in another patch again. Also note that since TYPO3 v9 ist also possible to access relevant page and record logs in the history module. Resolves: #97031 Releases: main Change-Id: I2d445b0b9039ee9a99ba262729b34f3736448a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73708 Tested-by:
-
Nikita Hovratov authored
The TCA type group became more and more a pure database relation type throughout the years. The only annoyance that was still there is internal_type with "folder" set. Although they are very similar in the user interface, internally they are handled completely separate. They share only a fraction of common TCA properties, too. This leads to checks for internal_type !== 'folder' everywhere across the codebase. To avoid this, folder must become an own type. With folder as an own type, the code becomes much more readable and there is a lot less if-branching. Resolves: #96983 Releases: main Change-Id: Ifb746be9a5fc978a9a47af4c9e65bfc5498abf51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73622 Tested-by:
-
Björn Jacob authored
The documentation now includes an overview of the used validation messages and their error codes. While being on it, the DateRange validator has been documented as well. Resolves: #87393 Releases: main, 11.5 Change-Id: I5e91131d5464fde370609310a2a5a5a3b64941c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73714 Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
-
Björn Jacob authored
The API Reference of the form framework resided inside the docs for integrators. This patch creates a new main chapter "For Developers/ API Reference" and moves all the related content there. In addition, the content has been splitted in three documents. Resolves: #97039 Releases: main, 11.5 Change-Id: Ie626f3ebdd137dfb7aef308b1bf7568dc17de985 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73710 Tested-by:
Colin Findeisen <colin.findeisen@tritum.de> Tested-by:
-
Elias Häußler authored
The localization of error with code 1521293686 in DateRangeValidator is missing. This patch adds the missing localization. Resolves: #97044 Releases: main, 11.5 Change-Id: I18c05c17d34f85b897c796cb987a94151d6da1ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73715 Tested-by:
-
Ralf Zimmermann authored
To make the form manager and form plugins load faster, the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/58054/ optimized the parsing of form definitions. Instead of using the YAML parser, a very rudimentary "parser" was introduced. This works fine, except for the fact that YAML escapes in form labels are not unescaped when displayed. This patch partially reintroduces the parsing of YAML, but only for the label. The performance drops only slightly. 10000x "loadMetaData()" (status quo) = 0.41 seconds 10000x "loadMetaData()" + parse label with yaml parser = 0.57 seconds 10000x parse the whole form definition with yaml parser = 7.57 seconds Resolves: #95733 Releases: main, 11.5 Change-Id: I742b18313af4c8fe90d2899848518d90f543f86e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73688 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Helmut Hummel authored
As a followup to #96424, expressive API is introduced and covered with unit tests, to better convey the intention in the places it is used. Resolves: #96424 Releases: main, 11.5 Change-Id: I9596e2269b891042cbb03ccbedfcbc086f2897ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73707 Tested-by:
-
Björn Jacob authored
This patch adds a new FAQ entry. It explains how to handle duplicate form submissions. Resolves: #95074 Releases: main, 11.5 Change-Id: Ide89f57dc296ab629b9bb50d76d7896cb998c008 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73701 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
