[BUGFIX] phpstan: declare return type of forwardOnFieldChangeQueryParams

Resolves: #97058
Releases: main, 11.5
Change-Id: Id0871bd2931f5b28c3a8f56471bd15d9aac3fadc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73733


Tested-by: core-ci <typo3@b13.com>
Tested-by: Simon Gilli <typo3@gilbertsoft.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Simon Gilli <typo3@gilbertsoft.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

Build/phpstan/phpstan-baseline.neon

@@ -120,21 +120,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\AbstractFormElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\FolderElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/FolderElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\GroupElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/GroupElement.php
-
 		-
 			message: "#^Method TYPO3Fluid\\\\Fluid\\\\View\\\\ViewInterface\\:\\:render\\(\\) invoked with 1 parameter, 0 required\\.$#"
 			count: 1
@@ -150,31 +135,11 @@ parameters:
 			count: 2
 			path: ../../typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\InputLinkElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\InputTextElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/InputTextElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\RadioElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/RadioElement.php
-
 		-
 			message: "#^If condition is always true\\.$#"
 			count: 3
 			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\SelectCheckBoxElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php
-
 		-
 			message: "#^Offset 'header' on array\\{header\\: array\\{icon\\: string, title\\: mixed\\}, items\\: array\\<int, array\\{id\\: string, name\\: non\\-empty\\-string, value\\: mixed, checked\\: bool, icon\\: string, title\\: mixed, help\\: string\\}\\>\\} on left side of \\?\\? always exists and is not nullable\\.$#"
 			count: 1
@@ -185,11 +150,6 @@ parameters:
 			count: 2
 			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\SelectMultipleSideBySideElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php
-
 		-
 			message: "#^Offset 'header' on array\\{header\\: array\\{title\\: mixed, disabled\\?\\: false\\}, items\\: non\\-empty\\-array\\<int, array\\{label\\: string, attributes\\: non\\-empty\\-array\\<literal\\-string&non\\-empty\\-string, mixed\\>\\}\\>\\} in isset\\(\\) always exists and is not nullable\\.$#"
 			count: 1
@@ -200,16 +160,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\SelectSingleBoxElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\SelectSingleElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php
-
 		-
 			message: "#^Offset 'header' on array\\{header\\: array\\{title\\: mixed\\}, items\\: non\\-empty\\-array\\<int, array\\{title\\: string, value\\: mixed, icon\\: string, selected\\: bool\\}\\>\\} on left side of \\?\\? always exists and is not nullable\\.$#"
 			count: 1
@@ -225,36 +175,11 @@ parameters:
 			count: 2
 			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\SelectTreeElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php
-
 		-
 			message: "#^Right side of && is always true\\.$#"
 			count: 1
 			path: ../../typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php
 
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\TextElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/TextElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\Element\\\\TextTableElement\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/Element/TextTableElement.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\FieldControl\\\\EditPopup\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php
-
-		-
-			message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Form\\\\FieldControl\\\\LinkPopup\\:\\:forwardOnFieldChangeQueryParams\\(\\) should return array\\<string, string\\> but returns array\\<string, array\\<int, array\\>\\|string\\>\\.$#"
-			count: 1
-			path: ../../typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php
-
 		-
 			message: "#^Negated boolean expression is always false\\.$#"
 			count: 1

typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeTrait.php

@@ -59,7 +59,7 @@ trait OnFieldChangeTrait
     /**
      * Forwards URL query params for `LinkBrowserController`
      * @param list<OnFieldChangeInterface> $items `fieldChangeFunc` items
-     * @return array<string, string> relevant URL query params for `LinkBrowserController`
+     * @return array{fieldChangeFunc: array<int, array>, fieldChangeFuncHash: string} relevant URL query params for `LinkBrowserController`
      */
     protected function forwardOnFieldChangeQueryParams(array $items): array
     {