Skip to content
Snippets Groups Projects
Commit 10ee1935 authored by Benni Mack's avatar Benni Mack
Browse files

[TASK] Clean up CharsetConverter

This change finalizes a long time of cleaning up
the main CharsetConverter class, whereas most
functionality is now internal and can use strict types
for their arguments, simplifying the code and return
types.

Resolves: #97076
Releases: main
Change-Id: I479da42096df0c83b8a091612d674ff334761535
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73760


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent 94e65de9
Branches
Tags
No related merge requests found
......@@ -575,26 +575,6 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Classes/Cache/Frontend/PhpFrontend.php
-
message: "#^If condition is always true\\.$#"
count: 3
path: ../../typo3/sysext/core/Classes/Charset/CharsetConverter.php
-
message: "#^Left side of && is always true\\.$#"
count: 3
path: ../../typo3/sysext/core/Classes/Charset/CharsetConverter.php
-
message: "#^Method TYPO3\\\\CMS\\\\Core\\\\Charset\\\\CharsetConverter\\:\\:initToASCII\\(\\) should return int but returns false\\.$#"
count: 2
path: ../../typo3/sysext/core/Classes/Charset/CharsetConverter.php
-
message: "#^Method TYPO3\\\\CMS\\\\Core\\\\Charset\\\\CharsetConverter\\:\\:initUnicodeData\\(\\) should return int but returns false\\.$#"
count: 2
path: ../../typo3/sysext/core/Classes/Charset/CharsetConverter.php
-
message: "#^Unsafe usage of new static\\(\\)\\.$#"
count: 1
......
This diff is collapsed.
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment