[TASK] Use dependency injection in PageRenderer
Add dependency injection to PageRenderer and it's direct dependencies. Most prominently this avoids the static assets-cache injection from TYPO3 bootstrap and refactors to regular injection instead. ResourceCompressor is adapted to be delay it's initialization to be injectable without immediate side-effects. Backend Router and UriBuilder are not injected because they are a) only needed in backend context and b) should ideally be moved out of the PageRenderer into EXT:backend anyway. Resolves: #97030 Releases: main Change-Id: I8e72e5f87a095372439c3cd8106318ae272c6ce0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73594 Tested-by:core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 5 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/core/Classes/Core/BootService.php 0 additions, 3 deletionstypo3/sysext/core/Classes/Core/BootService.php
- typo3/sysext/core/Classes/Core/Bootstrap.php 0 additions, 2 deletionstypo3/sysext/core/Classes/Core/Bootstrap.php
- typo3/sysext/core/Classes/Page/PageRenderer.php 57 additions, 94 deletionstypo3/sysext/core/Classes/Page/PageRenderer.php
- typo3/sysext/core/Classes/Resource/ResourceCompressor.php 15 additions, 4 deletionstypo3/sysext/core/Classes/Resource/ResourceCompressor.php
- typo3/sysext/core/Classes/Service/MarkerBasedTemplateService.php 12 additions, 28 deletions...ysext/core/Classes/Service/MarkerBasedTemplateService.php
- typo3/sysext/core/Configuration/Services.yaml 10 additions, 0 deletionstypo3/sysext/core/Configuration/Services.yaml
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php 29 additions, 5 deletionstypo3/sysext/core/Tests/Functional/Page/PageRendererTest.php
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php 79 additions, 0 deletions.../sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php 17 additions, 6 deletionstypo3/sysext/core/Tests/Unit/Page/PageRendererTest.php
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php 9 additions, 6 deletions...Tests/Unit/Resource/ResourceCompressorIntegrationTest.php
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php 4 additions, 7 deletions...ore/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php 7 additions, 4 deletions...ext/frontend/Classes/ContentObject/ImageContentObject.php
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php 149 additions, 4 deletions...sts/Unit/ContentObject/FluidTemplateContentObjectTest.php
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php 21 additions, 13 deletions...ntend/Tests/Unit/ContentObject/ImageContentObjectTest.php
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php 7 additions, 0 deletions...Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php 9 additions, 1 deletion...ests/Unit/Controller/TypoScriptFrontendControllerTest.php
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php 6 additions, 0 deletions.../sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php
Please register or sign in to comment