[!!!][FEATURE] Separate internal_type=folder into an own type
The TCA type group became more and more a pure database relation type throughout the years. The only annoyance that was still there is internal_type with "folder" set. Although they are very similar in the user interface, internally they are handled completely separate. They share only a fraction of common TCA properties, too. This leads to checks for internal_type !== 'folder' everywhere across the codebase. To avoid this, folder must become an own type. With folder as an own type, the code becomes much more readable and there is a lot less if-branching. Resolves: #96983 Releases: main Change-Id: Ifb746be9a5fc978a9a47af4c9e65bfc5498abf51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73622 Tested-by:core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
Showing
- Build/Sources/TypeScript/backend/form-engine/element/folder-element.ts 54 additions, 0 deletions.../TypeScript/backend/form-engine/element/folder-element.ts
- Build/phpstan/phpstan-baseline.neon 5 additions, 0 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php 267 additions, 0 deletionstypo3/sysext/backend/Classes/Form/Element/FolderElement.php
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php 15 additions, 32 deletionstypo3/sysext/backend/Classes/Form/Element/GroupElement.php
- typo3/sysext/backend/Classes/Form/FieldControl/ElementBrowser.php 8 additions, 7 deletions...sext/backend/Classes/Form/FieldControl/ElementBrowser.php
- typo3/sysext/backend/Classes/Form/FieldControl/InsertClipboard.php 6 additions, 10 deletions...ext/backend/Classes/Form/FieldControl/InsertClipboard.php
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php 1 addition, 7 deletions...sext/backend/Classes/Form/FieldWizard/RecordsOverview.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFolder.php 84 additions, 0 deletions...ysext/backend/Classes/Form/FormDataProvider/TcaFolder.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php 54 additions, 88 deletions...sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php 0 additions, 13 deletions.../Classes/Form/FormDataProvider/TcaInlineConfiguration.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php 19 additions, 5 deletions.../backend/Classes/Form/FormDataProvider/TcaRecordTitle.php
- typo3/sysext/backend/Classes/Form/NodeFactory.php 1 addition, 0 deletionstypo3/sysext/backend/Classes/Form/NodeFactory.php
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php 2 additions, 1 deletion...sysext/backend/Classes/Form/Utility/FormEngineUtility.php
- typo3/sysext/backend/Classes/Utility/BackendUtility.php 8 additions, 9 deletionstypo3/sysext/backend/Classes/Utility/BackendUtility.php
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/folder-element.js 13 additions, 0 deletions...s/Public/JavaScript/form-engine/element/folder-element.js
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaGroupTest.php 0 additions, 2 deletions...d/Tests/Functional/Form/FormDataProvider/TcaGroupTest.php
- typo3/sysext/backend/Tests/Unit/Form/FieldControl/ElementBrowserTest.php 14 additions, 3 deletions...ckend/Tests/Unit/Form/FieldControl/ElementBrowserTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFolderTest.php 96 additions, 0 deletions...ackend/Tests/Unit/Form/FormDataProvider/TcaFolderTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php 0 additions, 68 deletions...backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php 0 additions, 28 deletions...Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php
Please register or sign in to comment