- Sep 16, 2021
-
-
Helmut Hummel authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/71075 usage of InstalledVersions class was introduced. More specifically the install_path of the root package. However install paths of packages are only available in composer-runtime-api 2.1, therefore we need to require this a minimum version. As drive by change the usage of Composer runtime API is encapsulated in the Environment class and path normalisation is put there as well, to not require normalisation for each package. composer req composer-runtime-api:^2.1 composer req composer-runtime-api:^2.1 -d typo3/sysext/core/ --no-update Resolves: #95237 Related: #94996 Related: #95171 Releases: master Change-Id: Ibe8f676830327b1036be8074e0dc38e54743b479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71083 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Rachel Foucard authored
The unused elements in the page module have a specific styling (orange heading). When the items are drag&drop'ed into an active colPos, they previously kept their unused styling. This change gives the "Unused elements" a global warning background and removes the warning style from the content items so that they don't stay orange after a drag and drop in a real colPos. Resolves: #95230 Releases: master Change-Id: Idaa323166ec2c8f62b6f0fe747e7965910dbd4b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71103 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Christian Kuhn authored
The extbase ViewInterface fits little purpose: Most methods are part of the fluid based class and interface chain, with the exception of setControllerContext(), which is deprecated, and initializeView(), which is always only implemented as empty method. The patch deprecates the interface keeping its usage in API classes to prevent compatibility issues and prepares the interface removal for v12. Change-Id: I012ad0307f7a40923a793f55b596a27e8b770bf4 Resolves: #95222 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71089 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
EditDocumentController failed to properly track if the edit form could be created or not. This lead to a couple of consequential errors. For example, the spinner was added but could never be removed, since the FormEngine JavaScript component was not initialized. With PHP > 8 this also lead to a lot of warnings since $this->firstEl is not set, in case the edit form could not be created. This is now fixed by properly tracking whether the edit form was created and whether $this->firstEl was initialized. In case the edit form could not be created, an info box notifies the user. Resolves: #95183 Related: #95052 Releases: master Change-Id: I5a710b22319f4ce34b86c64d2141b59ba3a7a12a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71023 Tested-by:
-
Jochen Roth authored
[BE]versionNumberInFilename set to "true" triggers a undefined key warning in PHP8. This has been fixed by testing for a empty value in the array key. Resolves: #95223 Releases: master Change-Id: I3b88010d73e6e459819bbbfbe6751a4b2fb7f8f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71090 Tested-by:
-
Torben Hansen authored
The status code of a PSR-7 response object returned by an extbase action has no influence on the actual status code returned in frontend context. With this change, a status code >= 300 from the PSR-7 response is applied using the PHP header() function. Resolves: #94533 Releases: master Change-Id: Icfca5cbf6d37841fdb5f4d36d29bd2b2bce3fbd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71014 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
The fluid-based page module has hard-coded labels within the GridColumnItem class, which is not possible to override in templates right now. Instead, f:translate viewhelper is used in this case. In addition, the PageActions and the ContextMenu get some additional HTML attributes to clear up logic. Resolves: #95243 Releases: master Change-Id: I1911c4930586867c0cc21a3394263e80ae3fe782 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71101 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
The TypoScriptFrontendController holds a property called "ATagParams". Its value is a copy of $TSFE->config[config][ATagParams]. The information can be retrieved from the config array, just like all other things are loaded there, as the usages of this property are rather low. In addition cObj->getTagParams' 2nd argument "addGlobal" which is always set to true, is marked as deprecated as well. Resolves: #95219 Releases: master Change-Id: I39a12bc717bff8bb3c50af7eaab726cf7b2f4d7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70965 Tested-by:
-
Oliver Bartsch authored
This restores the "Go back" button in the "Composer Support of Extensions" view of the extension manager module. Resolves: #95233 Related: #95164 Releases: master Change-Id: I3f051b61ff79be6e783c81aa4ea3956ad48147ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71098 Tested-by:
-
Oliver Bartsch authored
The SvgTree filter previously used type=text, which prevented the element from properly responding to keyboard events, e.g. using "escape" to clear the search term. This is now fixed by using type=search. This also allows to remove the manual "clearable" initialization, which is the default browser behaviour for this type. Resolves: #95226 Releases: master Change-Id: Ie0bd636a840c399643b97c43a6e969ca1f97ba32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71092 Tested-by:
-
Oliver Bartsch authored
Elements, transferred to the clipboard are no longer selected after reloading the module. Since introducing multi record selection, the checkboxes are no longer bound to clipboard functionality, which makes selecting elements, just because they were added to a clipboard, pointless. This did anyway never work for elements in the "normal" clipboard. Furthermore did selecting elements always display the corresponding multi record selection actions. Since those actions overlayed the module specific actions, e.g. the link to single table view in the recordlist module, it was no longer possible to execute the module specific actions, as soon as one record had been transferred to clipboard. The old clipboard behaviour allowed to remove items from clipboard by unchecking them and submitting this deselection. With the multi record selection component, this is no longer possible. At least not all elements can be remove, since the actions are only shown if at least one element is selected. To fix this, a new action "Remove from clipboard" is added to the actions bar, allowing to remove a dedicated selection of elements from clipboard. This is anyways more understandable for an editor. Finally the "paste" action is removed from the multi record selection actions as it has nothing to do with the current selection. Resolves: #95225 Related: #95146 Releases: master Change-Id: Ibbdadba1c89ac81f9f440fee5d34600663ad6974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71091 Tested-by:
-
Oliver Bartsch authored
The ModuleTemplate, mostly used in backend controllers previously featured the getIconFactory() and getPageRenderer() methods, which exposed internally used services. Except for a few places, TYPO3 core did no longer use this getters, since it only hides the dependency to the corresponding services. Therefore, the getters are now deprecated. Controllers, relying on the services have to inject them explicitly. Resolves: #95235 Releases: master Change-Id: I92f9546bdfd71f7439e6724af12faefe796182fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71099 Tested-by:
-
- Sep 15, 2021
-
-
Benni Mack authored
This change * removes an unneeded CSS class from all tree items, making the DOM smaller * adds passive listeners for touch events in Resizables. This way browsers do not complain anymore Resolves: #94835 Releases: master Change-Id: Ia240751c9f623c753be80b9fc8063bb536c54481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70482 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
Database columns 'sorting' and 'sorting_foreign' for MM relation tables are hard coded and not a valid TCA configuration option since a long time. Drop two recently added todo's to clearify this. Resolves: #95232 Releases: master Change-Id: I8f874bd2f08eebadc81c5f3a46afbd0970e603c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71096 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Wouter Wolters authored
The parent keyword is misused in some places and $this can be used instead. Resolves: #95199 Releases: master Change-Id: I79f7bd041c46210fa1961a93326b02137dcc7abe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71042 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Froemken authored
DebugUtility threw warnings of the type "Undefined array key" which results in error for uncached content in frontend. This warning is fixed in this patch. Resolves: #95211 Releases: master Change-Id: I692f88e1cf123003bfdbef4f8303c41fab855f01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71079 Tested-by:
-
Oliver Bartsch authored
The edit permissions for linked live search suggestions, shown in the the dropdown layer, were previously not properly evaluated. This is now fixed. In case a user does have insufficient edit permissions for a live search suggestion, it won't be linked anymore. Resolves: #95052 Releases: master, 10.4 Change-Id: I84f7beeae8be62d275236779b993bbbf380fb835 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71050 Tested-by:
-
Christian Kuhn authored
The BackendTemplateView is a - usually Extbase backend module related - Fluid view that adds a default backend ModuleTemplate to render backend module content. That implementation has a couple of drawbacks: * Using BackendTemplateView hides a dependency to the request object by triggering a fallback in ModuleTemplate accessing $GLOBALS['TYPO3_REQUEST']. * Using $this->view->getModuleTemplate() is pretty ugly, controllers should work with the ModuleTemplateFactory instead and retrieve an instance of ModuleTemplate using create($request). * The level of indirection by having ModuleTemplate within the view class magically created makes controller actions harder to follow and understand. With extbase Request nowadays implementing ServerRequestInterface we can get rid of this indirection: Controllers should get an instance of ModuleTemplateFactory injected, receive the ModuleTemplate using ->create($request), and add further title and doc header related details using that instance. The patch changes ext:indexed_search, ext:extensionmanager and ext:form to do that, and deprecates BackendTemplateView. Change-Id: I613a560c8fc3c35343e31f397479f0c008a4a314 Resolves: #95164 Related: #92513 Related: #94428 Related: #94209 Related: #93885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70973 Tested-by:
-
Andreas Fernandez authored
To give extension authors the possibility to react on drag&drop events happening in the page module, AjaxDataHandler now emits the `typo3:datahandler:process` event. Resolves: #95069 Releases: master, 10.4 Change-Id: I07956357afa301e77b1bed033113bd8b9dca662d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70859 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Sybille Peters authored
Previously, the pagination controls were sometimes shown on the bottom of the page and sometimes on the top and the bottom (e.g. EXT:form, EXT:redirect). The pagination controls are now only shown on the bottom. This adds more consistency to the user interface. Resolves: #95192 Releases: master Change-Id: Id724a26b4fcb978182160036694b764adc275bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71077 Tested-by:
-
- Sep 14, 2021
-
-
Simon Schaufelberger authored
Remove identical like in hasProtocolAndSchemeDataProvider Resolves: #95215 Releases: master Change-Id: I5341667f5984b1044c375ee42a076fea50aea6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71085 Tested-by:
-
Oliver Klee authored
This change helps static code analyzers like PHPStan or Psalm. Resolves: #95104 Releases: master, 10.4 Change-Id: I3c5900e57116c3e4e2ba8542a6c0471a372504f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70886 Tested-by:
crell <larry@garfieldtech.com> Tested-by:
Rick Septer <rick.septer@maxserv.com> Reviewed-by:
-
Oliver Hader authored
In issue #75657 `onFocus` has been purged from `FormEngine` - purging from JavaScript class `SelectSingleElement` has been forgotten. Resolves: #95214 Related: #75657 Releases: master Change-Id: I2e2be48a924bf2e9babd7f561e2ffbbe1eead3d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71080 Reviewed-by:
-
- Sep 13, 2021
-
-
Christian Weiske authored
Releases: master Resolves: #95208 Change-Id: I852fbdc1d34afb819798cb93b2bb2f2b05e7a082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71051 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Tina Westner authored
isSubmenu() produces different results depending on the includeNotInMenu setting, Therefore we need to use separate cache entries. Resolves: #95043 Releases: master, 10.4 Change-Id: I34bdeb1a25606998e07ce2dc8aa366045dc3eefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828 Tested-by:
Tina Westner <tina.westner@bgm-gmbh.de> Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
-
Helmut Hummel authored
Drop usage of getenv('TYPO3_PATH_COMPOSER_ROOT') and use Composer provided runtime API to determine the path of the root package. This mitigates thread unsafety at least for packages, which is more prevalent than other getenv usages, that exist in TYPO3 already. These should be tackled in subsequent changes. Resolves: #95171 Related: #94996 Releases: master Change-Id: I7e45aaf72d24ac3575488b708220ba754cc131e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71075 Tested-by:Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Anja Leichsenring authored
The files grow ever larger when repeatedly executing splitAcceptanceTests.php. Deleting them before they are written for the current run resolves the problem. Resolves: #95196 Releases: master, 10.4 Change-Id: I175e486af001307bc99f5879dbc59f9a11c3d69b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71038 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Helmut Hummel authored
Similar to #95027 FAL public URLs are now automatically prefixed with absRefPrefix, making it much easier for developers to deal with FAL URLs, as these URLs are always "complete" / path absolute, after retrieving it from getPublicUrl() With that, TYPO3 code can be simplified as well and separate appending of absRefPrefix for FAL resources is now removed. Releases: master Resolves: #95027 Related: #95027 Change-Id: I614f0ad8ecb9c168d3006a812dbfe9fba6b7de51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70839 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Torben Hansen authored
Resolves: #95205 Releases: master, 10.4 Change-Id: Ibee44bc384105955248ef7dff04b1c1ec96b8d2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71049 Tested-by:
-
Anja Leichsenring authored
Testing for visibility of 'Admin Tools' requires the TYPO3 instance to be set to Development context, or the user to be system maintainer. Both requirements are not in the scope of the Acceptance Test in question, so the better choice of test is something in its context. A backend user having set the admin flag (which is part of the be_users DB table and therefor within the setup responsibility of the test in question) sees the 'System' section in BE modules, while an editor user does not. Resolves: #95193 Releases: master, 10.4 Change-Id: I93ccac0673e95723df378079a2465fddb4327571 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71036 Tested-by:
-
Oliver Bartsch authored
In case a paginated listing does only contain records for one page, the pagination controls do not make any sense and will at worst just confuse editors. This patch therefore adds consistency to the backend modules by only showing pagination controls if the number of paginated pages is greater than one. Resolves: #95092 Releases: master Change-Id: I3cf45ffa194d5a925df26be4f6e144dbe8f4df04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71016 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Alexander Nitsche authored
Some EXT:impexp functional tests threw warnings of the type "Undefined array key" which did not abort the test but were written unnoticed to the TYPO3 logs. These warnings are fixed in this patch. Resolves: #94972 Releases: master Change-Id: I0e4f3558cd12ef49ae6dc071edd67cd2621dbc2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70741 Tested-by:
-
Jonas Eberle authored
git stores files either 0664 or 0775. Script checkFilePermissions.sh is improved to deal with that. Resolves: #95203 Releases: master Change-Id: I49ede03ac7e1180621c497081e463d8c617250b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71046 Tested-by:
-
Helmut Hummel authored
The root package is now always considered as TYPO3 package. The "ignore-as-root" flag and the exclusion of root packages in general was only introduced to allow integration testing setups of extensions with public resources. For such a scenario to work properly, the testing framework introduced \TYPO3\TestingFramework\Composer\ExtensionTestEnvironment to be included as composer autoload hook, which symlinks the root path inside the typo3conf/ext folder. This exact behaviour is now introduced in TYPO3 directly, making it possible to always consider the root package for TYPO3, and obsoleting the double negative "ignore-as-root" flag. Releases: master Relates: #94996 Change-Id: Ib033b7634736f5f201b55ad374943cb10dafa0a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71029 Tested-by:
Stefan Bürk <stefan@buerk...>
-
Oliver Bartsch authored
With #90548 the filelist module has been extended for the possibility to download files and folders. Since file download might not be enabled for all users, or should at least be limited to a set of file extensions, this patch adds the necessary configuration options. It's therefore now possible to either specify allowed / disallowed file extensions or to completely disable the file download. In case the download can not be prepared due to no valid files were found, the user receives a notification. Resolves: #95113 Related: #90548 Releases: master Change-Id: Ifc4b4a5cd4ac8cb49b14e8eb6239ece37596e7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71013 Tested-by:
-
Benni Mack authored
This change uses the existing session information (moduleData[browse_links.php][expandFolder]) to read and write the last opened folder not just for the File Browser (as currently used) but also the file link handler. Resolves: #73195 Releases: master Change-Id: I7957325599407333486898d5538247d452c7af18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70959 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Sep 12, 2021
-
-
Wouter Wolters authored
composer req --dev codeception/module-webdriver:^1.4.0 composer req --dev composer/package-versions-deprecated:^1.11.99.3 composer req --dev friendsofphp/php-cs-fixer:^3.1 composer u phpunit/phpunit phpspec/prophecy Resolves: #95195 Releases: master Change-Id: I66ef7d9ebf32b79fe7640e91e8fc791a079de193 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71037 Tested-by:
-
Christian Kuhn authored
Since moving to gitlab, script checkFilePermissions.sh was inactive due to a gitlab detail that leads to funny permissions of cloned files. This can be suppressed with a gitlab feature toggle. The patch activates that toggle, activates the test script and fixes a couple of files that slipped in with broken permissions meanwhile. Change-Id: I2b0fdca282dbc39fe230b33910a690118a21b74e Resolves: #95194 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71033 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 11, 2021
-
-
Christian Kuhn authored
We're delivering a "test distribution" composer.json in Build/composer since #94996. The patch adds "runTests.sh -s composerTestDistribution" that "composer update" this project and adds it to pre-merge and nightly integrity suite. This verifies core dependencies are fine at all times. Main difference to the monorepo: This composer setup has no dev dependencies that influence version decisions. Resolves: #95188 Related: #94996 Releases: master Change-Id: I04084a2a44a69903d523b5c4740d62d7dc46c1f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71030 Tested-by:
-
Richard Haeser authored
Check if the right status code is added to the header of a redirect. Furhtermore check if the current available status codes can be selected when creating a new redirect in the backend. Releases: master, 10.4 Resolves: #95154 Change-Id: I48bb678ce7ef4de098d545e5cf72cfe2704d4714 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70971 Tested-by:
-
