Skip to content
Snippets Groups Projects
Commit 98267055 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] Deprecate ext:backend BackendTemplateView

The BackendTemplateView is a - usually Extbase backend
module related - Fluid view that adds a default backend
ModuleTemplate to render backend module content.

That implementation has a couple of drawbacks:
* Using BackendTemplateView hides a dependency to the
  request object by triggering a fallback in ModuleTemplate
  accessing $GLOBALS['TYPO3_REQUEST'].
* Using $this->view->getModuleTemplate() is pretty ugly,
  controllers should work with the ModuleTemplateFactory
  instead and retrieve an instance of ModuleTemplate using
  create($request).
* The level of indirection by having ModuleTemplate within
  the view class magically created makes controller actions
  harder to follow and understand.

With extbase Request nowadays implementing ServerRequestInterface
we can get rid of this indirection: Controllers should get an
instance of ModuleTemplateFactory injected, receive the
ModuleTemplate using ->create($request), and add further
title and doc header related details using that instance.

The patch changes ext:indexed_search, ext:extensionmanager and
ext:form to do that, and deprecates BackendTemplateView.

Change-Id: I613a560c8fc3c35343e31f397479f0c008a4a314
Resolves: #95164
Related: #92513
Related: #94428
Related: #94209
Related: #93885
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70973


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarJochen <rothjochen@gmail.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarJochen <rothjochen@gmail.com>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent fc7c77d8
Branches
Tags
No related merge requests found
Showing
with 383 additions and 489 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment