- Dec 02, 2023
-
-
Christian Kuhn authored
EXT:adminpanel class TypoScriptWaterfall sets both 'no_cache' and the typoscript context aspect 'forcedTemplateParsing' to true when the admin panel related option 'Force template parsing' is enabled. This setting is "on" by either using the admin panel FE interface (which stores settings in BE user "uc"), or using BE user UserTsConfig admPanel.override.tsdebug.forceTemplateParsing = 1. All consumers of the forcedTemplateParsing aspect property (namely in TypoScriptFrontendController) always check both 'no_cache' and 'forcedTemplateParsing', so that's duplicate information. The patch removes the 'typoscript' context aspect altogether and simplifies consumers to rely on the 'no_cache' flag only. Resolves: #102583 Releases: main Change-Id: I33599ff7c23ce48102f9473d74ae1358f343c36c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82066 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
Resolves: #102576 Releases: main Change-Id: I5c24e0e794c224ed28c1f04a8d93d678460aed7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82056 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Kuhn authored
Also fix one unneeded null coalescing operator usage, which was discovered with this release. > composer require --dev phpstan/phpstan:^1.10.47 Resolves: #102584 Releases: main, 12.4 Change-Id: I19876bfe33fcf05166df7e0d92696c2368b29490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82067 Reviewed-by:
-
- Dec 01, 2023
-
-
Patrick Schriner authored
Allow a title argument to be set in the IconViewHelper. The give title will be passed to the `Icon` object and will be rendered as title attribute in the icon HTML markup, enhancing accessibility. Resolves: #102314 Releases: main, 12.4 Change-Id: Ifbaf5961cda843054c7933025617d3d18a4887f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81679 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
Due to the removal of jQuery in #102418, the corresponding event listener functions receive the actual target element as second argument. Instead on trying to fetch the target from the event, we now use the passed element directly. Resolves: #102566 Releases: main Change-Id: I57df12c78c0a7bd4c43272b013b184a7405caa64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82059 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Stefan Bürk authored
New `core-testing-phpXY` images has been build and released. This change update used image version to: * core-testing-php81:2.8 - php 8.1.26 (patchlevel) * core-testing-php82:1.7 - php 8.2.13 (patchlevel) * core-testing-php83:1.8 - php 8.3.0 (major) [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/6ead80df3d46bf1f0c2363e8728435b2d2363fba Resolves: #102575 Releases: main, 12.4, 11.5 Change-Id: I85a8b0a97d63fea01c790fd9c7ab5d51536a21b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82052 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.3 and related packages used for JavaScript building. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.13.1 \ @typescript-eslint/parser@^6.13.1 \ @typescript-eslint/typescript-estree@^6.13.1 \ eslint@^8.54.0 \ eslint-plugin-lit@^1.10.1 \ eslint-plugin-wc@^2.0.4 \ typescript@^5.3.2 npm run build Updated `eslint` packages revealed issues in the `@typo3/backend/page-tree/page-tree` module that are fixed along with the updates. Resolves: #102564 Releases: main, 12.4 Change-Id: Ibd2ff74b3ea2b42511cf775a94f1725d08e4065d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82048 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
When PHP 8.0 support was added, a lot of places received extra checks with the $conf ?? []. PHPStan complained about this now, as methods already have native PHP types added now, and the check is not needed anymore, so it can be simplified A few other places did not receive proper PHPdoc annotations which has been fixed as well. In addition, some str_ends_with calls are migrated. Resolves: #102528 Releases: main Change-Id: I031d677473d4e9601fbf9d7c90214c311cfea863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81975 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Franzke authored
(Custom) element children are not guaranteed to be available by the time the element is added to the DOM — i.e. when the connectedCallback() is triggered by the browser. That means we can not assume that value-picker <select> children will always be available. Note that it worked most of the times, because JavaScript modules are loaded asynchronously, and thus "most of the times" execute later after the DOM is rendered, but when the server is really busy, the HTML output can be rendered very late, so that a connectedCallback is triggered immediately when an opening tag is written to the DOM — even before the childrens are attached. (Otherwise the browsers would have to delay the connectedCallback's until the closing tag is rendered, but that's not the case — at least not in google chrome.) To circumvent this we use a slotchange listener (which is basically a mutation observer) to assure we are notified about async child updates. Resolves: #102550 Related: #102330 Releases: main, 12.4 Change-Id: I73179335c390f08f42f3426dcffec338f6355d61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81993 Tested-by:
-
- Nov 30, 2023
-
-
Sascha Nowak authored
When the endtime of a page is lower than the default lifetime (24h), the calculation did not respect the endtime and set the lifetime to default lifetime. This lead to cache entries with incorrect lifetimes. The upper bound of the cache lifetime is now additionally clamped to the endtime of the current page. Resolves: #102525 Related: #102422 Releases: main, 12.4 Change-Id: I5e2c48fcfd237fb0eca130aba8812224368474ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81930 Tested-by:
-
Benni Mack authored
This changes the behaviour of config.sendCacheHeaders = 1. When a non-cacheable option is used, the HTTP Response Headers for ensuring that a response should never be cached (that is Cache-Control: private, no-store) should be sent at any time, as it could contain sensitive information, regardless of the TypoScript option. The TypoScript option config.sendCacheHeaders is then only used to actually explicitly send the headers for a fully client-cacheable page (e.g. for a proxy), to explicitly allow the cached content to be stored for a defined amount of time. In addition, a lot of tests have been adapted to remove this option as it does not have any effect in the tests if the option is set. Resolves: #102445 Releases: main, 12.4 Change-Id: I603e73a114eb9668910484da7e9dc4e0e33e56ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81840 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Sascha Nowak <sascha.nowak@netlogix.de> Tested-by:
-
Christian Kuhn authored
Internal property TypoScriptFrontendController->pSetup contains the TypoScript PAGE TS array of the current type/typeNum. FE RequestHandler uses this, but it can be derived directly from the current type in Request attribute 'routing' combined with a TS array lookup in Request attribute 'controller.typoscript'. The patch avoids and removes TSFE->pSetup which resolves a spaghetti dependency from TypoScriptFrontendController up into RequestHandler. Main method processHtmlBasedRenderingSettings() is streamlined carefully along the way. Resolves: #102562 Releases: main Change-Id: I67970ad68e1a3b5fdc5c578d26d430fd61727d4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82047 Tested-by:
-
Garvin Hicking authored
When entering the sequence "/*" into any t3editor instance (i.e. TypoScript editor in the backend), it puts the browser in an endless loop. The reason is that the method `stream.next()` declares to either return a string value or `void` (=`undefined`), but the code checks for `null`. The check is now fixed and another cases where a loose null comparison was used is adapted as well. Note that a loose null comparison between null and undefined return equality, but a strict comparison doesn't. Resolves: #101893 Related: #101803 Releases: main, 12.4 Change-Id: If1c090daf13a6d730a2e5b96d46afab171fbcde2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82038 Tested-by:
Andreas Kalkhoff <a.kalkhoff@trisinus.de> Reviewed-by:
-
- Nov 29, 2023
-
-
Oliver Bartsch authored
The form framework adds a warning flash messages to the page module in case a page contains a form content element, having some error. In case of a generic invalid form configuration, the message now also displays the corresponding form identifier of the form configuration, containing the invalid configuration. Resolves: #102557 Releases: main, 12.4 Change-Id: I592a415692822200608f218268f1406fc33df118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82039 Tested-by:
-
Markus Klein authored
The ext_tables_static+adt.sql data are now re-imported, if its data changed, when setting up the extensions. This happens either from within the Extension Manager, or via the CLI command. Moreover, a legacy value, which was already taken care of in `ReloadSqlDataViewHelper`, is now respected as well. Resolves: #102376 Releases: main, 12.4 Change-Id: I67074f8b98acd0bbfc7ce03732b18f759e1d81de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81749 Tested-by:
Thomas Hohn <tho@gyldendal.dk>
-
Oliver Bartsch authored
Due to the removed fallback to $GLOBALS['TYPO3_REQUEST'] in #102513, it's required to properly set a request object to a configuration manager instance. This is now done in FormPersistenceManager, which previously just set a fake request to the global variable but did not use the setRequest() method. Resolves: #102558 Related: #102513 Releases: main Change-Id: I5347e70feb11b192ad5d7829d48f412f27f79bd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82040 Reviewed-by:
-
Mathias Brodala authored
Resolves: #102077 Releases: main Change-Id: I6c5428f97e35807dbb22db0e4d862b62ab7c84cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81307 Tested-by:
-
Andreas Kienast authored
Historically, FlexForms store their section collapsing state within the flex structure in the database, having the impact that the state is reflected to every backend user. The internal `_TOGGLE` field is removed from any handling, the collapse state is now stored in backend user's localStorage. Resolves: #102551 Releases: main Change-Id: I3fdb7a5434c8769edda2ba86d53177cdc5a6621e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81997 Tested-by:
-
Oliver Bartsch authored
Usage of ServerRequestFactory::fromGlobals() on CLI is discouraged as the request url, used to create the request is invalid, except the $_SERVER variable is adjusted beforehand. To properly inform the developer, a dedicated exception is now being thrown, if in CLI context. Resolves: #102533 Releases: main, 12.4 Change-Id: Ie84fdf9c0555eeeaf5438a2ed29acabbe2755965 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81978 Tested-by:
-
Simon Praetorius authored
Fluid now provides a ScopedVariableProvider to make sure that ViewHelpers that provide variables to child nodes don't change global variable state. With this patch, the new ScopedVariableProvider from Fluid Standalone is used in Core ViewHelpers as well. Resolves #102481 Releases: main Change-Id: Iaf887208c3f5be07492834734226f0d3c79eebca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81918 Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Garvin Hicking authored
The ClassMapGenerator is used in non-composer ("legacy") mode installations and builds files used for PSR-autoloading. It only parsed class|interface|trait files, but not files containing enum type definitions. Thus, the PSR-autoloading created by this classmap was not able to autoload these enum files. The underlying code had been adapted from the Composer libraries some time in the past, meanwhile that code from Composer was extracted to the package "composer/class-map-generator" and has drifted from the current TYPO3 implementation. That implementation at https://github.com/composer/class-map-generator/blob/953cc4ea32e0c31f2185549c7d216d7921f03da9/src/PhpFileParser.php#L118 supports "enum" class loading in case the PHP version matches. This patch simply also adds "enum" as a recognized identifier. Resolves: #102498 Releases: main, 12.4 Change-Id: I1b98e8ceeecd25f1512d3539e84de6c725a8e3c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82034 Reviewed-by:Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Oliver Bartsch authored
To avoid unnecessary initialization of page title providers and calling any stdWrap, an early return is added to `TSFE::generatePageTitle` for the case that `noPageTitle` is set to "2", as this means do not render the title tag at all. Resolves: #102555 Releases: main, 12.4 Change-Id: Ia879218e84db865bce11bca8c61f33c7266884b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82037 Tested-by:
-
Daniel Hoffmann authored
When a file or folder is rename()'ed, the name property is updated immediately. The file list controller handling a rename thus needs to park the old name in a variable to render the correct 'before' name. The patch fixes this and cleans up the class a bit. Resolves: #102478 Releases: main, 12.4 Change-Id: I438fa351febc821242c401cb208e644617f2f090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81891 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Achim Fritz authored
The return value of HtmlentitiesDecodeViewHelper can be null e.g. {foo -> f:format.htmlentitiesDecode()} with foo might be undefined Resolves: #102553 Releases: main, 12.4 Change-Id: I41fa1917f23a40a742e1ebc27ef37d6fee0bd858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82033 Tested-by: -
Christoph Lehmann authored
Don't check accessibility to current page again. This is already done in the TypoScriptFrontendController. In addition some PHPStan issues are resolved. Resolves: #102121 Releases: main, 12.4 Change-Id: Id3757e214cf73e027092f3c8ce0bc7d5709e0e04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81380 Tested-by:
-
Benni Mack authored
This commit updates all Symfony components to version 6.4, as 6.3 ran out of support. Symfony 6.4 also marks an LTS release. Please see the upgrade document at [1]. Executed command: composer require \ symfony/config:^6.4 \ symfony/console:^6.4 \ symfony/dependency-injection:^6.4 \ symfony/doctrine-messenger:^6.4 \ symfony/expression-language:^6.4 \ symfony/filesystem:^6.4 \ symfony/finder:^6.4 \ symfony/http-foundation:^6.4 \ symfony/mailer:^6.4 \ symfony/messenger:^6.4 \ symfony/mime:^6.4 \ symfony/options-resolver:^6.4 \ symfony/property-access:^6.4 \ symfony/property-info:^6.4 \ symfony/rate-limiter:^6.4 \ symfony/routing:^6.4 \ symfony/uid:^6.4 \ symfony/var-dumper:^6.4 \ symfony/yaml:^6.4 \ -W composer require --dev \ symfony/translation:^6.4 \ -W [1]: https://github.com/symfony/symfony/blob/6.4/UPGRADE-6.4.md Resolves: #102552 Releases: main, 12.4 Change-Id: I01f8fcedff74eac49a6901651b36584272f93b82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82032 Tested-by: -
Benni Mack authored
The main goal of this change is to use constants for sys_workspace.publish_access options to make the code more readable. This is made possible by moving the method BE_USER->workspacePublishAccess to EXT:workspaces Resolves: #102549 Releases: main Change-Id: I47ba1e66a3c2e83fa31a2841fcdfd6fc217f1ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82006 Tested-by:
-
Oliver Bartsch authored
The link attributes of a field control are added to the link tag using implodeAttributes() with the second parameter `xhtmlSafe` set to `true`. To prevent double encoding, previously applied "hsc" calls are removed. Resolves: #102541 Releases: main, 12.4 Change-Id: If7b4f036b9cea71162a5265458e53dc05b91b7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81996 Tested-by:
-
Oliver Bartsch authored
Adds the loading="lazy" HTML attribute to a couple of img tags, used to display thumbnails in the backend. This will improve performance, especially for larger listings, e.g. in the filelist module. Resolves: #102501 Releases: main, 12.4 Change-Id: I5f4b7c37786e8f4283bb997f40c501f09984e410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81999 Reviewed-by:
-
Christian Kuhn authored
Internal property TypoScriptFrontendController->type is a duplication of PageArguments->getPageType(). This can be used directly instead of parking that state in TSFE a second time. Resolves: #102547 Releases: main Change-Id: I06e3b3cf202bdd22d2af7ebff8f9b43287759873 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82007 Tested-by:
-
Christian Kuhn authored
$typoscriptCache is initialized to either a cache frontend instance or null depending on $this->no_cache. The cache argument is nullable in getTreeBySysTemplateRowsAndSite(). We can skip some if constructs within getFromCache(). Resolves: #102539 Related: #97816 Releases: main Change-Id: I7df0a9f8e8cc7b9c6758869d97febc72bf04369a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81992 Tested-by:
-
Christian Kuhn authored
The check in FieldControl is obsolete. Resolves: #102546 Releases: main Change-Id: I968451905a372a9c236c25300851be5ac7d7ec9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82005 Tested-by:
-
Mathias Brodala authored
Aside from being disabled itself, a form field can also be placed in a container which is disabled statically or using variants. In either case the field must not be validated since it is not rendered and thus cannot be filled by the user. Resolves: #102083 Releases: main, 12.4 Change-Id: I8f2bcd45d3563907bf5737628020ab8bf50a68bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81318 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
Willi Wehmeier authored
Max values have been set to the input fields in the TCA of the sys_file_metadata table. The settings have been adjusted to the set varchar length in the ext_tables.sql file. Additionally the language column length has been adjusted to the other fields. The length is set from 12 to 45. Resolves: #102456 Releases: main, 12.4 Change-Id: Id2b7d510c16b5c2659fa0a7367edeb4f49b782f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81859 Reviewed-by:
-
Oliver Bartsch authored
Since #101859, the `setFields` property of the record list, which contains the fields to show / download is initialized in the start() method. To enable the "all columns" option again, overwriting of the property is now done after calling start(). Additionally, the module data call is removed as this is done by record list already. Resolves: #102538 Related: #101859 Releases: main, 12.4 Change-Id: I39d7348b4eaa848f012cf238abc54e3a0e5d2e31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81994 Reviewed-by:
-
Benni Mack authored
Due to the introduction of the "DefaultUploadFolderResolver" class in v12, a dedicated service to load information about the Default Upload Folder for a user, some internal methods in BackendUserAuthentication can be removed. DI is not used due to complications in the inheritance of the ImportExport class (which needs to be resolved first). Resolves: #102500 Releases: main Change-Id: I4ef4001ff258d2ec09d701df488205e7b208e3dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81949 Reviewed-by:
-
Oliver Klee authored
The new version fixes a false positive, adds a second warning for a problem that already is logged in the baseline, and sadly introduces one new false positive. > composer req --dev phpstan/phpstan:^1.10.46 > composer req --dev phpstan/phpstan-phpunit:^1.3.15 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102544 Releases: main, 12.4 Change-Id: I79e3854458f1061b4943d0b3fab78b1a7502b13f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81998 Tested-by:
-
- Nov 27, 2023
-
-
Christian Rath-Ulrich authored
Resolves: #102534 Releases: main, 12.4 Change-Id: I09c5cc656702c7c262638a95a28d6d0f0cf79cf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81979 Tested-by:
-
Christian Kuhn authored
Standalone fluid 2.10 comes with a series of features that will streamline and simplify EXT:fluid for core v13. We'll leverage this with upcoming patches. > composer req typo3fluid/fluid:^2.10.0 Resolves: #102537 Releases: main Change-Id: I963dfd8304c4e39a0ddba8312139171eb14391da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81984 Tested-by:
-
Christian Kuhn authored
> composer require --dev phpstan/phpstan:^1.10.45 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102536 Releases: main, 12.4 Change-Id: Ie529eba3c951d20bf4d0b6f2b838d329ac771805 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81981 Tested-by:
-
