[TASK] Avoid TSFE->pSetup
Internal property TypoScriptFrontendController->pSetup contains the TypoScript PAGE TS array of the current type/typeNum. FE RequestHandler uses this, but it can be derived directly from the current type in Request attribute 'routing' combined with a TS array lookup in Request attribute 'controller.typoscript'. The patch avoids and removes TSFE->pSetup which resolves a spaghetti dependency from TypoScriptFrontendController up into RequestHandler. Main method processHtmlBasedRenderingSettings() is streamlined carefully along the way. Resolves: #102562 Releases: main Change-Id: I67970ad68e1a3b5fdc5c578d26d430fd61727d4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82047 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
Showing
- Build/phpstan/phpstan-baseline.neon 0 additions, 10 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php 4 additions, 12 deletions...ntend/Classes/Controller/TypoScriptFrontendController.php
- typo3/sysext/frontend/Classes/Http/RequestHandler.php 341 additions, 365 deletionstypo3/sysext/frontend/Classes/Http/RequestHandler.php
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php 56 additions, 29 deletionstypo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php
Please register or sign in to comment