- Aug 30, 2021
-
-
Benjamin Franzke authored
A cache:warmup CLI command is added that is safe to be executed during deployment or development mode. It is made extra sure that the command will be executable, even if all caches are stale or even broken. That means this command is able to repair broken di, localconf and tca caches. Technically this became due to preparations for lowlevel cli commands in #86248. Caches that will be warmed up by TYPO3 core: + DI + ext_localconf + TCA + ext_tables + middleware stack + PackageManager + sites-configuration + expressionLanguageProviders + BackendRoutes + l10n (parses all xlf files, and creates cache for all languages) + assets: BackendIcons + dashboard: DashboardPresets + dashboard: WidgetGroups Out of scope or impossible to be warmed: * Frontend warmup: Can be providedby extensions that listen for the CacheWarmupEvent * RequireJS (assets cache): Often applies with context-conditions therefore not reliably warmable. * Extbase – better of for a separate patch intesting cache entries would be: RequestHandlers, ClassSchemata and PersistenceClasses(?) * Warmup of Fluid templates: It is impossible to auto-detect whether all files in Resources/{Templates,Layouts,Partials} are Fluid files. Could by added later on with an explicit registry that allows to define which templates are suitable for warmup. Releases: master Resolves: #93436 Change-Id: I53dd8915a2e06b3d21d778af985c76132e0d4f67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61645 Tested-by:Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 29, 2021
-
-
Christian Kuhn authored
Resolves: #95030 Releases: master, 10.4 Change-Id: Ifc27ab7065dd7e9711b9770603bcfab8e70b06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70816 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Resolves: #95029 Releases: master Change-Id: I444aa1b0161c140c40af2dca455246d8336fa4ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70813 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Wouter Wolters authored
The following core extensions are handled: EXT:install Resolves: #94880 Releases: master Change-Id: I2ae58f7f1c5a944394c82bb592ccbdac3bb57352 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70585 Tested-by:
-
Nikita Hovratov authored
This fixes some links to related rst files. Resolves: #94854 Releases: master Change-Id: Ifc981666661846291923adf55b63ecbde62f0cbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70511 Tested-by:
-
Christian Kuhn authored
This minor version raise brings significant performance improvements for functional tests, especially with mysql/mariadb & sqlite. composer req --dev typo3/testing-framework:^6.10.0 Change-Id: I09f8a673f55710b8d237faa280121853dcabc378 Resolves: #95028 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70806 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Aug 28, 2021
-
-
Stephan Bauer authored
Existing configuration should not be overwritten when adding new table options. Releases: master Resolves: #95019 Change-Id: Ie45619e9539e055ef99af1d7cec8cb80b6ed8bde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70802 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Oliver Bartsch authored
The multi record selection component is now able to handle multiple instances per page, by using an unique identifier for each instance. Resolves: #95017 Releases: master Change-Id: I31f5a85f74044501912fdc92183408ea9ca03b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70799 Tested-by:
-
- Aug 27, 2021
-
-
Simon Schaufelberger authored
Revert back tick that was introduced in commit 3b03ef46 Releases: master Resolves: #95018 Change-Id: I0ceb8c8f46a2bdd601d9ce0b250fda94e12e3735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70800 Tested-by:
-
Helmut Hummel authored
The idea of this change is, that when using Composer, all TYPO3 extensions, that are part of the Composer installation, should be considered as active and there is no need whatsoever to install code of an extension with Composer (and making all its classes available), but not wanting the extension to interact with TYPO3 API. Therefore with this change, all TYPO3 extensions installed with Composer are considered to be active (and therefore can and will interact with TYPO3 API). Additionally, since the list of active extension is known during Composer installation, a persistent artefact is created at this point, which represents the final state of TYPO3 extension packages for the PackageManager, making both, the PackageStates.php file and the PackageManager cache obsolete for Composer managed TYPO3 installations. Note any extension present in the typo3conf/ext folder, but not installed by Composer, will still be considered and marked as part of TYPO3 packages when doing a "composer install". The only requirement here is, that such extensions need a composer.json file nonetheless. Note this behaviour is deprecated and will be removed with TYPO3 12. Additionally the extension manager UI is adapted to not allow changing the active state of extensions anymore. Respectively the commands "extension:activate" and "extension:deactivate" are disabled in Composer managed systems as well. A new cli command "extension:setup" is introduced, which supersedes both, the extension manager UI as well as the activate/deactivate commands. It performs all steps that were done before, except changing the active state of an extension. With cli command "extension:setup" ALL extensions are set up in terms of database schema changes, static data import, distribution files imports, etc. Last but not least, any installed Composer package, that defines an extra.typo3/cms section in their composer.json file, but is not of type "typo3-cms-extension" at the same time, will be considered for TYPO3 and will have full access to TYPO3 API. It has to be noted though that such packages can not deliver public resources. This remains exclusive for TYPO3 extensions for now. Releases: master Resolves: #94996 Change-Id: I919873dd4ddd087c943f1289a12253c6acec7fa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Andreas Fernandez authored
Resolves: #94983 Related: #94280 Releases: master Change-Id: Ifb2b8a967de9345e900ad07f9a20fc7ef24e2918 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70744 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Benni Mack authored
LiveSearch, Shortcut and OpenDocs call jump() and thus, uses some "magic" top-level variables to store the actual URL to go to. This is not ideal, and the ModuleMenu should resolve this, preserve the state of the "id" parameter, open the content frame and (optionally) select a module which was in use. The global functions and variables are deprecated now: * top.currentSubScript * top.currentModuleLoaded * top.nextLoadModuleUrl * jump() Resolves: #95011 Releases: master Change-Id: I173fcaf3a90d753b0397e367fb99792edeedba65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70732 Tested-by:
-
Benni Mack authored
TYPO3's PSR-7 implementation has a small flaw when having URLs without a scheme, which should always return an empty string. This change initializes the scheme with an empty string by default. Resolves: #94872 Releases: master, 10.4 Change-Id: If2898d697f37e6e5fc8c4553d0bb500f7fc8b47e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70547 Tested-by:
-
- Aug 26, 2021
-
-
Oliver Hader authored
jQuery `$.proxy` invocation was used prior to ES6 times to have proper `thisArg` scoping in plain JavaScript functions that were used within jQuery events. Since arrow functions are used (which keep their local `thisArg` scope), corresponding `$.proxy` invocations can be removed completely. Resolves: #94970 Releases: master Change-Id: I2c7ec6f3a6140c98482a1c681fbae809c12c5431 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70733 Tested-by:
-
Oliver Bartsch authored
Fixes a regression, introduced in #94315 and restores legacy placeholder in cases it is used in custom error messages, set via TypoScript. Resolves: #95008 Related: #94315 Releases: master Change-Id: I59b95d9d311be81faa73ae14d48f97584882f5fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70771 Tested-by:
-
Jochen Roth authored
Cli commands were fixed by adding a fallback where undefined array key warning occured. Added tests as well to make sure it will work ever after. Resolves: #94763 Releases: master Change-Id: I76e91d61649b5e2c54b83f737e46d679df2526a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70306 Tested-by:
-
Christian Kuhn authored
Extbase ActionController has a view functionality to test if the target template files exist and to render an error message via NotFoundView if not. This is the only use of @internal marked NotFoundView and the only practical usage of extbase ViewInterface canRender(). This structure can be simplified significantly, without loosing functionality. The patch: * Removes @internal NotFoundView and its template * Drops canRender() from ViewInterface * Keeps canRender() in extbase ViewInterface implementations but marks them @deprecated and logs usages. * Changes extbase ActionController to not test canRender() but to let InvalidTemplateResourceException bubble up during $view->render(). This handling as a result - in case of missing templates - provides a full backtrace with a better error message than before, that of course still includes the controller and action name, plus the template location that has not been found. In the frontend, the exception is handled by the casual "plugin based exception handling" (TypoScript config.contentObjectExceptionHandler), a "template missing" programming error is now handled just like any other plugin exception. Resolves: #95003 Releases: master Change-Id: I5e55fdb2f1cfa66682b3b3a6ad0ebd21188dc10e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70762 Tested-by:
-
Christian Kuhn authored
Extbase EmptyView is unused since its introduction in 4.5. Calling render() returns a html comment. It has been substituted by NotFoundView within 4.5 development already. NotFoundView is removed with a different patch, too. Resolves: #95005 Related: #95003 Releases: master Change-Id: I8bbb4a641fa05fe34e2f7eabd7621ec3c0fe7bdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70769 Tested-by:
-
Jochen Roth authored
It's not possible to add rows/colums once all have been deleted manually. This has been fixed by adding a new button next to this "Small fields" button which allows a user to set the needed amount of columns and rows. Resolves: #94802 Releases: master Change-Id: I437d07c5d9176e9c962698882bbacef5eab19349 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70443 Tested-by:
-
Wouter Wolters authored
Resolves: #94985 Releases: master Change-Id: I1514630bb43929dd12da15d44110c675b0774a97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70746 Tested-by:
-
Oliver Bartsch authored
The column selector component is moved to EXT:backend. This allows to use it in further modules without adding cross dependencies to EXT:recordlist. Resolves: #94990 Releases: master Change-Id: I97c6ce868e4accfe8906bffcd9b5c272066d5272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70750 Tested-by:
-
Oliver Bartsch authored
Creating and editing file metadata translations is usually done in the filelist module. Therefore a custom toggle button in the "Localization" column had to be used. In the expanded state, various flag icons with an hard to guess overlay icon were displayed. Those could be used to either create or edit the file metadata records. This however had some drawbacks: - The toggle button was not accessible by keyboard - As toggle icon, the "pages languages overlay" icon was used, making it hard to understand for editors - As soon as one of those toggle buttons was clicked, all other toggle buttons jumped to the left To improve this, the toggle button is moved into the controls group and does now uses the "actions-translate" icon. It furthermore does now open a dropdown with proper link labels - as already known from the secondary menu. This therefore also increases consistency. Besides the visual changes, this patch also cleans up the underlying code and removes the custom JavaScript component, which was used for the toggle button. Resolves: #94997 Releases: master Change-Id: I898e234d35b125ba37ac6c30874fa206d2515184 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70759 Tested-by:
-
Christian Kuhn authored
Handling ContentObjectRenderer instances is messy, especially within extbase: The ConfigurationManager is a stateful singleton since it depends on current ContentObjectRenderer being set within frontend. The extbase Bootstrap takes care of setting the current cObj. ConfigurationManager is also misused (ext:form) to "park" the current cObj for later retrieval. This needs to be tackled with a dedicated patch. This is worse with fluid StandaloneView, which accepts cObj as constructor argument to update ConfigurationManager state. Funnily, this optional constructor argument is never hand over in core. Additionally, extbase usually does not use StandaloneView, but fluid's TemplateView instead. The patch deprecates the constructor argument of fluid StandaloneView to avoid a dependency from StandaloneView to extbase. Resolves: #94959 Releases: master Change-Id: I605d4bb1133a30daf418eb418f2d5502d981b4c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70721 Tested-by:
-
Benjamin Franzke authored
Executed commands: cd Build/ yarn upgrade lit@^2.0.0-rc.3 \ lit-html@^2.0.0-rc.4 \ lit-element@^3.0.0-rc.3 \ @lit/reactive-element@1.0.0-rc.3 grunt rollup Resolves: #94943 Releases: master Change-Id: I5140e9782a8a98361dfbcaf8318c74cdc8a05600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70687 Tested-by: -
Benni Mack authored
Rendering links set for sys_news (shown at backend login) records via RTE does not work. Reason is a nasty dependency to TypoScript lib.parsefunc, which isn't easy to retrieve in BE scope. With recent RTE html parser related changes, it's now relatively easy to submit a fallback layer in case for instance f:html view helper isn't used within FE context. Resolves: #67556 Releases: master Change-Id: I7d6226bd998396a1d3859cbf956f9d5d61bed7d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70740 Tested-by:
-
Oliver Hader authored
composer req typo3/html-sanitizer:^2.0.10;\ composer req typo3/html-sanitizer:^2.0.10 \ -d typo3/sysext/core --no-update Resolves: #95000 Releases: master, 11.3, 10.4, 9.5 Change-Id: Ia2170f6bd6f3bace862fac124ef8cc2966d35171 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70763 Tested-by:
-
Oliver Bartsch authored
The TOTP info modal displays the OTP auth url along with a description. This content however is added to the modal body by a callback. To prevent the "modal content empty" warning from being shown, the modal is now initialized with an empty string as content. Resolves: #94999 Releases: master Change-Id: I0a8c274466d4f62da8edb26a4c2b547b66be3ba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70761 Tested-by:
-
- Aug 25, 2021
-
-
Wolfgang Klinger authored
This adds the column selector component, introduced in #94218, to the filelist module. As known from recordlist, it can be used to manage the fields to be displayed for each file / folder. Fields to be selected are the combination of special fields (e.g. read/write permissions), sys_file fields and sys_file_metadata fields. Resolves: #84184 Releases: master Change-Id: Ie1369e616f35dc4a92e90409eba202aa4afe15f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56073 Tested-by:
-
Frank Naegler authored
This patch removes the LOCK TABLE permission check from the PermissionsCheck class that is part of the installer. TYPO3 Core doesn't need the LOCK TABLE permission, hence the check can be removed. Resolves: #94978 Related: #78885 Releases: master, 10.4 Change-Id: I41a07583706fdb9d51bca5b1e74f64f56e38eebe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70738 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Jochen Roth authored
Now that we have frontend tests in the Backend suite the name Backend for acceptance suite does not fit anymore. So the suite name was changed from Backend to Application. Resolves: #94864 Releases: master Change-Id: Ib52053f6dbbfad9b7fef1ff11e81110cffa010b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70550 Tested-by:
-
Daniel Siepmann authored
It can be beneficial to suppress caching using xml2arrayProcess() directly instead of the cache enabled wrapper xml2array() in some situations. The patch makes the worker method public, adapts tests to mock less and moves a data changing detail from xml2array() to xml2arrayProcess(). Resolves: #94993 Releases: master, 10.4 Change-Id: I2b0347ebb1a293d2826b2d13b00f21b56568195c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70757 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Christian Kuhn authored
The fluid view classes have a rather complex inheritance and dependency chain, especially when looking at the various extbase related classes, too. One step is TYPO3Fluid\Fluid\View\TemplateView: This empty class adds no value, TYPO3\CMS\Fluid\View\AbstractTemplateView can extend TYPO3Fluid\Fluid\View\AbstractTemplateView instead, without functional change. Resolves: #94973 Releases: master Change-Id: I41888b371d69ca70deb30ff0d47028d4c8e0e6ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70734 Tested-by:
-
Frank Naegler authored
This patch adds the possibility to access site configuration with a placeholder in TCA's `foreign_table_where` query. To access a configuration value the following syntax is available: * ###SITE:rootPageId### * ###SITE:foo.bar.baz### (array path notation) Resolves: #94662 Releases: master Change-Id: I2047085d20c914960bbcd88df5b4c7a7f8d53282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70126 Tested-by:
-
Benni Mack authored
This change is a precursor to https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 This change effectively: * Centralizes checks to PackageStates.php in Bootstrap * Centralizes some specific Install-Tool functionality in PackageManager * Adds a cache identifier for ext_localconf/TCA/ext_tables.php from the packagemanager The last adaption allows to have custom cache identifier when the active packages have been updated. Resolves: #94987 Releases: master Change-Id: Ibc34fe1084ee42ef0a86e2942c6aed3a345b7188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70752 Tested-by:
-
Uwe Trotzek authored
The workspace module gets an additional stage filter to reduce the amount of changes a user is facing. This is very helpful if you are dealing with a lot of changes and want to see only records which are in a certain stage e.g. "Ready to publish". Resolves: #91021 Releases: master Change-Id: I80a3fa5c00ff302c9b2257370bdeda328033c204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64197 Tested-by:
-
Benni Mack authored
TemplateView does not use AbstractView, and others do not need this as well, ViewInterface is the one people should rely on. Resolves: #94991 Releases: master Change-Id: Ie09d6dcb3644b4e383bf67e7043765227b622948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70726 Tested-by:
-
Helmut Hummel authored
This change allows TYPO3 to detect and trigger a deprecation of the Cache Manager and database connection not only during loading of ext_localconf.php, but as well during building of TCA and loading of ext_tables.php. Code executed in these places has two purposes: 1. Provide/ adapt configuration 2. Register extension APIs (icons, modules, etc.) Both purposes will eventually migrated to DI configuration, which currently already is executed in a "stateless" environment. To prepare extension authors that this change will happen, before we will be able to migrate all current use cases to be registered in DI configuration, usage of DB connection and cache manager is deprecated at these early boot extension points. Releases: master Resolves: #94979 Change-Id: If03910ddd10c06662e1c9f5bea179ff12d64c989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69509 Tested-by:
-
Oliver Bartsch authored
Depending on the backend localization, the action labels might be "longer" than initially expected. To prevent the action bar from breaking into another row, the columns width is now automatically calculated while the fiter input is set to flex-grow to automatically use the remaining space. Resolves: #94988 Releases: master Change-Id: I7d19fab9cacb52695c8385258a00f9fef38df33a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70753 Tested-by:
-
Oliver Bartsch authored
System news records (sys_news) contain a `content` field, which features a richtext editor. Previously using the default configuration, having most of the available options enabled. Since system news are only displayed on the login screen and are only intended for simple information, most of the options are not relevant. Additionally, some of those options did not work at all, due to the missing frontend context (see e.g. #67556). To ease the use for administrators, a simplified RTE configuration is now used for the `content` field of sys_news records. In case administrators need additional options, this can as usual still be achieved by overriding the corresponding TCA configuration. Resolves: #94980 Releases: master Change-Id: Ib8825344b453a3d19c5cbcd96844be3c47408f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70742 Tested-by:
-
Oliver Hader authored
Having `additionalParams = &simple[id]=okay&simple[other]=other` with the following route enhancer configuration lead to some flaws: routeEnhancers: TestSimple: type: Simple routePath: '/simple/{simple_id}' _arguments: simple_id: 'simple/id' * generated URI contained `simple__other`, not resolving nesting (`/simple/okay?simple__other=other&cHash=...`) * `PageArguments::$staticArguments` contained parameter `simple_id` (unresolved to actual query parameter, incorrectly marked static) * other `PageArguments` properties contained `simple__other` (unresolved to actual query parameter, ignored nesting) Resolves: #91447 Releases: master, 10.4, 9.5 Change-Id: If96a6245f44a12d6e666d0ead8b1cc9cbbb43170 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69227 Tested-by:Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
