- Nov 09, 2017
-
-
Helmut Hummel authored
Because users have no access to deleted pages, the access check always fails, leading to delete page actions not being shown in the history despite being properly tracked. We now check this case and do a more lightweight check so that we still have the permissions checked, but can show deleted pages without disclosing unwanted information. Resolves: #45056 Releases: 7.6, 8.7, master Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c Reviewed-on: https://review.typo3.org/54580 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Alexander Opitz authored
Update the lock file to pull in the latest (1.4.5) release. This version is marked as PHP 7.2 compatible. composer command: composer update typo3/cms-composer-installers Releases: 8.7, master Resolves: #82898 Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7 Reviewed-on: https://review.typo3.org/54570 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Ralf Zimmermann authored
Cache the merged YAML settings into the assets cache to improve the performance. Resolves: #82373 Releases: master, 8.7 Change-Id: I601364d5957f26f1b369b513534936820f72b78e Reviewed-on: https://review.typo3.org/54106 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <susanne.moog@typo3.org>
-
Benni Mack authored
The TYPO3 Backend PageTree, built in TYPO3 4.5, has some strange quirks resolving DB records, doing a lot of queries for fetching a single page multiple times. This is unnecessary because this can be fetched with one query, which happens anyway. Additionally, the WSOL should only happen when a workspace is selected. Explicitly querying for "-1" pid etc. should be handled via SQL, and not explicitly implemented by the page tree. Bottom line: Remove one SQL-query per page which is loaded. As most of the PHP classes will be restructured with the upcoming ExtJS / ExtDirect removal, the removed methods will be part of the breaking change of ExtJS removal. Resolves: #82945 Releases: master Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e Reviewed-on: https://review.typo3.org/54574 Tested-by:
-
- Nov 08, 2017
-
-
Susanne Moog authored
Several times the install tool was using html() instead of text(). Use text() whenever possible. Resolves: #82949 Releases: master Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a Reviewed-on: https://review.typo3.org/54586 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Christian Kuhn authored
The v9/master branch of styleguide generates correct page localizations of styleguide demo data pages in table pages instead of pages_language_overlay. Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc Resolves: #82952 Related: #82445 Releases: master Reviewed-on: https://review.typo3.org/54592 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
This is probably the last version with v8 and v9 in sync before branching off styleguide v8. Styleguide introduced a new table with 8.0.13, one of the acceptance tests that uses a rather hard coded xpath now needs a slightly different selector to cope with that. Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0 Resolves: #82951 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54588 Tested-by:
-
Andreas Fernandez authored
Ensure that jQuery is available in NewRecordController. Resolves: #75676 Releases: master Change-Id: Idf437554fb136e8e4ae18ce0d229d6b3ed8a58e4 Reviewed-on: https://review.typo3.org/54587 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Cybercraft authored
Instead of having the new content element wizard in a separate module page it will be opened in a modal now. Resolves: #75676 Releases: master Change-Id: If117fe3f2d55a4163bcb5c153b47938953050348 Reviewed-on: https://review.typo3.org/52999 Tested-by:
-
Benni Mack authored
The patch migrates all data from pages_language_overlay into pages, and moves all API calls to overlay pages. The following restrictions are set: * Backend is always showing pages only for "sys_language_uid=0" for the page tree, element browser (e.g. "linking to default language page"), except where explicitly requested like the Page Module => Languages view. * pid and sorting are always the same for all translations and their default language page * Elements on a page are always keeping the field "pid" to the default language page (no change) * Permission checks for Backend users are always made against the default language page (perms_* fields and webmounts) Resolves: #82445 Releases: master Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260 Reviewed-on: https://review.typo3.org/51272 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
The DB setting "sys_domain.forced" is confusing and does not make sense nowadays, especially with nested domain records - where the rootline is now correctly traversed with the RootLine utility. Resolves: #82926 Releases: master Change-Id: I874c54aeb03c0b62c9a1cebc9d629cee7550ec0b Reviewed-on: https://review.typo3.org/54540 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Georg Ringer authored
The title of a translated page must be overlayed with the workspace version. Resolves: #65607 Releases: master, 8.7, 7.6 Change-Id: If10260f196776a16a53968b78542827ecbc145fe Reviewed-on: https://review.typo3.org/54583 Reviewed-by:
-
- Nov 07, 2017
-
-
Malte Koitka authored
If an overideChildTca key is already added by a TYPO3 core function like ExtensionManagementUtility::getFileFieldTCAConfig() the TCA migration should not be skipped. Otherwise the config will be incomplete and result in missing fields. The migration is changed that old "foreign_types", "foreign_selector_fieldTcaOverride" and "foreign_record_defaults" are merged into new "overrideChildTca", but the new settings are keps (take precedence) if given. Resolves: #80719 Resolves: #81045 Releases: master, 8.7 Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505 Reviewed-on: https://review.typo3.org/52693 Tested-by:
-
Benni Mack authored
This patch unifies the Backend module registration for Extbase modules like it has already been done for all other Backend modules using PSR-7 entry-points. This way backend route dispatching and module registration has been simplified. The entrypoint for Extbase Backend modules is now \TYPO3\CMS\Extbase\Core\Bootstrap->handleBackendRequest() which returns a PSR-7 response object. The following functionality has been marked as deprecated as it was solely built to handle Extbase modules when conf.php and index.php were still in style: ExtensionManagementUtility::configureModule() $GLOBALS['TBE_MODULES']['_configuration'][$name]['configureModuleFunction'] Releases: master Resolves: #82902 Related: #58621 Change-Id: I7956b350d650ed52bc7b5d83db20df386d79eb65 Reviewed-on: https://review.typo3.org/54531 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benjamin Rannow authored
under the right condition multiple duplicate cache commands are executed for Example: save a record in Backend can course multiple 'pages' commands will be executed, if the record has inline records. flushing '20' times the 'pages' cache is unnecessary. Resolves: #82930 Releases: master, 8.7 Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4 Reviewed-on: https://review.typo3.org/54569 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Tymoteusz Motylewski authored
In order to make page tree smaller and easier to review, this patch applies new JS CGLs on SvgTree related files. Releases: master Resolves: #82935 Change-Id: I5c9b8b889b21e77b4bcd7add2236eb849d204356 Reviewed-on: https://review.typo3.org/54572 Tested-by:
-
Claus Due authored
This patch moves a previously hardcoded list of Fluid implementations from the RenderingContext constructor, to TYPO3_CONF_VARS. Extensions and site administrators can then add their own implementations to this array and have them be used in every RenderingContext. See included RST file for further information on usage. Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417 Resolves: #82763 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54395 Tested-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
The type=input, renderType=inputLink field control has an option "allowedExtensions" to restrict the file element browser to specific file endings. This option is now correctly considered in file browser. Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018 Resolves: #82861 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54520 Tested-by:
-
- Nov 06, 2017
-
-
Tymoteusz Motylewski authored
Fixes missing labels in the svg category tree toolbar. Releases: master Resolves: #82934 Change-Id: Iac29bc35b40894630599b3fbec48daf870a8777a Reviewed-on: https://review.typo3.org/54571 Reviewed-by:
-
Dandy Umlauft authored
Added default and inline usage for the optional attribute "allowedTags" Maybe you have to think about the name, cause in http://php.net/manual/de/function.strip-tags.php the second parameter is called "allowableTags", and not "allowedTags" This can lead to a quick overlooked error ;) Releases: master Resolves: #82912 Change-Id: Icc3cab9a931790e621f5593ea487c9b23b779e30 Reviewed-on: https://review.typo3.org/54546 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Helmut Hummel authored
Update the lock file to pull in the latest release. composer command: composer update typo3/cms-composer-installers Releases: 8.7, master Resolves: #82898 Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981 Reviewed-on: https://review.typo3.org/54568 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benni Mack authored
The following pageTSconfig options are removed: - options.pageTree.excludeDoktypes No doktypes are exclueded anymore in search. - options.pageTree.disableIconLinkToContextmenu Icon Links are always selected (option had no effect anymore). - options.pageTree.searchInAlias Alias is now always searched for. - options.pageTree.hideFilter The filter is always shown, this feature should not be available on a per-user basis. Resolves: #82919 Releases: master Change-Id: Ie0031fef9948bf758e880b04662210d74e27688b Reviewed-on: https://review.typo3.org/54560 Reviewed-by:
Eugene Kenah Djomo <kdeugene@yahoo.fr> Reviewed-by:
-
Georg Ringer authored
The parameter 'gclid' is used as click identifier for Google AdWords and must not be used during the cHash generation. Resolves: #82927 Releases: master, 8.7 Change-Id: Id279238738550cfbd0b86e6decf94a86230535ee Reviewed-on: https://review.typo3.org/54562 Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #82920 Releases: master, 8.7 Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a Reviewed-on: https://review.typo3.org/54557 Tested-by:
-
Wouter Wolters authored
With #69884 the new button API was introduced but the back button in DatabaseRecordList was forgotten. The button is now done with the new API. Resolves: #82056 Releases: master Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d Reviewed-on: https://review.typo3.org/53722 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Reviewed-by:
-
- Nov 05, 2017
-
-
Georg Ringer authored
Remove the TypoScript option 'page.stylesheet' in favor of using `page.includeCSS`. Resolves: #82915 Releases: master Change-Id: If8bb68a1520c23096ab0729caba681031c6a5401 Reviewed-on: https://review.typo3.org/54549 Tested-by:
-
Georg Ringer authored
The option 'page.bodyTagMargins' is rarly used and can be removed. Any style information should be placed in a CSS file. Resolves: #82914 Releases: master Change-Id: Ib34ae835d0e50653b70f7ecf9573f42fbcca83a6 Reviewed-on: https://review.typo3.org/54548 Tested-by:
-
- Nov 04, 2017
-
-
Helmut Hummel authored
This reverts commit 68e85303. The patch needs to be reverted due to wrong implementation. The desired goal is not achievable at all with the current code base. Reverts: #66535 Releases: master, 8.7 Change-Id: Ibd8eb7c4023d1b9f0e0de8b75d66193d66b89147 Reviewed-on: https://review.typo3.org/54551 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Mathias Schreiber authored
Bring back the meta generator which got lost in the original patch Resolves: #81464 Releases: master Change-Id: I5c68e35bdab953c8ff3df3afd85099439ed42787 Reviewed-on: https://review.typo3.org/54554 Reviewed-by:
-
Claus Due authored
Refactors templates to minimise the impact of using the uncompilable PaginateWidget. By moving the Widget to a separate partial and the body rendered by the Widget to another partial the impact is reduced to a minimum, because the uncompilable template has just two nodes. Change-Id: I6f1d528ed0c45d776c4952596ac5a8828d04f477 Resolves: #81766 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53376 Tested-by:
-
- Nov 03, 2017
-
-
Mathias Schreiber authored
TYPO3 now allows to set, get and unset meta tags with an clear and concise API. This API allows it to set any meta tag via an extension while having the possibility to get the current content of a given meta tag. Unsetting meta tags allows to remove unwanted tags from 3rd party code. Resolves: #81464 Resolves: #22992 Resolves: #52471 Releases: master Change-Id: I31c2c29e29242ad9c2fadf2b625ae04288cc3bb5 Reviewed-on: https://review.typo3.org/53110 Tested-by:
-
Markus Hoelzle authored
Add possibility to get a label in a specific language in LocalizationUtility::translate() and the TranslateViewHelper Change-Id: I8589e2b155e57eed3124ed48b0d859fe7796ff3b Resolves: #82354 Related: #81834 Releases: master Reviewed-on: https://review.typo3.org/53967 Tested-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
Pascal Rinker authored
Add a deleted flag to database table "tx_scheduler_task". Any task execution will also consider this field. Resolves: #79777 Releases: master Change-Id: I9f96ae9b255042ebf4ba3c812726cbf5ba4fa41c Reviewed-on: https://review.typo3.org/51656 Reviewed-by:
Markus Sommer <markus.sommer@typo3.org> Tested-by:
-
Benni Mack authored
The TypoScript option 'config.typolinkCheckRootline' was introduced back in TYPO3 v4.x when there was no proper rootline cache or sys_domain cache in place, in order to resolve the proper domain. This now has changed, and this option can be removed in order to simplify page link generation. When in a multi-site setup, this option MUST be active otherwise it will result in ugly and hard-to-debug side-effects. For a single-site setup having this option disabled will result in a marginal performance decrease (one SQL query more) when linking to a page with a sys_domain record available. A deprecation notice is thrown if your TypoScript setup still includes this option. Resolves: #82909 Releases: master Change-Id: I36abcdd1e2eabe2da66d8edd720a5a27ec306ede Reviewed-on: https://review.typo3.org/54545 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
If an inline child, opened via ajax request, generates links leaving the current records and opening a different one, on closing that record the returnUrl is wrong and points to the url of the inline ajax request. The original return url of the main record is lost in the compile chain. The returnUrl data provider sets $data['returnUrl'] to current url if not otherwise given. The patch hands over the original return url to the inline ajax controller and lets it 'sink down' in the data compile chain to inline children so the original return url is available when container or elements generate urls. Additionally some broken 'returnURL' handling in InlineRecordContainer and jsfunc.inline.js is cleaned up and removed. Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5 Resolves: #82525 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54543 Tested-by:
Kjeld Schumacher <k.schumacher@familie-redlich.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #82900 Releases: master Change-Id: I9e80f662981dc107d5bcd1e4fc28bcf9d2ff3b4a Reviewed-on: https://review.typo3.org/54534 Tested-by:
-
Benni Mack authored
Resolves: #82908 Releases: master Change-Id: I96d661e294a737e36a084d4fa7423cc9257d1578 Reviewed-on: https://review.typo3.org/54542 Reviewed-by:
-
Georg Ringer authored
The class ClientUtility is outdated and not used anymore and can be deprecated. Resolves: #82903 Releases: master Change-Id: I616b4518bfebac8239ecca0b48cad1b037c0ba6d Reviewed-on: https://review.typo3.org/54538 Reviewed-by:
-
- Nov 02, 2017
-
-
Tymoteusz Motylewski authored
This change make SVG tree expect icon identifier instead of icon source in JSON node data. Tree fetches icon source via JS Icon API only once per icon type. This makes JSON response few times smaller. Resolves: #82849 Releases: master Change-Id: I8954837f68cee3bcc316bc56e30788e0d16c81d6 Reviewed-on: https://review.typo3.org/54468 Tested-by:
-
Susanne Moog authored
On SQLServer you cannot insert integers in varchar columns therefore the workspaces module ajax requests are failing and you cannot use the module. Cast the workspaceId to a string before using it as a cache tag. Change-Id: I0827dd6dddd9203fb7846934a034b826a515cdf3 Resolves: #82901 Releases: master Reviewed-on: https://review.typo3.org/54535 Tested-by:
-
