Skip to content
Snippets Groups Projects
Commit 73239fa6 authored by Claus Due's avatar Claus Due Committed by Jigal van Hemert
Browse files

[TASK] Refactor implementation of PaginateWidget 

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Change-Id: I6f1d528ed0c45d776c4952596ac5a8828d04f477
Resolves: #81766
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53376


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: default avatarAndreas Fernandez <typo3@scripting-base.de>
Reviewed-by: default avatarHenning Liebe <h.liebe@neusta.de>
Reviewed-by: default avatarTymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: default avatarJigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: default avatarJigal van Hemert <jigal.van.hemert@typo3.org>
parent 96144717
Branches
Tags
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 60 additions and 62 deletions
typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedListWidget.html 0 → 100644
+ 3
− 0
View file @ 73239fa6
<f:be.widget.paginate objects="{backendUsers}" as="paginatedBackendUsers" configuration="{itemsPerPage: 50, insertBelow: 1}">
<f:render partial="BackendUser/PaginatedListWidgetBody" arguments="{_all}" />
</f:be.widget.paginate>
\ No newline at end of file
typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedListWidgetBody.html 0 → 100644
+ 27
− 0
View file @ 73239fa6
<div class="table-fit">
<table id="typo3-backend-user-list" class="table table-striped table-hover">
<thead>
<tr>
<th></th>
<th class="col-title"><f:translate key="userName" /> / <f:translate key="realName" /></th>
<th><f:translate key="lastLogin" /></th>
<th class="col-control"></th>
</tr>
</thead>
<tbody>
<f:for each="{paginatedBackendUsers}" as="backendUser">
<f:render partial="BackendUser/IndexListRow" arguments="{demand: demand, backendUser: backendUser, onlineBackendUsers: onlineBackendUsers, dateFormat: dateFormat, timeFormat: timeFormat, returnUrl: returnUrl, compareUserUidList: compareUserUidList}" />
</f:for>
<f:comment>
Footer row: no officially defined style yet
</f:comment>
</tbody>
<tfoot>
<tr>
<td colspan="5">
<f:count subject="{backendUsers}" /> <f:translate key="users" />
</td>
</tr>
</tfoot>
</table>
</div>
\ No newline at end of file
typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedListWidget.html 0 → 100644
+ 3
− 0
View file @ 73239fa6
<f:be.widget.paginate objects="{backendUserGroups}" as="paginatedBackendUserGroups" configuration="{itemsPerPage: 50, insertBelow: 1}">
<f:render partial="BackendUserGroup/PaginatedListWidgetBody" arguments="{_all}" />
</f:be.widget.paginate>
\ No newline at end of file
typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedListWidgetBody.html 0 → 100644
+ 25
− 0
View file @ 73239fa6
<div class="table-fit">
<table class="table table-striped table-hover">
<thead>
<tr>
<th class="col-icon"></th>
<th class="col-title"><f:translate key="backendUserGroup" /></th>
<th><f:translate key="subGroups" /></th>
<th class="col-control"></th>
</tr>
</thead>
<tbody>
<f:for each="{paginatedBackendUserGroups}" as="backendUserGroup">
<f:render partial="BackendUserGroup/IndexListRow" arguments="{demand: demand, backendUserGroup: backendUserGroup, dateFormat: dateFormat, timeFormat: timeFormat, returnUrl: returnUrl}" />
</f:for>
<f:comment>
Footer row: no officially defined style yet
</f:comment>
<tr>
<td colspan="4">
<f:count subject="{backendUserGroups}" /> <f:translate key="LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:be_groups" />s
</td>
</tr>
</tbody>
</table>
</div>
\ No newline at end of file
typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html
+ 1
− 32
View file @ 73239fa6
......@@ -48,37 +48,6 @@
</f:comment>
<f:render partial="Filters/BackendUser/Index" arguments="{demand: demand, backendUserGroups: backendUserGroups}" />
<f:comment>
Listing of all users
</f:comment>
<f:be.widget.paginate objects="{backendUsers}" as="paginatedBackendUsers" configuration="{itemsPerPage: 50, insertBelow: 1}">
<div class="table-fit">
<table id="typo3-backend-user-list" class="table table-striped table-hover">
<thead>
<tr>
<th></th>
<th class="col-title"><f:translate key="userName" /> / <f:translate key="realName" /></th>
<th><f:translate key="lastLogin" /></th>
<th class="col-control"></th>
</tr>
</thead>
<tbody>
<f:for each="{paginatedBackendUsers}" as="backendUser">
<f:render partial="BackendUser/IndexListRow" arguments="{demand: demand, backendUser: backendUser, onlineBackendUsers: onlineBackendUsers, dateFormat: dateFormat, timeFormat: timeFormat, returnUrl: returnUrl, compareUserUidList: compareUserUidList}" />
</f:for>
<f:comment>
Footer row: no officially defined style yet
</f:comment>
</tbody>
<tfoot>
<tr>
<td colspan="5">
<f:count subject="{backendUsers}" /> <f:translate key="users" />
</td>
</tr>
</tfoot>
</table>
</div>
</f:be.widget.paginate>
<f:render partial="BackendUser/PaginatedListWidget" arguments="{_all}" />
</f:section>
typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Index.html
+ 1
− 30
View file @ 73239fa6
......@@ -9,35 +9,6 @@
<f:section name="content">
<f:comment>
Listing of all user groups
</f:comment>
<f:be.widget.paginate objects="{backendUserGroups}" as="paginatedBackendUserGroups" configuration="{itemsPerPage: 50, insertBelow: 1}">
<div class="table-fit">
<table class="table table-striped table-hover">
<thead>
<tr>
<th class="col-icon"></th>
<th class="col-title"><f:translate key="backendUserGroup" /></th>
<th><f:translate key="subGroups" /></th>
<th class="col-control"></th>
</tr>
</thead>
<tbody>
<f:for each="{paginatedBackendUserGroups}" as="backendUserGroup">
<f:render partial="BackendUserGroup/IndexListRow" arguments="{demand: demand, backendUserGroup: backendUserGroup, dateFormat: dateFormat, timeFormat: timeFormat, returnUrl: returnUrl}" />
</f:for>
<f:comment>
Footer row: no officially defined style yet
</f:comment>
<tr>
<td colspan="4">
<f:count subject="{backendUserGroups}" /> <f:translate key="LLL:EXT:lang/Resources/Private/Language/locallang_tca.xlf:be_groups" />s
</td>
</tr>
</tbody>
</table>
</div>
</f:be.widget.paginate>
<f:render partial="BackendUserGroup/PaginatedListWidget" arguments="{_all}" />
</f:section>
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment