- Dec 20, 2021
-
-
Christian Kuhn authored
Resolves: #96402 Releases: main Change-Id: I8266c5859954ea118a4ec92ca3ca9660e9854c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72743 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Stefan Bürk authored
The dev dependency friendsofphp/php-cs-fixer now has a minimum requirement to 3.4, which comes with PHP8.1 support. This allows TYPO3 to run PHP-CS Fixer with PHP 8.1 in the CI pipeline. Testing configuration is not adjusted with this patch, but allows using corresponding runTests.sh testsuites cgl and cglGit: Build/Scripts/runTests.sh -p 8.1 -s cglGit -n Build/Scripts/runTests.sh -p 8.1 -s cgl -n Used command: composer req friendsofphp/php-cs-fixer:^3.4 --dev Resolves: #96398 Releases: main, 11.5 Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72739 Tested-by:
-
Benni Mack authored
Resolves: #96392 Related: #95320 Releases: main Change-Id: I6dfe1e5ea95c1e5ceb748e2b1c50eec8644f1ecf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72732 Tested-by:
-
Benjamin Franzke authored
theChar is not initialized and therefore pollutes global scope. (It is assigned to window.theChar in the FormEngine iframe). Currently not an error (we are not using strict mode in RequireJS), just bad style, but once we switch to strict mode (type="module"), this will fail without proper declaration. Releases: main, 11.5 Resolves: #96395 Related: #96323 Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72735 Tested-by:
-
Stefan Bürk authored
doctrine/dbal:^3.2 changed return type of result for QueryBuilder execute methods, no longer have used prepared statement accessible for further query execution with other placeholder values. To raise doctrine/dbal:^3.2 two places have been changed to reuse the QueryBuilder instance itself instead of prepared statement with the corresponding patch #96287, thus given up the performance gain through reusable query execution plan in corresponding dbms systems. This patch adds support for prepared statements to TYPO3's QueryBuilder facade as this was not publicly available yet for TYPO3 users to be forward-compatible with Doctrine DBAL 3. Resolves: #96393 Related: #96287 Releases: main Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72610 Tested-by:
-
Sybille Peters authored
In a previous patch, some language labels were unified in EXT:redirects to that the same label was used for each field in the list module as well as in the edit view. Due to this some of the labels have become redundant and are now removed. Resolves: #96015 Related: #95832 Releases: main Change-Id: I2fd9c650dcca0aea81999a3de2b427895984c70f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72708 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
doctrine/dbal deprecated quite some methods to cleanup their codebase and provided replacements with more speaking method names. Most depcrecated method usages have been replaced in the core, but we missed some. The patch replaces the depcrecated method 'executeUpdate()' with the corresponding 'executeStatement()' method in several places to cleanup this up. This can be done also in 11.5 too, the required minimum version of doctrine/dbal provides these new methods as upwards compatible layer. Resolves: #96389 Releases: main, 11.5 Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72710 Tested-by:
-
- Dec 19, 2021
-
-
Stefan Bürk authored
With a recent change in typo3/testing-framework, various core caches in functional tests are set to NullBackend. This speeds up functional tests up to 10% since the table creation and insert load is higher in testing scenarios than actual cache hit benefits. Some functional tests however work on those tables, for instance the functional test of the database cache backend. The patch adapts these tests to according LocalConfiguration setup. > composer u typo3/testing-framework Resolves: #96387 Releases: main Change-Id: I9770c65d4cf80f98d2c4745024867acf6807e01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72706 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Dec 18, 2021
-
-
Torben Hansen authored
This patch ensures that the getQuery() function only uses the minus operator to negate the $storagePid variable, if the variable can be interpreted as an integer. Resolves: #96321 Releases: main, 11.5 Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72704 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Dec 17, 2021
-
-
Markus Klein authored
RTE yaml configuration can be incomplete/wrong or empty. Do not access configuration settings without a safeguard. Resolves: #96383 Releases: main, 11.5 Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72702 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Helmut Hummel authored
A "type" does not need to be set in a composer.json, so the checks for package type must account for the type being null, to not trigger a warning in PHP 8 Releases: 11.5, main Resolves: #96372 Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72695 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Helmut Hummel authored
Instead of relying on a hard coded extension install path, now the real extension path is used provided by the package manager Releases: main, 11.5 Resolves: #96375 Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72697 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Helmut Hummel authored
Get rid of the select query entirely, which optimises the task to only require one update query instead of one select and possibly multiple update queries and gets rid of doctrine version related incompatibilities with fetching the select result. Resolves: #96369 Related: #87162 Releases: main, 11.5, 10.4 Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72693 Reviewed-by:
-
Oliver Bartsch authored
The RecordListGetTable hook allows to add an additional where clause to the recordlist query. Since the sanitized result was wrapped in an array before being passed to $queryBuilder->andWhere(), this led to an exception. This is now fixed by passing the sanitized clause as string to `addWhere()`. Resolves: #96378 Related: #92065 Releases: main, 11.5 Change-Id: I99fa184f49f9db9f7edf061d4137e1e6c275446e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72699 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
As anticipated in v11 with #95298, this patch declares ViewHelper classes PHP final, third party extensions can no longer extend core ViewHelpers. There is one exception: The ext:fluid FormViewHelper, which is currently extended by ext:form. This can't be resolved easily since it's on one hand quite a bit of code that would have to be copied, and more importantly, the FormField* ViewHelpers refer to the "parent" FormViewHelper class name in various places. Declaring FormViewHelper final thus needs a different refactoring, which may be done in v12 with further patches. Resolves: #96368 Related: #95298 Releases: main Change-Id: I7e8a587dadef4e411390710dd47e309cd2414e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72671 Tested-by:
-
- Dec 16, 2021
-
-
Nikita Hovratov authored
The FinisherOptionGenerator of the form extension generates the data structure for the form setting overrides on the fly. By doing so, it didn't make a distinction between normal TCA fields and flexform specific sections/containers and added the wrapper "TCEforms" to sections as well, which broke the validation in DataHandler for the fields inside the container (E.g. the email field). The patch checks if section is set to "true" and adds the "TCEforms" key only for normal TCA field configurations. Unit tests have been added for the DataHandler checkValue_flex_procInData_travDS method, which show cases with and without the "TCEforms" key. Also, since this works now, a PHP 8 warning appeared. This is fixed now, too. Resolves: #95441 Releases: main, 11.5 Change-Id: Ib12a0484bcbdc827664181ca6af89edfadee13d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71490 Tested-by:
-
Markus Klein authored
Fix PHP8 warning issue if $_SERVER['PATH_INFO'] is not set. Resolves: #96373 Releases: main, 11.4 Change-Id: I427aee39c6f6389e418f27474c01cbfd973355e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72696 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Benni Mack authored
Resolves: #96358 Releases: main, 11.5 Change-Id: I36b7ddc31eb3e240c86f3a550d068d7577099f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72694 Tested-by:
-
Benni Mack authored
Resolves: #96310 Releases: main, 11.5 Change-Id: Ie12ca1683b3d8668deafbd37af03437f047c0ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72599 Tested-by:
-
Benni Mack authored
HMENU special="directory" and special="updated" did not use PageRepository directly, which led to duplicate entries with workspaces. This change does not use "$cObj->exec_..." anymore and fixes all problems. Resolves: #96226 Releases: main, 11.5 Change-Id: I595ac05981d03246eb7671c9ae072f499bff5188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72648 Tested-by:
-
Oliver Bartsch authored
The new `setContext` method is added to the ProviderInterface, making the API more robust. Resolves: #96333 Releases: main Change-Id: I1e2c2de893c247845a3640cac37fd76acead5595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72670 Tested-by:
-
Nikita Hovratov authored
This patch combines all seperated unit tests of DataMapFactory->setRelations() into a single test. These tests are now represented by the dataProvider. Resolves: #96364 Releases: main Change-Id: I1c1b7a9694a700a9fce68476c308df1b318dd8db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72667 Tested-by:
-
Christian Kuhn authored
ext:extensionmanager has a couple of view helpers that extend ActionViewHelper for no apparent reason. Change those to extend AbstractTagBasedViewHelper instead. Resolves: #96361 Releases: main, 11.5 Change-Id: Iedab908a30df0418a7c86d073d97a47548a87ab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72665 Tested-by:
-
Christian Kuhn authored
To prepare making all view helpers final as anticipated with #95298, ext:backend ThumbnailViewhelper must no longer extend ext:fluid ImageViewHelper. The patch is a simple transition, we may later have a look at the ThumbnailViewHelper again, since probably some of the possible arguments are not needed for thumbnails. Resolves: #96362 Related: #95298 Releases: main Change-Id: Ibf0f3ac108ab1849454769a947061a4604eb9fbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72666 Tested-by:
-
- Dec 15, 2021
-
-
Christian Kuhn authored
The "max" drop down in the ext:belog filter html is the only one that uses belog:form.translateLabelSelect view helper. By refactoring slightly, we can drop this view helper and simplify the code a bit. Resolves: #96360 Related: main Change-Id: Ib952dd3475d952354f8a07c31917f88751b93704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72664 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Marc Bastian Heinrichs authored
Resolves: #96308 Releases: main, 11.5, 10.4 Change-Id: Ibcbda7fd97a338d721cf00b38026727e941c72ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72598 Tested-by:
-
Georg Ringer authored
If EXT:workspaces is not installed, the workspace information should also be skipped in the logging module. This makes it easier to read and less bloated. Resolves: #96314 Releases: main, 11.5 Change-Id: I22277ca681cc877d57686e02f36fe54e630d2f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72607 Tested-by:
-
Christian Kuhn authored
$command being either 'new' or 'edit' is tested in a previous if() a couple of lines above already. Resolves: #96357 Releases: main Change-Id: I8088d50df6c854127ebecb8038a648fdad9af172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72662 Tested-by:
-
Stefan Bürk authored
Add support for sqlite acceptance testing to 'Build/Scripts/runTests.sh'. Run acceptance/sqlite testing with PHP 8.1 in nightly as a first execution implementation, which could be reshuffled when minimum PHP requirements have been decided. Furthermore two acceptance tests are marked as skipped when executed with sqlite, which should be fixed in dedicated patches: * MaintenanceCest.php->analyzeDatabaseStructureWorks() Skipped, as database compare is never clean and ends in endless loop with sqlite, when ext:indexed_search is installed. This is a general issue, existing at least since v10.4. Needs investigation and a dedicated patch. * UpgradeCest.php->seeUpgradeWizard() Skipped, as utf-8 charset upgrade wizard is not visible for sqlite dbms backend, thus rendering this test obsolete with sqlite. Needs another update wizard test and possibly a dedicated patch. Resolves: #96340 Releases: main Change-Id: I74c8f1156d98a5419309e110ed761e3de21fa37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72446 Tested-by:
-
Benni Mack authored
Resolves: #94308 Releases: main, 11.5 Change-Id: I84836ba46e3b8e3fa8d4ac915efb5a6a7afbdca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72657 Tested-by:
-
Christian Kuhn authored
Resolves: #96305 Related: #94115 Releases: main Change-Id: Id048e7f8b8679fd0dc2ab4e7f2120410e053a4df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72595 Tested-by:
-
Chris Müller authored
The following deprecation occurred in PHP 8.1: PHP Runtime Deprecation Notice: trim(): Passing null to parameter #1 ($string) of type string is deprecated. This happens in various places: * Using stdWrap_field() or in stdWrap() places * BackendUtility (e.g. new IRRE elements) * ExtensionManager Resolves: #96354 Releases: main, 11.5 Change-Id: Ie5c721784b51ed5493c8d9e1d557b08611263f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72659 Tested-by:
-
Florian Rival authored
Resolves: #96350 Releases: main, 11.5 Change-Id: I67e9fd68de038b84c83f7f12a465e6e37f918568 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72654 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Simon Gilli authored
The routes added via ExtensionManagementUtility::addModule() are missing when the UriBuilder/Router is used prior to ext_localconf loading. Also for this particular case, multiple instances of the Router class were created, as UriBuilder is loaded from the failsafe installtool container instead of using an instance from the symfony container (as created by LateBootService n loadExtLocalconfDatabaseAndExtTables). This resulted in multiple routers being loaded with different sets of routes. This patch ensures that the routes are loaded from a UriBuilder/Router instance that is fully populated with information from ext_localconf. Therefore GeneralUtility::makeInstance() is avoided and UriBuilder is fetched from the late booted container instead. Resolves: #95806 Releases: main, 11.5 Change-Id: Id57bf09fb7798eac26dbdbc6ed89228c54fbafb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72463 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Guido Schmechel authored
If a language in the SiteConfig is set to the fallbackType free and there is no translated page for this language, then there is now no generated hreflang. Previously, a link was always generated with default language slug, which lead to 404 page not found. Resolves: #94270 Releases: main, 11.5, 10.4 Change-Id: Ifb261cf388fccbaabbf2bcae9ac805b143c9b42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69919 Tested-by:
-
- Dec 14, 2021
-
-
linawolf authored
Releases: main, 11.5 Resolves: #96346 Change-Id: Ie64e82e84c63142f86b4e0f3e5072514b516aa33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72653 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Benni Mack authored
The method TemplateService->updateRootlineData() can be removed. Until TYPO3 v11 TemplateService resolved the TypoScript for a specific page, then found out the actual used language (config.sys_language_uid via TSFE->settingLanguage()) and then fetched the (translated) rootline based on the resolved language information. This is not needed anymore, as settingLanguage() does not call this method anymore, and is called much earlier now, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/65044. TypoScript is now always loaded after a translated page rootline has been fetched. This method is now completely unneeded, and is remoevd without replacement as the concept has now been streamlined. Resolves: #96351 Related: #23736 Releases: main Change-Id: If959a36333fcf5c91bee84ee497fddd2bfcec89b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72605 Tested-by:
-
Benjamin Franzke authored
jquery-ui/sortable has been patched as minified file in #83593 with a patch taken from https://github.com/jquery/jquery-ui/pull/1093 That pull request never got merged, but in the meantime the chrome bug seems to be fixed (the original report is no longer reproducable), therefore we now remove the patch. Note: Our binary patch (#83593) implicitly reverted jquery-ui/sortable to a 2013er version. Thus, this change implicitly updated our copy back to version 1.11.4 (from 2015) as defined in our package.json Resolves: #96335 Related: #83593 Related: #96323 Releases: main Change-Id: I71360f2808c655a0af00259552dcf8507742b729 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72628 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Franzke authored
Add a patch file for jquery.autocomplete that contains the custom TYPO3 patches added in #79938 and #70988. Enable the grunt copy action to ensure that mass package-upgrades like #92419 do not miss to update our local fork. A non-applying patch will produce an error during upgrade, while a local fork is silently ignored. Also, pin devbridge-autocomplete to the version that is actually used (updated last time in #70988): yarn add devbridge-autocomplete@~1.3.0 The patch file has been generated via: cp typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery.autocomplete.js \ Build/node_modules/devbridge-autocomplete/dist/jquery.autocomplete.js patch-package devbridge-autocomplete Note: The version line change is removed and the indentation (tabs vs spaces) is fixed, as it rather limits updatability, therefore the resulting javascript file format is slightly changed. No functional change. Resolves: #96334 Related: #92419 Related: #79938 Related: #70988 Related: #96323 Releases: main Change-Id: Ib8f9a79c3df1875e8a1606122f30e7d15bce06a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72626 Tested-by: -
linawolf authored
Includes changed links, missing images, wrong path's in includes etc. Excluded EXT:form as resolving the warnings is a large TASK there. Releases: main, 11.5 Resolves: #96345 Change-Id: I05d73d7fa211bbf9308a3c7a2161b1b5184d7b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72640 Tested-by:
-
