[!!!][TASK] Remove extbase parameter type resolving via doc blocks

Resolves: #96305
Related: #94115
Releases: main
Change-Id: Id048e7f8b8679fd0dc2ab4e7f2120410e053a4df
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72595


Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>

typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96107-DeprecatedFunctionalityRemoved.rst

@@ -376,6 +376,8 @@ The following fallbacks have been removed:
   :php:`\TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin()`, :php:`\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin()`
   and :php:`\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule()` and controller class names must be registered
   with their fully qualified name.
+- Extbase no longer determines types from doc block annotations for dependency injection methods and actions with validators,
+  defined types in method signatures must be used.
 
 The following database tables have been removed:
 

typo3/sysext/extbase/Classes/Reflection/ClassSchema.php

@@ -404,6 +404,8 @@ class ClassSchema
                      * due to non PSR-5 compatible tags in the core and in user land code.
                      *
                      * Fetching the data type via doc blocks is deprecated and will be removed in the near future.
+                     * Currently, this affects at least fooAction() ActionController methods, which does not
+                     * deprecate non-PHP-type-hinted methods.
                      */
                     $params = self::$docBlockFactory->create($docComment)
                         ->getTagsByName('param');
@@ -423,10 +425,10 @@ class ClassSchema
                     if ($typeDetectedViaDocBlock) {
                         $parameterType = $this->methods[$methodName]['params'][$parameterName]['type'];
                         $errorMessage = <<<MESSAGE
-The type ($parameterType) of parameter \$$parameterName of method $this->className::$methodName() is defined via php DocBlock, which is deprecated and will be removed in TYPO3 12.0. Use a proper parameter type hint instead:
+The type ($parameterType) of parameter \$$parameterName of method $this->className::$methodName() is defined via php DocBlock. Use a proper PHP parameter type hint instead:
 [private|protected|public] function $methodName($parameterType \$$parameterName)
 MESSAGE;
-                        trigger_error($errorMessage, E_USER_DEPRECATED);
+                        throw new \RuntimeException($errorMessage, 1639224353);
                     }
                     $this->methods[$methodName]['params'][$parameterName]['dependency'] = $reflectionType->getName();
                 }
@@ -442,11 +444,10 @@ MESSAGE;
                     if ($typeDetectedViaDocBlock) {
                         $parameterType = $this->methods[$methodName]['params'][$parameterName]['type'];
                         $errorMessage = <<<MESSAGE
-The type ($parameterType) of parameter \$$parameterName of method $this->className::$methodName() is defined via php DocBlock, which is deprecated and will be removed in TYPO3 12.0. Use a proper parameter type hint instead:
+The type ($parameterType) of parameter \$$parameterName of method $this->className::$methodName() is defined via php DocBlock. Use a proper PHP parameter type hint instead:
 [private|protected|public] function $methodName($parameterType \$$parameterName)
 MESSAGE;
-
-                        trigger_error($errorMessage, E_USER_DEPRECATED);
+                        throw new \RuntimeException($errorMessage, 1639224354);
                     }
 
                     $this->methods[$methodName]['params'][$parameterName]['validators'] = $argumentValidators[$parameterName];