Skip to content
Snippets Groups Projects
  1. Feb 16, 2024
  2. Feb 15, 2024
  3. Feb 14, 2024
  4. Feb 13, 2024
  5. Feb 12, 2024
  6. Feb 11, 2024
  7. Feb 10, 2024
  8. Feb 09, 2024
  9. Feb 08, 2024
  10. Feb 07, 2024
  11. Feb 06, 2024
    • Dimitri König's avatar
      [BUGFIX] Reverse rootline for PageLayoutResolver calls · dfa3a35d
      Dimitri König authored
      There have been quite a lot of patches around the pagelayout
      condition, which was introduced in early TYPO3 v11. It was
      broken in the beginning and got fixed with #98044.
      Soon after, a major refactoring of the ConditionMatcher
      has been applied with #100047, which re-introduced bugs
      regarding the pagelayout TypoScript condition. These have
      partially fixed with #100764 and #100921.
      
      The affected code is a bit messy due to a weird sorted
      array returned by the 'rootline' methods and classes,
      which we can't resolve right now.
      
      The fix itself revolves a last issue by reversing the
      rootline again. This was already done in the old backend
      ConditionMatcher. The frontend ConditionMatcher received
      the fullRootline, which is already reversed (deepest first).
      
      With the introduction of IncludeTreeConditionMatcherVisitor
      this has been unified, but the array_reverse was forgotten.
      
      In addition, the fullRootline from the frontend controller
      and BackendUtility::getPagesTSconfig() calls are sorted with
      `ksort` before passed over, meaning we always receive a
      top-down (root-first) rootline. Hence, the array_reverse is
      a viable fix for both backend and frontend.
      
      The patch covers BE pageTS, FE TypoScript and FE getData
      with tests to cover the situation once and for all.
      
      Resolves: #102268
      Related: #100047
      Related: #100764
      Related: #100921
      Related: #98044
      Related: #97816
      Releases: main, 12.4
      Change-Id: Ibec77f3cf63073e40e4a711d69f584b9265b1ad6
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82743
      
      
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      dfa3a35d
    • Stefan Bürk's avatar
      [TASK] Update `doctrine/dbal:^3.8.1` · ff1931a7
      Stefan Bürk authored
      Doctrine DBAL 3.8.x comes with further deprecations, but
      also with the new `QueryBuilder::reset*()` methods as a
      mitigation for the deprecated generic QueryBuilder methods
      `resetQueryParams()` and `resetQueryParam()`.
      
      See [1] for release notes and [2] for changes from current
      minimum version towards 3.8.1.
      
      Raising the minimum version ensures that extension authors
      are able to create TYPO3 v12 and v13 compatible code. At least,
      they can rely on it with the TYPO3 release containing this change
      for non-Composer and Composer mode.
      
      Used command(s):
      
      > \
        composer req --no-update --no-install \
          -d typo3/sysext/redirects \
          "doctrine/dbal":"^3.8.1" ; \
        composer req --no-update --no-install \
          -d typo3/sysext/core \
          "doctrine/dbal":"^3.8.1" ; \
        composer req --no-update --no-install \
          -d typo3/sysext/install \
          "doctrine/dbal":"^3.8.1" ; \
        composer req -W \
          "doctrine/dbal":"^3.8.1"
      
      [1] https://github.com/doctrine/dbal/releases/tag/3.8.1
      [2] https://github.com/doctrine/dbal/compare/3.7.2...3.8.1
      
      Resolves: #103031
      Releases: 12.4
      Change-Id: Ifb1b236c9c57a46a7cde7b753e813d6ae8cfbd01
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82778
      
      
      Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      ff1931a7