- Jun 04, 2024
-
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ @ckeditor/ckeditor5-horizontal-line@^41.4.2 \ @ckeditor/ckeditor5-html-support@^41.4.2 \ @ckeditor/ckeditor5-indent@^41.4.2 \ @ckeditor/ckeditor5-link@^41.4.2 \ @ckeditor/ckeditor5-list@^41.4.2 \ @ckeditor/ckeditor5-paragraph@^41.4.2 \ @ckeditor/ckeditor5-paste-from-office@^41.4.2 \ @ckeditor/ckeditor5-remove-format@^41.4.2 \ @ckeditor/ckeditor5-select-all@41.4.2 \ @ckeditor/ckeditor5-show-blocks@^41.4.2 \ @ckeditor/ckeditor5-source-editing@^41.4.2 \ @ckeditor/ckeditor5-special-characters@^41.4.2 \ @ckeditor/ckeditor5-style@^41.4.2 \ @ckeditor/ckeditor5-table@^41.4.2 \ @ckeditor/ckeditor5-theme-lark@^41.4.2 \ @ckeditor/ckeditor5-ui@^41.4.2 \ @ckeditor/ckeditor5-undo@^41.4.2 \ @ckeditor/ckeditor5-upload@^41.4.2 \ @ckeditor/ckeditor5-utils@^41.4.2 \ @ckeditor/ckeditor5-watchdog@^41.4.2 \ @ckeditor/ckeditor5-word-count@^41.4.2 npm install --save-dev \ @ckeditor/ckeditor5-dev-utils@^40.0.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2 Resolves: #103840 Releases: main, 12.4 Change-Id: I46dc33ab8e8cfcc75aa13bfe50d8850fb704f75e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84281 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84420 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Imko Schumacher authored
The value of the `time` input is sent as an ISO date to the FormEngine, except for the time "00:00", which is just submitted as "0". This has lead to the input field not getting populated by the JavaScript initialization, and the input "00:00" was lost. In cases where such a `time` input is set as a required field, the validation would then fail because of the field getting interpreted as being empty/unset. With this patch, a "0" value is also interpreted as a valid "1970-01-01T00:00:00+00:00" string, that is parseable by FormEngine. Note this only affects display within the FormEngine; the format of the stored data is not changed (converted by DataHandler to proper values and covered by existing tests). IMPORTANT: This only applies to NULLABLE time|timesec inputs. Only for this configuration it is possible to decide, that a stored "0" value in the database is actually "00:00" and not an unset entry. Integrators/developers need to set 'nullable' TCA key to 'true' of the corresponding 'config' array, in case they want to make a time/timesec input picker be able to store and retrieve "00:00" as a valid timestamp. Resolves: #102602 Releases: main, 12.4 Change-Id: Id5dae6564a5da9ab3abd99bdc14b718cc7064464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82093 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Garvin Hicking authored
The current implementation does not properly split UTF-8 formatted strings into multi-lines. This patch now utilizes the corresponding mb_* PHP functions to ensure proper splitting. Tests are added to verify this behaviour. Resolves: #103952 Releases: main, 12.4 Change-Id: I493dac05177ae60942513f93ac2c322b63a7a60b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84444 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Torben Hansen authored
With this change, CPP is used in FileDumpController. Resolves: #103963 Releases: main Change-Id: I42ff822a06fd0e138a8d3109163ea4fc76a09ae2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84474 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Torben Hansen authored
It is possible to use the namespaced shorthand notation in extbase to add validators for properties or arguments. As an example, `TYPO3.CMS.Extbase:NotEmpty` will be resolved as `TYPO3\CMS\Extbase\Validation\Validator\NotEmptyValidator` or `Vendor.Extension:Custom` will be resolved as `\Vendor\MyExtension\Validation\Validator\CustomValidator`. The namespaced shorthand notation for extbase validators has however never been documented and is rarely used in extensions. This change deprecates the usage of the namespaced shorthand notation for validators in extbase. Resolves: #103965 Releases: main Change-Id: I787401cc3271cc54fed5c875a27cfde545b4e6dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84477 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jun 01, 2024
-
-
Nikita Hovratov authored
GitHub repository of justinrainbow/json-schema has been renamed to jsonrainbow/json-schema. As a consequence we update the lock file so that other patches with composer.lock changes are clean. > composer update --lock Resolves: #103964 Releases: main, 12.4 Change-Id: Ie071856eb4b1fd8b7b74be9611757b9e08932c2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84475 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
Benni Mack authored
This change adapts the newly introduced PageContentFetching data processor, which reduces the number of SQL queries for colPos entries that do not use the "slideMode" feature. This means, that installations which use - multiple colPos on one layout will have 1 instead of "amountOfColPos" DB queries for fetching all content of a page. For colPos with a slide mode, the previous logic still applies. Resolves: #103906 Related: #103894 Releases: main Change-Id: I5172fa427a69f279e88c27f9b97793036d94c533 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84387 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
-
Anja Leichsenring authored
Phpstan claims the contract guard condition can never be true (in which case an exception will be thrown) but this is not true. So we keep the condition, but suppress the error. PHPStan gets updated and pinned to lowest version 1.11.3 with composer require --dev phpstan/phpstan:^1.11.3 Resolves: #103962 Related: #99146 Releases: main, 12.4 Change-Id: I8c184ef24ed95c7277e1e6b5ac8b8c9ea3ad0521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- May 31, 2024
-
-
Benjamin Franzke authored
Allow proxies to cache the TYPO3 content by stripping the nonce from the generated CSP header if the nonce was not actually consumed. Also ensure that the nonce value substitution consumes a nonce to ensure that a (replaced) nonces in cached-content receive a matching CSP header as well. Resolves: #103942 Releases: main, 12.4 Change-Id: I437c83de522ff4a6f4ee0ef2f13881d24bfb990c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84435 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Kai Ole Hartwig <o.hartwig@moselwal.de> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com>
-
Georg Ringer authored
The stdWrap options stripHtml and htmlSpecialChars requires the value to be a string. A typecast forces the string to avoid exceptions. Resolves: #103085 Releases: main, 12.4 Change-Id: Ia936a19e06fdf954ca3aef442cad34c164e9c54e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84446 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Kienast authored
With migration away from prophecy during v12 development, the variable `$siteMockRevelation` is not needed anymore as phpunit mocks don't know the concept of revelations. Resolves: #103958 Releases: main, 12.4 Change-Id: I92497737dfbba3ef1cd99e4fbd96751e00057a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84449 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Andreas Kienast authored
This commit updates some colors in the color picker component. The dark background is removed from focussed input fields. Also, the input styling now matches FormEngine styling. Resolves: #103891 Releases: main Change-Id: I9a3a9e10c48be0bf49395d388be55cb8c8535693 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84379 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- May 29, 2024
-
-
Garvin Hicking authored
Using '%env(SOME_VARIABLE)%' within a site configuration YAML did not resolve contents in SOME_VARIABLE that were falsy ('false', '0', 0). This patch now properly converts those falsy values to actual values. Tests are added to verify the new behavior and prevent future regressions. Drive-by fix on Unit tests which did not actually remove env vars after testing, putenv('var') is needed instead of putenv('var='), because the latter will keep the environment var around (with an empty value). Resolves: #91710 Releases: main, 12.4 Change-Id: I99d64f080737ada38fd58a63f4e04e5b0d8c9ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84442 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Georg Ringer authored
If no icon is provided for submodule, use a fallback to the icon of the parent module instead of directly using the empty-empty icon. Resolves: #103904 Releases: main, 12.4 Change-Id: I4e989483880fd88df904e9028f1d2cf6cd5c29f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84390 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- May 28, 2024
-
-
Oliver Bartsch authored
For consistency, the redirect demand's default value for the integrity status is now set to NULL, to show all records by default. This is especially important for existing installations, having redirects which do not yet contain a value for the new `integrity_status` field. Resolves: #103900 Related: #99485 Releases: main Change-Id: Iba8dc0180e22f5e31b51e6c33fb71b47b5486238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84382 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
Detail methods of the two TypoScript tokenizers tend to add mental load since they often update `$this` state. The patch changes `splitLines()` and `parseValueForConstants()` to return updated things instead, for consuming methods to take care of this. This is a pre-patch to simplify #102742. Resolves: #103944 Related: #102742 Releases: main, 12.4 Change-Id: I1a5dbccc1bdfbfc52681e323eb1fe9a2b0bb7dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84439 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
<INCLUDE_TYPOSCRIPT: source="DIR:..." condition="[tree.level > 2]"> The TypoScript tokenizers fail here since ">" within the condition is interpreted as "end of INCLUDE_TYPOSCRIPT". Add a couple of tests and fix it. Resolves: #103875 Releases: main, 12.4 Change-Id: I43c59bd61645bee9ce9c175b00ce1d2cba44c023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84346 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 27, 2024
-
-
Christian Kuhn authored
There is little point extracting single widget configuration to an own file - we don't split Services.yaml in any other extension. Merge DashboardWidgets.yaml into Services.yaml. Resolves: #103936 Releases: main Change-Id: I00ba601a57942fc543728c87404f0944a307bf0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84425 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Benjamin Franzke authored
Add a filename context to page.tsconfig include nodes (autoloaded from extensions Configuration folder or from site sets) in order to allow relative imports to be resolved. Releases: main, 12.4 Resolves: #79737 Related: #97816 Change-Id: Id6404127b667a61e013d4e5b528048201ad0e6c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83712 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator and removes the null default value for the first parameter, which mitigates both issues. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103927 Releases: main, 12.4, 11.5 Change-Id: I0ba574769e5b95852379aa30f03d45715aec2055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84416 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Ayke Halder authored
This enables the already available `phpstan-phpunit` rules: * PHPStan\Rules\PHPUnit\AssertSameBooleanExpectedRule * PHPStan\Rules\PHPUnit\AssertSameNullExpectedRule * PHPStan\Rules\PHPUnit\AssertSameWithCountRule * PHPStan\Rules\PHPUnit\MockMethodCallRule * PHPStan\Rules\PHPUnit\ShouldCallParentMethodsRule `ShouldCallParentMethodsRule` is of great interest: It checks for missing calls to `parent::setUp` and `parent::tearDown`. `AssertSameWithCountRule` replaces `assertSame($expectedCount, count($variable))` with `assertCount($expectedCount, $variable)`. Resolves: #103880 Related: #103929 Releases: main Change-Id: I43a69d0dcf342cc65d34eb03f2d9800b1e70e8a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84351 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Stefan Bürk authored
This change modifies the `runTests.sh` helptext to mention the `checkIntegrityPhp` correctly added with #103465. Resolves: #103930 Related: #103465 Releases: main Change-Id: I0ffdb66236bbc0c82f702cf960bf9462dedbdfcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84419 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Christian Kuhn authored
Using PHP attributes to configure DI within classes directly is more easy to understand since developers don't need to constantly look up DI configuration Services.yaml files, but have everything in one place. The patch switches all classes that previously used '@cache.xy' to get a specific cache injected to an `Autowire` attribute. Resolves: #103921 Releases: main Change-Id: I16b064242cdbc2bbcfbed89700c97afac012fdf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84406 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Garvin Hicking authored
Using the methods does not improve output, but makes reading harder: A first wantTo() changes the title of a test within the output - that is usually derived from the test method name - to the wantTo() message. This leads to things like different tests having the same name. Our test names are good, use them! Any second or other use of wantTo() does nothing in the output at all. The patch removes wantTo() and wantToTest() (similar behavior), and turns some of them into code comments. This should make the test logs more easy to understand and follow. Resolves: #103916 Releases: main Change-Id: Ie88d8fd937151c1b471cfa3b4743e7639bf2c7fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84403 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Resolves: #103933 Releases: main Change-Id: Ic1626081bf0f4ee2159543be1fe6cdfc80b9b4e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84421 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes code to mock Connection methods conditionally, based on their existance surrounded by a `@todo` comment to remove this, when `doctrine/dbal` has been required with 2.11.0 as minimal version. The version raise has been done already a long time ago, however the removal of this conditional test mock has been missed. This change removes the conditional mocking now. Resolves: #103929 Releases: main, 12.4, 11.5 Change-Id: I4cc2d5942149f69e044c25379c82388f1c4b9f45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84418 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Ayke Halder <mail@ayke-halder.de>
-
- May 26, 2024
-
-
Christian Kuhn authored
$this->count() in phpunit always returns 1 and has no arguments as correctly found by phpstan. Fix a test to actually assert subject result count. Resolves: #103924 Releases: main, 12.4 Change-Id: I396b695eaeaa986a4cd9883e028ed6032d2f6339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84412 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
GeneralUtility::callUserFunction() has only three parameters, as detected by phpstan. Resolves: #103923 Releases: main, 12.4 Change-Id: I31fc48f343558dd2e0d73feeb3933e249fa625a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84410 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Two unit tests are skipped since they try to verify correct behavior while the system under test returns something broken or not implemented. The patch activates the tests to document the broken behavior and adds `@todo` annotations explaining what is going wrong or should be expected. Resolves: #103922 Releases: main Change-Id: Ib93bfa6baa3cb8369e084bd01a7dd0d40c7a4bee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84409 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
With `@touch()` being changed to `touch()` with #103911, its now clear the random fail stems from the test not being able to create the file sometimes: touch(): Unable to create file /builds/typo3/CI/cms/typo3temp/var/lock/../../var/lock/foo because No such file or directory This also explains why it happens in unitRandom on CI only: Usually this test is run after some previous test created typo3temp already, with unitRandom it may be rejuggled so typo3temp does not exist yet. Also, local machines typically have this directory after a first unit test run, which is why the test fails on CI only, since CI always starts with a 'git clean' directory state. The patch changes the test to make sure the directory path is created before the fixture file is touched. Resolves: #103920 Related: #103911 Releases: main Change-Id: I1cbb23b99860f2dbb158995a8c041cdef34a5e35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84408 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Full class is set readonly, no need to set it for a single constructor argument. Resolves: #103918 Related: #103437 Releases: main Change-Id: Ide8580bb12d15f5b23caa4b96372b72a0f38e8f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84405 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
Change #101653 introduced the auto-creation of DB fields for TCA type "check", but used a hardcoded "0" as default. Since TCA definitions might define a different default, and records may not always be created using the DataHandler to respect TCA defaults, this can lead to DB entries getting created with an unexpected default setting. IMPORTANT: This patch only fixes the root cause of the bug. If an existing v13 installation has already created new records after the DB migration wizard update in 13.0, all records may have wrong defaults. Check the contents of your database for the fields listed below and apply manual adjustments as needed (for example, record storages having "auto_extract_metadata"=1 instead of 0). An example symptom of this is the auto-creation of a file storage record, which uses the QueryBuilder to create a record, without specifying the whole list of all possible fields. For example then leading to added YouTube media files not auto-creating metadata records. This patch uses the proper evaluation of the TCA "default" setting of an auto-created field. In TYPO3 Core this only affected `be_users.options` and `sys_file_storage.auto_extract_metadata` default record creation. The latter field has now been included to the default record creation as a fixed value like the others. A follow-up patch could rewrite this functionality using the DataHandler or QueryBuilder default value injection. Tests have been created to verify this regression, existing tests for be_user creation have been adapted for the proper default values. Executing the DB schema analyzer will now adjust the following fields: * be_users.options (0->3) * sys_file_storage.is_browsable (0->1) * sys_file_storage.is_writable (0->1) * sys_file_storage.is_online (0->1) * sys_file_storage.auto_extract_metadata (0->1) * sys_file_metadata.visible (0->1) * tt_content.sectionIndex (0->1) * tx_styleguide_palette.palette_1_1 (0->1) * tx_styleguide_palette.palette_1_3 (0->1) * tx_styleguide_valuesdefault.checkbox_1 (0->1) * tx_styleguide_valuesdefault.checkbox_2 (0->1) * tx_styleguide_valuesdefault.checkbox_3 (0->5) * tx_styleguide_valuesdefault.checkbox_4 (0->5) * sys_workspace.edit_allow_notificaton_settings (0->3) * sys_workspace.edit_notification_preselection (0->2) * sys_workspace.publish_allow_notificaton_settings (0->3) * sys_workspace.publish_notification_preselection (0->1) * sys_workspace.execute_allow_notificaton_settings (0->3) * sys_workspace.execute_notification_preselection (0->3) * sys_workspace_stage.allow_notificaton_settings (0->3) * sys_workspace_stage.notification_preselection (0->8) Resolves: #103915 Related: #101653 Releases: main Change-Id: Ia42e00b03d1369efe319e41e2b406b5303804854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84402 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Wand <wand@itaw.de> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
And rename the method since those general getButtons() methods are ugly. Resolves: #103914 Related: #103903 Releases: main, 12.4 Change-Id: Iaa428d711b98d2bf178aa0ba54ab507f7ca1c09b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84399 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 25, 2024
-
-
Robert Silén authored
TYPO3 works with various DBMS. Avoid a specific mention of MySQL in README.md, the version matrix reveals details. Releases: main, 12.4 Resolves: #103719 Change-Id: I38cc50be00838643cb0095b3c848ef1d8a0c3014 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84015 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Georg Ringer authored
The shortcut button requires the resolved name as display name and not the LLL path. Resolves: #103903 Releases: main, 12.4 Change-Id: I59e38bf9c40f0a940fecb6ac3178b2976f168069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84388 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Torben Hansen <derhansen@gmail.com>
-
Lina Wolf authored
There is no word 'postparation' according to native speaker Sarah McCarthy. And also the sentence was hard to understand for non-native speakers. The command is not only useful during deployment so we mention other usecases. Resolves: #103857 Releases: main, 12.4 Change-Id: I602d8fe70ccbe6831278669fb2078318be4bcf63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84312 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
* Set this internal method to protected * Add type hints for two arguments that are safe to set * Skip BU::isTableLocalizable(), and check state of the two main TCA 'ctrl' props with an early return instead * add @todo for incomplete use of getTSconfig_pidValue() results * $this->BE_USER->workspace is always an int, skip cast * fetchAllAssociative() always returns an array, remove an if and return early with empty result set instead Resolves: #103912 Related: #103828 Releases: main Change-Id: I3d11822c40c0c58474225ba95ff86c5b672c9f7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84397 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.1.1 npm run build Resolves: #103890 Releases: main Change-Id: Id8cd17bbb1142a0522e1fd80f7dbd0f83455720a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84378 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-