Skip to content
Snippets Groups Projects
Commit 5564286e authored by Garvin Hicking's avatar Garvin Hicking Committed by Stefan Bürk
Browse files

[BUGFIX] Resolve falsy ENV-variables in YAML Site Configuration values

Using '%env(SOME_VARIABLE)%' within a site configuration YAML
did not resolve contents in SOME_VARIABLE that were
falsy ('false', '0', 0).

This patch now properly converts those falsy values to actual
values.

Tests are added to verify the new behavior and prevent
future regressions. Drive-by fix on Unit tests which did
not actually remove env vars after testing, putenv('var')
is needed instead of putenv('var='), because the latter
will keep the environment var around (with an empty value).

Resolves: #91710
Releases: main, 12.4
Change-Id: I99d64f080737ada38fd58a63f4e04e5b0d8c9ef3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84442


Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarOliver Hader <oliver.hader@typo3.org>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
parent e74ff406
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment