Skip to content
Snippets Groups Projects
Commit d3cbe8c6 authored by Christian Kuhn's avatar Christian Kuhn Committed by Stefan Bürk
Browse files

[TASK] Avoid useless readonly in SiteSettingsFactory

Full class is set readonly, no need to set it
for a single constructor argument.

Resolves: #103918
Related: #103437
Releases: main
Change-Id: Ide8580bb12d15f5b23caa4b96372b72a0f38e8f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84405


Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarTorben Hansen <derhansen@gmail.com>
Tested-by: default avatarTorben Hansen <derhansen@gmail.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
parent f397539e
Branches
Tags
No related merge requests found
......@@ -39,7 +39,7 @@ readonly class SiteSettingsFactory
protected SettingsTypeRegistry $settingsTypeRegistry,
protected YamlFileLoader $yamlFileLoader,
#[Autowire(service: 'cache.core')]
protected readonly PhpFrontend $cache,
protected PhpFrontend $cache,
#[Autowire(expression: 'service("package-dependent-cache-identifier").withPrefix("SiteSettings")')]
protected PackageDependentCacheIdentifier $cacheIdentifier,
protected string $settingsFileName = 'settings.yaml',
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment