Skip to content
Snippets Groups Projects
Commit 3fa40417 authored by Christian Kuhn's avatar Christian Kuhn Committed by Anja Leichsenring
Browse files

[BUGFIX] Stabilize SimpleLockStrategyTest

With `@touch()` being changed to `touch()` with #103911,
its now clear the random fail stems from the test not being
able to create the file sometimes:

touch(): Unable to create file
/builds/typo3/CI/cms/typo3temp/var/lock/../../var/lock/foo
because No such file or directory

This also explains why it happens in unitRandom on CI only:
Usually this test is run after some previous test created
typo3temp already, with unitRandom it may be rejuggled so
typo3temp does not exist yet. Also, local machines typically
have this directory after a first unit test run, which is why
the test fails on CI only, since CI always starts with a
'git clean' directory state.

The patch changes the test to make sure the directory path
is created before the fixture file is touched.

Resolves: #103920
Related: #103911
Releases: main
Change-Id: I1cbb23b99860f2dbb158995a8c041cdef34a5e35
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84408


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
parent d3cbe8c6
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment