- Sep 20, 2021
-
-
Oliver Hader authored
Introduces `<f:transform.html>` view-helper, providing capabilities to resolves system internal links, like `t3://`. Example: <f:transform.html selector="a.href,div.data-uri"> <a href="t3://page?uid=1" class="page">visit</a> <div data-uri="t3://page?uid=1" class="page trigger">visit</div> </f:transform.html> ... will be resolved and transformed to the following markup ... <a href="https://typo3.localhost/" class="page">visit</a> <div data-uri="https://typo3.localhost/" class="page trigger"> visit</div> Following Composer dependency is made explicit: composer req masterminds/html5:'^2.7' ext-dom:'*' Resolves: #95176 Releases: master Change-Id: Ib0101fbe120343dc404f0816da6d38946df0d931 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70977 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Sep 19, 2021
-
-
Christian Kuhn authored
Variable $uploadedFiles is carried around in DataHandler through various methods, but is in fact never used since TCA type=group with internal_type=file has been dropped in v10. The patch drops that argument. All method changes are detail implementations within DataHandler and either protected or marked @internal, the change does not raise backwards compatibility issues. Change-Id: I4ca56005d9e52255d3168358d16bbb66347d8974 Resolves: #95264 Related: #87428 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71115 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Sep 17, 2021
-
-
Nikita Hovratov authored
Since commit e09082f7 (v10 release) the possibility to override the preview header was gone. This patch moves the drawItem hook out of the renderPageModulePreviewContent method to be able to pass the before rendered previewHeader to it. Resolves: #91760 Relates: #90906 Releases: master Change-Id: Ia7d29333543d764f4ebaec0330df1817032dc8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68953 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Hader authored
Removes inline JavaScript from installer step "Create Administrative User & Specify Site Name". Also mark button as type="button" to avoid intercepting the form submit due to the toggling event handler. Resolves: #95266 Resolves: #95241 Releases: master Change-Id: I002fabc185bf8fdf88793abfdf6ca89b61847e3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71121 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Hader authored
Remaining individual inline JavaScript in `onclick` handler to open an URI in a new window is replaced with default frontend JavaScript (see #95041) in `AbstractPlugin::pi_openAtagHrefInJSwindow()`. Resolves: #95151 Releases: master Change-Id: I90e12d521efaf1a0ac0be0890c940f20b832aa21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70968 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Methods FlexFormTools->getArrayValueByPath() and FlexFormTools->setArrayValueByPath() have well test covered counterparts in ArrayUtility since v7. Usages can be adapted easily and the outdated implementations can be deprecated. Change-Id: Ieb40369c883b95f6c7cc398cfdab3a9a08054b8f Resolves: #95254 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71112 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Nikita Hovratov authored
The variable $log_data does not always have 5 entries. Use the array spread operator to provide all available entries. Resolves: #95066 Releases: master Change-Id: Iead57b5d6c6bd43cfe8c9f3abaf5bfc1cd8ecd9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70858 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The method "GeneralUtility::minifyJavaScript()" was introduced back in 2007 when TYPO3 used "jsmin". Then, the hook was introduced, and "jsmin" was removed from TYPO3 Core again. TYPO3 Core also added - in parallel - the concept of the PageRenderer, which also contains a hook for extensions (such as EXT:min), or then calls the ResourceCompressor, which takes care of compressing and concatenating resources. The hook is now moved from GeneralUtility and executed within the ResourceCompressor, so extensions can still use the hook to compress inline JavaScript. However, the method is completely mis-placed nowadays and is moved to the according place in ResourceCompressor. Resolves: #94791 Releases: master Change-Id: Ia7b7534ea2fbd44258a191b8a4b16144adaa0c7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70236 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Rachel Foucard authored
The drop zones added space when they appear during a drag and drop action and it changed the mouse position. Also each content had a “new content” button relative to it and this button was dragged with it. This fixes both problems. Resolves: #95231 Releases: master Change-Id: I03f2219726ce1b7563409198449ed20dfc681a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71105 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Oliver Bartsch authored
In the fluid based page module, when in columns mode and having a L>0 language selected, the context always contained L=0 as the current site language. Since this value is used in the fluid templates for data attributes and similar, it might lead to unintended outcome. This is now fixed by cloning the context for the currently selected language before forwarding it to grid creation, as it's already done in languages mode and for the special "defLangBinding" view. Resolves: #95255 Releases: master Change-Id: I3f6f6213e90123ab74f2b4e04985909986df9534 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71113 Tested-by:
-
Rudy Gnodde authored
Resolves: #94655 Releases: master, 10.4 Change-Id: I91b671d4dea58f022c1b5cb9f1c9f4c5c91bb38c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Jochen Roth authored
For PHP8 in the frontend there are still undefined key warnings. This is fixed by adding fallbacks. Resolves: #95082 Releases: master Change-Id: I4ef512366aeb3b53adba4e96b07869657415b55d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 Tested-by:
-
Jochen Roth authored
EXT:recycler and EXT:workspaces use nearly the same code for their custom JavaScript based pagination. Therefore, both are adjusted accordingly. All buttons are now always equal height, since the "page-link" class now uses the full parent container space. The prev / next buttons now use the TYPO3 icon element instead of font awesome, making additional classes superfluous. All buttons are now "buttons", since they do not contain a target. This also brings previously missing user agent styles, such as cursor:pointer. Also the full area is now clickable. Additionally, a left over code block from #81086 is removed in the Recycler JavaScript module. Resolves: #95251 Releases: master Change-Id: I5456d0edd566cdc6dc3fb3a8e26d7dc959bd27f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71104 Tested-by:
-
- Sep 16, 2021
-
-
Benjamin Franzke authored
LanguagePackService is supposed to dispatch events that third party extensions can handle. The service instance therefore needs to be factored thorugh the late-booted symfony container, in order for event handlers to be associated. Releases: master, 10.4 Resolves: #93889 Related: #89813 Change-Id: Ia252fbe1b28d55f0944d5cc51801d01b41b008a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68754 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Georg Ringer authored
The record information element displayed the records' table name as "record type", while the actual record row already contains a "record type" column, displaying the TCA defined title for the table. This is now streamlined. The "record type" column is removed from both, the actual row and the information element. All records are now grouped by their record type. The grouping is visualized by a dedicated "header" row, showing the TCA defined title and if debug enabled and admin user, also the table name in brackets (as known from FormEngine). In case the listing is filtered by record type, the additional "header" row is not displayed. Resolves: #95227 Releases: master Change-Id: Ieed145a183cd140b2af0dff6e37b1e7273368022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71093 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Simon Schaufelberger authored
With the introduction of #94402 error pages are fetched via a sub-request. Manual "page not found" ErrorController invocations within an extbase action then resulted in rendering the originally requested page instead of the defined 404 page. This happened because the PrepareTypoScriptFrontendRendering middleware hold a reference to the outer TSFE instance which contains the original page id. Instead of injecting the stateful TSFE (which is generally discouraged), TSFE in now passed as request attribute. The container will log an according warning message from now on. Resolves: #95174 Releases: master Change-Id: Ieda58e2bef8f08762fcba06b76df03aff7b10d5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71084 Tested-by:
-
Larry Garfield authored
We can re-enable them by default when we're much more certain that stateful services have been removed or properly handled. Resolves: #95253 Related: #95174 Related: #94402 Releases: master Change-Id: I820f48797a21ded4ce49b74ce11b9c1eb164b353 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71107 Tested-by:
-
Christian Kuhn authored
TYPO3_CONF_VARS BE/flexFormXMLincludeDiffBase and "vDEFbase" has been removed in v7. Drop a left over. Change-Id: Ia6092f44970daea556042c380e308c727c576f4a Resolves: #95252 Related: #70138 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71106 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Christian Kuhn authored
"True" MM relations (those tables that have a "uid_local" and "uid_foreign" db column and NO TCA) have a "local" and a "foreign" side. For instance with categories, the category table is the "local" side, and the referencing table "pages", "tt_content", or whatever table, is the foreign side. Without the patch, MM table rows when localizing the local side of an MM relation is buggy, scenario: A default language tt_content record references a default language category. This gives one row in the mm table. If now the category is localized, a second entry from the localized category to the default language content element is added. This is wrong. The patch fixes this in the DataHandler by setting a dedicated override for this "local side localization" scenario, so the RelationHandler omits MM processing in this case. A functional test is added for non-workspace that exists for workspace already to verify a new relation can still be added when creating the local side. Note this is only half of the picture - MM relation should still be set and updated when a localized foreign side exists for the just localized local side. This does not happen currently and leads to broken MM rows even with the patch. This scenario however needs a bigger refactoring and further increased coverage and will be handled with further patches. Still, this patch is relatively straight forward, increases test coverage for future patches and already solves various long standing forge issues. Change-Id: Ieee8b5a4c101065c03bc7e90c8a4aa36b1bdf6a7 Resolves: #89659 Resolves: #89620 Resolves: #91842 Resolves: #77902 Related: #70460 Related: #62727 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71094 Tested-by:
-
Helmut Hummel authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/71075 usage of InstalledVersions class was introduced. More specifically the install_path of the root package. However install paths of packages are only available in composer-runtime-api 2.1, therefore we need to require this a minimum version. As drive by change the usage of Composer runtime API is encapsulated in the Environment class and path normalisation is put there as well, to not require normalisation for each package. composer req composer-runtime-api:^2.1 composer req composer-runtime-api:^2.1 -d typo3/sysext/core/ --no-update Resolves: #95237 Related: #94996 Related: #95171 Releases: master Change-Id: Ibe8f676830327b1036be8074e0dc38e54743b479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71083 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Rachel Foucard authored
The unused elements in the page module have a specific styling (orange heading). When the items are drag&drop'ed into an active colPos, they previously kept their unused styling. This change gives the "Unused elements" a global warning background and removes the warning style from the content items so that they don't stay orange after a drag and drop in a real colPos. Resolves: #95230 Releases: master Change-Id: Idaa323166ec2c8f62b6f0fe747e7965910dbd4b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71103 Tested-by:
-
Christian Kuhn authored
The extbase ViewInterface fits little purpose: Most methods are part of the fluid based class and interface chain, with the exception of setControllerContext(), which is deprecated, and initializeView(), which is always only implemented as empty method. The patch deprecates the interface keeping its usage in API classes to prevent compatibility issues and prepares the interface removal for v12. Change-Id: I012ad0307f7a40923a793f55b596a27e8b770bf4 Resolves: #95222 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71089 Tested-by:
-
Oliver Bartsch authored
EditDocumentController failed to properly track if the edit form could be created or not. This lead to a couple of consequential errors. For example, the spinner was added but could never be removed, since the FormEngine JavaScript component was not initialized. With PHP > 8 this also lead to a lot of warnings since $this->firstEl is not set, in case the edit form could not be created. This is now fixed by properly tracking whether the edit form was created and whether $this->firstEl was initialized. In case the edit form could not be created, an info box notifies the user. Resolves: #95183 Related: #95052 Releases: master Change-Id: I5a710b22319f4ce34b86c64d2141b59ba3a7a12a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71023 Tested-by:
-
Jochen Roth authored
[BE]versionNumberInFilename set to "true" triggers a undefined key warning in PHP8. This has been fixed by testing for a empty value in the array key. Resolves: #95223 Releases: master Change-Id: I3b88010d73e6e459819bbbfbe6751a4b2fb7f8f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71090 Tested-by:
-
Torben Hansen authored
The status code of a PSR-7 response object returned by an extbase action has no influence on the actual status code returned in frontend context. With this change, a status code >= 300 from the PSR-7 response is applied using the PHP header() function. Resolves: #94533 Releases: master Change-Id: Icfca5cbf6d37841fdb5f4d36d29bd2b2bce3fbd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71014 Tested-by:
-
Benni Mack authored
The fluid-based page module has hard-coded labels within the GridColumnItem class, which is not possible to override in templates right now. Instead, f:translate viewhelper is used in this case. In addition, the PageActions and the ContextMenu get some additional HTML attributes to clear up logic. Resolves: #95243 Releases: master Change-Id: I1911c4930586867c0cc21a3394263e80ae3fe782 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71101 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
-
Benni Mack authored
The TypoScriptFrontendController holds a property called "ATagParams". Its value is a copy of $TSFE->config[config][ATagParams]. The information can be retrieved from the config array, just like all other things are loaded there, as the usages of this property are rather low. In addition cObj->getTagParams' 2nd argument "addGlobal" which is always set to true, is marked as deprecated as well. Resolves: #95219 Releases: master Change-Id: I39a12bc717bff8bb3c50af7eaab726cf7b2f4d7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70965 Tested-by:
-
Oliver Bartsch authored
This restores the "Go back" button in the "Composer Support of Extensions" view of the extension manager module. Resolves: #95233 Related: #95164 Releases: master Change-Id: I3f051b61ff79be6e783c81aa4ea3956ad48147ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71098 Tested-by:
-
Oliver Bartsch authored
The SvgTree filter previously used type=text, which prevented the element from properly responding to keyboard events, e.g. using "escape" to clear the search term. This is now fixed by using type=search. This also allows to remove the manual "clearable" initialization, which is the default browser behaviour for this type. Resolves: #95226 Releases: master Change-Id: Ie0bd636a840c399643b97c43a6e969ca1f97ba32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71092 Tested-by:
-
Oliver Bartsch authored
Elements, transferred to the clipboard are no longer selected after reloading the module. Since introducing multi record selection, the checkboxes are no longer bound to clipboard functionality, which makes selecting elements, just because they were added to a clipboard, pointless. This did anyway never work for elements in the "normal" clipboard. Furthermore did selecting elements always display the corresponding multi record selection actions. Since those actions overlayed the module specific actions, e.g. the link to single table view in the recordlist module, it was no longer possible to execute the module specific actions, as soon as one record had been transferred to clipboard. The old clipboard behaviour allowed to remove items from clipboard by unchecking them and submitting this deselection. With the multi record selection component, this is no longer possible. At least not all elements can be remove, since the actions are only shown if at least one element is selected. To fix this, a new action "Remove from clipboard" is added to the actions bar, allowing to remove a dedicated selection of elements from clipboard. This is anyways more understandable for an editor. Finally the "paste" action is removed from the multi record selection actions as it has nothing to do with the current selection. Resolves: #95225 Related: #95146 Releases: master Change-Id: Ibbdadba1c89ac81f9f440fee5d34600663ad6974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71091 Tested-by:
-
Oliver Bartsch authored
The ModuleTemplate, mostly used in backend controllers previously featured the getIconFactory() and getPageRenderer() methods, which exposed internally used services. Except for a few places, TYPO3 core did no longer use this getters, since it only hides the dependency to the corresponding services. Therefore, the getters are now deprecated. Controllers, relying on the services have to inject them explicitly. Resolves: #95235 Releases: master Change-Id: I92f9546bdfd71f7439e6724af12faefe796182fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71099 Tested-by:
-
- Sep 15, 2021
-
-
Benni Mack authored
This change * removes an unneeded CSS class from all tree items, making the DOM smaller * adds passive listeners for touch events in Resizables. This way browsers do not complain anymore Resolves: #94835 Releases: master Change-Id: Ia240751c9f623c753be80b9fc8063bb536c54481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70482 Tested-by:
-
Christian Kuhn authored
Database columns 'sorting' and 'sorting_foreign' for MM relation tables are hard coded and not a valid TCA configuration option since a long time. Drop two recently added todo's to clearify this. Resolves: #95232 Releases: master Change-Id: I8f874bd2f08eebadc81c5f3a46afbd0970e603c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71096 Tested-by:
-
Wouter Wolters authored
The parent keyword is misused in some places and $this can be used instead. Resolves: #95199 Releases: master Change-Id: I79f7bd041c46210fa1961a93326b02137dcc7abe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71042 Tested-by:
-
Stefan Froemken authored
DebugUtility threw warnings of the type "Undefined array key" which results in error for uncached content in frontend. This warning is fixed in this patch. Resolves: #95211 Releases: master Change-Id: I692f88e1cf123003bfdbef4f8303c41fab855f01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71079 Tested-by:
-
Oliver Bartsch authored
The edit permissions for linked live search suggestions, shown in the the dropdown layer, were previously not properly evaluated. This is now fixed. In case a user does have insufficient edit permissions for a live search suggestion, it won't be linked anymore. Resolves: #95052 Releases: master, 10.4 Change-Id: I84f7beeae8be62d275236779b993bbbf380fb835 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71050 Tested-by:
-
Christian Kuhn authored
The BackendTemplateView is a - usually Extbase backend module related - Fluid view that adds a default backend ModuleTemplate to render backend module content. That implementation has a couple of drawbacks: * Using BackendTemplateView hides a dependency to the request object by triggering a fallback in ModuleTemplate accessing $GLOBALS['TYPO3_REQUEST']. * Using $this->view->getModuleTemplate() is pretty ugly, controllers should work with the ModuleTemplateFactory instead and retrieve an instance of ModuleTemplate using create($request). * The level of indirection by having ModuleTemplate within the view class magically created makes controller actions harder to follow and understand. With extbase Request nowadays implementing ServerRequestInterface we can get rid of this indirection: Controllers should get an instance of ModuleTemplateFactory injected, receive the ModuleTemplate using ->create($request), and add further title and doc header related details using that instance. The patch changes ext:indexed_search, ext:extensionmanager and ext:form to do that, and deprecates BackendTemplateView. Change-Id: I613a560c8fc3c35343e31f397479f0c008a4a314 Resolves: #95164 Related: #92513 Related: #94428 Related: #94209 Related: #93885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70973 Tested-by:
-
Andreas Fernandez authored
To give extension authors the possibility to react on drag&drop events happening in the page module, AjaxDataHandler now emits the `typo3:datahandler:process` event. Resolves: #95069 Releases: master, 10.4 Change-Id: I07956357afa301e77b1bed033113bd8b9dca662d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70859 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Sybille Peters authored
Previously, the pagination controls were sometimes shown on the bottom of the page and sometimes on the top and the bottom (e.g. EXT:form, EXT:redirect). The pagination controls are now only shown on the bottom. This adds more consistency to the user interface. Resolves: #95192 Releases: master Change-Id: Id724a26b4fcb978182160036694b764adc275bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71077 Tested-by:
-
- Sep 14, 2021
-
-
Simon Schaufelberger authored
Remove identical like in hasProtocolAndSchemeDataProvider Resolves: #95215 Releases: master Change-Id: I5341667f5984b1044c375ee42a076fea50aea6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71085 Tested-by:
-
