Skip to content
Snippets Groups Projects
Commit 7159ff8a authored by Simon Schaufelberger's avatar Simon Schaufelberger Committed by Benjamin Franzke
Browse files

[BUGFIX] Fix TypoScriptFrontendController initialization in subrequests

With the introduction of #94402 error pages are fetched via a
sub-request. Manual "page not found" ErrorController invocations
within an extbase action then resulted in rendering the originally
requested page instead of the defined 404 page.
This happened because the PrepareTypoScriptFrontendRendering
middleware hold a reference to the outer TSFE instance which
contains the original page id.

Instead of injecting the stateful TSFE (which is generally discouraged),
TSFE in now passed as request attribute. The container will
log an according warning message from now on.

Resolves: #95174
Releases: master
Change-Id: Ieda58e2bef8f08762fcba06b76df03aff7b10d5c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71084


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarSimon Gilli <typo3@gilbertsoft.org>
Tested-by: default avatarBenjamin Franzke <bfr@qbus.de>
Reviewed-by: default avatarSimon Gilli <typo3@gilbertsoft.org>
Reviewed-by: default avatarBenjamin Franzke <bfr@qbus.de>
parent 6bebc19e
Branches
Tags
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment