- May 31, 2024
-
-
Georg Ringer authored
The stdWrap options stripHtml and htmlSpecialChars requires the value to be a string. A typecast forces the string to avoid exceptions. Resolves: #103085 Releases: main, 12.4 Change-Id: Ia936a19e06fdf954ca3aef442cad34c164e9c54e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84446 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Kienast authored
With migration away from prophecy during v12 development, the variable `$siteMockRevelation` is not needed anymore as phpunit mocks don't know the concept of revelations. Resolves: #103958 Releases: main, 12.4 Change-Id: I92497737dfbba3ef1cd99e4fbd96751e00057a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84449 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Andreas Kienast authored
This commit updates some colors in the color picker component. The dark background is removed from focussed input fields. Also, the input styling now matches FormEngine styling. Resolves: #103891 Releases: main Change-Id: I9a3a9e10c48be0bf49395d388be55cb8c8535693 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84379 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- May 29, 2024
-
-
Garvin Hicking authored
Using '%env(SOME_VARIABLE)%' within a site configuration YAML did not resolve contents in SOME_VARIABLE that were falsy ('false', '0', 0). This patch now properly converts those falsy values to actual values. Tests are added to verify the new behavior and prevent future regressions. Drive-by fix on Unit tests which did not actually remove env vars after testing, putenv('var') is needed instead of putenv('var='), because the latter will keep the environment var around (with an empty value). Resolves: #91710 Releases: main, 12.4 Change-Id: I99d64f080737ada38fd58a63f4e04e5b0d8c9ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84442 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Georg Ringer authored
If no icon is provided for submodule, use a fallback to the icon of the parent module instead of directly using the empty-empty icon. Resolves: #103904 Releases: main, 12.4 Change-Id: I4e989483880fd88df904e9028f1d2cf6cd5c29f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84390 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- May 28, 2024
-
-
Oliver Bartsch authored
For consistency, the redirect demand's default value for the integrity status is now set to NULL, to show all records by default. This is especially important for existing installations, having redirects which do not yet contain a value for the new `integrity_status` field. Resolves: #103900 Related: #99485 Releases: main Change-Id: Iba8dc0180e22f5e31b51e6c33fb71b47b5486238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84382 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
Detail methods of the two TypoScript tokenizers tend to add mental load since they often update `$this` state. The patch changes `splitLines()` and `parseValueForConstants()` to return updated things instead, for consuming methods to take care of this. This is a pre-patch to simplify #102742. Resolves: #103944 Related: #102742 Releases: main, 12.4 Change-Id: I1a5dbccc1bdfbfc52681e323eb1fe9a2b0bb7dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84439 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
<INCLUDE_TYPOSCRIPT: source="DIR:..." condition="[tree.level > 2]"> The TypoScript tokenizers fail here since ">" within the condition is interpreted as "end of INCLUDE_TYPOSCRIPT". Add a couple of tests and fix it. Resolves: #103875 Releases: main, 12.4 Change-Id: I43c59bd61645bee9ce9c175b00ce1d2cba44c023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84346 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 27, 2024
-
-
Christian Kuhn authored
There is little point extracting single widget configuration to an own file - we don't split Services.yaml in any other extension. Merge DashboardWidgets.yaml into Services.yaml. Resolves: #103936 Releases: main Change-Id: I00ba601a57942fc543728c87404f0944a307bf0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84425 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Benjamin Franzke authored
Add a filename context to page.tsconfig include nodes (autoloaded from extensions Configuration folder or from site sets) in order to allow relative imports to be resolved. Releases: main, 12.4 Resolves: #79737 Related: #97816 Change-Id: Id6404127b667a61e013d4e5b528048201ad0e6c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83712 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator and removes the null default value for the first parameter, which mitigates both issues. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103927 Releases: main, 12.4, 11.5 Change-Id: I0ba574769e5b95852379aa30f03d45715aec2055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84416 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Ayke Halder authored
This enables the already available `phpstan-phpunit` rules: * PHPStan\Rules\PHPUnit\AssertSameBooleanExpectedRule * PHPStan\Rules\PHPUnit\AssertSameNullExpectedRule * PHPStan\Rules\PHPUnit\AssertSameWithCountRule * PHPStan\Rules\PHPUnit\MockMethodCallRule * PHPStan\Rules\PHPUnit\ShouldCallParentMethodsRule `ShouldCallParentMethodsRule` is of great interest: It checks for missing calls to `parent::setUp` and `parent::tearDown`. `AssertSameWithCountRule` replaces `assertSame($expectedCount, count($variable))` with `assertCount($expectedCount, $variable)`. Resolves: #103880 Related: #103929 Releases: main Change-Id: I43a69d0dcf342cc65d34eb03f2d9800b1e70e8a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84351 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Stefan Bürk authored
This change modifies the `runTests.sh` helptext to mention the `checkIntegrityPhp` correctly added with #103465. Resolves: #103930 Related: #103465 Releases: main Change-Id: I0ffdb66236bbc0c82f702cf960bf9462dedbdfcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84419 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Christian Kuhn authored
Using PHP attributes to configure DI within classes directly is more easy to understand since developers don't need to constantly look up DI configuration Services.yaml files, but have everything in one place. The patch switches all classes that previously used '@cache.xy' to get a specific cache injected to an `Autowire` attribute. Resolves: #103921 Releases: main Change-Id: I16b064242cdbc2bbcfbed89700c97afac012fdf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84406 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84415 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Garvin Hicking authored
Using the methods does not improve output, but makes reading harder: A first wantTo() changes the title of a test within the output - that is usually derived from the test method name - to the wantTo() message. This leads to things like different tests having the same name. Our test names are good, use them! Any second or other use of wantTo() does nothing in the output at all. The patch removes wantTo() and wantToTest() (similar behavior), and turns some of them into code comments. This should make the test logs more easy to understand and follow. Resolves: #103916 Releases: main Change-Id: Ie88d8fd937151c1b471cfa3b4743e7639bf2c7fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84403 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Resolves: #103933 Releases: main Change-Id: Ic1626081bf0f4ee2159543be1fe6cdfc80b9b4e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84421 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes code to mock Connection methods conditionally, based on their existance surrounded by a `@todo` comment to remove this, when `doctrine/dbal` has been required with 2.11.0 as minimal version. The version raise has been done already a long time ago, however the removal of this conditional test mock has been missed. This change removes the conditional mocking now. Resolves: #103929 Releases: main, 12.4, 11.5 Change-Id: I4cc2d5942149f69e044c25379c82388f1c4b9f45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84418 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Ayke Halder <mail@ayke-halder.de>
-
- May 26, 2024
-
-
Christian Kuhn authored
$this->count() in phpunit always returns 1 and has no arguments as correctly found by phpstan. Fix a test to actually assert subject result count. Resolves: #103924 Releases: main, 12.4 Change-Id: I396b695eaeaa986a4cd9883e028ed6032d2f6339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84412 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
GeneralUtility::callUserFunction() has only three parameters, as detected by phpstan. Resolves: #103923 Releases: main, 12.4 Change-Id: I31fc48f343558dd2e0d73feeb3933e249fa625a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84410 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Two unit tests are skipped since they try to verify correct behavior while the system under test returns something broken or not implemented. The patch activates the tests to document the broken behavior and adds `@todo` annotations explaining what is going wrong or should be expected. Resolves: #103922 Releases: main Change-Id: Ib93bfa6baa3cb8369e084bd01a7dd0d40c7a4bee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84409 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
With `@touch()` being changed to `touch()` with #103911, its now clear the random fail stems from the test not being able to create the file sometimes: touch(): Unable to create file /builds/typo3/CI/cms/typo3temp/var/lock/../../var/lock/foo because No such file or directory This also explains why it happens in unitRandom on CI only: Usually this test is run after some previous test created typo3temp already, with unitRandom it may be rejuggled so typo3temp does not exist yet. Also, local machines typically have this directory after a first unit test run, which is why the test fails on CI only, since CI always starts with a 'git clean' directory state. The patch changes the test to make sure the directory path is created before the fixture file is touched. Resolves: #103920 Related: #103911 Releases: main Change-Id: I1cbb23b99860f2dbb158995a8c041cdef34a5e35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84408 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Full class is set readonly, no need to set it for a single constructor argument. Resolves: #103918 Related: #103437 Releases: main Change-Id: Ide8580bb12d15f5b23caa4b96372b72a0f38e8f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84405 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
Change #101653 introduced the auto-creation of DB fields for TCA type "check", but used a hardcoded "0" as default. Since TCA definitions might define a different default, and records may not always be created using the DataHandler to respect TCA defaults, this can lead to DB entries getting created with an unexpected default setting. IMPORTANT: This patch only fixes the root cause of the bug. If an existing v13 installation has already created new records after the DB migration wizard update in 13.0, all records may have wrong defaults. Check the contents of your database for the fields listed below and apply manual adjustments as needed (for example, record storages having "auto_extract_metadata"=1 instead of 0). An example symptom of this is the auto-creation of a file storage record, which uses the QueryBuilder to create a record, without specifying the whole list of all possible fields. For example then leading to added YouTube media files not auto-creating metadata records. This patch uses the proper evaluation of the TCA "default" setting of an auto-created field. In TYPO3 Core this only affected `be_users.options` and `sys_file_storage.auto_extract_metadata` default record creation. The latter field has now been included to the default record creation as a fixed value like the others. A follow-up patch could rewrite this functionality using the DataHandler or QueryBuilder default value injection. Tests have been created to verify this regression, existing tests for be_user creation have been adapted for the proper default values. Executing the DB schema analyzer will now adjust the following fields: * be_users.options (0->3) * sys_file_storage.is_browsable (0->1) * sys_file_storage.is_writable (0->1) * sys_file_storage.is_online (0->1) * sys_file_storage.auto_extract_metadata (0->1) * sys_file_metadata.visible (0->1) * tt_content.sectionIndex (0->1) * tx_styleguide_palette.palette_1_1 (0->1) * tx_styleguide_palette.palette_1_3 (0->1) * tx_styleguide_valuesdefault.checkbox_1 (0->1) * tx_styleguide_valuesdefault.checkbox_2 (0->1) * tx_styleguide_valuesdefault.checkbox_3 (0->5) * tx_styleguide_valuesdefault.checkbox_4 (0->5) * sys_workspace.edit_allow_notificaton_settings (0->3) * sys_workspace.edit_notification_preselection (0->2) * sys_workspace.publish_allow_notificaton_settings (0->3) * sys_workspace.publish_notification_preselection (0->1) * sys_workspace.execute_allow_notificaton_settings (0->3) * sys_workspace.execute_notification_preselection (0->3) * sys_workspace_stage.allow_notificaton_settings (0->3) * sys_workspace_stage.notification_preselection (0->8) Resolves: #103915 Related: #101653 Releases: main Change-Id: Ia42e00b03d1369efe319e41e2b406b5303804854 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84402 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Wand <wand@itaw.de> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
And rename the method since those general getButtons() methods are ugly. Resolves: #103914 Related: #103903 Releases: main, 12.4 Change-Id: Iaa428d711b98d2bf178aa0ba54ab507f7ca1c09b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84399 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 25, 2024
-
-
Robert Silén authored
TYPO3 works with various DBMS. Avoid a specific mention of MySQL in README.md, the version matrix reveals details. Releases: main, 12.4 Resolves: #103719 Change-Id: I38cc50be00838643cb0095b3c848ef1d8a0c3014 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84015 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Georg Ringer authored
The shortcut button requires the resolved name as display name and not the LLL path. Resolves: #103903 Releases: main, 12.4 Change-Id: I59e38bf9c40f0a940fecb6ac3178b2976f168069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84388 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Torben Hansen <derhansen@gmail.com>
-
Lina Wolf authored
There is no word 'postparation' according to native speaker Sarah McCarthy. And also the sentence was hard to understand for non-native speakers. The command is not only useful during deployment so we mention other usecases. Resolves: #103857 Releases: main, 12.4 Change-Id: I602d8fe70ccbe6831278669fb2078318be4bcf63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84312 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
* Set this internal method to protected * Add type hints for two arguments that are safe to set * Skip BU::isTableLocalizable(), and check state of the two main TCA 'ctrl' props with an early return instead * add @todo for incomplete use of getTSconfig_pidValue() results * $this->BE_USER->workspace is always an int, skip cast * fetchAllAssociative() always returns an array, remove an if and return early with empty result set instead Resolves: #103912 Related: #103828 Releases: main Change-Id: I3d11822c40c0c58474225ba95ff86c5b672c9f7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84397 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.1.1 npm run build Resolves: #103890 Releases: main Change-Id: Id8cd17bbb1142a0522e1fd80f7dbd0f83455720a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84378 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
releaseDoesNotRemoveFilesNotWithinTypo3TempLocksDirectory() is a bit flaky on CI. This seems to happen occassionally with unitRandom, but is hard to track down, and there may be multiple reasons. One possible reason is that touch() fails, maybe due to a different test changing Environment, but not resetting it. Unfortunately, we do not see a warning when touch() fails since it is suppressed with `@`. This was introduced in #88255, then skipping the test, and that skip operation has been removed with #102110. To see if the touch operation is the root of all evil, we'll for now remove the `@` again to potentially receive a php warning with an early fail. This may make this situation reproducible locally, to drill down the true reason of this occassional fail. Resolves: #103911 Related: #88255 Related: #102110 Releases: main Change-Id: I642df9579751e1415c2aa6edb9c27b1aff6d8454 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84396 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Georg Ringer authored
The configuration `foreign_table` of the type `select` is optional. Add a check to avoid PHP warnings. Resolves: #103825 Releases: main, 12.4, 11.5 Change-Id: I65925bae287a0ed340c67923ac4e4a2c72ce9d28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84391 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
André Buchmann authored
When records are copied, DataHandler copies its localizations as well. This is good, but can lead to "orphan" localization records if the target page a record is copied to is not localized to that language. This is inconsistent and leads to various headaches with access rights and when localized records are synchronized later. Also, such localized records suddenly appear, when the parent page is localized to the missing target language, which is an unexpected behavior for BE editors. The patch changes this by skipping copying localizations of records when the target page is not localized to that language. Note DH method copyL10nOverlayRecords() will receive another clean up with another patch to rule out some shenanigans we stumbled upon when implementing this solution. Resolves: #103828 Releases: main Change-Id: Iee5530a5c6dc29180c423301b07f8cf7ecf84fc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84237 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Anja Leichsenring authored
The test setup used a dataProvider and in order to get it's own setup right, it reverses and resets leftover instances from the previous run. It is way easier to split the test setup according the admin flag, that decides about the resets, and run on a clear dedicated environment. Additionally, the system under test is in itself a mocked instance, which is neither necessary in this case, nor generally recommended. The mock has been resolved. Resolves: #103901 Releases: main, 12.4, 11.5 Change-Id: If40ef38a0e0fc2e73dd5f0bc8caff923cc48d661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84385 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
The @deprecated QueryBuilder->setParameter() annotation for $type does not reflect current signature. Remove it and clean up the other annotations, too. Resolves: #103907 Related: #102875 Releases: main Change-Id: I48215038c1d1d179bb7a44ea29bfaffccf9692a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84389 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com>
-
- May 24, 2024
-
-
Georg Ringer authored
Instead of prefixing the type (user, group) for every option an optgroup is used. With this change it is possible to use the keyboard to jump to a specific letter. Furthermore BackendUtility::getRecordTitle is used to retrieve the label instead of using a hardcoded field name. Resolves: #103893 Releases: main, 12.4 Change-Id: I6e9bcd46c2b953660c1b4419eaf567c2d8dc8c80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84380 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Benni Mack authored
This change adds a new RecordCollector which is similar to CONTENT cObject, except that it does not render the records directly, but instead creates instances of a generic Record object, so the Templating Engine can deal with the way of how the record should be rendered. Based on the Page Layout / Backend Layout, all registered colPos contents are fetched, and grouped, if the Backend Layout has an "identifier" set via a new PageContentFetchingProcessor ("page-content"). The slide functionality can now be defined in the Page Layout as well (Backend Layout), with a Enum defining to Collect, CollectReverse and a simple Slide logic. This feature brings a clearer separation of fetching content from the database and the actual representation in the output (fluid) in place, allowing for further optimizations. In addition, one needs to write much less TypoScript to fetch all contents from a page. Next steps is then to enrich the records with their relations (see next feature), and to optimize the Fluid-based rendering for any kind of content. Resolves: #103894 Releases: main Change-Id: I6a1a0efacefe8c83e86b9551b00199c93e284a28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83638 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Torben Hansen authored
This change removes a 5 years old todo in extbase persistence backend. Although the affected feature `newRecordStoragePid` currently is not documented, it is used in various TER extensions and most likely also in custom projects. In relation to this change, a PR for the TYPO3 documentation has been created on GitHub, so the setting will be documented. Resolves: #103895 Releases: main, 12.4 Change-Id: I5c5cf7e87fdb50ab08e409e69aff2b373d39a022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84381 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Andreas Kienast authored
Previously, the internal method `loadFromServer()` from the module `@typo3/backend/storage/persistent` fetched the data, wrote it into an internal property `data` and also returned it. The code is now simplified to only return the response. Setting `data` is now done within the public `get()` method, which is now also simplified a bit. Resolves: #103886 Releases: main Change-Id: I975a6ad0c2761afdadadfdc05dfa9c11a47779fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84374 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Marvin Buchmann <marvin.buchmann@typo3.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
The GenericMetaTagManager as well as the abstract class (used by extensions) does now properly respect the current doctype and therefore omits the ending slash at the end for HTML5. Resolves: #102058 Releases: main, 12.4 Change-Id: I4ce6bcb61a44aff6eda738f52fe2f2548818ee95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84375 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de>
-