- Sep 07, 2023
-
-
Benjamin Franzke authored
All in-tree .js files have been migrated to TypeScript, so it's time to add a CI check to ensure no stray build files (see #101786) or non-updated JavaScript files (e.g. #101784, #101785, #101787) are present in the git tree. Resolves: #101783 Related: #101784 Related: #101785 Related: #101786 Related: #101787 Releases: main, 12.4 Change-Id: I02aeaaeaae7fa0df634f39cb151f4316240936ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Aug 08, 2023
-
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80367 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Aug 07, 2023
-
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80428 Tested-by:
-
- Jul 31, 2023
-
-
Christian Kuhn authored
Creating reports.xml in acceptance tests and feeding this to gitlab has been added with issue #96628 in the hope to be useful for finding frequently failing ac tests. The gitlab UI however buries this, it's de facto impossible to make use of this information. We drop this definition again. Resolves: #101514 Related: #96628 Releases: main, 12.4, 11.5 Change-Id: I91f13f402f0b9f72f2ca41252db93bb1714efcd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80287 Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
- Jul 29, 2023
-
-
Benjamin Franzke authored
Releases: main, 12.4, 11.5 Resolves: #101482 Change-Id: Id23a78cdb85c3b58a0ce79eacbc5626c27cde46b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80217 Tested-by:
-
- Jul 28, 2023
-
-
Christian Kuhn authored
As a preparation towards podman as container executor next to docker, runTests.sh is refactored a bit: * Image names now always have a host prefix like docker.io/ or ghcr.io/, except on CI, which will change later, too. podman needs those prefixes and does not fall back to docker.io if it's missing: "redis:latest" -> "docker.io/redis:latest" * Image names are now put into variables. * Rename "docker" to "container" in variables. * Have a variable for the container binary, set to "docker" for now. * Change the cleanUp() function slightly, it will later work with both docker and podman this way. Resolves: #101470 Related: #97566 Releases: main, 12.4, 11.5 Change-Id: Ifab85468dff5c21564611a45568d11e8559e155c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80202 Tested-by:
-
- Jul 25, 2023
-
-
Jochen Roth authored
runTests.sh uses of docker-compose to run tests. The patch ditches docker-compose in favor of direct docker cli commands for the following reasons: * runTests.sh is more concise and does not need to deal with writing a .env for docker-compose anymore. * Establish a foundation to use podman as alternative container runner. * Ditch the lengthy docker-compose.yml file that repeats things over and over again. * Better control of running containers. * Allow running multiple runTests.sh instances in parallel without disturbing each other by establishing unique names for networks and containers. * Minor performance improvements by getting rid of the docker-compose python overhead. * Simplified quoting in scripts. * Less path headaches. Resolves: #97566 Releases: main, 12.4, 11.5 Change-Id: I7ae50d1cec4c770b54dc9d4a1053420ad85f5ff0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80124 Reviewed-by:
-
- Jul 19, 2023
-
-
Christian Kuhn authored
Some rather minor script modifications in runTests.sh to prepare #97566 Resolves: #101389 Related: #97566 Releases: main, 12.4, 11.5 Change-Id: I35e2acd7848f5b49c2a1359d2e976cb553d72ac0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80094 Tested-by:
-
- Jun 09, 2023
-
-
Stefan Bürk authored
This change adds basic support for PHP8.3 to `Build/Scripts/runTests.sh`. That is done to get an early chance to evaluate how the core is behaving against the upcoming PHP version. Note, no ci runs added for now. First current existing issues should be fixed first to make tests green before enabling it for CI runs. Resolves: #100984 Releases: main, 12.4, 11.5 Change-Id: Icefa0a83f860672ff0d688acb1968185e0bc3053 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79219 Tested-by:
-
- May 03, 2023
-
-
Stefan Bürk authored
Adjustes gitlab workflow configurations to match branch `12.4` testing. This includes dedicated cache keys and setting to not run after merge on branch `12.4`. Additionally, setting `COMPOSER_ROOT_VERSION` environment variable is reintroduced to `Build/Scripts/runTests.sh`. That ensures, that composer can detect the correct root version. Resolves: #100800 Releases: 12.4 Change-Id: I640ee609c28e53f6c1ede468c2629214d1a52187 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78930 Tested-by:
-
- Apr 21, 2023
-
-
Christian Kuhn authored
We established a language and country database with related issues provided by core in v12. Data is fetched from a debian repository, available via sokil/php-isocodes-db-i18n. Script Build/Scripts/updateIsoDatabase.php creates core files based on this. The patch adds a nightly run that fetches latest dependencies, calls the update script and looks if core files have been changed. This gives us a red nightly as soon as TYPO3 files need an update due to upstream changes. When nightly goes red, a patch should be merged that incorporates the changes done by this run: > Build/Scripts/runTests.sh -s checkIsoDatabase Resolves: #100709 Related: #100659 Related: #99642 Related: #99618 Releases: main Change-Id: I2982a1a09a6e3012e92c7dad0fde8d0468f9708a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78788 Tested-by:
-
- Apr 16, 2023
-
-
Stefan Bürk authored
The docker container image hub is slowly becoming more and more problematic for open source organisations, it's time to move to another container registry for core-testing images. Images are now build and published to both Docker HUB and GitHub Container Registry (`ghcr.io`). To test the ghcr.io images, the patch changes runTests.sh to use them them for local (non CI) execution already. We can not fully switch to ghcr.io yet, since CI uses the docker registry container as mirror for images to heavily reduce network load and increase performance. The registry container however can only mirror hub.docker.io images, so we need a different solution for CI first. When this is done, we'll stop uploading images to docker hub later. Resolves: #100617 Releases: main, 11.5, 10.4 Change-Id: Ia309826618696dc25b15527b73fa704235285479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78665 Reviewed-by:
-
- Apr 15, 2023
-
-
Christian Kuhn authored
Switch to phpunit:^10.1.0 as minimum version, removing phpunit:^9 in core main. Clean up a test case, clean up temporary CI setup, switch to new phpunit xml config files, raise some acceptance test related dependencies. > composer req --dev phpunit/phpunit:^10.1.0 -w > composer req --dev codeception/module-webdriver:^4.0.0 > composer req --dev php-webdriver/webdriver:^1.14.0 Change-Id: I3f11355aa5a11f3ca879b09c64821ce3f89fe1c1 Resolves: #100608 Resolves: #100249 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78649 Tested-by:
-
- Apr 11, 2023
-
-
Wouter Wolters authored
Test classes should never extend each other. phpunit 10 is also a bit more picky about naming of abstract test cases. The patch adds a script to verify all test case files are declared final, adds it to CI, and adapts existing tests accordingly. > Build/Scripts/runTests.sh -s checkTestClassFinal Change-Id: I07581bffebe42a82fafc56a9bc6cae7c46508b1a Resolves: #100544 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78460 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 06, 2023
-
-
Christian Kuhn authored
Functional deprecated tests are quite easy to fix for phpunit 10: Just some static data providers. We do the same as with "casual" functional tests: Temporarily allowing execution with phpunit 10 in runTests.sh in addition to phpunit 9, plus CI addition. Resolves: #100507 Related: #100249 Releases: main Change-Id: I31e012c558214b55ba24cbd311f918ef54ab0111 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78513 Reviewed-by:
-
Christian Kuhn authored
Unit deprecated tests are quite easy to fix for phpunit 10: Just static data providers and a single broken test case usage. We do the same as with "casual" unit tests: Temporarily allowing execution with phpunit 10 in runTests.sh in addition to phpunit 9, plus CI addition. Resolves: #100495 Related: #100249 Releases: main Change-Id: I7120d434d25352c27d170011b4f37cfd2a870cf9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78504 Tested-by:
-
Christian Kuhn authored
Casual local systems should have young enough docker and docker-compose versions meanwhile, and PHP 8.2 runs with xdebug without issues. Resolves: #100496 Releases: main Change-Id: Ia8366ed33ac184a1d6bc1b9d1d06b492c1925a34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78505 Tested-by:
-
Stefan Bürk authored
This changed adjusts the `Build/Scripts/runTests.sh` support for the different database types and versions. That means, which version for which types can be selected for functional and/or acceptance tests. Additionally, the help text output is enhanced to list information about the support of database versions provided by the vendors, on actual published release informations: * https://mariadb.com/kb/en/mariadb-server-release-dates/ * https://www.postgresql.org/support/versioning/ * https://endoflife.software/applications/databases/mysql Available versions are choosen for supported versions of the TYPO3 core version, see following matrix as generic overview. **NOTE** Be aware, that this does not mean that tests are green with all version. This only enables execution through `Build/Scripts/runTests.sh` for now. `CI` adjustments are done afterwards in a dedicated shuffle change. mysql ----- * 5.5 unmaintained since 2018-12 (11.5, 10.4) * 5.6 unmaintained since 2021-02 (11.5, 10.4) * 5.7 maintained until 2023-10 (11.5, 10.4) * 8.0 maintained until 2026-04 (main, 11.5) mariadb ------- * 10.1 short-term, no longer maintained (11.5, 10.4) * 10.2 short-term, no longer maintained (11.5, 10.4) * 10.3 short-term, maintained until 2023-05-25 (main, 11.5, 10.4) * 10.4 short-term, maintained until 2024-06-18 (main, 11.5, 10.4) * 10.5 short-term, maintained until 2025-06-24 (main, 11.5, 10.4) * 10.6 long-term, maintained until 2026-06 (main, 11.5, 10.4) * 10.7 short-term, no longer maintained (main, 11.5, 10.4) * 10.8 short-term, maintained until 2023-05 (main, 11.5, 10.4) * 10.9 short-term, maintained until 2023-08 (main, 11.5, 10.4) * 10.10 short-term, maintained until 2023-11 (main, 11.5, 10.4) * 10.11 long-term, maintained until 2028-02 (main, 11.5, 10.4) * 11.0 development series (main) [not working] * 11.1 short-term development series (main) [not working] postgres -------- * 9.6 unmaintained since 2021-11-11 (11.5, 10.4) * 10 unmaintained since 2022-11-10 (main, 11.5, 10.4) * 11 maintained until 2023-11-09 (main, 11.5, 10.4) * 12 maintained until 2024-11-14 (main, 11.5, 10.4) * 13 maintained until 2025-11-13 (main, 11.5, 10.4) * 14 maintained until 2026-11-12 (main, 11.5, 10.4) * 15 maintained until 2027-11-11 (main, 11.5, 10.4) Resolves: #100492 Releases: main, 11.5, 10.4 Change-Id: Iac5d4f799fd05ed7b766d1a9db95481caea2f898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78498 Tested-by:
-
- Apr 05, 2023
-
-
Christian Kuhn authored
This is a temporary, a bit hacky solution to run the functional tests with phpunit 10 next to phpunit 9 for now. Goal is to ensure they don't break again. We'll later remove phpunit 9, but need to still sort out some further details. Resolves: #100490 Related: #100249 Releases: main Change-Id: I2b0d2b6abfec9236bc2f3f819b080338111b21ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78495 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Apr 04, 2023
-
-
Christian Kuhn authored
Unit tests with phpunit 10 are green for now. We temporarily add them to the CI test suite to ensure they don't break again. This will be kept until other suites are green as well, and further details have been sorted out. We'll later ditch phpunit 9 entirely, but need further patches, first. > Build/Scripts/runTests.sh -s unit10 Note this changes composer.json and composer.lock locally and needs to be used with care. Resolves: #100445 Related: #100249 Releases: main Change-Id: I7ec0a0752b01ddb3564bb13d79d4ad9f1450d21d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78458 Tested-by:
-
- Dec 29, 2022
-
-
Jochen Roth authored
Currently, mariadb is only supported up to v10.6. This has been changed up to v10.10 and jobs have been added to the ci pipeline. And on top v15 of postgres has been added for testing purposes only. Resolves: #99362 Releases: main, 11.5 Change-Id: I0202de4d3138b747b01e6cf0c32dc16b4ad398eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77123 Tested-by:
-
- Aug 26, 2022
-
-
Stefan Bürk authored
Core php file header check got silently be disabled. Since then the one or other file header error has slipped into the core. It also pops up from time to time in reviews of patches that file headers are missing (or are wrong). This change ensures that file headers are checked again and can be fixed by given contributers the proper tools at hand. Changes: * add cglFixMyCommitFileHeader.(sh|bat) * add cglHeader and cglHeaderGit to runTests.sh along with proper help text * extend pre-commit hook to execute both fixer scripts side-by-side with error output and fixing possibility * fix minor issue with header comment php-cs-fixer config Additionally the cglHeader check is added to gitlab workflow pre-merge (commit files) and nightly (all files). Slipped in errors has been fixed with a dedicated change #98204. Resolves: #98203 Related: #98204 Releases: main Change-Id: I9567d1dcf8fb53d4901a575213c0ff16dc33ffd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75549 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Aug 05, 2022
-
-
Stefan Bürk authored
Quite some issues with docker-compose v2 have been fixed We'll now try to use it again and remove a v1 restriction in `Build/Scripts/runTests.sh`. Resolves: #98086 Releases: main, 11.5, 10.4 Change-Id: I7e4ff82df374db33ba42db0e0d1483f6320ba9ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75374 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
- Jul 31, 2022
-
-
Stefan Bürk authored
Codeception released new major version 5, which unblocks upgrading to symfony 6 components. This patch raises codeception only, thus acting as a pre-patch to raise symfony requirements. Codeception 5 is hard to impossible with core v11, so this patch is v12 only: Codeception 5 requires PHP 8.0, so we'd have to support both 4 and 5 in v11 to allow testing with older PHP versions. This would result in various headaches since some API changes in codeception 5 are hard breaking in PHP, especially due to changed class property type hints. We'll thus keep codeception 4 in v11 and go with codeception 5 in v12. Minor acceptance test related adaptions are needed: * Replaced config option `path.log` with `path.output` * Added proper property type because of inheritance to codeception setup classes * Ensure method return type compatibility * Use `actor`instead of `class name` in suite config * Create acceptance split files in proper folder to ensure group filtering keeps working. Adjust clean up scripts and gitignore for this Used commands: > composer req --dev -w \ typo3/testing-framework:dev-main \ codeception/codeception:^5.0.0 \ codeception/module-asserts:^3.0.0 \ codeception/module-cli:^2.0.0 \ codeception/module-filesystem:^3.0.0 \ codeception/module-webdriver:^3.1.2 \ codeception/lib-asserts:^2.0.0 Resolves: #98047 Releases: main Change-Id: I5cea60c2641988cc032b30ed1fbe3d8b0ed3b3d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75317 Tested-by:
-
- Jul 01, 2022
-
-
Stefan Bürk authored
xdebug does not have an official compatible version which can be used with PHP8.2, and thus xdebug had been missing in the PHP8.2 alpha1 image. To avoid using xdebug with PHP8.2 this had been guarded with a corresponding check in `runTests.sh`. `typo3/core-testing-php82` docker image has since been rebuilt with PHP8.2 alpha2 and using a fork of xdebug, which compiles the extension against PHP8.2. The check in `runTests.sh` is now removed again in order to allow early xdebug-ging using `Build/Scripts/runTests.sh`. Resolves: #97811 Releases: main, 11.5 Change-Id: Ie9b6795873f38e0a8ea98cfabe4acf7de9ef2056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74983 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
- Jun 19, 2022
-
-
Stefan Bürk authored
This patch adds a script to scan and verify namespace of core class and test files to be PSR-4 compliant. It uses provided namespace registration in core system extensions and root composer file for test namespace registrations. Test fixture test extensions are ignored for now. Check for these will be enabled in a dedicated patch, after streamling of fixture test extensions has been done. Resolves: #97790 Releases: main, 11.5 Change-Id: I36d2946891f2e12dd140b98075a13a65f0b70bb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74930 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Jun 11, 2022
-
-
Stefan Bürk authored
This change adds the ability to clean rendered documentation folder and files in all system extension folders in one go. Mentioned folders are `typo3/sysext/*/Documentation-GENERATED-temp`. Added command/testsuite: * `Build/Scripts/runTests.sh -s cleanRenderedDocumentation` Additionally the already combined cleaning command `-s clean` is extended to delete rendered documentation in the same run. Resolves: #97673 Releases: main, 11.5, 10.4 Change-Id: I344f897769cd5f475d43db67dd1b27693f49a658 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74717 Tested-by:
-
- Jun 10, 2022
-
-
Stefan Bürk authored
This patch adds the ability to run commands with PHP8.2 using `Build/Scripts/runTests.sh`. Support is added early to check which issues may raise up with new major PHP version. Help text of script is adopted to state the possibility of the new PHP version with proper example commands. Additionally, a note and check for currently not supported xdebug with PHP8.2 is added. Resolves: #97755 Releases: main, 11.5 Change-Id: I9df13d35278793fba8c5475c8abd602bd1c27896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74869 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- May 07, 2022
-
-
Stefan Bürk authored
phpstan parallel execution is limited to a maximum of 5 processes to be a nice neighbor when executed during core CI runs. This however leads to longer execution times when executed on local developer machines with many available CPU's. This patch introduces two separated phpstan config file entrypoints, one for local and one for CI. They are automatically selected in runTests.sh based on existence of a CI env variable. Resolves: #97571 Releases: main, 11.5 Change-Id: I14bf13412de7a2471703e7982dad4030ae6ba735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74536 Tested-by:
-
- May 04, 2022
-
-
Jochen Roth authored
Currently acceptance tests do not work on arm64 (Apple M1) due to the lack of support in the selenium docker image. This has been fixed by detecting arm64 and switch to arm64 compatible image (seleniarm/standalone-chromium). Resolves: #97541 Releases: main, 11.5, 10.4 Change-Id: I531e7e1d7f0f11a1c6d850699eee3b4a9aa3e5d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74502 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Apr 27, 2022
-
-
Stefan Bürk authored
composer v2 is no longer an experimental feature of Docker Desktop for MacOS/Windows. Broken composer v2 error message should be updated to give proper actual information how to disable it correctly. Resolves: #97489 Releases: main, 11.5, 10.4 Change-Id: I7c4199e5d3d3c47bbadba8210cc96b0385ab6fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74448 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
- Apr 25, 2022
-
-
Stefan Bürk authored
Add script to 'Build/Scripts/runTests.sh' to clean build and test related files and folders to get fast a clean state. Local instance related files are untouched and kept intact. Added commands: > Build/Scripts/runTests.sh -s clean > Build/Scripts/runTests.sh -s cleanBuild > Build/Scripts/runTests.sh -s cleanCache > Build/Scripts/runTests.sh -s cleanTests Resolves: #97355 Releases: main, 11.5, 10.4 Change-Id: I05c9dd966f4703315474e369dad52b1a40881c60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74267 Tested-by:
-
Stefan Bürk authored
New versions for MariaDB and PostgreSQL has been released in the meanwhile, which falls into the supported range. Also not considered for automated testing yet, support to run it them at least locally on development machines should be added. This patch adds following versions: * MariaDB version '10.6' and '10.7' for argument '-i' * PostgreSQL version '14' for argument '-k' Missed removing of no longer availabe versions in the runTests.sh help text is done as side cleanup. Example commands: > Build/Scripts/runTests.sh -s functional -d mariadb -i 10.6 > Build/Scripts/runTests.sh -s functional -d mariadb -i 10.7 > Build/Scripts/runTests.sh -s functional -d postgres -k 14 Resolves: #97464 Releases: main, 11.5 Change-Id: I096905c49979395f6b53e40edd692f690dadbfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74383 Tested-by:
-
- Apr 20, 2022
-
-
Stefan Bürk authored
Over time dangling local anonymous docker volumes pollutes local docker environments and consuming space on core contributors discs. This patch additionally removes dangling, unused anonymous local docker volumes when updating core testing images are requested with: > Build/Scripts/runTests.sh -u Resolves: #97361 Releases: main, 11.5, 10.4 Change-Id: I6b25a88a9ff119035eea7d5efd6c415bd490a3eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74271 Tested-by:
-
- Apr 06, 2022
-
-
Stefan Bürk authored
The check for doing the functional test splitting script and running the selected chunk used similar but different minimum chunk value to check against. Thus the splitting script has not been executed in all chunk execution contexts. This patch uses now exactly the same check in the 'Build/Scripts/runTests.sh' like it is defined in the corresponding docker-compose service config. Furthermore all previous created functional split files are now removed to avoid leftovers, which occured if re-run has lower chunksize defined. Example which is now properly fixed: > Build/Scripts/runTests.sh -s functional -c 1/1 Example with partial part files from previous run: > Build/Scripts/runTests.sh -s functional -c 1/10 > Build/Scripts/runTests.sh -s functional -c 1/8 Resolves: #97283 Releases: main, 11.5, 10.4 Change-Id: Id3a0d1c85540b4e7e46aaea69cf2d96839e8e72e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74157 Tested-by:
-
- Mar 31, 2022
-
-
Christian Kuhn authored
When core functional tests started to heavily rely on CSV based import- and assertion files, we found that editing such .csv files in Microsoft Excel leads to warnings if the number of columns is not identical for each row. Script checkIntegrityCsvFixtures.php has then been established to verify all rows of .csv fixture files have the same amount of fields per file, and has been enabled as CI job to ensure all existing fixture files follow this. Nowadays, this restriction feels archaic: Devs actively working with these CSV files typically edit them in an IDE like PhpStorm directly and don't use Excel for this anymore. The PhpStorm plugin "Rainbox CSV" also helps by coloring these files and other alternatives like libreoffice do not have this 'all rows must have same number of colums' restriction. The patch drops the script, the runTests.sh usage and the CI calls. This has the additional advantage that line breaks for single fields are now possible, which will further improve handling and readability of field values in upcoming patches. Resolves: #97274 Related: #83943 Releases: main, 11.5, 10.4 Change-Id: I2b4c2afc98c8471bccae1afb15e055182b563ee7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74129 Tested-by:
Jan Helke <jh@f7.de> Tested-by:
-
- Jan 29, 2022
-
-
Stefan Bürk authored
We currently have the situation that phpstan is hard to update and maintain due to the phpstan config file that sets very specific rulesets. This is unfortunate since phpstan tends to change and rename rules at will. The general usage API of phpstan is basically as follows: Have a slim config file that sets the basic level. Then maintain a 'baseline' file that lists violations, using the --generate-baseline command option. The todo job for people working on phpstan errors is then to look at the baseline file, pick up some issues, fix them, then re-generate baseline. When baseline is small enough, the level is raised, a new baseline is generated, and the fix-job starts again. The patch does exactly this: The existing config is dropped and runTests.sh receives a command to generate baseline. With this in place, we can easily raise phpstan to a PHP 8.1 compatible version: > composer req friendsoftypo3/phpstan-typo3:"^0.9.0" --dev > composer req phpstan/phpstan:"^1.4.3" --dev > Build/Script/runTests.sh -s phpstanGenerateBaseline This initialy adds about 4000 ignores to the baseline with level 3, but we can reduce this drastically with just a couple of dedicated patches, soon. The config is heavily streamlined and for instance does *not* ignore tests anymore, which actually finds a ton of misuses and bugs within tests and classes. Resolves: #96675 Releases: main, 11.5 Change-Id: I0e7ff7aa796e59a2c5eedde0b673f741f8b87dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73037 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Jan 21, 2022
-
-
Christian Kuhn authored
Change the default DBMS for functional tests in runTests.sh from mariadb to sqlite: sqlite is sigificantly quicker with functional tests and thus the preferred DBMS selection when running tests locally for us lazy devs since we can omit the '-d sqlite' option now. This has no impact on CI since the DBMS is always explicitly set in gitlab-ci configs. Resolves: #96585 Releases: main, 11.5 Change-Id: I93b68f48a409fc1afb14d8a2aecbc295dd2255e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73065 Tested-by:
-
- Jan 18, 2022
-
-
Stefan Bürk authored
System Requirements have been announced for TYPO3 v12 [1]: PHP 8.1 and higher, raised minimum DBMS versions and removed mssql support. The patch sets according PHP requirements in the central composer.json files: > composer config platform.php 8.1.1 > composer req php:"^8.1" > composer req php:"^8.1" -d typo3/sysext/core --no-update The patch adjusts the core main test suite to run tests with PHP 8.1, ignoring older PHP releases, drops mssql from the test suites and raises versions of other DBMS in the test suite. The option set of Build/Scripts/runTests.sh is updated accordingly. phpstan needs a special handling since it is not PHP 8.1 ready, yet: The code scanner is still run using PHP 8.0 for now. With the default charset being changed to utf8 in mysql, an acceptance tests becomes obsolete and is substituted with an @todo comment to further investigate if we could streamline the underlying code in the install tool. [1] https://typo3.org/article/new-system-requirements-for-upcoming-typo3-v12 Resolves: #96553 Releases: main Change-Id: I34981523dffe6c650a1126c0002f3fa519e11c65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73035 Tested-by:
-
- Dec 15, 2021
-
-
Stefan Bürk authored
Add support for sqlite acceptance testing to 'Build/Scripts/runTests.sh'. Run acceptance/sqlite testing with PHP 8.1 in nightly as a first execution implementation, which could be reshuffled when minimum PHP requirements have been decided. Furthermore two acceptance tests are marked as skipped when executed with sqlite, which should be fixed in dedicated patches: * MaintenanceCest.php->analyzeDatabaseStructureWorks() Skipped, as database compare is never clean and ends in endless loop with sqlite, when ext:indexed_search is installed. This is a general issue, existing at least since v10.4. Needs investigation and a dedicated patch. * UpgradeCest.php->seeUpgradeWizard() Skipped, as utf-8 charset upgrade wizard is not visible for sqlite dbms backend, thus rendering this test obsolete with sqlite. Needs another update wizard test and possibly a dedicated patch. Resolves: #96340 Releases: main Change-Id: I74c8f1156d98a5419309e110ed761e3de21fa37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72446 Tested-by:
-
