[TASK] Ensure php files contain correct legal file header
Core php file header check got silently be disabled. Since then the one or other file header error has slipped into the core. It also pops up from time to time in reviews of patches that file headers are missing (or are wrong). This change ensures that file headers are checked again and can be fixed by given contributers the proper tools at hand. Changes: * add cglFixMyCommitFileHeader.(sh|bat) * add cglHeader and cglHeaderGit to runTests.sh along with proper help text * extend pre-commit hook to execute both fixer scripts side-by-side with error output and fixing possibility * fix minor issue with header comment php-cs-fixer config Additionally the cglHeader check is added to gitlab workflow pre-merge (commit files) and nightly (all files). Slipped in errors has been fixed with a dedicated change #98204. Resolves: #98203 Related: #98204 Releases: main Change-Id: I9567d1dcf8fb53d4901a575213c0ff16dc33ffd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75549 Tested-by:core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
Showing
- Build/Scripts/cglFixMyCommitFileHeader.bat 4 additions, 0 deletionsBuild/Scripts/cglFixMyCommitFileHeader.bat
- Build/Scripts/cglFixMyCommitFileHeader.sh 145 additions, 0 deletionsBuild/Scripts/cglFixMyCommitFileHeader.sh
- Build/Scripts/runTests.sh 19 additions, 1 deletionBuild/Scripts/runTests.sh
- Build/git-hooks/unix+mac/pre-commit 48 additions, 19 deletionsBuild/git-hooks/unix+mac/pre-commit
- Build/gitlab-ci/nightly/integrity.yml 1 addition, 0 deletionsBuild/gitlab-ci/nightly/integrity.yml
- Build/gitlab-ci/pre-merge/integrity.yml 1 addition, 0 deletionsBuild/gitlab-ci/pre-merge/integrity.yml
- Build/php-cs-fixer/header-comment.php 6 additions, 1 deletionBuild/php-cs-fixer/header-comment.php
- Build/testing-docker/local/docker-compose.yml 29 additions, 0 deletionsBuild/testing-docker/local/docker-compose.yml
Please register or sign in to comment