Skip to content
Snippets Groups Projects
Commit 1e52b401 authored by Stefan Bürk's avatar Stefan Bürk
Browse files

[TASK] Ensure php files contain correct legal file header

Core php file header check got silently be disabled. Since
then the one or other file header error has slipped into
the core. It also pops up from time to time in reviews of
patches that file headers are missing (or are wrong).

This change ensures that file headers are checked again
and can be fixed by given contributers the proper tools
at hand.

Changes:

* add cglFixMyCommitFileHeader.(sh|bat)
* add cglHeader and cglHeaderGit to runTests.sh along
  with proper help text
* extend pre-commit hook to execute both fixer scripts
  side-by-side with error output and fixing possibility
* fix minor issue with header comment php-cs-fixer config

Additionally the cglHeader check is added to gitlab workflow
pre-merge (commit files) and nightly (all files).

Slipped in errors has been fixed with a dedicated change #98204.

Resolves: #98203
Related: #98204
Releases: main
Change-Id: I9567d1dcf8fb53d4901a575213c0ff16dc33ffd2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75549


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenjamin Franzke <bfr@qbus.de>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenjamin Franzke <bfr@qbus.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
parent af2e5c07
Branches
Tags
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment