- Dec 21, 2021
-
-
Stephan Großberndt authored
This patch changes the behaviour when building the SchemaDiff on a non-default connection to only fetch tables which are mapped to that connection instead of fetching table details of all tables and discarding the information for unmapped tables later on. This improves the performance and avoids errors for data types unknown to doctrine/dbal in details of unmapped tables. Resolves: #92959 Releases: main, 11.5 Change-Id: Ia4a62d861ea0748995eb0dec4f01e9e65eb3ed46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66949 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Chris Müller authored
This avoids the deprecation notice in PHP 8.1: Passing null to parameter #2 ($string) of type string is deprecated in /var/www/html/public/typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php line 179 Resolves: #96422 Releases: main, 11.5 Change-Id: I9c811bc0d2d4523a78fc6c72ee02be96efbe1bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72764 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Chris Müller authored
Resolves: #96420 Releases: main, 11.5 Change-Id: Ida1b27956bfe759062904ee9d0c8246ea73f0667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72763 Tested-by:
-
Chris Müller authored
When one or more hidden records are referenced in an "Insert records" content element, an "undefined array key" warning was thrown. Resolves: #96419 Releases: main, 11.5 Change-Id: I4f90dc78540bf8c56163cfb8247a13c86869fbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72762 Tested-by:
-
Andreas Fernandez authored
If the PageLinkBuilder is invoked with a non-available TSFE as e.g. in the "Redirects" module, generating the URLs to pages with a fragment, e.g. to a referenced content element, works now as we're using the TSFE generated within PageLinkBuilder itself. Resolves: #96101 Releases: main, 11.5 Change-Id: I481b7d8573424dab59df22b0d81a734e03b70575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72323 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
f:uri.resource is frequently used to load CSS and JavaScript resources. It is the only ViewHelper that does not understand the general "EXT:" syntax that is usually available when extension resource files are referenced. This is now added to improve consistency and documented as best practice in VH documentation. Change-Id: I504c79eef349b1ea6cc70cc0d7753319e1f356d9 Resolves: #96414 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72759 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Benjamin Franzke authored
Helps to migrate to ES6 modules as that's just a tsconfig setting then. Releases: main Resolves: #96409 Related: #96323 Change-Id: Ib897c3c2cfdb6d7ff0a88ea70ed9213b33dd2138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72753 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benjamin Franzke authored
Commands executed: yarn add web-animate yarn build Releases: main Resolves: #96410 Related: #91072 Related: #96323 Change-Id: Id4c06262af9122c638861e798b1f9bfade8ee56f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72754 Tested-by: -
Andreas Fernandez authored
The category starting points introduced with #95037 were designed to allow comma-separated values in its configuration. Due to improper tests, this specific notation was not discovered as being broken right now. If the incoming configuration is a string, GeneralUtility::intExplode() is applied to remove any non-integer value. Afterwards, a new CSV string is generated. Resolves: #96397 Related: #95037 Releases: main, 11.5 Change-Id: I0759d8093bb4665b7709f4e20539307467f246df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72738 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Tom Warwick authored
Releases: main Resolves: #96228 Change-Id: I680bf20c1a3dc63003cf1638ec680ca6ab07447f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72492 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Simon Schaufelberger authored
According to https://docs.phpdoc.org/latest/guide/guides/types.html#union-types it is only allowed to use "string|null" and not "?string" Resolves: #96407 Releases: main, 11.5 Change-Id: I4e9ec53d05feb5cfffc4eebc29de447d6225ab66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72749 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benjamin Franzke authored
RecordExportButton.js has been introduced in #94622 by accident (probably a left-over from a previous patchset re-added due to grunt watch). The TypeScript source for Enum/Viewport/TopbarIdentifiers.js has been removed with #78760, it is unused since then and therefore removed. Releases: main, 11.5 Resolves: #96411 Resolves: #96412 Related: #94545 Related: #78760 Related: #96323 Change-Id: I226d51fc87ab8012e917e7d219688fca21eda364 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72755 Tested-by:
-
Simon Gilli authored
The core version service now uses the new entry point of the REST API available via https://get.typo3.org/api. The old entry point is still available but should not be longer used. For more information see `https://get.typo3.org/api/doc <https://get.typo3.org/api/doc>`_ and `https://github.com/TYPO3/get.typo3.org/pull/272 <https://github.com/TYPO3/get.typo3.org/pull/272>`_. Resolves: #92020 Releases: main, 11.5, 10.4 Change-Id: I2c92554e9ba212827b6412d4a88ac5c92e26aa17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65342 Tested-by:
-
Benni Mack authored
Currently, HMENU generates the direct destination for a shortcut URL, but typolink does not. This is an inconsistency, and since HMENU is actually using typolink now as well (in 4.x this was different), the resolving of shortcuts can now be moved into the typolink/link building functionality. Page Shortcuts are now resolved (recursively!) at a single point for all links, except for RANDOM_SUBPAGE variants, as this is sorted out during runtime when hitting the RANDOM_SUBPAGE shortcut page. Resolves: #80113 Resolves: #95947 Releases: main, 11.5 Change-Id: Ib6204ff1b0ecb699ec87f5154dc18c974676e65c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71402 Tested-by:
-
Stefan Bürk authored
With #96393 forward-compatible prepared statement support has been added to QueryBuilder and also provided several tests to covers this implementation. However one test tests doctrine/dbal behaviour for 'Statement->bindValue()' which behaves differently accross drivers and platforms, emitting different exception types or need an additional execute. This patch removes this test as it is not the job of core testing to test 3rd party code and inconsistent behaviour. Removed test were already removed on backport for #96393. Resolves: #96408 Related: #96393 Releases: main Change-Id: I35d65171dda9fbcc91c906708324997006e21c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72752 Tested-by:
-
- Dec 20, 2021
-
-
Andreas Fernandez authored
The function `idn_to_ascii()` will return either `false` or a string, the former one is returned on errors. In #93900, the result was cast to string, making the check for `false` useless. As `idn_to_ascii()` can return both, the string cast is removed to make the check for `false` functional again. Resolves: #96399 Related: #93900 Releases: main, 11.5 Change-Id: Ib5327766fc545a75feb7389d18358aa85b76e5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72740 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benjamin Franzke authored
In ES6 mode Viewport.Topbar and ModuleMenu.App properties cannot be overwritten (in order to be substituted with a call spy), as they reference other JavaScript modules. The properties of ES6 models are readonly ("frozen") and can therefore not be overwritten in a test setup. Therefore the test is adapted to overwrite the references in Viewport and ModuleMenu instead. Also a timeout is added as await import('TYPO3/CMS/Backend/ModuleMenu') does not guarantee a loading order between modules in ES6, which causes test asserts to be executed too early. Releases: main Resolves: #96396 Related #96323 Change-Id: I5c213b70e43c5e1256e91ffe0d9f12f96dbb6615 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72736 Tested-by: -
Sybille Peters authored
The phpstan configuration documentation recommends to specify the paths relative to the directory of the configuration file. Thus using, currentWorkingDirectory (as current working directory) is unnecessary and removed. Resolves: #96163 Releases: main Change-Id: I2b625f4722e1955b5928a22dbdd2b4aedf6daafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72709 Tested-by:
-
Christian Kuhn authored
The patch makes the bulk of ViewHelper classes more strict and applies some general love. Some ViewHelpers have been left, those will see bigger refactorings soon. All affected classes are final, the changes are (hopefully) non-breaking. * declare(strict_types=1) if missing. * Use self:: instead of static:: since all VH's are final, so there is not point in using late static binding. * Return and argument type hints where possible and reduction of methods doc annotations which are covered by PHP method signatures. * Add types to some class properties. * Protect some detail methods that were apparently public by accident. This is not considered breaking. * Avoid extbase LocalizationUtility::translate() in favor of core LanguageService. * Avoid static class state, especially with TSFE. * Minor comment fixes. Change-Id: I4e3b9d01ea92802e47d05a10f4243196120b8510 Resolves: #96400 Related: #96368 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72741 Tested-by:
-
Benjamin Franzke authored
CKEditor is now loaded via a plain <script async> tag in preparation for a transition from requirejs to ES6 modules. CKEditor v4 is not available as ES6 module and can not easily be transformed into a strict-mode compatible module. CKEditor v4 requires `this` to be the global window object in various functions, but `this` is not bound to the global window object in strict-mode (as implied by <script type="module">). Note: CKEditor is not a real AMD module anyway, but is configured to be shimed by requirejs to be loadable as AMD module, therefore it can safely be loaded using good old <script>. Releases: main Resolves: #96394 Related: #96323 Change-Id: Ife0b476ba29b85f85dfd654ea096cdf30c47b6ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72733 Tested-by:
-
Christian Kuhn authored
BackendController renders "Main.html" as central backend skeleton, plus "Topbar.html" and "MainModule.html". The patch moved the templates into one folder. Resolves: #96404 Releases: main Change-Id: I485d9ff03e457d78c8454e36ac893fbbc1ffe77c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72746 Tested-by:
-
Christian Kuhn authored
There is no point in having the main template in a sub folder, move it up. Additionally use full EXT: syntax for f:translate arguments and avoid a useless flashMessage VH call that is already done by ModuleTemplate automatically. Resolves: #96405 Releases: main Change-Id: Id2f9e4bd28f9ed7649ff5b3c73348cf7d2307a51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72747 Tested-by:
-
Christian Kuhn authored
Avoid dash between the two words. Resolves: #96401 Releases: main Change-Id: If3455598e643f1304400aa2271733bb5f69df0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72742 Tested-by:
-
Christian Kuhn authored
Resolves: #96403 Releases: main Change-Id: Id4843f31254fe2b4bd46fe3c7c37669c6f3a06f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72744 Tested-by:
-
Christian Kuhn authored
Resolves: #96402 Releases: main Change-Id: I8266c5859954ea118a4ec92ca3ca9660e9854c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72743 Tested-by:
-
Stefan Bürk authored
The dev dependency friendsofphp/php-cs-fixer now has a minimum requirement to 3.4, which comes with PHP8.1 support. This allows TYPO3 to run PHP-CS Fixer with PHP 8.1 in the CI pipeline. Testing configuration is not adjusted with this patch, but allows using corresponding runTests.sh testsuites cgl and cglGit: Build/Scripts/runTests.sh -p 8.1 -s cglGit -n Build/Scripts/runTests.sh -p 8.1 -s cgl -n Used command: composer req friendsofphp/php-cs-fixer:^3.4 --dev Resolves: #96398 Releases: main, 11.5 Change-Id: I6a4eaec0294829afcdf84b7b32303eaafbaa72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72739 Tested-by:
-
Benni Mack authored
Resolves: #96392 Related: #95320 Releases: main Change-Id: I6dfe1e5ea95c1e5ceb748e2b1c50eec8644f1ecf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72732 Tested-by:
-
Benjamin Franzke authored
theChar is not initialized and therefore pollutes global scope. (It is assigned to window.theChar in the FormEngine iframe). Currently not an error (we are not using strict mode in RequireJS), just bad style, but once we switch to strict mode (type="module"), this will fail without proper declaration. Releases: main, 11.5 Resolves: #96395 Related: #96323 Change-Id: Ie82da6a1b664e4010179cccaabb07e7d87b19038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72735 Tested-by:
-
Stefan Bürk authored
doctrine/dbal:^3.2 changed return type of result for QueryBuilder execute methods, no longer have used prepared statement accessible for further query execution with other placeholder values. To raise doctrine/dbal:^3.2 two places have been changed to reuse the QueryBuilder instance itself instead of prepared statement with the corresponding patch #96287, thus given up the performance gain through reusable query execution plan in corresponding dbms systems. This patch adds support for prepared statements to TYPO3's QueryBuilder facade as this was not publicly available yet for TYPO3 users to be forward-compatible with Doctrine DBAL 3. Resolves: #96393 Related: #96287 Releases: main Change-Id: I814670ebf9920ed3162a31f98ad9efd4031f47c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72610 Tested-by:
-
Sybille Peters authored
In a previous patch, some language labels were unified in EXT:redirects to that the same label was used for each field in the list module as well as in the edit view. Due to this some of the labels have become redundant and are now removed. Resolves: #96015 Related: #95832 Releases: main Change-Id: I2fd9c650dcca0aea81999a3de2b427895984c70f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72708 Tested-by:
-
Stefan Bürk authored
doctrine/dbal deprecated quite some methods to cleanup their codebase and provided replacements with more speaking method names. Most depcrecated method usages have been replaced in the core, but we missed some. The patch replaces the depcrecated method 'executeUpdate()' with the corresponding 'executeStatement()' method in several places to cleanup this up. This can be done also in 11.5 too, the required minimum version of doctrine/dbal provides these new methods as upwards compatible layer. Resolves: #96389 Releases: main, 11.5 Change-Id: Ibf8f49a27a1c8c4b34bda88a20f4fba6afe45cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72710 Tested-by:
-
- Dec 19, 2021
-
-
Stefan Bürk authored
With a recent change in typo3/testing-framework, various core caches in functional tests are set to NullBackend. This speeds up functional tests up to 10% since the table creation and insert load is higher in testing scenarios than actual cache hit benefits. Some functional tests however work on those tables, for instance the functional test of the database cache backend. The patch adapts these tests to according LocalConfiguration setup. > composer u typo3/testing-framework Resolves: #96387 Releases: main Change-Id: I9770c65d4cf80f98d2c4745024867acf6807e01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72706 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Dec 18, 2021
-
-
Torben Hansen authored
This patch ensures that the getQuery() function only uses the minus operator to negate the $storagePid variable, if the variable can be interpreted as an integer. Resolves: #96321 Releases: main, 11.5 Change-Id: Idacd43fd6639218fc1126bffcd43e78338f18e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72704 Tested-by:
-
- Dec 17, 2021
-
-
Markus Klein authored
RTE yaml configuration can be incomplete/wrong or empty. Do not access configuration settings without a safeguard. Resolves: #96383 Releases: main, 11.5 Change-Id: Ie0888402e64a669816edd200d2d54e401e0c399f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72702 Reviewed-by:
-
Helmut Hummel authored
A "type" does not need to be set in a composer.json, so the checks for package type must account for the type being null, to not trigger a warning in PHP 8 Releases: 11.5, main Resolves: #96372 Change-Id: Ic607c3dbb16dfcf4a28b0417b8340be36bcafa87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72695 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Helmut Hummel authored
Instead of relying on a hard coded extension install path, now the real extension path is used provided by the package manager Releases: main, 11.5 Resolves: #96375 Change-Id: Ic2e4d71413416a5271420e939e5f74fa28cbaca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72697 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Helmut Hummel authored
Get rid of the select query entirely, which optimises the task to only require one update query instead of one select and possibly multiple update queries and gets rid of doctrine version related incompatibilities with fetching the select result. Resolves: #96369 Related: #87162 Releases: main, 11.5, 10.4 Change-Id: I87b570f5efa3d77ed5f2c5fc0074e84bef4675a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72693 Reviewed-by:
-
Oliver Bartsch authored
The RecordListGetTable hook allows to add an additional where clause to the recordlist query. Since the sanitized result was wrapped in an array before being passed to $queryBuilder->andWhere(), this led to an exception. This is now fixed by passing the sanitized clause as string to `addWhere()`. Resolves: #96378 Related: #92065 Releases: main, 11.5 Change-Id: I99fa184f49f9db9f7edf061d4137e1e6c275446e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72699 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
As anticipated in v11 with #95298, this patch declares ViewHelper classes PHP final, third party extensions can no longer extend core ViewHelpers. There is one exception: The ext:fluid FormViewHelper, which is currently extended by ext:form. This can't be resolved easily since it's on one hand quite a bit of code that would have to be copied, and more importantly, the FormField* ViewHelpers refer to the "parent" FormViewHelper class name in various places. Declaring FormViewHelper final thus needs a different refactoring, which may be done in v12 with further patches. Resolves: #96368 Related: #95298 Releases: main Change-Id: I7e8a587dadef4e411390710dd47e309cd2414e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72671 Tested-by:
-
- Dec 16, 2021
-
-
Nikita Hovratov authored
The FinisherOptionGenerator of the form extension generates the data structure for the form setting overrides on the fly. By doing so, it didn't make a distinction between normal TCA fields and flexform specific sections/containers and added the wrapper "TCEforms" to sections as well, which broke the validation in DataHandler for the fields inside the container (E.g. the email field). The patch checks if section is set to "true" and adds the "TCEforms" key only for normal TCA field configurations. Unit tests have been added for the DataHandler checkValue_flex_procInData_travDS method, which show cases with and without the "TCEforms" key. Also, since this works now, a PHP 8 warning appeared. This is fixed now, too. Resolves: #95441 Releases: main, 11.5 Change-Id: Ib12a0484bcbdc827664181ca6af89edfadee13d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71490 Tested-by:
-
