- Apr 28, 2020
-
-
Benjamin Franzke authored
The existing "inline" rendering for icons causes bitmaps to be rendered for SVG-inline usage using the <image> tag. This tag can not be rendered in HTML context. The backend module menu uses inlined SVGs. Rendering bitmap icons with SVG-syntax, without an SVG root element, does not work in this context. (Note: It works in SVG trees because the optional svg container is removed by SvgTree.js and the image-tag is wrapped into a new <g> element) We do now wrap "inline" bitmap icons into an svg tag, which will fix the bitmap module case while the bitmap icons will still be embeddable into svg groups (<g>) for svg trees. Resolves: #89558 Related: #89206 Releases: master, 9.5 Change-Id: Ifaec3e697a45ba37b1ee23c0369414ce431cf4e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by: Markus Klein <markus.klei...
-
Benjamin Franzke authored
SMTP encrypt options were quite a hassle with swiftmailer: 'tls' was used as identifier to start a STARTTLS connection via SMTP (instead of using SMTPS), while strings like ssl/tlsv1.0/tlsv1.1/tlsv1.2 instructed to use a SSL/TLS connection via SMTPS (without STARTTLS). symfony/mailer does no longer allow to specify the STARTTLS usage, as it will use it by default (if the server provides support for it). Therefore, we now adapt the SMTP encryption configuration setting via a silent configuration upgrade to avoid that the previous STARTTLS 'tls' is casted to true while symfony/mailer expects false/null. While at it, we also fix an incorrect migration for the transport type 'mail'. This wizard didn't work because of a wrong typecast (which has probably been a copy & paste mistake). Releases: master Resolves: #91070 Related: #90295 Change-Id: I7fb1112730fedbbfcdb641c8ce04e17ea925d927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64246 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Simon Gilli authored
This will check the dependencies of dependencies during the install of an extension with the extension manager. This solves especially issues with dependent extensions having various major versions for different TYPO3 major versions e.g. ext:powermail. Resolves: #91179 Releases: master, 9.5 Change-Id: I98e6c019066aab303e78b5455ac4dfb58f78cd50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64308 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Apr 27, 2020
-
-
Daniel Siepmann authored
* Fix broken indentation * Add missing blank line * Fix wrong used reference target * Add missing interface to docs, which already was referenced Resolves: #91199 Releases: master Change-Id: If42021e0f7b4a0b879ba5be6bde9112b6c7e658d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64322 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Benjamin Franzke authored
We fix PackageManager and ContainerBuilder to allow multiple container instances (including multiple cache identifiers) to be live. ExtensionManager will now load a new symfony container after installing a new extension, and before reloading all ext_localconf files. We need to ensure that possible services in ext_localconf can be loaded when they depend on symfony DI. Note: This is not a BUGFIX as this was never supported for extensions. But it may lead to hard-to-debug bugs when extension developers add a service to ext localconf but do not test the re-installation procedure before publishing the extension to TER. Releases: master Resolves: #91150 Change-Id: I9b01feae6fe2f1637ca653403336cd7d216483bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64263 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Raphael Zschorsch <rafu1987@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
The newly added ContentFetcher class uses the legacy cache name "cache_runtime" which was renamed in TYPO3 v10.0 to "runtime". The change modifies the cache to "runtime". Resolves: #91188 Releases: master Change-Id: I3d6f1b61f766120f13c5fee2fac78b50adfb35b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64313 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Anja Leichsenring authored
The current nightly run simply takes too long, we need to cut down the sheer number of tests we run. The current setup aims to execute a small subset of all tests on each DBMS and Php version, but in total every test is run in each composer stage at least once. Resolves: #91058 Releases: master, 9.5 Change-Id: I94fc6627f5da0cc6f36cf789ef8aa227d73d8daa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64152 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Resolves: #91198 Releases: master, 9.5 Change-Id: Ibd8ec73ee4a3b38feced4fca3a8609be4b0a3757 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64317 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Stephan Großberndt authored
If caching is disabled in the CacheManager, caches using the TransientMemoryBackend are not adjusted to NullBackend anymore. This mainly affects the runtime cache, which is memory-based anyways and should be a "forget after the request"-cache. This also fixes a PDOException in the page slug update wizard when using PostgreSQL, as the Install Tool is using the core in "no-cache" mode. (See entry point of the Install Tool) Resolves: #91206 Releases: master, 9.5 Change-Id: Id9085bd85bdbf321ef210c75c2bb8aefc6f5f061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64320 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Georg Ringer authored
Replace the usage of `GeneralUtility::milliseconds` in Indexer class which has been deprecated with 91001. Resolves: #91192 Releases: master Change-Id: I2057ecec038195d67acab10946d4542b1fba9646 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64316 Tested-by:
-
Andreas Fernandez authored
While migrating DataTables to tablesort, the sorting for updateable or (un)installed extensions went lost. This patch adds the ability to sort these columns again. Resolves: #91182 Related: #86343 Releases: master Change-Id: Ia33c3dcc789967a984090ccf26150f6d319e85e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64310 Tested-by:
-
- Apr 25, 2020
-
-
Alexander Obert authored
Releases: master, 9.5 Resolves: #91189 Change-Id: Ice3d01530ce595b353fc90a5d672573b9a8d7d78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64314 Tested-by:
-
- Apr 22, 2020
-
-
Oliver Hader authored
Previously `&returnUrl` has been generated in JavaScript dynamically. On changing to regular anchor links that information was forgotten. Resolves: #91171 Releases: master Change-Id: I4038122f769f1cf85949adbf6c5638a5ad8e5084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64303 Tested-by:
-
Daniel Siepmann authored
Explain how to register dashboard widgets via Services.php instead of Services.yaml. This might be necessary if a widget is provided under certain circumstances, e.g. if a specific extension is enabled. Resolves: #91159 Releases: master Change-Id: Ic16e79f478b6da446ff1854979c3c3a822674d1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64296 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
When a live page is hidden, but the workspace version is not hidden, the actual content is now shown properly. Resolves: #85003 Releases: master, 9.5 Change-Id: Ib41e1b6f24f32e5f6deb06f692b929f11ac8e38b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64215 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * adjusts invocations of top.TYPO3.InfoWindow.showItem * adjusts low-level inline `onchange` and `onclick` events Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and `TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle these new triggers and correpsonding events - that's why they are loaded in `ModuleTemplate` and deprecated `DocumentTemplate`. Resolves: #91117 Releases: master Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242 Tested-by:
-
Oliver Hader authored
Resolves: #91166 Releases: master Change-Id: Ief1dfff09aba275a11306693cf39ebc71992f5f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64301 Tested-by:
-
Use newer formating, e.g.: * Definition lists for better readability. * Content directive to automatically update local TOC. To not update by hand. * Use short :: for yaml examples. To shorten rst code and make it more readable. * Use option directive to highlight options. * Update intersphinx urls to not trigger redirects. Always use YAML instead of yaml or Yaml. Use inline Fluid example, instead of adding it with another tip. Update Includes.txt to match current state and provide expected css classes and text roles. Resolves: #91137 Releases: master Change-Id: I185c17a80e69b723b292b9c99eddfe4412362f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64299 Tested-by:
-
Josef Glatz authored
Resolves: #91164 Releases: master, 9.5 Change-Id: Ida1267d13ad2330945c0efafb00cf8ac1656bc61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64300 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Apr 21, 2020
-
-
Daniel Siepmann authored
Resolves: #91155 Releases: master Change-Id: I8e26f7d9bb0c22dcb00cadc704cf8c61ffaf8c0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64293 Reviewed-by:
-
Daniel Siepmann authored
Resolves: #91163 Releases: master Change-Id: I52c4323f2ef812e87015a203f0e2dbaa5a38a581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64298 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Christian Eßl authored
The fluidbased page layout refactoring done in #90882 missed two spots, where the no longer existing function getBackendLayout() is called on a GridObject. Resolves: #91162 Related: #90882 Releases: master Change-Id: I7d381fe35a02c4f1464f9c4bb9fc31b27ef02b1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64297 Tested-by:
-
David Steeb authored
Releases: master Resolves: #91158 Change-Id: I71de97b4b62985e0630d2475523a96d4d7f206ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64294 Reviewed-by:
-
Christian Eßl authored
The code block using $scheme is never reached, because there is already an elseif condition further above, that is true for all urls containing ":". The last else block even states in the comment: "special handling without a scheme" Therefore the variable is removed to remove a bit of complexity from the function. Resolves: #90951 Releases: master, 9.5 Change-Id: I2bc9fe0c546cb946fc32789ee384c3c60ac7c1fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64077 Tested-by:
-
Benni Mack authored
Change-Id: Ia7d214d29ca5fd958fd9c8169b2d76578cbeb511 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64292 Reviewed-by:
-
Benni Mack authored
Change-Id: I8f9c86cfb5a9785e6884ebd643127cac91bbbd67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64271 Tested-by:
-
Thomas Pronold authored
The 'else' part would never be returned in this cases. Used [a-zA-Z0-9]{3,}\)[^(]?\$.*\?\? to find the cases. Care, this brings up false positives as well. Resolves: #91154 Releases: master, 9.5 Change-Id: Ifdb0f75995543c3cc8abeb81aba52e935e9bf9a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64270 Tested-by: -
Claus Due authored
Skip creation of the PageLayoutContext in PageLayoutController if the user has no access to the page, or if the ID parameter was malformed. Releases: master Resolves: #91147 Change-Id: Idd73aa7ba5e6b3a2b41429b1887ad8f9d1db45ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64259 Tested-by:
-
Benni Mack authored
ZipService->extract was introduced for a security patch set but the permissions are not set correctly, as fixPermissions receives a directory with a slash at the end, resulting in "//" for recursive checks. This patch fixes the issue. Resolves: #90417 Relates: #90118 Releases: master, 9.5 Change-Id: Ie56ef6a3781b12c9ac2cf9a859ec226f48691d7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64267 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
-
Andreas Fernandez authored
This commit updates ckeditor to version 4.14.0. This release contains a bugfix for self-XSS'ing the editor: https://ckeditor.com/blog/CKEditor-4.14-with-Paste-from-LibreOffice-released/#security-issues-fixed Command executed: yarn add ckeditor4:^4.14.0 Resolves: #91149 Releases: master, 9.5 Change-Id: I46e2b95773ed0b4fd623a1843ab690a0b596728d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64262 Tested-by:
-
Andreas Fernandez authored
Pasted records use a negative integer to determine their location which is passed as "pid". The DataHandler now resolves the real pid of the records before executing any checks. Resolves: #91144 Related: #89555 Releases: master Change-Id: I10f74542bee5a8a15113731b975580f540748cdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64257 Tested-by:
-
Anja Leichsenring authored
The changelog files for the version 10.4 must leave the master folder now and move to their final home in 10.4. Resolves: #91106 Releases: master Change-Id: If4b7d5e737b0759592600c06578e6aac3a78f6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64269 Tested-by:
-
Benni Mack authored
In order to stabilize this API, all APIs are marked as internal in order to allow changes once Fluid-based page module is stable enough to remove the info in further patch-level releases. Resolves: #91153 Releases: master Change-Id: I26737e5ab89947fdcd7a0bf99c30310fce3b0a3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64268 Tested-by:
-
- Apr 20, 2020
-
-
Oliver Bartsch authored
The check if a user is allowed to paste content from the clipboard now evaluates the content modify and content edit permissions instead of the page edit permission. This is done in both PageLayoutView and the fluid based page module. Resolves: #90961 Releases: master, 9.5 Change-Id: I65a29a9a6cf4ae4e73af28d1319d0b730fd5f5bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64105 Reviewed-by:
-
Benni Mack authored
Due to the fact that backend user objects have not been initialized properly in PSR-15 middlewares defining the current in-memory state for workspaces falls back to the users' default workspace. Basically `BackendUserAuthentication::groupData['workspace_perms']` was not initialized which results in the mentioned behavior for non-admin users. `fetchGroupData` was split up into public `initializeGroupData` to be used internally only and protected `enrichGroupData`. Resolves: #90954 Releases: master, 9.5 Change-Id: I75ad15ac600ca489b9951199482e97bcb54d1778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64264 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
Due to the replacment of DocumentTemplate with ModuleTemplate the rendering is now different. In order to overcome this, a new flag enableDocHeader is added. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290 Resolves: #90834 Releases: master Change-Id: Ifb278f7dff1c9b1e18b09f7587dbe33caff13732 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64261 Reviewed-by:
-
Oliver Bartsch authored
Remove wrong fourth parameter from the items array as this broke the whole column. Resolves: #91152 Releases: master Change-Id: I07f5a1d3fd3d25fadba88b54581ccbfc52184fb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64266 Tested-by:
-
Georg Ringer authored
This reverts commit 47e63fc3 because of regressions. Resolves: #89989 Reverts: #88344 Releases: master, 9.5 Change-Id: I1f43d0f343484366e81581435bdb418cfebf317a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62832 Tested-by:
-
Claus Due authored
Provide the correct UID for the "edit record" link which edits the default language page record when page module is in "Languages" mode and the edit icon in top of default language's column is clicked. Releases: master Resolves: #91146 Change-Id: I17c415efdcbf80737d05982ec90a4ac62ce5abea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64258 Tested-by:
-
Benni Mack authored
This patch prevents throwing and spamming the logs with 500 server errors. Resolves: #91145 Releases: master, 9.5 Change-Id: I9385a9c0a2a665cedb1340cc8397740b0bd6255e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64084 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
