- Feb 08, 2018
-
-
Frank Naegler authored
This change deprecates the "buildQueryParameters" hook in three different classes and adds two new hooks in DatabaseRecordList and PageLayoutView to modify the current query. With #82334 a cleanup of AbstractRecordList has introduced the same hook into multiple classes, which breaks existing hooks, because of the sixth parameter which can be one of three different classes without a common parent class or interface. This makes it impossible to use a type hint in the hook class. Another problem is: an extension which implements the hook for the list module and uses a type hint will break the page module. The same query manipulation can be achieved with the two new hooks, which have a separate identifier. Resolves: #83740 Related: #82334 Releases: master Change-Id: Ie3b2c8082f86c6632400a8194dca4ca244b428bc Reviewed-on: https://review.typo3.org/55512 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
- Feb 07, 2018
-
-
Benni Mack authored
Handling of "&M" parameters is added back in order to make the transition for Backend modules easier. Resolves: #83800 Related: #82406 Releases: master Change-Id: Iaa237b62254804d78314b48d80dfbea563fd7af4 Reviewed-on: https://review.typo3.org/55589 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Wouter Wolters authored
There is no return value, drop the @return tag. Also add @param int $requestType to setRequestType Resolves: #83801 Releases: master Change-Id: I1f371effb5a56c02860af716ca4071ac3db3c4da Reviewed-on: https://review.typo3.org/55593 Reviewed-by:
-
Benjamin Franzke authored
The code is restructured to clearly distinct between aborting the middleware chain – returning an own response – and forwarding the request to the next middleware/request handler. Change-Id: I51d88b9f9fae8d2aafca343da1e67bf60182d765 Releases: master Resolves: #83727 Reviewed-on: https://review.typo3.org/55539 Tested-by:
-
Benjamin Franzke authored
Correct middleware configuration to preserve the ordering timetracker initialization and pre-process hook had prior the re-implementation as middleware. The timetracker initialization needs to be first, pre-process second. Change-Id: Ieecfff459000566f75b692516f27f5d7e176149b Resolves: #83802 Releases: master Reviewed-on: https://review.typo3.org/55594 Tested-by:
-
Thomas Hohn authored
Removes "public internal" cache variable and implements runtime_cache instead. Change-Id: I8262a699d60db9e9eb04f23c3f7da78ef7e1149d Resolves: #79071 Releases: master Reviewed-on: https://review.typo3.org/51019 Tested-by:
-
Daniel Windloff authored
Resolves: #81466 Releases: master, 8.7 Change-Id: Icf9dace3b00667e4d6a17cc5d3559782beffb725 Reviewed-on: https://review.typo3.org/53265 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Markus Sommer authored
Enable all additionalAttributes and additionalConfig’s to cover w3c and special spacs. Resolves: #81743, #81741 Releases: master, 8.7 Change-Id: Ibfce2bd66e6de95eeb7c05eab160eec40ae437ef Reviewed-on: https://review.typo3.org/53356 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Jasmina Ließmann authored
Use the same layout for tables in submodules of module 'Info'. Resolves: #81457 Releases: master Change-Id: I1135bbf57eaa033fd09538c242192907b5b20ee4 Reviewed-on: https://review.typo3.org/53479 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christoph Lehmann authored
This prevents a redirect loop with realurl where an editor doesn't see the pagetree of his login domain in his workspace and opens his login domain in the FE. As result he sees the requested page. Resolves: #82297 Releases: master, 8.7 Change-Id: Ie948f6defa21e3e1d8766533f54a48769d2220c9 Reviewed-on: https://review.typo3.org/53977 Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Reiner Teubner <rteubner@me.com> Reviewed-by:
-
David Wong authored
The language identifier key for Chinese in TYPO3s backend is ‘ch’. The valid identifier should be ‘zh-cn’, but we cannot change the entire translation server in a meaningful way. Releases: master Resolves: #79179 Change-Id: I5fee14f2eceacc5676588bdb8cac2aeceb88fff6 Reviewed-on: https://review.typo3.org/51161 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 06, 2018
-
-
Benni Mack authored
The public method TSFE->isBackendUserLoggedIn() instead of TSFE->beUserLogin (public property). Resolves: #83785 Releases: master Change-Id: I1e54b7365b3b6810b606e93b0f888a7790492014 Reviewed-on: https://review.typo3.org/55575 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Benni Mack authored
This patch moves logic out of the RequestHandlers into PSR-15 compatible middleware classes to call a hook and initialize the time tracker. Resolves: #83765 Releases: master Change-Id: I200fdc80390625fb45564a4c09cecd00d846fad8 Reviewed-on: https://review.typo3.org/55584 Reviewed-by:
-
Benjamin Franzke authored
PSR-15 middlewares are hooks on steroids for HTTP requests. Due to chaining middlewares and the core request handler(s), middlewares can execute code before and after the application. Middlewares may return early, that means they can prevent consecutive middleware and the core application from being executed at all. A full middleware coverage for *all* requests will need a lot of changes to the core and extensions. We'll eventually need to stop using header()/exit()/die() or HttpUtility::{redirect,sendRespose}(). Those method calls need to be replaced by manipulation of PSR-7 message objects. PSR-15 interfaces are provided by psr/http-server-middleware: composer require psr/http-server-middleware:^1.0 Change-Id: Ia906d51da2e4309a37fb47a7966b52f873782d8f Releases: master Resolves: #83725 Reviewed-on: https://review.typo3.org/55544 Reviewed-by: -
Reiner Teubner authored
This patch replaces the calls to the PHP function each() as it is marked as deprecated in PHP 7.2. Additionally it adds unit tests for QueryGenerator::getSubscript(). Resolves: #83737 Releases: master, 8.7, 7.6 Change-Id: Ie61a6d44fcdbd4ce6105a6c185085a3a68866fd8 Reviewed-on: https://review.typo3.org/55510 Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Feb 05, 2018
-
-
Michael Oehlhof authored
Include possible package base paths only if subdirectories are available. Otherwise no extension can be found in the base path anyway. Resolves: #83070 Releases: master, 8.7, 7.6 Change-Id: I503623c607554a60bd144c83e3f69e78fe5a7ea0 Reviewed-on: https://review.typo3.org/55018 Reviewed-by:
-
Georg Ringer authored
Improve the debug output by forwarding the given title. Resolves: #83688 Releases: master, 8.7 Change-Id: I160b5676c5ff70c056319446733c9549a663569a Reviewed-on: https://review.typo3.org/55473 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
Jasmina Liessmann authored
Resolves: #82442 Releases: master Change-Id: I90b596839a85c43c59c2d45870b344c09e59769d Reviewed-on: https://review.typo3.org/54316 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Ralf Zimmermann authored
If you use the "__inheritance" operator within an EXT:form configuration file, configuration keys of the parent element can be deleted in the child element by giving the configuration key in the child element the value NULL. See https://docs.typo3.org/typo3cms/extensions/form/latest/Concepts/ Configuration/Index.html#inheritances for further information. Before the "__inheritance" operators are executed, all configuration files are merged using TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule(). However, this does not work if you are using several configuration files. Let's assume the configuration key in the previous configuration file is an array. mergeRecursiveWithOverrule() does not delete this configuration key, if the configuration key in the overriding configuration file is not an array (for example: NULL). This is simply ignored by mergeRecursiveWithOverrule(). This patch fixes this issue by adding a variation of array_merge_recursive(). Resolves: #82051 Releases: master, 8.7 Change-Id: Id9d256226a3eb82f6bc3fd03904f944719e525e7 Reviewed-on: https://review.typo3.org/55487 Reviewed-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
-
Frank Naegler authored
Some modules in the filelist are missing DOM ready checks. This patch adds the missing checks to prevent loading issues. Resolves: #78976 Releases: master, 8.7 Change-Id: Iee328808a89cf92f4fde1afd59167ae9fa7280be Reviewed-on: https://review.typo3.org/55390 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Nicole Cordes authored
The patch decouples the ErrorHandler test from MySQL and some internal deprecated function. Related: #83770 Releases: master Change-Id: Id3b9ed3486d0c5c8a4f6ba030a25f1f8aee75b97 Reviewed-on: https://review.typo3.org/55562 Tested-by:
-
Frank Naegler authored
This is the first step for introduce CGL for JavaScript files. The settings of the .editorconfig file is now applied to all JavaScript files. This will prevent merge conflicts for the next patches. Resolves: #83752 Releases: master, 8.7 Change-Id: Ie84691e7f7f3a3974f3c62133895a62377b22f67 Reviewed-on: https://review.typo3.org/55521 Reviewed-by:
-
Andreas Fernandez authored
This patch adjusts the drag and drop handling on the page module. Localized content element can't get moved anymore when they are in connected mode. Languages without a `l18n_parent` may be freely moved. Resolves: #83470 Related: #66540 Releases: master, 8.7 Change-Id: I7dcb61279d4bfeb094dcb0e2fbffd416da9c787b Reviewed-on: https://review.typo3.org/55453 Tested-by:
Armin Vieweg <armin@v.ieweg.de> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Christian Kuhn authored
Fixes various issues, brings PHP 7.2 compatibility to v8 core branch of standalone fluid. composer command used: composer update typo3fluid/fluid Change-Id: I52c3a97e7dc8dafd7b0dee1e07df5105f29cdbde Resolves: #83774 Resolves: #82227 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55560 Reviewed-by:
-
- Feb 04, 2018
-
-
Nicole Cordes authored
This patch moves the execution of configured initCommands to the end of connect function. This prevents a database connection from being opened by default due to the execution of commands right after class initialization and still ensures a connection is configured properly before first command execution. Furthermore this patch adds a new functional test for the ErrorHandler. The test uses some predefined initCommands to enforce the strict mode of MySQL database to be set. Due to the predefined initCommands the test failed before as the connection was forced to be opened. For further information see the referenced forge ticket. Resolves: #83770 Releases: master, 8.7 Change-Id: I2287600959b3ec06d338e26373562850307ce0b1 Reviewed-on: https://review.typo3.org/55548 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Wolfgang Klinger authored
Bring back the possibility to access FE session data in TypoScript conditions: [globalVar = TSFE:fe_user|sesData|some_key > 10] Resolves: #83506 Releases: master, 8.7 Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521 Reviewed-on: https://review.typo3.org/55408 Tested-by:
Timo Pfeffer <pfeffer.timo+typo3@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Stefan Neufeind authored
When using filters the colorspace is not always applied. A quickfix is to add the colorspace-setting again before writing the output-image. Multiple colorspace-settings on the commandline will be executed in order. For example the grayscale-filter uses "-colorspace GRAY". The final output-image can then be converted to "-colorspace sRGB" again so the brightness appears correct (not too dark) again. Resolves: #78816 Releases: master, 8.7 Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd Reviewed-on: https://review.typo3.org/50791 Reviewed-by:
-
Mathias Schreiber authored
In order to give FormEngine a fresher look we add the following renderTypes to type=checkbox * checkboxToggle * checkboxLabeledToggle Furthermore, checkboxes are now displayed with icons provided via the IconFactory and can be changed. Resolves: #83556 Release: master Change-Id: I24570dc4ee8cb672a5f961399b709fe7da05e2f0 Reviewed-on: https://review.typo3.org/55351 Reviewed-by:
-
Mathias Schreiber authored
The central InsufficientFolderReadPermissionsException now displays the name of the folder in question to ease tracing down errors. Resolves: #82342 Releases: master Change-Id: I968c74e6b2e210b07964f7ebb141155525c26ee5 Reviewed-on: https://review.typo3.org/55541 Tested-by:
-
Mathias Schreiber authored
Editing faulty FileStorages is possible again due to catching the respective exception and piping it into a FlashMessage Resolves: #83762 Releases: master, 8.7 Change-Id: I5081d86fd73076359b1d9eba954ba07c50bcb7b2 Reviewed-on: https://review.typo3.org/55551 Reviewed-by:
-
Andreas Fernandez authored
When the element browser is opened in a popup window, the parent element (=popup) is now accessed properly. This patch also fixes the case for `list_frame` which didn't work in Firefox. Resolves: #83693 Releases: master Change-Id: I2436942a239b868cd1e3e269c6161a9df92e05ff Reviewed-on: https://review.typo3.org/55511 Tested-by:
-
Mathias Schreiber authored
The Suggest Wizard now allows to search for multiple terms in field by splitting the searchterm by +. This allows to search for a combination of values which is helpful when dealing with large data sets. Resolves: #61981 Releases: master Change-Id: I764039a575ca5d9ccbd97dd3dc57f3947906a5c3 Reviewed-on: https://review.typo3.org/55546 Reviewed-by:
-
Mathias Schreiber authored
The SuggestWizard no longer returns translated pages. For the sake of database relations, relating directly to a translated page makes no sense and will most likely result in unintended behavior. Resolves: #83771 Releases: master Change-Id: Ibfa8dfa3082245726e0a519e77f26849507e421b Reviewed-on: https://review.typo3.org/55550 Reviewed-by:
-
Christian Kuhn authored
Sets the typo3 database cache backend "content" field from mediumblob to longblob. Mediumblob on mysql equals 16MB max storage, which can be too small for cache entries. Switching to longblob increases single cache row size to 4GB and costs only one additional byte per row. Change-Id: I1ab5b84b6845280e77e339cbe4a59e0043f84cc2 Resolves: #83772 Releases: master Reviewed-on: https://review.typo3.org/55549 Tested-by:
-
- Feb 03, 2018
-
-
Benni Mack authored
This reverts commit f22792ec reviewed on https://review.typo3.org/#/c/55528/ due to a fault of mine removing the original ownership of the commit. Change-Id: Idd8b09754ec124047bd620c7529b0937c823e6b1 Resolves: #83767 Reverts: #83725 Releases: master Reviewed-on: https://review.typo3.org/55543 Tested-by:
-
Benni Mack authored
This reverts commit a1f5a232 due to author conflicts. https://review.typo3.org/#/c/55537/ Change-Id: Ie6003a41e75d395a1214904ecce8994ec63ac798 Resolves: #83766 Reverts: #83785 Releases: master Reviewed-on: https://review.typo3.org/55542 Tested-by:
-
Benni Mack authored
This patch moves logic out of the RequestHandlers into PSR-15 compatible middleware classes to call a hook and initialize the time tracker. Resolves: #83765 Releases: master Change-Id: Ibe2435833a8cbf0fb19cfe1fddd519d47147707e Reviewed-on: https://review.typo3.org/55537 Tested-by:
-
Benni Mack authored
PSR-15 middlewares are hooks on steroids for HTTP requests. Due to chaining middlewares and the core request handler(s), middlewares can execute code before and after the application. Middlewares may return early, that means they can prevent consecutive middleware and the core application from being executed at all. A full middleware coverage for *all* requests will need a lot of changes to the core and extensions. We'll eventually need to stop using header()/exit()/die() or HttpUtility::{redirect,sendRespose}(). Those method calls need to be replaced by manipulation of PSR-7 message objects. Change-Id: I075639835115f7cf28f18c3814ef6dd190fdf29b Releases: master Resolves: #83725 Reviewed-on: https://review.typo3.org/55528 Reviewed-by: -
Benni Mack authored
The Browseable Trees (Element Browser) show pages with language > 0 (page translations), due to a missing fix during the pages_language_overlay refactoring. The patch adds the restriction on deleted pages and sys_language_uid=0 pages, just like PageTreeView and the new page tree do it. Resolves: #83764 Releases: master Change-Id: I90d76a37a0ee146ea549adcbb3aeff027fe42d26 Reviewed-on: https://review.typo3.org/55536 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Tymoteusz Motylewski authored
Chrome 64 changed the behaviour regarding xhr.open() calls when passing null values as password and username. The d3.js file is manually patched. Once PR https://github.com/d3/d3-request/pull/34/files is merged we can use official d3.js version again. Resolves: #83741 Releases: master, 8.7 Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125 Reviewed-on: https://review.typo3.org/55534 Tested-by:
-
