- Mar 11, 2021
-
-
Daniel Goerz authored
From now on, phpstan will validate arguments passed to methods for type integrity. This patch also resolves all remaining issues in the core up to PHP 7.4. Running phpstan on PHP 8 is therefore disabled temporarily and will be enabled again with another patch that resolves all remaining PHP 8 issues regarding argument types. Resolves: #93652 Releases: master Change-Id: I2cbd15c5e83ae188a4d453c71b5841d424b2eef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68191 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
Because bootstrap 5 requires the `.nav-link` class for styling of nav tab links, our custom SCSS now uses the class selector together with the type selector. Otherwise it will be overruled by the default bootstrap styles because of their specificity. See: https://getbootstrap.com/docs/5.0/components/navs-tabs/#fill-and-justify Furthermore is the `.active` class, indicating the active tab, not longer set on the `.nav-item` element, but on the `.nav-link` element. The custom SCSS is therefore adjusted to respect this changed behaviour. Resolves: #93691 Releases: master Change-Id: I57260c370a12dd997652065fa6eebb82705eec38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68302 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
In case a TCA column with type=inline does not contain "container controls", e.g. the `languages` column in a site configuration, a TypeError was triggered by the toggleContainerControls() method. This is fixed by proper type checking. Resolves: #93690 Releases: master, 10.4 Change-Id: I6dc0a874adddb6e9c56565087b090072656b54eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68301 Tested-by:
-
Markus Klein authored
Logs written via the logging API now include the correct remote address instead of the marker ###IP###. Additionally, some actions were logged twice, this is streamlined. Resolves: #93693 Releases: master, 10.4 Change-Id: I7d420046f5cff605383ce330784821644d9b9fac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68304 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Benni Mack authored
This change optimizes the SVG Tree implementations (again), this time focussing on using proper constructors for SVG tree and its derivatives (SelectTree, PageTree, FileStorageTree). In addition, the search + filter logic is now moved into the base class, in order to reduce duplicate code, and to re-add features (next steps) that were not implemented in TYPO3 v9 when re-writing the page tree, such as highlighting filtered results. In addition, unused properties and settings are removed. This change marks one of the final changes for reworking the SVG Tree implementation, afterwards allowing us to move towards: * native DOM events in favor of d3-dispatch * custom elements instead of wrapper methods * decouple "top." and "document." based settings into the Container classes Resolves: #93701 Releases: master Change-Id: I55733b8c2d0a84ca263ac6e77d7d0bac30877e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68332 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
The MFA TOTP provider is based on a shared secret. Therefore, to set this provider up, the secret has to be exchanged between TYPO3 and the corresponding OTP application or device. This can either be done by: * Scanning the QR code * Entering the shared secret directly While the shared secret does not contain any additional data, the QR code contains the so-called otpauth URL, a common URI scheme, accepted by most OTP applications. This URL features additional information like the issuer and the related account. To improve the usability, the user is now able to also access this URL directly through a new modal with further explanation. Resolves: #93666 Releases: master Change-Id: I27dc805bcca7aeb29d15a5c20223426999277625 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68293 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Oliver Bartsch authored
The ['TYPO3_CONF_VARS']['BE']['requireMfa'] configuration is extended by another option to only require MFA being set up by system maintainers. Resolves: #93647 Releases: master Change-Id: Ie06c89cad6dc5d16dfa164d27f42407739074657 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68333 Tested-by:
-
- Mar 10, 2021
-
-
Benjamin Franzke authored
Back when the PSR-18 implementation was added in #89216 we promised to replace our PSR-18 client wrapper once Guzzle supports PSR-18 natively. The intention was to point our dependency injection (DI) alias configuration for the PSR-18 client interface to guzzles native implementation once available. Due to the major Guzzle update (to v7) in #92995, the PSR-18 interface implementation became available and therefore the previous client wrapper is now dropped and DI configuration is adapted accordingly. We keep the existing unit tests to verify compatibility between GuzzleHTTP client and our PSR-7 request stack. `provide.psr/http-client-implementation` is dropped from composer.json as this is now set by guzzlehttp/guzzle. Resolves: #93573 Related: #89216 Related: #92995 Releases: master Change-Id: Idcdf2e429019c60c14e93e954cd9fa45c6c57fbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68057 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Česlav Przywara authored
Introduce new helper method to fetch stats for temporary processed files folder that has storage UID 0 assigned internally. Existing public method that fetches directory stats based on storage UID calls this helper method when necessary avoiding fatal error due to no actual storage with UID 0 being available. Resolves: #93415 Releases: master, 10.4 Change-Id: I19746c0d3281cb5372d07821f37ee959d3f3035e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68099 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Andreas Fernandez authored
The introduced validation of checkboxes in `selectCheckBox` took the "Toggle all" checkbox into account as well which broke in combination with a `maxitems` constraint. This patch now takes only checkboxes with a `value` attribute into consideration. Resolves: #93699 Related: #93191 Releases: master, 10.4 Change-Id: I884361a8b1b5ff5e2bbc4235f7c7084d1c3e2b6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68311 Tested-by:
-
Markus Klein authored
The example is taken from the actual code comment. Resolves: #93698 Releases: master, 10.4 Change-Id: Ic032f4eb76c0241b63a8adfe64190373e3d25528 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68308 Tested-by:
-
Andreas Fernandez authored
If a selectMultipleSideBySide field has a "minItems" constraint, the wrong field gets validated which makes it impossible to store a record if an affected field would fulfill the constraint after a change. This patch adds an additional validation for the human-readable field. Resolves: #93574 Related: #93191 Releases: master, 10.4 Change-Id: I1bb129f809d18a318ac15872bcfef8fdf3db2395 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68257 Reviewed-by:
-
Benni Mack authored
As the temporary mount point functionality is not bound to the actual PageTree, but the navigation component, this code is now moved outside of the PageTree, and using lit-based rendering and proper event handling. The advantages of this change are that the SVG Tree / PageTree component - does not access HTML outside its own wrapper (parentNode) - the mount point information is now rendered via LIT (= automatically updated) - additional setting "temporaryMountPointPath" is not needed inside the PageTree anymore - We also now use <typo3-backend-icon> and the $lll lit helper Resolves: #93697 Releases: master Change-Id: Idaa56f12e6d1444a1abdf23d2a37b71948d47023 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68307 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Oliver Bartsch authored
Some EXT:dashboard related PHP classes are calling LanguageService::sl() instead of LanguageService::sL(). This is fixed by using the correct case for the function call. Resolves: #93696 Releases: master, 10.4 Change-Id: Ic1d51c0f1dd314598b309e31446c3c50736f8ccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68306 Tested-by:
-
Benni Mack authored
In order to reduce the memory footprint of fetching label files, a superfluous cache LL_files_cache is removed, as there is a cache within readLLfile() already. Resolves: #93694 Releases: master Change-Id: I206eb566e14d5b72f0ad15d64625cf5493bae3ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68305 Tested-by:
-
Benni Mack authored
This patch provides the following changes in order to have better abstractions and encapsulate the dependencies of each implementation. 1. SelectTree (Category Tree) The TreeToolbar is now clearly coupled into the SelectTree and built as LitElement inside the SelectTreeElement. SelectTree now contains all relevant functionality regarding selecting multiple items, and shows settings (SelectTreeSettings) which were only used in SelectTree. This is especially relevant for the multiple item selection, and the exclusiveKey handling. 2. PageTree + FileStorageTree Obsolete public methods are removed, and visibility is changed. Filtering is now separated in favor of a non-public property. By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted Obsolete wrapper methods are removed. Resolves: #93692 Releases: master Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303 Tested-by:
-
Benjamin Franzke authored
The shortcut handling added in #86248 caused the matching command to be loaded before the symfony DI container was made available to GeneralUtility::makeInstance (FailsafeContainer was still active). This caused services (e.g in #93442) that are instantiated using the GeneralUtility::makeInstance-to-DI-Container bridge to fail as these services are not available in the FailsafeContainer. Background: the symfony Application:find() method did not just search for a matching command, but it also initialized it, once found. Therefore shortcut resolving is now handled within the TYPO3 command application to ensure commands are only instantiated once the symfony container (and localconf) is fully loaded. Resolves: #93569 Related: #86248 Related: #93442 Releases: master Change-Id: I717df6aa03f4f474e437f98eef62d291e39010fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68254 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Mar 09, 2021
-
-
Benni Mack authored
The login controller now allows to set two new GET parameters "redirect" (pointing to a valid route identifier) and "redirectParams" (a list of query arguments which are rawurlencode'd). This way, the login controller can redirect to another route instead of dealing with a hard-coded "redirectURL", which can be phased out in the future. This is a first step towards allowing a defined redirect route for all other places in the TYPO3 Backend, where currently "redirectURL" is used. Also "linkThisScript" should become obsolete after this change. This change also removes the need to store a first click in the install tool when loading the distributions within the "uc". Resolves: #93674 Releases: master Change-Id: Ic00113e528d00ab97215d750e1826d1ae8467a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68198 Tested-by:
-
Christian Kuhn authored
Milestone: With a last series of type handling and array access fixes throughout core and in typo3/testing-framework, a first set of functional pre-merge tests can be enabled with PHP 8.0. composer req --dev typo3/testing-framework:^6.7.2 Resolves: #93686 Releases: master Change-Id: I2d35725967be563fe9408083ee8aee59ea1533e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68294 Tested-by:
-
Georg Ringer authored
LanguageService::sL(), also known as the split label function, is widely used through Core and third-party extensions. It checks if the given input is a label reference and otherwise just returns the input. Since this method is often used with dynamic values, coming from e.g. XML files, there might be whitespace in the input string. In such case the label reference can not be resolved, even if the key is valid, and the input gets returned unchanged. To prevent this behaviour, LanguageService::sL() now applies trim() to the input, whenever a specifc strpos() check takes place. Resolves: #93676 Releases: master, 10.4 Change-Id: If195b5fed75f79912edd6478ad3a47a27157155d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68255 Tested-by:
-
Benni Mack authored
Native HTMLElements are more versatile than a the current NavigationComponent interface. All custom actions can be dispatched via events, that means the NavigationComponent interface, as recently introduced in #93672, is removed again. Resolves: #93685 Releases: master Change-Id: I578810ce655d1da3f34bcb456967f62756793b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68233 Tested-by:
-
Benni Mack authored
When in a workspace, the slug of a workspace'd page record is properly resolved (good!), but the versioned ID of the page is used within the PageArguments. This is in turn lets TSFE think that the "Page ID" is the versioned ID, which is wrong (similarly to the localized page ID / translated page ID), which always need to be the live Page ID in order to properly handle records on the page ("pid=live/default ID of the page") Resolves: #93650 Releases: master, 10.4 Change-Id: I52e3880e2edb1f774a5dfb24a7bddaf81a3dcb19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68182 Tested-by: -
Andreas Fernandez authored
With the update to Bootstrap 5 the CSS class name for animated progress bars changed from `active` to `progress-bar-animated`. This patch updates the wrong class names accordingly. Resolves: #93682 Releases: master Change-Id: If8f4e388513822f0457afa2a37d88ed440f6d709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68259 Tested-by:
-
- Mar 08, 2021
-
-
Benjamin Franzke authored
The v1.1 interface adds support for parameter type declarations. Also mark as psr/container v2 compatible as we add the `bool` return type annoation for `has()` right away. (yes that is compatible with the v1.1 interface, although it doesn't contain a return type declaration) This is not yet testable against psr/container v2, but will show up in nightly composer-max stages once symfony/dependency-injection is released with support for psr/container v2. Commands used: composer require "psr/container:^1.1 || ^2.0" composer require "psr/container:^1.1 || ^2.0" \ --no-update -d typo3/sysext/core Releases: master Resolves: #93681 Change-Id: Ia0e5024bae0a05ae72b83964233d449b63896440 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68256 Tested-by: -
Benni Mack authored
TSFE now always contains the Site object so it is not necessary to use the SiteFinder based on the ID to fetch the correct Site anymore, but use TSFE->getSite() directly. Resolves: #93654 Releases: master Change-Id: I2ddd6b0409f73edc4f6fa8f6c7bb0ab21d567272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68188 Tested-by:
-
Georg Ringer authored
If a label is too long, which is especially possible if the field name is shown, it should wrap into new lines. Resolves: #93462 Releases: master, 10.4 Change-Id: I6150e4c62e06b28c952f8b9f4f71115ffedd4401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68189 Tested-by:
-
Benni Mack authored
Historically (even before TYPO3 3.3.0), the UI language (the language of the TYPO3 Backend of a user) is stored in ->uc['lang'], which is only filled from the database field be_users.lang when a user logs in the first time. be_user.lang is/was used for admins when creating users to set a default language when the user first logs in for the first time, but is never used afterwards. However, using "uc[lang]" in various places does not make life easier because uc always needs to be unpacked (e.g. for sending bulk mails to users, or changing languages for users as admins, listing users' preferred languages in list module). For this reason, be_users.lang now defines the users' UI language, however uc[lang] is synced on each login of a user now, if the language has changed. In addition, the TCA for be_users.lang is now handled via an itemsProcFunc, making uncached requests a tiny bit faster as Locales are not populated during TCA creation, and allows for more features such as dynamically showing available/downloaded languages in a be_users FormEngine field. The Setup module now updates be_users.lang instead of uc[lang], which makes it easier in the future to use native TCA for rendering the setup module fields. An upgrade wizard migrates all "uc[lang]" values into "be_users.lang" and ensures that empty values are never used, instead "default" (= English) is added to all user records to have an explicit value (also for new users). Resolves: #93663 Releases: master Change-Id: Icb8e07f3fabb1f3022f3adcbdce6dc9efd790302 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68192 Tested-by:
-
Oliver Bartsch authored
This improves some MFA labels and fixes some typos. Resolves: #93657 Releases: master Change-Id: I0078e606d90aebdd3110c4a753170180d2870f8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68190 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
composer req --dev typo3/cms-styleguide:~11.1.0 New version brings a series of field label changes. The FormEngine acceptance tests need a slight xpath adaption to deal with this, which also stabilizes the selectors a bit. Change-Id: I3b4ac800b3d9303228ed652f23aaf2d6c773274d Resolves: #93673 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68232 Tested-by:
-
Christian Kuhn authored
One last place in PlainDataResolver now gets the missing DeletedRestriction added to a query. This should stabilize some usages in DataHandler and a couple of other places. A detail with workspace inline scenarios and delete placeholders with sorting is changed together with the patch to not trigger side effects. The scenario is described in detail with a code comment. Resolves: #92481 Releases: master Change-Id: Id2c4d09c5c36caa299ab6ee7aa6b63c20f926dad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66011 Tested-by:
-
Daniel Goerz authored
Resolves: #93658 Releases: master Change-Id: I257f425d267114b9fa54636c66a77ddbeffa2bad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68193 Tested-by:
-
Christian Kuhn authored
PHP 8 throws warning level errors instead of notice level errors when an not existing array key is accessed. The patch fixes another batch of this kind of issues found by functional tests. Resolves: #93675 Releases: master Change-Id: I88e2a0a28af21a95b9ec3e74c7449d9cdc7a23bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68234 Tested-by:
-
Benni Mack authored
In order to use the non-iframe navigation component properly, the current ties to "PageTree" (which was de-facto the only possible navigation component to be used until TYPO3 v11 due to heavy coupling) are removed. The TreeInterface, which served as a wrapper for the PageTree Navigation Component is removed, and replaced by the NavigationComponent interface in TypeScript. In addition, loading and initializing (and keeping state) of the used navigation component now solely relies in the NavigationContainer. This in turn, finally allows to e.g. properly re-load the FileStorageTree and PageTree separately (see BackendUtility change) while incorporating some ES6 nullable functionality. In addition, the NavigationContainer is now jQuery-free. Resolves: #93672 Releases: master Change-Id: Ia16a3e789459225b21fa12efd1db6f3b4500cfef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68201 Tested-by:
-
Christian Kuhn authored
Resolves: #93638 Related: #93632 Releases: master Change-Id: I89c3b9835bc894973034841e22934608ad681403 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68174 Tested-by:
-
- Mar 06, 2021
-
-
Christian Kuhn authored
Scenario: A translated content element is hidden in live, a workspace overlay is not hidden. In workspace preview, the element should be shown - since it is not hidden in workspace. This is not the case. The patch fixes this: The 'base' db call for content elements ignores hidden & time based restrictions and elements are sorted out by versionOl() instead, if a workspace preview is requested. Resolves: #93336 Releases: master, 10.4 Change-Id: I6ed285c0fae240482da8719ab50b26f89375d599 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68185 Tested-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Tested-by:
-
- Mar 04, 2021
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master Resolves: #92280 Change-Id: Id2ef49722eb608d8810bd61f46e018664eb19d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65680 Tested-by:
-
Daniel Siepmann authored
The reference to 85829 was broken. It linked to 9.5 while the actual change was made in 9.4. Therefore the link is adjusted to link to the actual existing file. We use the :doc: syntax to allow sphinx to properly build the URL from relative file path. Resolves: #93641 Releases: master, 10.4, 9.5 Change-Id: Ia7755110b67ee4ff2efd3755cc5037d1f8e35f29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68181 Tested-by:
-
Christian Kuhn authored
Change-Id: I9b365a2adf98bfa52352a95b225f338e75f93871 Resolves: #93640 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68175 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Mar 03, 2021
-
-
Oliver Bartsch authored
Accessing the workspace module while in live workspace led to a JavaScript TypeError. This is fixed by proper type checking. Resolves: #93625 Releases: master, 10.4 Change-Id: Ief2f484f197ce068660dffc1751618fbc17c0cd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68165 Tested-by:
-
Oliver Bartsch authored
This removes some searchFields from sys_file_reference, since they are not suitable for users, searching for such records in the backend. As a side effect, a superfluous condition in workspaces is removed. Resolves: #93634 Releases: master Change-Id: I5204a79146128cbca0a3b74eda7b11ed5bcd7119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68171 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
