Skip to content
Snippets Groups Projects
Commit a06d6d7e authored by Benni Mack's avatar Benni Mack Committed by Richard Haeser
Browse files

[TASK] De-duplicate Tree code for filtering

This change optimizes the SVG Tree implementations (again),
this time focussing on using proper constructors for SVG
tree and its derivatives (SelectTree, PageTree, FileStorageTree).

In addition, the search + filter logic is now moved
into the base class, in order to reduce duplicate code,
and to re-add features (next steps) that were not
implemented in TYPO3 v9 when re-writing the page tree,
such as highlighting filtered results.

In addition, unused properties and settings are
removed.

This change marks one of the final changes for
reworking the SVG Tree implementation, afterwards
allowing us to move towards:
* native DOM events in favor of d3-dispatch
* custom elements instead of wrapper methods
* decouple "top." and "document." based settings into the Container classes

Resolves: #93701
Releases: master
Change-Id: I55733b8c2d0a84ca263ac6e77d7d0bac30877e25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68332


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: default avatarRichard Haeser <richard@richardhaeser.com>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarRichard Haeser <richard@richardhaeser.com>
parent 110480e5
Showing
with 170 additions and 261 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment