[TASK] De-duplicate Tree code for filtering
This change optimizes the SVG Tree implementations (again), this time focussing on using proper constructors for SVG tree and its derivatives (SelectTree, PageTree, FileStorageTree). In addition, the search + filter logic is now moved into the base class, in order to reduce duplicate code, and to re-add features (next steps) that were not implemented in TYPO3 v9 when re-writing the page tree, such as highlighting filtered results. In addition, unused properties and settings are removed. This change marks one of the final changes for reworking the SVG Tree implementation, afterwards allowing us to move towards: * native DOM events in favor of d3-dispatch * custom elements instead of wrapper methods * decouple "top." and "document." based settings into the Container classes Resolves: #93701 Releases: master Change-Id: I55733b8c2d0a84ca263ac6e77d7d0bac30877e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68332 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com>
Showing
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTree.ts 40 additions, 7 deletions...ources/Public/TypeScript/FormEngine/Element/SelectTree.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts 8 additions, 40 deletions...Public/TypeScript/FormEngine/Element/SelectTreeElement.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTree.ts 4 additions, 71 deletions.../backend/Resources/Public/TypeScript/PageTree/PageTree.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts 2 additions, 9 deletions...d/Resources/Public/TypeScript/PageTree/PageTreeElement.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts 88 additions, 26 deletions...TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTree.ts 5 additions, 77 deletions...ckend/Resources/Public/TypeScript/Tree/FileStorageTree.ts
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeContainer.ts 2 additions, 10 deletions...ources/Public/TypeScript/Tree/FileStorageTreeContainer.ts
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js 1 addition, 1 deletion...ources/Public/JavaScript/FormEngine/Element/SelectTree.js
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js 6 additions, 6 deletions...Public/JavaScript/FormEngine/Element/SelectTreeElement.js
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js 1 addition, 1 deletion.../backend/Resources/Public/JavaScript/PageTree/PageTree.js
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js 8 additions, 8 deletions...d/Resources/Public/JavaScript/PageTree/PageTreeElement.js
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js 1 addition, 1 deletiontypo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTree.js 1 addition, 1 deletion...ckend/Resources/Public/JavaScript/Tree/FileStorageTree.js
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.js 3 additions, 3 deletions...ources/Public/JavaScript/Tree/FileStorageTreeContainer.js
Please register or sign in to comment