- Sep 27, 2023
-
-
Stefan Bürk authored
The doctrine team realeased `doctrine/dbal 3.7.0` recently and this change raises the dependency to that version. Extension authors activating `doctrine/dbal` deprecation will then get the newest `doctrine/dbal` deprecations included in that release. That helps in preparation for planned `doctrine/dbal 4.x` upgrade with TYPO3 v13 to avoid stumpling into breaking changes. Used command(s): > composer require --no-update \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.0" ; \ composer require \ "doctrine/dbal":"^3.7.0" Resolves: #102042 Releases: main, 12.4 Change-Id: I34ee939fc94078df2006ad338d1e7ff1cac14a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81258 Reviewed-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewe...
-
Andreas Fernandez authored
Resolves: #102040 Related: #101790 Releases: main, 12.4 Change-Id: I7a6a21fd98d1a9506da864d983b1f40b03f4259e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81256 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Sep 26, 2023
-
-
Sven Proffe authored
Releases: main, 12.4 Resolves: #102039 Related: #97449 Change-Id: I5f7d314e40e53d09505bad92b5ce49bcc3ea8f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81254 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
J. Peter M. Schuler authored
Feature #76085 introduced an admin panel option which shows red boxes with section and partials for easier debugging. However sometimes no partial name is shown in the output, because the retrieved name is not cleaned correctly. Resolves: #97509 Related: #76085 Releases: main, 12.4, 11.5 Change-Id: I087e3688fa8d5703c621e182f80b594492c11115 Signed-off-by:
J. Peter M. Schuler <j.peter.m.schuler@uni-due.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74484 Reviewed-by:
-
Thomas Hohn authored
Remove fallback for CKEditor removePlugins as a string. It must now be an array. Resolves: #101192 Related: #98613 Releases: main Change-Id: Ifd1bb7591c63f7e5e02bce18caea21c4c42ccff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79554 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Benjamin Franzke authored
In case a link with an invalid CSS class is edited, the class value is not simply invalidated and shown as empty (which isn't true), but a virtual select option "[ INVALID VALUE (…) ]" is added (and selected) that documents the fact that the current value invalid, but will be preserved upon updates. (as in FormEngine) This allows the editor to choose between preserving, removing or changing to another css class value. With this change applied, we can not properly remove empty value. Note that empty values previously implicitly preserved existing values, which made it impossible to remove a link title or target. Resolves: #102012 Resolves: #102013 Releases: main, 12.4 Change-Id: Iefae377a9e18467e8eb9111ef3ef7a96c89b6ce1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81176 Reviewed-by:
Benjamin Franzke <ben@bn...>
-
Andreas Nedbal authored
Another GFX-setting that enables PNG generation for temporary files. PNG files offer many benefits, one of them being faster generation using image processors. We previously held back on removing this setting because the temporary images using gdlib_png were significantly darker than the GIF files, but this stems from the TYPO3 default configuration using the RGB colorspace (if nothing else is set) in combination with ImageMagick. The sRGB colorspace, as recommended in the preset, should be used. If GraphicsMagick is used, generating temporary images using the RGB colorspace works fine. With this knowledge it is safe to remove the setting, but a migration notice has been left notifying users of each image processor of required migration steps. Resolves: #102020 Releases: main Change-Id: I4be795406cbb010d4b668a2de588c4591c443cf3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81184 Tested-by:
-
Chris Müller authored
Outdated manuals which are not supported anymore are removed. The missing system extensions manuals are added. Some special cases: - t3install was renamed to t3upgrade (as the Installation Guide was also renamed to Upgrade Guide) - t3l10n and t3translate are duplicates, t3l10n was removed The current list of manuals is maintained in https://github.com/TYPO3-Documentation/TYPO3CMS-Example-ExtensionManual Resolves: #102035 Releases: main, 12.4 Change-Id: I344f8a17d1c5de9dbcdc5148bed5322518d72b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81218 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Chris Müller authored
Additionally, convert a paragraph into an attention directive to be more outstanding. Resolves: #102037 Related: #101113 Releases: main Change-Id: Ifcc5b86d844f8043784e5a251977216578a8c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81219 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Sep 25, 2023
-
-
Ramón Schlosser authored
Resolves: #102029 Releases: main, 12.4, 11.5 Change-Id: Idfa299ece1011727da09421ee148a820dc4e0326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81234 Reviewed-by:
-
Chris Müller authored
Resolves: #102019 Releases: main, 12.4 Change-Id: Ib65eaf32d3bff91b943d965684eb2f0fcf25a44d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81182 Tested-by:
-
Chris Müller authored
With the change in #101933 the AfterUserLoggedInEvent is also dispatched when a frontend user is successfully logged in. Therefore, this event is added to the list of available events (although that event is not in the felogin namespace) to ease the access for the developer who looks for appropriate events regarding felogin. Resolves: #102030 Related: #101933 Releases: main Change-Id: I26bcc1cbc7648e91eeef9b9bd2564afcb8ebc268 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81216 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benjamin Franzke authored
The karma unit testing framework has been deprecated and suggests to use modern alternatives instead. We use one of the recommended alternatives named @web/test-runner which is toolset by the modern-web.dev and open-wc.org initiatives. It is based on mocha and es-dev-server, which allows to run our JavaScript modules natively in the browser (without having to bundle them via rollup). Note that compiled test files have been removed from the source tree, since we configure es-dev-server to transpile them on demand, allowing error output from tests to be using original line numbers and unmangled identifiers. The tests are executed in chrome by default (locally and CI). They can be executed via: # Run once npm run test # Run tests whenever files change npm run watch:build npm run watch:test # Open browser with devtools and debug mode activated MODE=dev npm run watch:test -- --debug Configuration is prepared to run in other browsers via playwright. Example: # https://playwright.dev/docs/browsers#install-system-dependencies npx playwright install --with-deps BROWSERS=chrome,chromium,firefox,webkit npm run test Commands executed: npm remove \ karma \ karma-chrome-launcher \ karma-coverage \ karma-jasmine \ karma-junit-reporter \ karma-rollup-preprocessor \ jasmine-core \ @types/jasmine npm install --save-dev \ @web/test-runner \ @web/test-runner-playwright \ @web/dev-server-import-maps \ @web/dev-server-esbuild \ @open-wc/testing \ sinon git rm -rf \ typo3/sysext/core/Tests/JavaScript \ typo3/sysext/backend/Tests/JavaScript npm run build Resolves: #101960 Releases: main, 12.4 Change-Id: Ia2fa94a9f6d66664d9fce72e7443aaeb12e0ca08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81040 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change adds more examples to getImageScale to have a good test bed in place before we move code around for v13. Resolves: #102026 Releases: main, 12.4 Change-Id: I82bfa00fb8f8342270505071d161de2462b782ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81189 Reviewed-by:
-
Georg Ringer authored
After deleting a log entry, the user must be properly redirected to the list action. Resolves: #102003 Releases: main, 12.4 Change-Id: I6caf8fb958acc92823d83fcacac6276ec7ab1d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81177 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Torben Hansen authored
The `AfterUserLoggedInEvent` introduced with TYPO3 12.3 is currently only triggered for a successful backend login. With this change, the `AfterUserLoggedInEvent` is now also dispatched, when a successful frontend user login is performed. Resolves: #101933 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Iab3361032697fc214040a1cd4d2b54e5a91ac496 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81033 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Chris Müller authored
Resolves: #102028 Related: #100333 Releases: main, 12.4 Change-Id: If44aa9106de3fe1ae94eae45b5f97b1c842b7e0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81214 Reviewed-by:
-
Benjamin Franzke authored
Remove selection link attributes after updating an existing link that has been selected with a collapsed selection (that is when the cursor is placed anywhere inside the link). We missed to cleanup all our (and ckeditor's) link related attributes after creating a collapsed selection ("cursor placed after the link") after a link was updated. Adapt to upstream logic to cleanup link attributes as seen in https://github.com/ckeditor/ckeditor5/blob/v39.0.2/packages/ckeditor5-link/src/linkcommand.ts#L206-L208 The logic is slightly modified to use the same generic approach in https://github.com/ckeditor/ckeditor5/blob/v39.0.2/packages/ckeditor5-link/src/linkediting.ts#L697 included our workaround from #101429 Resolves: #102006 Releases: main, 12.4 Change-Id: I79f23a1c309213fbf12017ecb485c7d963fe5a2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81172 Tested-by:Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Franzke authored
RTE link classes that are configured via `buttons.link.properties.class.allowedClasses` are selectable in all link types in the link browser. Specific classes can be limited to specific link types with a separate configuration option `classesAnchor.{id}.type|class`. When such limits are active, classes that are *not* configured to associated/limited to a specfic type, remain listed and available for *all* link types. When an existing link with such type of globally allowed class is opened its value was cleared because it was not defined in the set of limits. This was an inconsistency as the link class was still selectable, but the selection was removed upon reoping such link. Such values are now preserved. Resolves: #102005 Releases: main, 12.4, 11.5 Change-Id: I0ad4273819f1d5a8e06f587b94fefb4598a07c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81168 Reviewed-by: -
Benjamin Franzke authored
The GHS (General HTML Support [1]) attribute `htmlA` is used by the style plugin to apply or remove style classes. Make sure to use the same attribute interface in order for CSS class usage to be interopable across our set of CKEditor5 plugins. Note that our custom `linkClass` attribute prevented the CKEditor5 style plugin from parsing existing classes, as this plugin expects CSS classes to be available on the `htmlA` attribute (defined in the nested `classes` array). [1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html Resolves: #101429 Resolves: #101427 Releases: main, 12.4 Change-Id: I704982cd950f0c7cacb1c99bac6a70f417caf40a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81051 Reviewed-by:
-
Torben Hansen authored
The documentation for the PSR-14 event `PasswordChangeEvent` currently states, that it is possible to mark a password as invalid. This functionality has been removed in TYPO3 v13. This change corrects the documentation of the `PasswordChangeEvent` event. Resolves: #102024 Relates: #100355 Releases: main Signed-off-by:
-
- Sep 22, 2023
-
-
Benni Mack authored
When using "file.crop" via TypoScript, PHP 8 requires strict types for float values. Therefore, all values, which were strings before, are now properly casted to floats, avoiding PHP errors. Example TypoScript: page.10 = IMAGE page.10 { file = 1:/myimage.jpg file.ext = png file.width = 200 file.height = 200 file.crop = 50,50,100,100 } Resolves: #101994 Releases: main, 12.4 Change-Id: I73c2dc9128fded7874b506ddb37026077f5a67a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81156 Tested-by: -
Benni Mack authored
Resolves: #101185 Releases: main, 12.4, 11.5 Change-Id: If54f9308ac2928ce9521228593d6a3ef88713d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81157 Reviewed-by:
-
Oliver Bartsch authored
This will prevent type errors in case given folder parameter is set but not a Folder object. Resolves: #102016 Related: #102014 Releases: main, 12.4 Change-Id: I828cab2ab1a5a649ba6fdf08375453b4c3382432 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81179 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Jochen Roth authored
Currently, when linking to a non-existing folder in and the user clicks on save an error is thrown. This has been fixed by returning early with a empty string in case the folder object is null. Resolves: #102014 Releases: main, 12.4 Change-Id: I548737fae5e6957fe59bf414b70737bea28700b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81178 Tested-by:
-
Christian Kuhn authored
The exception became unused with removal of signal/slot in v10. Resolves: #102010 Releases: main Change-Id: I81c944adcbe287db0e7f196de220328bba8fee0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81175 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
This change removes the cache "imagesizes" along with the public methods within GraphicalFunctions. The main reason for having cache_imagesizes back in TYPO3 v4.x was that detecting the image sizes was done via ImageMagick solely. Nowadays, the ImageInfo functionality is used, which uses - getimagesize() - exif_read_data() before falling back to ImageMagick identify. Most places in TYPO3 Core already use ImageInfo directly without using the cache. A image size calculation is nowadays with SSD much faster than a decade before, whereas a DB cache (by default) for cache_imagesizes has a much more latency. As cache_imagesizes is solely used for local files, remote FAL drivers do not have a problem here as well. Removed public methods: - GraphicalFunctions->cacheImageDimensions() - GraphicalFunctions->getCachedImageDimensions() The main public method GraphicalFunctions->getImageDimensions() still continues to exist and work as before. Resolves: #102009 Releases: main Change-Id: I6075e796b5e729733bd60eb7d2e005f5f5cc4b33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81105 Tested-by:
-
Georg Ringer authored
The most used view is the indexing information of a page and its subpages and not a general statistic. Therefore the default action should be the detail action. Resolves: #102000 Releases: main, 12.4 Change-Id: I4822b9aea8f4310837d4d55ac9376d45ac2c4df7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81163 Tested-by:
-
Georg Ringer authored
As the keyword field can be null, the value must be cast to a string. Resolves: #102002 Releases: main, 12.4, 11.5 Change-Id: Ic2e437c489c699833c2d51301bdff715f613ea6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81165 Tested-by:
-
Oliver Bartsch authored
The scheduler module stores the information about each tasks groups collapse state for each user. When accessing the module, the correct state is now resolved again. Resolves: #101167 Releases: main, 12.4 Change-Id: I7492f90cf2c5aef634c663e5c3ef891286207007 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81162 Reviewed-by:
-
- Sep 21, 2023
-
-
Benni Mack authored
Since TYPO3 v10 it is possible to use any number of doktype with "pages.doktype" and the limitation of custom doktypes "less than 200" was lifted. One part is still missing - the ContextMenu still has the limitation of only showing up for doktypes less than 200. This patch changes this behavior. Resolves: #101999 Releases: main, 12.4 Change-Id: I6971c9856297bc669d32cdf778be1883a1be54ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81161 Tested-by:
-
Christian Kuhn authored
Tables with TCA columns set to type="flex" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=flex. Resolves: #101997 Related: #101553 Releases: main Change-Id: Ide5458994cfbfca0113be08b0e87b51babaeb540 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81158 Reviewed-by:
-
Andreas Fernandez authored
The AJAX API (`@typo3/core/ajax/ajax-request`) has been enhanced to accept native URL-related objects, making usage of the API for developers a little bit easier. Resolves: #101970 Releases: main Change-Id: Ica7c8d5ded7184c5aad6355dbdfa5c4f1f82b0ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81100 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Oliver Bartsch authored
Decoupling the ThumbnailViewHelper from the ImageViewHelper in #96362, all arguments were moved to the ThumbnailViewHelper. The commit message as well as a code comment stated that unneeded arguments will be removed later on. This is now done. All unused arguments are removed from the ViewHelper. Resolves: #101993 Related: #96362 Releases: main Change-Id: I62e711eeea54f24f19439e2f370f4195ed580414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81154 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Stefan Bürk authored
If imgResource option `noScale = 1` [1] is configured, the image itself is not scaled. However, the calculated scaled width and height values needs to be used for the `img` tag attributes `width` and `height`. In that case, the orginal image is used instead of a processed image, and the calculated values are discarded. This change recalculates these values if `noScale = 1` is requested to ensure that the scaled width and height values are used correctly. Example ------- page.100 = IMAGE page.100 { file = fileadmin/styleguide/bus_lane.jpg file.noScale = 1 file.width = 240m file.height = 240m wrap = |<br> } [1] https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Imgresource.html#noscale Resolves: #100972 Releases: main, 12.4 Change-Id: Ib09e3e837225347ee2e2a9c9979b014d8fd2b850 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81130 Reviewed-by: -
Torben Hansen authored
When a link is selected in CKEditor 5, the class `ck-link_selected` is added to the link. This caused the link browser to not show the selected class, which has been fixed with #101436. The bugfix does however not consider, that a CSS class in link browser can consist of a string with multiple classes separated by a space. This change ensures, that the link browser again accepts a class string containing multiple class names and shows the selected class string in the CSS-Class select field. Resolves: #101959 Related: #101436 Releases: main, 12.4 Signed-off-by:
-
Oliver Bartsch authored
The `@internal` `ThumbnailController` is removed, because it has been unused since the introduction of the deferred BE image processing in #92188. Resolves: #101992 Related: #92188 Releases: main Change-Id: I670acb83fcc7be9c8867658467b4e1ca87bcb954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81152 Tested-by:
-
Daniel Siepmann authored
The change log previously only mentioned the database impact. But code might access the field as array key on the user array. This would result in unexpected behaviour. Furthermore this would result in Warnings since PHP 8.0. The changelog is extended with the impact. That allows people to not only check database queries but also array access while migrating. Furthermore suggested migration class was replaced by the FQCN to ease migration. People do no longer need to find the FQCN. Furthermore it might exist a class with same name in the project from third party code, or it might be added another class in the future. Resolves: #101987 Releases: main, 12.4, 11.5 Change-Id: I475606e0f9a325880ee10339adaa2971985b05fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81124 Reviewed-by:
-
Andreas Nedbal authored
If generated images used the exact X/Y coordinates all time (as in one documentation example) the initial image would always be reused. Serializing the setup array using ConfigurationService::serialize keeps performance but includes enough data to never reuse similarly positioned mask images. Resolves: #97212 Releases: main, 12.4 Change-Id: Ic9e02e8c082cc68a9eecf4e9b1b2bc6d770e1d17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81122 Tested-by:
-
Benjamin Kott authored
Resolves: #101975 Releases: main, 12.4 Change-Id: I630ebddc2287b5492cddeb0a098dcedcce765c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81106 Tested-by:
-
