[BUGFIX] Show but preserve invalid classes in link-browser
In case a link with an invalid CSS class is edited, the class value is not simply invalidated and shown as empty (which isn't true), but a virtual select option "[ INVALID VALUE (…) ]" is added (and selected) that documents the fact that the current value invalid, but will be preserved upon updates. (as in FormEngine) This allows the editor to choose between preserving, removing or changing to another css class value. With this change applied, we can not properly remove empty value. Note that empty values previously implicitly preserved existing values, which made it impossible to remove a link title or target. Resolves: #102012 Resolves: #102013 Releases: main, 12.4 Change-Id: Iefae377a9e18467e8eb9111ef3ef7a96c89b6ce1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81176 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
Showing
- Build/Sources/TypeScript/backend/link-browser.ts 1 addition, 1 deletionBuild/Sources/TypeScript/backend/link-browser.ts
- Build/Sources/TypeScript/rte_ckeditor/plugin/typo3-link.ts 22 additions, 7 deletionsBuild/Sources/TypeScript/rte_ckeditor/plugin/typo3-link.ts
- typo3/sysext/backend/Resources/Public/JavaScript/link-browser.js 1 addition, 1 deletion...ysext/backend/Resources/Public/JavaScript/link-browser.js
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php 32 additions, 13 deletions...rte_ckeditor/Classes/Controller/BrowseLinksController.php
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js 1 addition, 1 deletion...ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js
Please register or sign in to comment